From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 84EA04386A for ; Fri, 1 Jul 2022 08:47:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7CF4B68B81D; Fri, 1 Jul 2022 11:47:51 +0300 (EEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8B8D768B7FF for ; Fri, 1 Jul 2022 11:47:43 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656665268; x=1688201268; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=pryqAD8J0btIxLACo+lpk1VbHZsasBQuY2s5lQO11DU=; b=G7UQSSUPSfVFEObeuOBavRan/5TZhkOtjGqXVkX+TBS92PerDHYG5hhM J052NqpNlI+LWfM9eQAF0AM5aRTZCLmOLEYA3L6EdlVcUcn2QeMN+HMdL QQothgUTcMHvnrLE0C8OT8i2nljK0f/wrLZ6IN5IixrBDkDVyEwR/lDhW eO+wCMsjQQ+CRjoC0lAQi7kuR16C632lQD9FEavZy7DjaMZ6dQwP1ndxV lTIp9zKnoR+37hA3H7KUYpZ0RpUACfM3drfwLLZG7OwYwvomxUtDYWoc5 TcITTUyb+asX6ZYj5/VLL7yJqYmgUDvGSsHsxO7iD61+KWO2Q5nmi6htJ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10394"; a="368913269" X-IronPort-AV: E=Sophos;i="5.92,236,1650956400"; d="scan'208";a="368913269" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2022 01:47:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,236,1650956400"; d="scan'208";a="624113362" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 01 Jul 2022 01:47:40 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 1 Jul 2022 01:47:40 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 1 Jul 2022 01:47:40 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 1 Jul 2022 01:47:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6t28u5Pn2G2fh5rVkbRCG8WqDh12hbwUJGFm+ggqTpZyeWk/6OBkN1aW+ZiqGUvaai+gx0/5KdS16TPV3y3tCMBcNXAw4bDVyION0gq+6YHmHxoG2l5kj1jxesP50tx7+Pz0HqhNgyfZPZKsrB1VPdcA2NUFfOx7DOPTZ37f5UvY3zYXWLpU8ldC99HhD84KCx2+mIf7QWTmS+XN9lA1YR1SBx7uykTIKGKrfy2Z6WP7N4jV6xMN3F3jcupzSv4PO7C69Hu1HOC9xpqJirb47gWoa9XgmgJ84IALywwFhP/QE8QCWfS97iWCXP88FuKmEyeXNcwYCw+8AuozdSLeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0gh3yXARnr7IYgvIgRDznrOeqUSh2lYVyQAHFTyT2KY=; b=W6ZEpdhdui90kMZWpEZ1/hr/uLVH4Wq1vx4p4CBR/ZpTm13r34mhM+hemdZGpM31sL9cVmQNnvkRtXoMZmkZB7sE3jx2UIiwrehwNZAU1+xGH9rKSdwjAoh2e0A2JvacGQzoqjuvOV5xWOzgqZ+UjRNEn6moN2cNIoPxTzPUETyEd41LVI9jA9TjJqJlxagQiyMjjyvEtkTCu/hgZbJTsXK3zeGqxEI5cJpFbEUVLAJ6gOSvbqJ9LvETuYO0qW5jaSzvfAbW3hRHLtKM2maBoIWxSrAnabEEtL3UP4daaQC4YEhK76dqq3rWHtWsN7Brh3wiFLSbKqs+cH/Mv4z5Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB3879.namprd11.prod.outlook.com (2603:10b6:a03:18f::17) by DM6PR11MB2891.namprd11.prod.outlook.com (2603:10b6:5:71::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Fri, 1 Jul 2022 08:47:33 +0000 Received: from BY5PR11MB3879.namprd11.prod.outlook.com ([fe80::b02e:fe48:73f6:f310]) by BY5PR11MB3879.namprd11.prod.outlook.com ([fe80::b02e:fe48:73f6:f310%6]) with mapi id 15.20.5373.018; Fri, 1 Jul 2022 08:47:32 +0000 From: "Chen, Wenbin" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a chroma mb size error in sse_mb() Thread-Index: AQHYjQzv7ygbdL1zI02qVOPrYp178a1pJvcAgAADnICAAAfiYA== Date: Fri, 1 Jul 2022 08:47:32 +0000 Message-ID: References: <20220701053434.2137992-1-wenbin.chen@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e58873c1-1535-4985-c1a4-08da5b3e56c3 x-ms-traffictypediagnostic: DM6PR11MB2891:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZBcvzWQcq53j4o2q+ju7hYrKJ0Dmi8LuNwmgpoD0PrtOqpdARTfmbxwEiWA90bhq3ynJNMuLI3mGQ1wUFHdIMClWjrUqglKJh+hMEM1jOkCfxbsZ/46AWSnR4MdRzH4dUVXh1+de25OIGPWdqm9IS3an+5MD8fWy7HZJ9R6kGmua3s5qZrH+BBtWY/ZWyGuwLWZRlLq5C2ZQUVcteDzvCWCPSu6ylCHRsUqY6hwbuQe75ELe/JA1ZZqBuAht4Gu0enFq8YX5C5QnrlPrN5Bihp/E5PuFK5digjCt69q9bl/9GgP/YLYqt5OpmLrt0oEblnkQ3tVVrQzUow25zmYxCrt8p+4vnLPZ4kE5oHa4/xcaujVrrkwvC7Ffs7gh512auF89Yl7Cui4LHFYDtmUTC4ZiBonFJs82uQbHwkkdeKju+TgetFZvptQpmohTsuJJW5JdjNH1vBj9JgJXt6GkiQHs+3K9N3PVkXt/saCfQwQasI4RbNDlBAjUyl1rjlXkIUrciwG0kW2TCYlUmgPtc+ei1efI8csB8uVmGAIqCPzk8wgKOuMWK0RIFbnR0TCwo0rATayEAJdWb2UVymzajAgL7MdFhVSFu+E7/EZFYYhhrEswIKh7PDAgSzonMWRByt9AC8B1Afs0HTwp/fLPjrZ/Gq/cXbj5QAi+CBe6qg8zUC37O8oSoXr/seDnUqdcNa4JAF8Vpeko7iI+N0DLgqpfjSiAt54Wn9jcdudI0fwpzVQwapj6ve8l/R1zSIcCBlHbc9uYmSlY0DlAZ2xiI0V5eE2ODfnP5eMy7UPnH2O5/M3GaKVCHkluyBkj42eAscaaJvGExvov3zxPCyjtFZEUSChiVB5bZ8jIKKxnsW4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB3879.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(39860400002)(366004)(136003)(346002)(376002)(9686003)(7696005)(8936002)(52536014)(6506007)(30864003)(5660300002)(26005)(53546011)(71200400001)(76116006)(66946007)(38070700005)(66556008)(66476007)(64756008)(66446008)(6916009)(316002)(41300700001)(86362001)(82960400001)(478600001)(966005)(8676002)(122000001)(186003)(55016003)(83380400001)(33656002)(38100700002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9yhnlWj0Cdi7/CRILKzPl6dLTihCP7yyBOfjjjjzAQXdS3yNi65D+TEJi9MW?= =?us-ascii?Q?2Wshd07TWKi5+uoTj22/F9TXXA+7kBVSSPlUCxs9OqktkvbRBI6mWVJYWEVC?= =?us-ascii?Q?DrODTB80ChQW9/QqhnjeNgrJN6Ur9IK1PvQHXv0msAkq7bsX5dOxD9RRM8p9?= =?us-ascii?Q?kLnvJvk92zyzKUzsPQUQJWNOdEgd46BnSfFT3KDlV3v5n6/ZyqZtpkgY2gsh?= =?us-ascii?Q?fRh5z036+Sl6HfYGnEWfiSg1okNFrOEnZMUC8Ykeorql6+C5Y49Baa0Pj23+?= =?us-ascii?Q?s82Zymk/4nTd2WVK8mBA3oDksasawtYqFL+1dZOxOqLb0mEivz3TMfaIEDmF?= =?us-ascii?Q?mj7d2GSxC+ulJSrW0f+WKCogKzuL06sCM0YaTPilwR4RXejcmFd3ED1fMZo+?= =?us-ascii?Q?BVCO6muM6ksHvY2D9Wm8EBn4aaxHpVajNlF1wLaeovb2wt+oR9pZrGTeuQLK?= =?us-ascii?Q?jaZ4DdMwgUxBcuUBxgc6KF9VXJZpyq9tci2l3AHEITmmHD2yrLNohwHnzUoz?= =?us-ascii?Q?gcEKj/Y/OZbfvLJPGrBjTQ2wC7Ch2S520vGiueykzPPQypDve71aHiqEy8m6?= =?us-ascii?Q?I16L0CXH7iQq5zGJ92Dge50mCAoAiFOZCWsO7Rcf06mvP9KoO4kRZM0sAA2E?= =?us-ascii?Q?F7TV0MUNjnWe+p6MscZjL4vCtPnRuvnlPwSZv9IfkUDtyhFH1d5oDwb6S2gq?= =?us-ascii?Q?le7+NygrG8b+dkxkIgFCKej49erJX94UTlOXoCPQt8LiFHClyc+cj9JzR670?= =?us-ascii?Q?ehvUj9+8ynK9cdyVLdQv0USIlU7fbSM0ScP5VAVGawQVoy1m7O06YjV+3Rgs?= =?us-ascii?Q?K94JgGLpsjrwNxJ8eCzgXXNhzmK+lguNodNxe3SOhD51UY8vzCMzLU5+fVC2?= =?us-ascii?Q?kgLYMg6qbbJvvm0XnpkBZ/6nUkcTQnyl6g/EReQgaZcs8/4gRhVDmN7xdK0E?= =?us-ascii?Q?Vtdo43SuhjqOMuOvM8KhpVW89OLpfmQLMW106L1rRPoLXvQDJmWonpy8I9Qr?= =?us-ascii?Q?URnVXVWJCdy+F0sjRz8opd/7pscqrn88MVpar3TPbf8cLv13a+ECN7epT3Wj?= =?us-ascii?Q?efyU6ZHMgrbrGwEL9EQB+4pNgKUO+9kGIwgCGfNo5J3GNnkMjOldeM4ZIBvX?= =?us-ascii?Q?3vQZPPG1oppGiYZvMJh6nDnjwCVS3C6hilRskkdthLAUvQ/zTtMJGzoyHZ6c?= =?us-ascii?Q?PFBTVy+JCMA/IoWlzfVaJO3g3jBlymhhq0Njvclcuzd4Di1SrqblcyPVrQeh?= =?us-ascii?Q?SWqfjRpn0cCoZ5mskOuuo2QDHJu7psn8/Hz/y8tyVuhWThq0M+pbmfjE2X4l?= =?us-ascii?Q?oVjFjQorpS4RPnnORE0jpRlq9HmPH1uvjDIwfBYTrzvT51mkw7MGZrccmQAe?= =?us-ascii?Q?FtZIojcQE4UpvhONcX4ih/4bV5VByGoP91R05UMmHXbK0kFO6LP5eN4LTOZJ?= =?us-ascii?Q?aypZVUPdkSLugobf9nUe4EtSUgOjcNIDMGxUN0nTZ2l9tcxRT9lXJ6xbpnGU?= =?us-ascii?Q?BaVdsNsiT6f2OThT8MUMtgauX05cAlyIVzpmfUq+a+4wL1ou4hFUDg+UjKcg?= =?us-ascii?Q?2ksYYyxeedR/wLlKadcmg4EfP6sVG3bFwn6RQM40?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB3879.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e58873c1-1535-4985-c1a4-08da5b3e56c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2022 08:47:32.7491 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hR0uBAc0eal2BJQj+GpzcDv+VeLEXu0ki9zfUzqytlsROPAUApPPwsWMzloi9ScoL8k+tdEPIikbmkbxnmQa5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2891 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a chroma mb size error in sse_mb() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Fri, Jul 1, 2022 at 10:00 AM Xiang, Haihao < > haihao.xiang-at-intel.com@ffmpeg.org> wrote: > > > On Fri, 2022-07-01 at 13:34 +0800, Wenbin Chen wrote: > > > For 422 frames we should not use hard coded 8 to calculate mb size for > > > uv plane. Chroma shift should be taken into consideration to be > > > compatiple with different sampling format. > > > > > > The error is reported by fate test when av_cpu_max_align() return 64 > > > on the platform supporting AVX512. This is a hidden error and it is > > > exposed after commit 17a59a634c39b00a680c6ebbaea58db95594d13d. > > > > > > mpeg2enc has a mechanism to reuse frames. When it computes SSE (sum > of > > > squared error) on current mb, reconstructed mb will be wrote to the > > > previous mb space, so that the memory can be saved. However if the > align > > > is 64, the frame is shared in somewhere else, so the frame cannot be > > > reused and a new frame to store reconstrued data is created. Because > the > > > height of mb is wrong when compute sse on 422 frame, starting from the > > > second line of macro block, changed data is read when frame is reused > > > (we need to read row 16 rather than row 8 if frame is 422), and > unchanged > > > data is read when frame is not reused (a new frame is created so the > > > original frame will not be changed). > > > > > > That is why commit 17a59a634c39b00a680c6ebbaea58db95594d13d > exposes this > > > issue, because it add av_cpu_max_align() and this function return 64 on > > > platform supporting AVX512 which lead to creating a frame in mpeg2enc, > > > and this lead to the different outputs. > > > > > > Signed-off-by: Wenbin Chen > > > --- > > > libavcodec/mpegvideo_enc.c | 29 +++++++++++++------ > > > tests/ref/seek/vsynth_lena-mpeg2-422 | 40 +++++++++++++------------- > > > tests/ref/vsynth/vsynth1-mpeg2-422 | 8 +++--- > > > tests/ref/vsynth/vsynth2-mpeg2-422 | 8 +++--- > > > tests/ref/vsynth/vsynth3-mpeg2-422 | 8 +++--- > > > tests/ref/vsynth/vsynth_lena-mpeg2-422 | 8 +++--- > > > 6 files changed, 56 insertions(+), 45 deletions(-) > > > > > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > > > index d6a85a037a..c9d9e2a764 100644 > > > --- a/libavcodec/mpegvideo_enc.c > > > +++ b/libavcodec/mpegvideo_enc.c > > > @@ -2558,24 +2558,35 @@ static int sse(MpegEncContext *s, uint8_t > *src1, > > > uint8_t *src2, int w, int h, in > > > static int sse_mb(MpegEncContext *s){ > > > int w= 16; > > > int h= 16; > > > + int chroma_mb_w = w >> s->chroma_x_shift; > > > + int chroma_mb_h = h >> s->chroma_y_shift; > > > > > > if(s->mb_x*16 + 16 > s->width ) w= s->width - s->mb_x*16; > > > if(s->mb_y*16 + 16 > s->height) h= s->height- s->mb_y*16; > > > > > > if(w==16 && h==16) > > > if(s->avctx->mb_cmp == FF_CMP_NSSE){ > > > - return s->mecc.nsse[0](s, s->new_picture->data[0] + s->mb_x * > > 16 + s- > > > >mb_y * s->linesize * 16, s->dest[0], s->linesize, 16) + > > > - s->mecc.nsse[1](s, s->new_picture->data[1] + s->mb_x * > > 8 + s- > > > >mb_y * s->uvlinesize * 8, s->dest[1], s->uvlinesize, 8) + > > > - s->mecc.nsse[1](s, s->new_picture->data[2] + s->mb_x * > > 8 + s- > > > >mb_y * s->uvlinesize * 8, s->dest[2], s->uvlinesize, 8); > > > + return s->mecc.nsse[0](s, s->new_picture->data[0] + s->mb_x * > > 16 + s- > > > >mb_y * s->linesize * 16, > > > + s->dest[0], s->linesize, 16) + > > > + s->mecc.nsse[1](s, s->new_picture->data[1] + s->mb_x * > > > chroma_mb_w + s->mb_y * s->uvlinesize * chroma_mb_h, > > > + s->dest[1], s->uvlinesize, chroma_mb_h) + > > > + s->mecc.nsse[1](s, s->new_picture->data[2] + s->mb_x * > > > chroma_mb_w + s->mb_y * s->uvlinesize * chroma_mb_h, > > > + s->dest[2], s->uvlinesize, chroma_mb_h); > > > }else{ > > > - return s->mecc.sse[0](NULL, s->new_picture->data[0] + s->mb_x * > > 16 + > > > s->mb_y * s->linesize * 16, s->dest[0], s->linesize, 16) + > > > - s->mecc.sse[1](NULL, s->new_picture->data[1] + s->mb_x > > * 8 + > > > s->mb_y * s->uvlinesize * 8, s->dest[1], s->uvlinesize, 8) + > > > - s->mecc.sse[1](NULL, s->new_picture->data[2] + s->mb_x > > * 8 + > > > s->mb_y * s->uvlinesize * 8, s->dest[2], s->uvlinesize, 8); > > > + return s->mecc.sse[0](NULL, s->new_picture->data[0] + s->mb_x * > > 16 + > > > s->mb_y * s->linesize * 16, > > > + s->dest[0], s->linesize, 16) + > > > + s->mecc.sse[1](NULL, s->new_picture->data[1] + s->mb_x * > > > chroma_mb_w + s->mb_y * s->uvlinesize * chroma_mb_h, > > > + s->dest[1], s->uvlinesize, chroma_mb_h) + > > > + s->mecc.sse[1](NULL, s->new_picture->data[2] + s->mb_x * > > > chroma_mb_w + s->mb_y * s->uvlinesize * chroma_mb_h, > > > + s->dest[2], s->uvlinesize, chroma_mb_h); > > > } > > > else > > > - return sse(s, s->new_picture->data[0] + s->mb_x*16 + s->mb_y*s- > > > >linesize*16, s->dest[0], w, h, s->linesize) > > > - +sse(s, s->new_picture->data[1] + s->mb_x*8 + s->mb_y*s- > > > >uvlinesize*8,s->dest[1], w>>1, h>>1, s->uvlinesize) > > > - +sse(s, s->new_picture->data[2] + s->mb_x*8 + s->mb_y*s- > > > >uvlinesize*8,s->dest[2], w>>1, h>>1, s->uvlinesize); > > > + return sse(s, s->new_picture->data[0] + s->mb_x * 16 + s->mb_y > > * s- > > > >linesize * 16, > > > + s->dest[0], w, h, s->linesize) + > > > + sse(s, s->new_picture->data[1] + s->mb_x * chroma_mb_w > > + s- > > > >mb_y * s->uvlinesize * chroma_mb_h, > > > + s->dest[1], w >> s->chroma_x_shift, h >> s- > > > >chroma_y_shift, s->uvlinesize) + > > > + sse(s, s->new_picture->data[2] + s->mb_x * chroma_mb_w > > + s- > > > >mb_y * s->uvlinesize * chroma_mb_h, > > > + s->dest[2], w >> s->chroma_x_shift, h >> s- > > > >chroma_y_shift, s->uvlinesize); > > > } > > > > > > static int pre_estimate_motion_thread(AVCodecContext *c, void *arg){ > > > diff --git a/tests/ref/seek/vsynth_lena-mpeg2-422 > > > b/tests/ref/seek/vsynth_lena-mpeg2-422 > > > index 06d8f7ac3a..1fc2bf93a0 100644 > > > --- a/tests/ref/seek/vsynth_lena-mpeg2-422 > > > +++ b/tests/ref/seek/vsynth_lena-mpeg2-422 > > > @@ -1,46 +1,46 @@ > > > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 17497 > > > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 18339 > > > ret: 0 st:-1 flags:0 ts:-1.000000 > > > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 17497 > > > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 18339 > > > ret: 0 st:-1 flags:1 ts: 1.894167 > > > -ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 325397 > > size: > > > 19967 > > > +ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 329242 > > size: > > > 21479 > > > ret: 0 st: 0 flags:0 ts: 0.788334 > > > -ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 200747 > > size: > > > 22575 > > > +ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 203086 > > size: > > > 24774 > > > ret:-1 st: 0 flags:1 ts:-0.317499 > > > ret:-1 st:-1 flags:0 ts: 2.576668 > > > ret: 0 st:-1 flags:1 ts: 1.470835 > > > -ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 265466 > > size: > > > 21329 > > > +ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 268154 > > size: > > > 22845 > > > ret: 0 st: 0 flags:0 ts: 0.365002 > > > -ret: 0 st: 0 flags:1 dts: 0.400000 pts: NOPTS pos: 104454 > > size: > > > 28984 > > > +ret: 0 st: 0 flags:1 dts: 0.400000 pts: NOPTS pos: 108763 > > size: > > > 32204 > > > ret:-1 st: 0 flags:1 ts:-0.740831 > > > ret:-1 st:-1 flags:0 ts: 2.153336 > > > ret: 0 st:-1 flags:1 ts: 1.047503 > > > -ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 200747 > > size: > > > 22575 > > > +ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 203086 > > size: > > > 24774 > > > ret: 0 st: 0 flags:0 ts:-0.058330 > > > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 17497 > > > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 18339 > > > ret: 0 st: 0 flags:1 ts: 2.835837 > > > -ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 325397 > > size: > > > 19967 > > > +ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 329242 > > size: > > > 21479 > > > ret: 0 st:-1 flags:0 ts: 1.730004 > > > -ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 325397 > > size: > > > 19967 > > > +ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 329242 > > size: > > > 21479 > > > ret: 0 st:-1 flags:1 ts: 0.624171 > > > -ret: 0 st: 0 flags:1 dts: 0.400000 pts: NOPTS pos: 104454 > > size: > > > 28984 > > > +ret: 0 st: 0 flags:1 dts: 0.400000 pts: NOPTS pos: 108763 > > size: > > > 32204 > > > ret: 0 st: 0 flags:0 ts:-0.481662 > > > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 17497 > > > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 18339 > > > ret: 0 st: 0 flags:1 ts: 2.412505 > > > -ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 325397 > > size: > > > 19967 > > > +ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 329242 > > size: > > > 21479 > > > ret: 0 st:-1 flags:0 ts: 1.306672 > > > -ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 265466 > > size: > > > 21329 > > > +ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 268154 > > size: > > > 22845 > > > ret: 0 st:-1 flags:1 ts: 0.200839 > > > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 17497 > > > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 18339 > > > ret: 0 st: 0 flags:0 ts:-0.904994 > > > -ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 17497 > > > +ret: 0 st: 0 flags:1 dts: 0.000000 pts: NOPTS pos: 0 > > size: > > > 18339 > > > ret: 0 st: 0 flags:1 ts: 1.989173 > > > -ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 325397 > > size: > > > 19967 > > > +ret: 0 st: 0 flags:1 dts: 1.840000 pts: NOPTS pos: 329242 > > size: > > > 21479 > > > ret: 0 st:-1 flags:0 ts: 0.883340 > > > -ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 265466 > > size: > > > 21329 > > > +ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 268154 > > size: > > > 22845 > > > ret:-1 st:-1 flags:1 ts:-0.222493 > > > ret:-1 st: 0 flags:0 ts: 2.671674 > > > ret: 0 st: 0 flags:1 ts: 1.565841 > > > -ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 265466 > > size: > > > 21329 > > > +ret: 0 st: 0 flags:1 dts: 1.360000 pts: NOPTS pos: 268154 > > size: > > > 22845 > > > ret: 0 st:-1 flags:0 ts: 0.460008 > > > -ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 200747 > > size: > > > 22575 > > > +ret: 0 st: 0 flags:1 dts: 0.880000 pts: NOPTS pos: 203086 > > size: > > > 24774 > > > ret:-1 st:-1 flags:1 ts:-0.645825 > > > diff --git a/tests/ref/vsynth/vsynth1-mpeg2-422 > > b/tests/ref/vsynth/vsynth1- > > > mpeg2-422 > > > index e936ba463e..a39b2b4dce 100644 > > > --- a/tests/ref/vsynth/vsynth1-mpeg2-422 > > > +++ b/tests/ref/vsynth/vsynth1-mpeg2-422 > > > @@ -1,4 +1,4 @@ > > > -6e135a1a27235a320311a932147846b4 *tests/data/fate/vsynth1-mpeg2- > > > 422.mpeg2video > > > -730780 tests/data/fate/vsynth1-mpeg2-422.mpeg2video > > > -0273cd8463d1fc115378748239951560 *tests/data/fate/vsynth1-mpeg2- > > > 422.out.rawvideo > > > -stddev: 10.27 PSNR: 27.90 MAXDIFF: 162 bytes: 7603200/ 7603200 > > > +651f054730be04257498eeae08b3bdc5 *tests/data/fate/vsynth1-mpeg2- > > > 422.mpeg2video > > > +855859 tests/data/fate/vsynth1-mpeg2-422.mpeg2video > > > +10fd55dbd10b08f9271eb89617766be8 *tests/data/fate/vsynth1-mpeg2- > > > 422.out.rawvideo > > > +stddev: 9.38 PSNR: 28.68 MAXDIFF: 178 bytes: 7603200/ 7603200 > > > diff --git a/tests/ref/vsynth/vsynth2-mpeg2-422 > > b/tests/ref/vsynth/vsynth2- > > > mpeg2-422 > > > index ec7244f9f9..5da29b4eac 100644 > > > --- a/tests/ref/vsynth/vsynth2-mpeg2-422 > > > +++ b/tests/ref/vsynth/vsynth2-mpeg2-422 > > > @@ -1,4 +1,4 @@ > > > -b2fa9b73c3547191ecc01b8163abd4e5 *tests/data/fate/vsynth2-mpeg2- > > > 422.mpeg2video > > > -379164 tests/data/fate/vsynth2-mpeg2-422.mpeg2video > > > -704f6a96f93c2409219bd48b74169041 *tests/data/fate/vsynth2-mpeg2- > > > 422.out.rawvideo > > > -stddev: 4.17 PSNR: 35.73 MAXDIFF: 70 bytes: 7603200/ 7603200 > > > +fcaf6242ca4b706d392e40d9631e3465 *tests/data/fate/vsynth2-mpeg2- > > > 422.mpeg2video > > > +383946 tests/data/fate/vsynth2-mpeg2-422.mpeg2video > > > +474bb259f041bfb971691551f678fd09 *tests/data/fate/vsynth2-mpeg2- > > > 422.out.rawvideo > > > +stddev: 3.93 PSNR: 36.23 MAXDIFF: 69 bytes: 7603200/ 7603200 > > > diff --git a/tests/ref/vsynth/vsynth3-mpeg2-422 > > b/tests/ref/vsynth/vsynth3- > > > mpeg2-422 > > > index 2247f286e6..e83c23635c 100644 > > > --- a/tests/ref/vsynth/vsynth3-mpeg2-422 > > > +++ b/tests/ref/vsynth/vsynth3-mpeg2-422 > > > @@ -1,4 +1,4 @@ > > > -4d108b861715f1fa010fd70baea91793 *tests/data/fate/vsynth3-mpeg2- > > > 422.mpeg2video > > > -68612 tests/data/fate/vsynth3-mpeg2-422.mpeg2video > > > -73b16e906d07b6bbccf4b00d4a25302c *tests/data/fate/vsynth3-mpeg2- > > > 422.out.rawvideo > > > -stddev: 4.02 PSNR: 36.05 MAXDIFF: 46 bytes: 86700/ 86700 > > > +96dc854fc40a6410d4edc387b63ded1a *tests/data/fate/vsynth3-mpeg2- > > > 422.mpeg2video > > > +75445 tests/data/fate/vsynth3-mpeg2-422.mpeg2video > > > +5337fc0bfb789919cb3325a02d48eb82 *tests/data/fate/vsynth3-mpeg2- > > > 422.out.rawvideo > > > +stddev: 3.24 PSNR: 37.90 MAXDIFF: 27 bytes: 86700/ 86700 > > > diff --git a/tests/ref/vsynth/vsynth_lena-mpeg2-422 > > > b/tests/ref/vsynth/vsynth_lena-mpeg2-422 > > > index 5f11d4e7cd..85d598782c 100644 > > > --- a/tests/ref/vsynth/vsynth_lena-mpeg2-422 > > > +++ b/tests/ref/vsynth/vsynth_lena-mpeg2-422 > > > @@ -1,4 +1,4 @@ > > > -521ec92c0b8672011a43dd13db98c400 *tests/data/fate/vsynth_lena- > mpeg2- > > > 422.mpeg2video > > > -356431 tests/data/fate/vsynth_lena-mpeg2-422.mpeg2video > > > -51ca353620f85db8b5b1c56f1a275add *tests/data/fate/vsynth_lena- > mpeg2- > > > 422.out.rawvideo > > > -stddev: 3.15 PSNR: 38.14 MAXDIFF: 49 bytes: 7603200/ 7603200 > > > +87e5c69775b363db649c253050536045 *tests/data/fate/vsynth_lena- > mpeg2- > > > 422.mpeg2video > > > +361341 tests/data/fate/vsynth_lena-mpeg2-422.mpeg2video > > > +93cefcf101e6d0814acfaa626a02be90 *tests/data/fate/vsynth_lena- > mpeg2- > > > 422.out.rawvideo > > > +stddev: 2.97 PSNR: 38.67 MAXDIFF: 57 bytes: 7603200/ 7603200 > > > > > > Patch LGTM. `make fate-vsynth1-mpeg2-422` works again on my Ice Lake > after > > applying this patch. It was broken since commit 17a59a6, see > > > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220221122715.4244 > 75-1-onemda@gmail.com/ > > > But why PSNR got worse? Which case? All PSNR are better. vsynth1-mpeg2-422: 27.90 -> 28.68 vsynth2-mpeg2-422: 35.73 -> 36.23 vsynth3-mpeg2-422: 36.05 -> 37.90 vsynth_lena-mpeg2-422: 38.14 -> 38.67 > > > > > > > > Thanks > > Haihao > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".