From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2206E4399D for ; Mon, 4 Jul 2022 08:40:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5980068B9F2; Mon, 4 Jul 2022 11:40:47 +0300 (EEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ABABB68B890 for ; Mon, 4 Jul 2022 11:40:39 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656924044; x=1688460044; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=rt2n+fChU7ApVtXjCif6kBsBQV0hinQ+8vjG45zXosg=; b=ipbVMZfAJFot5apwx7R8ebbcaEkB0YtznWMgKboAp8qojXzEI2f/Ugyk hbetJ03ySWtAAyjwuxIKWNPpnii/KvlKv3rTudSMigcu2E7yn//kaLrv0 89jId78NCQktSuHngn462XbRkvXTLynJYz27bl6qVkvK1e94P0p/3vSVh R4Ol4X5Br02PrTnnjp4yS+ZhRt6Mb8vSkXxEldImWd16AHd+NFPizDUC9 7NzKT5H8shS0bO6a0iO71X2/Daax0TUHeBRvhVv40mBn7kCtBbz37l4p4 m9IvM8UwpnkraLs8dhm+CfCMiijOwGUJ0KXQIY6TKivulUxpftB4I9udK Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10397"; a="284182255" X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="284182255" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2022 01:40:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="567100243" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 04 Jul 2022 01:40:37 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 4 Jul 2022 01:40:36 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 4 Jul 2022 01:40:36 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 4 Jul 2022 01:40:36 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 4 Jul 2022 01:40:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BguqTDFRYrsdLdT8dw5j12qY+YTHam4KQlnogDfK1WlJ63P0CZNRnJH616FWCnh98rBiPB+RWnLFYcowOFoZ3zjlFJKPsyZHfN+L5tSuSLSZgfcXFh5HI0bfoMP74nQI99pk1TWMmSQMQKf8AqI5X3QJQMlxSJoOFJa4LoF+N4EdO/lDjrc7+xJH2AuEUeN9qq/xm45ADBv4c7zfA3Db+2h1WpYJs5kc82vgkRNnNIasmpv6J6Mc/KuOvzMtiRUFLshU/Lk5iKOL1xKdbwDpgI8Ygw8WQqguitSrNERNKBH7APbBzyPEbEFrlyH/LQcH1xtl0aAYfsmYANk0dPC1hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rt2n+fChU7ApVtXjCif6kBsBQV0hinQ+8vjG45zXosg=; b=GrMH/cn5+4oSe2jM7vlWDMen40mHgAuSOR4uxpSv7vBWR80RyjMxQsuWYovtYxg2P4jzBFArFkdUts6f65tmIIHE8Pe1gZDJvE6A3Nh/n3gB8+H6BYjoXlne+62UjG2TEUgfUckGzzSfrEnnHSHMtp3vnQJoga02klAW+KC+j1WtM1ILgC6F+9PSDJJzNl9iQ4Zwj0LDtvs3GNqM8IxM5HTdnoEU6zqGEvcRtkyZRAfx12v4JD155ZsXPgazxpUsYCF76X+5L8K1hh9zKcscwyhanHiXav9EnHN+n/hl3T7LQaajvBpe+cspO3eTW8cQpekBX0nPQDXWzROuGFk84w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB3879.namprd11.prod.outlook.com (2603:10b6:a03:18f::17) by DM6PR11MB3100.namprd11.prod.outlook.com (2603:10b6:5:72::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Mon, 4 Jul 2022 08:40:28 +0000 Received: from BY5PR11MB3879.namprd11.prod.outlook.com ([fe80::b02e:fe48:73f6:f310]) by BY5PR11MB3879.namprd11.prod.outlook.com ([fe80::b02e:fe48:73f6:f310%6]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 08:40:28 +0000 From: "Chen, Wenbin" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v3] libavcodec/qsvenc: Enable fixed QP configure in qsv CQP runtime Thread-Index: AQHYhsNdtQTqFte73E+7S94k0KTQ8q1q4aGAgAL0Rc6AABDBAA== Date: Mon, 4 Jul 2022 08:40:28 +0000 Message-ID: References: <20220623053242.360909-1-wenbin.chen@intel.com> <165675474959.31466.10582792568629584963@lain.khirnov.net> =?utf-8?q?=3CBY5?= =?utf-8?q?PR11MB3879CE08DC7589348CB1CBFDF8BE9=40BY5PR11MB3879=2Enamprd11=2E?= =?utf-8?q?prod=2Eoutlook=2Ecom=3E?= <165691711340.12703.7049243388119130188@lain.khirnov.net> In-Reply-To: <165691711340.12703.7049243388119130188@lain.khirnov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 818f7fb4-20ae-4c4b-753f-08da5d98d952 x-ms-traffictypediagnostic: DM6PR11MB3100:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9NQN+n6+g5m0SNCMQCJZQwtfYR3zEH5efTyZAccI39yZYFmWTjGcRRx2/8fajqhRFkTwrkwvaz4LWK6Sj/qATzAFZwpTeDvcLFjGj7gVW2/sbpLAImZzbPTpd43mL0wiznAeeQn0V/Tp5b3caD2SpteBVNWIuQAeBX3jxLE5lLT/9u/3wvGmi32KVH476H7AgaQB0linuEqSzuSVO7xyzccLFWro8xGKVfu4dtCvLOVdNnhtBssthIZ5+YC0qxsA8h8zvtS5OmDtCODQqRSm8fcZ/lJzfm0leRM0evNJ+Zwb9j8150p7n9V+gReKXKjo57NUk3oD7PL7pntVxeoHlEox14Ei3IDwOBP+bU/OwjF2mWxKhm22775WvypLRRQSytBoC6LCcWrC34onYhlShG9Y3Fl4U2+VUTUjOsr7yX2pIszQlOAS05SEoMb4KnTm+ASx7FIKN7H/6Nn2wZq5QwjfQZzl5gkJsZTjZkHMXOGvjsNlSxKVyNqp0CPGUKSPa8Ejg0KvW06vrXMkaZcDHivCgUlOyr4AdL74Rb8ccbNxDfoHmweKaLOv001xGI7wfHA/FKDqbymQFGRS+AZfVTbMLtVf+XO35nW0WQpTjFCLLDn99lws/IKNnwiYv1zbWAfn4sRn3VUGSlAFokBnVYhNs0NVeyqan3oDAcQtJkyH/V0/Qr0ULT1kgX2ioLareMjTxq+EDNOxHVTTe756DKgVW4lKjfDCeeA166D/gGY/ple8BDiWmgC/TEGJ+fRdXeGx8FH7C4sBItm3xOXs2UAFt9pjn5IjnDad3ox/oc/FX0PxInNz0XME6u+r8+IeAOoPTeqCdjNRI/VSFAHNBlI1BROzwlPk5PhZ9/Vd8Bg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB3879.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(39860400002)(136003)(366004)(376002)(396003)(38100700002)(76116006)(66556008)(33656002)(66946007)(66446008)(64756008)(8676002)(66476007)(86362001)(316002)(122000001)(55016003)(71200400001)(38070700005)(6916009)(26005)(9686003)(478600001)(966005)(2906002)(41300700001)(8936002)(52536014)(6506007)(7696005)(186003)(83380400001)(5660300002)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vLICtBZ6tabyvX13EPhwWpxz+UxDZwJ0IGptT/sonzDHCkbD3XcH0lma0o2h?= =?us-ascii?Q?kCiWn5/J/nrRxYFJW2/0E43mwkaAxgzv3uL1VhQeXmn8d8XuflneyCw0IDuh?= =?us-ascii?Q?8kJVLyNxnJTZvM1i83kT28TVkqNhleSGTTQfN1iDtVj5fol4wcvKXcIj4mz8?= =?us-ascii?Q?lQ15GYE+p/FKmSA9Q9nxq/tEiOp88p28ELkrRRZv4Z983sUOiMpHK5CKsUV9?= =?us-ascii?Q?w9oL0OZAWuXiUprX4MFUA30TyuEzaJ61GwVWSQyM6WkYWLCneNhMZirAwi6F?= =?us-ascii?Q?/9w9aP0BxTqmmPCDONzPgKV1sAHVrW82adpGfacZEfkiRron66MzRCd+duro?= =?us-ascii?Q?RRnLRk8nDYYZWFXikVf8UccWendz+RVeAYgvEPsvxfSNnldK2Huip6Avg066?= =?us-ascii?Q?m/h2t4AYL80TyxLm9M7Dqbx9gRhvzSK6wZ+OlhgjT1Ck7nHICYCHZi9+uGwd?= =?us-ascii?Q?yh6pNTU6PKsw/Q4qTATBcKf1BoKhWU1YKccWwMLg33CMMte7XBM2ufMUFBwa?= =?us-ascii?Q?0No4FE6I2DWgL7xRzb/LDpl+AyfhdhI1QN9Zk+KpoqG4qcg/4LYkRp7LHL6J?= =?us-ascii?Q?osAhhmIsAUn96ZmsFYnNueQZDYbjOB/Vli2AQ62RXqu2tAmBalsyROxoio4+?= =?us-ascii?Q?WmWOousVW4JwzhDgQYtA4VHMo91QLHX+7ufrC5OLV8AQmYg6BP/oWNBXLrb7?= =?us-ascii?Q?1IVdYRmHJ+qnh9KnOX6udJvzjQXxlj7YCq1Va325uisGMuxLhZiAxL9j3KMS?= =?us-ascii?Q?Bm4kAuSatMxPtDD31XGiuoo5I7Koczh+JdqYWxFK4eXhANxEGFiBrr8mtOg6?= =?us-ascii?Q?KT5uuNrFEtp4ClfI+Q2XJ6tVVaQMoo6O4VbOSaE6qqQIaA5j//KtTqv1mgwc?= =?us-ascii?Q?NGd32pqb1ADjEDtwaTbugPZpIuJCLrehA9PwJt1GfAbu8aEAYRjoOjgiQEjL?= =?us-ascii?Q?WQ0SAiTDVXNrL3HJ5paWSAoBRlKCKKLKPiEV/YbDWPus9KZcSzxEei/VLxFr?= =?us-ascii?Q?pFzpXg5Q0XghNflt/K9whHgNF0G7xBQ8kYxwLe/uY7p8p0Kwz7nZHIss+7ci?= =?us-ascii?Q?8B9GU/3NbqVIVKvIexi6Kc0CvRxa+UgoEoW2lJeVIgDMAGOFRY5SfKLSb75b?= =?us-ascii?Q?9Hdg+XzZMhi32TzAuKkvywTqjhJQ/ddIklWgZZzhLEmrYMMvHD7IMclofkWJ?= =?us-ascii?Q?hJHa9A0awhk109+dhDq5AJBgAzMVidN/0FAKQBNd8tqEZHEg0DnZuGDwP8oY?= =?us-ascii?Q?c7OzLu+5zAqeXzzpZHMh7RDG2w1GT3LdkyeVa+oZa3pT/OhFq0rIwew2iksp?= =?us-ascii?Q?SPUAQsG6MFcIsImLfBYNjurWLL+FqZhk+hWtI8gZKlEXA56ashiPy3EgssuZ?= =?us-ascii?Q?jbpHKSz9grLyB+nc0quhbJcaWfwI21hFapnzIRkWcQiyxeCuGQBKj0ma4s9B?= =?us-ascii?Q?vp5uES4ovDR3odXYLihtzGpi+Jw+E0msOh8Mjn/WWlc4LjGORFcqbHakKusx?= =?us-ascii?Q?SfsmcuuCXI8rcFz27csS9rp/KpPUInncY5uVOaTROQw/Yuz3cPg9Hw1r27HH?= =?us-ascii?Q?jGODsPY/EC754yaH/euHO48eGEC0JTu3igttcTlu?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB3879.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 818f7fb4-20ae-4c4b-753f-08da5d98d952 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2022 08:40:28.8506 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mXd0vM/iTSRYsNZLxeYZA3NOJT2IJqML9KSyh159/5egTp/D3kdOBWYJn5lfmEbLt0iItN6D27w+194vxIs6FQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3100 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v3] libavcodec/qsvenc: Enable fixed QP configure in qsv CQP runtime X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > Quoting Chen, Wenbin (2022-07-04 08:33:49) > > > Why is this using frame metadata rather than the AVVideoEncParams > side > > > data? > > > > The usage of AVVideoEncParams relates to the "qp" variable in > mfxEncodeCtrl which is passed > > to MFXVideoENCODE_encoderFrameAsync(). This variable in qsv is for per- > frame QP > > configuration. > > There are other parameter changing supports I want to add besides QP, for > > example, gop_size, max_frame_size, intra_refresh. These parameter > configurations are not > > all included in mfxEncodeCtrl, so I choose to use MFXVideoENCODE_Reset() > to do this. This > > code changes the encoding parameters which means these changes are > applied to all > > the following frames, but AVVideoEncParams is per-frame configuration, > so I think > > AVVideoEncParams is not suitable for this. > > AVFrame metadata is also per-frame, so your logic does not make sense to > me. > > You could also just update the AVCodecContext/private context values > directly or using AVOptions. This is a possible way. I will change it. Thanks for your advice. > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".