From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1D4A442FF1 for ; Thu, 13 Jan 2022 05:12:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A4DF668BB6E; Thu, 13 Jan 2022 07:12:22 +0200 (EET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9812B68B4EB for ; Thu, 13 Jan 2022 07:12:15 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642050740; x=1673586740; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=mEhtv1w54mnZs95CGxaYaPuAh4+uzRTgSnAR4qRXfbg=; b=CFPvjYZ/Ftk5L4B1MIB+VR6lDA+zpMUBR0KJ3E9hd1fmfFHUnzJHCzPt NzOBx2yVO4jpLQKyR2QPP3+ZDO/uXW4yIFTc8HJlj1hN/l3z2RdowqRrM LJNC4K+vwzN167LiG5lbxxKXIPIOySZ9mczrq9clHT0LYscFaSTnRokl+ Uyo+NlE+IpedBJpaguYDY0T9LiUA/ag0CoYBZxM3U8FlvPO6PnuE2H/o6 PlNo2x95JtdlDuXu+pGbso3hu6WUD1BRvJFuPeIl7fwF+Nb0C4QjUXbTp bXN4vZzOyO7MOtU92mvZt4BmDRLlx/8b/kRukPtu8yTZ/b7P8dVcP6fLc g==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="330281803" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="330281803" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 21:12:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="613832549" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 12 Jan 2022 21:12:12 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 21:12:12 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 21:12:12 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 21:11:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XSj1sC/2DL7HlT4XLXFzbRFcp9ZtYyUBr3GyOgGUiaWnMBfmTlzALL+Ded+DW8u3IBZEyqSQK5puYczkLTrLuCzghN7BOtH5S5bZIdXjbwblqklJqb/iDtsstkdl4CMT/ZhmIhRiCuAg2ZYu5QD16u2/oPVDmG0Ol6BMxjoC1mBSJtEgeUvd6xD4urKL318yYscBAg9/YbZ8C1hXrKxVWi5YpjeL4D+iSyL3u6Cv40ljOWSwGcu7rLgIWa69d9Vn6HuofKl80vw977gzHGheb5gFSQ5sp478JfbnyFtEIpkWapNzzd5HWm2/7TUtvNKMSv5DVMgc+ipQueZcCsEBfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ztBZ71wJn9lFk4xUGiJ47xc60ofeA6cV+ql9ktCvvi4=; b=bk1Uiul7CyMUf6P2hmKZf0BXEXhrGl0hjvlQ8Fm3tJyxUjtjA8L+Dqjs4hkQ4r16nUyvaTsI0Etov49SZA0hWZwlW+XpqMCKb9N4RVuDTA5Imo+Lr/YJRXSF/0D7B1KpOO7H9KbIpYSYcK0whm4ytaSwzJaEFWuzYqKV9axRxJxjCWUF0qluoztIRnoGy2jsT+dUYo7BzZoZh8VfLC1ONdrY103Gafn/okJEtSt3tZSW+rosLtEazg6VtsCFhoC/DBnrZwCm/SDT7kAqGlijcpGvUab2SFDO7zbjGdZwwtQPcaISne8Slf+wrc5Y/K6Z0cXoaZOwzRlOXJIoMlbtVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB3879.namprd11.prod.outlook.com (2603:10b6:a03:18f::17) by BYAPR11MB3080.namprd11.prod.outlook.com (2603:10b6:a03:8c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Thu, 13 Jan 2022 05:11:51 +0000 Received: from BY5PR11MB3879.namprd11.prod.outlook.com ([fe80::550:e7c7:13c4:7e0f]) by BY5PR11MB3879.namprd11.prod.outlook.com ([fe80::550:e7c7:13c4:7e0f%6]) with mapi id 15.20.4867.012; Thu, 13 Jan 2022 05:11:51 +0000 From: "Chen, Wenbin" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH V2] libavcodec/qsvenc: Add DisableDeblockingIdc support to qsv Thread-Index: AQHYB3WNKa25Rx8PA0aiC5t3Fa8qaKxgV6SAgAARJOA= Date: Thu, 13 Jan 2022 05:11:51 +0000 Message-ID: References: <20220112052850.1147160-1-wenbin.chen@intel.com> <5654098ef3c0b196c981872ddb789e27c39354ed.camel@intel.com> In-Reply-To: <5654098ef3c0b196c981872ddb789e27c39354ed.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b651b4fb-4e74-4bcd-7d85-08d9d653355c x-ms-traffictypediagnostic: BYAPR11MB3080:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vFNm/gaePTkcU1ge0MgyWcLF/xUDlR0VZv9MxEtRznfRvidm0XcKHbims91D5c4PA5NY0M3aFpq+wMmjTlhTjX2YnEYpNhT6iWlKkGjkM4UrF19TVk6jJQA05L9ei4bnOxN46N9lyEi3hRC0vjYPoCHS3Wt7syIdBh4q91BapRhbjU+LSGFh/Agi50qOKEImD+8aUzh8TPcOm3WLcBAH0cfRKA6gVxp2+x0fcZ0fCjQDLYwu7EbAaqNI08AAwq0nIad26X5+1LeNfe6nn6UUtzzYabM1HRwcyiAAc0XDiWUrH3uatnGMLBYqwDeDPM1+Wnv7P07nVxdIB6oRVilEfM3FQH+k4nll8oaj6lLZfnGiqqW1zGSoT4TVS9qUCvSHZ3Cti0epKmNDzjotpS7JgrUvbCuI/tM0vxzXsZl42FP0LuvqvsYPfHMtlJMkknxQeFcVHnkSnctOgZdWap6jUWVeORew62B58JYYQGWLB7AJIQd4x12wDBbmN0GtQFr5ZOVRttlEv85Vs+Il7s8kQFPb7AmENAgwmEnH8950yy92yfs2DLbFVt/UzruXppBj5Fat2Uee9W6r/qaYh/aBmNAhaXY/ian/EX/cbJOp29GkBOEbEGrX1wSFH9mkHdLpxeYGGrkK15Md5AiiNlJzkNUTO3Tf9cDTcfFyrVFZHy9gpxVBFMALyAWG8DIU8KjkRdHukFrJPUUSs4JWd7BIiz0w8DgtCOLGY9bm1xLAx40AWGLemarXk7a6rEjlZCN8NmxQY+sDSO0jxujAzwBmyjzfuoVnWCbf9494paLpUpM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB3879.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38070700005)(8936002)(66476007)(966005)(66446008)(66556008)(76116006)(38100700002)(66946007)(186003)(508600001)(6916009)(26005)(9686003)(71200400001)(64756008)(55016003)(2906002)(82960400001)(86362001)(316002)(52536014)(7696005)(83380400001)(122000001)(8676002)(33656002)(6506007)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GkQh68FeEy3u40b8tuuD13dT7DJIod0pWDy3jPykPCOCw/qrb8ri1TiDqDmh?= =?us-ascii?Q?Uim8wFzGGGI53SpLBFt0ymEvvzkUGsSXiHZOFAV3AbFcc6GF/n9liFD1GNGF?= =?us-ascii?Q?Xgu5lBFg2bIHBJ5M/EsWMvefYM9tAtzhjiNUFYGmW79qCy4rdVrVMUC/xccU?= =?us-ascii?Q?E3+IE7djwwKOMTwDniHLP5DOEqcRKHfcICglRevOVUePDz/QjyVjJ1UkH5su?= =?us-ascii?Q?Ll0iloPvtkcDqYj9Rg7ublU1BiL0Mwe1XrMhyuyhtGnWSWFtu7dSpXPI8akh?= =?us-ascii?Q?0scTC5PMENNn2KuKOgf/D2cO9xFBuebc30tOAB2bH5e2u/WTuyxoeoAFNAIT?= =?us-ascii?Q?DHkoijOFZnMv4TKx68EJqEBCu23JK0dCsopsF4LbkdXbUsWjxcJySqGfpStF?= =?us-ascii?Q?ke/hvOzNNcuyQXIbAspFpfCqxKuFaYtHmauqqqKOwAFKJDc/hA1in9xzLkg4?= =?us-ascii?Q?qQFo16X16lxhYbCokEIjIfRaLrYKpP1SxfTTC5mMEWRdW1AyZsKG9SpldHhV?= =?us-ascii?Q?WBAuAyl+mYhQehJlxlMAhm+PpXrUVry4R6HtJDaQ3WrouvQdoLuv8rM427mr?= =?us-ascii?Q?QzYwJKJCrwR8y1dclOC20BxQjM7X9esXvuUjLGJ+r6f0c22MYQY/ZMuzN0zE?= =?us-ascii?Q?6hYfKh6aDv1P62PQjRbk+c8TiC/aHPMC3UgLq/IQ/UeHrQkaCcE1NLvIpL25?= =?us-ascii?Q?2ZalLGKnGLmSIcrQdpsiLiUY10H/fKC/+XywFEp/cMCifFKkiVojcyZ2LEPg?= =?us-ascii?Q?fnJ5SVta1tQ0DWN7vQUDeGaPSoTLcSGpXedM747XC/VCoKyhupc1Yf+ump/w?= =?us-ascii?Q?JR9bOhghL0Y2cTcZYbVpUXtgrZu68dVQlrhbQaBE5ZPQNOs3xXF1f4ZEsoYM?= =?us-ascii?Q?PFtqQvPwl4d6vtmo0Q5pwi9weLcV9XaICsSkbRCO4e+D153rdcMU+s3+cVzf?= =?us-ascii?Q?HlDZYQ+Vrfg6nFsfo+8C93BZgM5bOeGnk2FbqB+jSCXSzuhoKfoBPORaBl1X?= =?us-ascii?Q?R1uwEeF/cpTPCDHXV1tt/fPsz8t8HYC87sxm8CCNZqH5mxB3hm6rBcA5YILh?= =?us-ascii?Q?trYj5K/u7oG5c1AOEgn2/UeIc92k1T79Un5Uoyef++tcRrx9qQCKR/Jpn9ph?= =?us-ascii?Q?/WB70k513UVC0VleVKmRL4k8bhQ/5qjtMEHUxzfEhfwcqGhf/f+xwDQ/gM2j?= =?us-ascii?Q?ZFgZm7WKmaTruAItJoXco4z1SAPjCIXSVICwbek+M8to88QFQSaTRrYw/FXZ?= =?us-ascii?Q?03DIiztWIGOTmLeNJ3xUzMlw/oCpAlr9HHBxv8Rwuo0X/7WruKLpj1iYc1sW?= =?us-ascii?Q?0Mb3xUMxACO6lQkFRrALcNK3tZB5m9CGAdm4ut9cGj4PraUZBmadP4hL4GP3?= =?us-ascii?Q?8kYzMl36wlx5Ov2jMMLWCZu0CLUxip+XmeRqoxiS1ftGT2tseLurPnPg3LGH?= =?us-ascii?Q?YDol4HZMd7c0PewmPQtbgk/Vmy12AoYTxlMx+Vniz1rOdSSTTNQWvN3ncKWZ?= =?us-ascii?Q?wRuAxA1XmOTH2CCZSMn1uMz+5y7++EBHHFSJ3ypY/xbAe/LgkJhWAi6u0yDl?= =?us-ascii?Q?gUKf/+3LRY5YK6CgDTMk0IsxIj8WZgvDedGVfvX/J2uqPAI4eHXyT4ojfv2n?= =?us-ascii?Q?EAHNSZOKQOOBsCsppSeXnqc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB3879.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b651b4fb-4e74-4bcd-7d85-08d9d653355c X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 05:11:51.4738 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NYBsFvIkxsxY3VXfF/b6wdsS861bycgzXNxJQFK9oHpPePHUPSBWJqG78AouxllYBYaYm45K4eevj6ySx7Aa1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3080 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH V2] libavcodec/qsvenc: Add DisableDeblockingIdc support to qsv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Wed, 2022-01-12 at 13:28 +0800, Wenbin Chen wrote: > > Add dblk_idc option to 264_qsv and hevc_qsv. Turining on this opion can > > disable deblocking. > > > > Signed-off-by: Wenbin Chen > > --- > > doc/encoders.texi | 6 ++++++ > > libavcodec/qsvenc.c | 8 ++++++++ > > libavcodec/qsvenc.h | 3 +++ > > 3 files changed, 17 insertions(+) > > > > diff --git a/doc/encoders.texi b/doc/encoders.texi > > index 68921fbd40..6fc94daa11 100644 > > --- a/doc/encoders.texi > > +++ b/doc/encoders.texi > > @@ -3299,6 +3299,9 @@ This flag controls changing of frame type from B > to P. > > @item @var{b_strategy} > > This option controls usage of B frames as reference. > > > > +@item @var{dblk_idc} > > +This option disable deblocking. It has value in range 0~2. > > + > > @item @var{cavlc} > > If set, CAVLC is used; if unset, CABAC is used for encoding. > > > > @@ -3391,6 +3394,9 @@ Enable rate distortion optimization. > > @item @var{max_frame_size} > > Maximum encoded frame size in bytes. > > > > +@item @var{dblk_idc} > > +This option disable deblocking. It has value in range 0~2. > > + > > @item @var{idr_interval} > > Distance (in I-frames) between IDR frames. > > @table @samp > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > > index a13718652e..3a51d00ca9 100644 > > --- a/libavcodec/qsvenc.c > > +++ b/libavcodec/qsvenc.c > > @@ -346,6 +346,10 @@ static void dump_video_param(AVCodecContext > *avctx, > > QSVEncContext *q, > > av_log(avctx, AV_LOG_VERBOSE, "FrameRateExtD: %"PRIu32"; > FrameRateExtN: > > %"PRIu32" \n", > > info->FrameInfo.FrameRateExtD, info->FrameInfo.FrameRateExtN); > > > > +#if QSV_HAVE_DISABLEDEBLOCKIDC > > + av_log(avctx, AV_LOG_VERBOSE, "DisableDeblockingIdc: %"PRIu32" \n", > co2- > > >DisableDeblockingIdc); > > +#endif > > + > > } > > > > static void dump_video_vp9_param(AVCodecContext *avctx, > QSVEncContext *q, > > @@ -885,6 +889,10 @@ static int init_video_param(AVCodecContext > *avctx, > > QSVEncContext *q) > > q->extco2.ExtBRC = q->extbrc ? MFX_CODINGOPTION_ON : > > MFX_CODINGOPTION_OFF; > > if (q->max_frame_size >= 0) > > q->extco2.MaxFrameSize = q->max_frame_size; > > +#if QSV_HAVE_DISABLEDEBLOCKIDC > > + if(q->dblk_idc >= 0) > > + q->extco2.DisableDeblockingIdc = q->dblk_idc; > > +#endif > > > > #if QSV_VERSION_ATLEAST(1, 9) > > if (avctx->qmin >= 0 && avctx->qmax >= 0 && avctx->qmin > avctx- > > >qmax) { > > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > > index 31516b8e55..aa49b35f07 100644 > > --- a/libavcodec/qsvenc.h > > +++ b/libavcodec/qsvenc.h > > @@ -44,6 +44,7 @@ > > > > #define QSV_HAVE_TRELLIS QSV_VERSION_ATLEAST(1, 8) > > #define QSV_HAVE_MAX_SLICE_SIZE QSV_VERSION_ATLEAST(1, 9) > > +#define QSV_HAVE_DISABLEDEBLOCKIDC QSV_VERSION_ATLEAST(1, 9) > > #define QSV_HAVE_BREF_TYPE QSV_VERSION_ATLEAST(1, 8) > > > > #define QSV_HAVE_LA QSV_VERSION_ATLEAST(1, 7) > > @@ -97,6 +98,7 @@ > > { "b_strategy", "Strategy to choose between I/P/B-frames", > > OFFSET(qsv.b_strategy), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 1, VE > > }, \ > > { "forced_idr", "Forcing I frames as IDR > > frames", OFFSET(qsv.forced_idr), AV_OPT_TYPE_BOOL,{ .i64 = > > 0 }, 0, 1, VE }, \ > > { "low_power", "enable low power mode(experimental: many limitations > by mfx > > version, BRC modes, etc.)", OFFSET(qsv.low_power), AV_OPT_TYPE_BOOL, > { .i64 = > > -1}, -1, 1, VE},\ > > +{ "dblk_idc", "This option disable deblocking. It has value in range > > 0~2.", OFFSET(qsv.dblk_idc), AV_OPT_TYPE_INT, { .i64 = -1 }, - > > 1, 2, VE}, \ > > > > extern const AVCodecHWConfigInternal *const ff_qsv_enc_hw_configs[]; > > > > @@ -169,6 +171,7 @@ typedef struct QSVEncContext { > > int rdo; > > int max_frame_size; > > int max_slice_size; > > + int dblk_idc; > > > > int tile_cols; > > int tile_rows; > > > patchwork failed to apply this patch, see > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220112052850.1147 > 160-1-wenbin.chen@intel.com/ > > Thanks > Haihao I see. I should submit patches in one patchset. I will resubmit them. Thanks Wenbin > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".