From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 32B7149E17 for ; Mon, 10 Jun 2024 21:14:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B361E68D7C5; Tue, 11 Jun 2024 00:14:34 +0300 (EEST) Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11020002.outbound.protection.outlook.com [52.101.193.2]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3C0B068CC58 for ; Tue, 11 Jun 2024 00:14:27 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D9dpUF4Hx7IW71A+UtjkLpHYEF/+y45VzA0likMMLOo7dZIlrVHTxudSt8D3Ivl4iZjbE56R6L4ZTEHDPGn/F72cOoNqRguq4Pnj3dsBqr6QSYOvyHSbDmrUran+A1/zEvujGveMwuzNi3Ligrs1Q59orEFHsNr7y1w2qpi1VONLVajV3/OBonfu+ken/feCmS5l1grQ5PQfKN/2BLOng0fc5K3W4ktABewqhvmc2x1a3nuCT94dl9abnJ3ZFPmrJ5MmMrV8XQR8+SPmcWFd9uX73d7P4djQYopDzf6wBxSLxKLubnI+TZrCCRHaRS12Zp9G6D4AZYz/Gpne77UIMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9l77lmlA3eRc7EymJ6OwFkMDBrmQwC9FMNeiYUR9M4k=; b=aPLLbTUWVFY2FSTa/42r7oh+es30k14XhQpfJLN0JYHz/05p6P7sEX9EKC13qEJGXLnuviDg1XryEEYhZXkhpItxMii0dLTgLUzJK92xjSzgHbxcqk8PjHXGSlaMJTL9ogw3MG32IVFj2Cur6gsTn9Ec34fl/2b1fV26e5tEQMhWW+PTHrY6OZCeFwgHRWumSse4H3JCJ2aIU7IpkSw5D3HddAHkdmgew56hGYNooulaIqg5WrRqCN6qL3RZpoDHOsewbEC24ml2Esj7ta18DZw9ILILwIFr8N4X4cQNNBGD7CF+mqTgS5fC5zFZnx0HZJQVu7gImCb0NHvg4NuCIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from BN7PR21MB1636.namprd21.prod.outlook.com (2603:10b6:406:b8::32) by MN0PR21MB3146.namprd21.prod.outlook.com (2603:10b6:208:37a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.16; Mon, 10 Jun 2024 21:14:22 +0000 Received: from BN7PR21MB1636.namprd21.prod.outlook.com ([fe80::7dc7:a9e6:aed1:4506]) by BN7PR21MB1636.namprd21.prod.outlook.com ([fe80::7dc7:a9e6:aed1:4506%7]) with mapi id 15.20.7677.014; Mon, 10 Jun 2024 21:14:22 +0000 To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH] Add extra const to FF_PFNGLSHADERSOURCEPROC. Thread-Index: Adq2+Zwvrp03FEyfQ/m/zE+pJyVT+wEgUtW5 Date: Mon, 10 Jun 2024 21:14:22 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-06-10T21:14:22.076Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR21MB1636:EE_|MN0PR21MB3146:EE_ x-ms-office365-filtering-correlation-id: 37cd977f-ec78-4d12-7571-08dc89924cbb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|376005|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?WPBS25pQRiUM4GPfBZWBl81nLFjB+ZxZGDkS+ZzZRPrIasrA7Eqm+CTRk0oq?= =?us-ascii?Q?t34FSt3vsmHvmu/FAL0/Qqs+j24yh77+xgCOC2ralEh7NV0ruHwLsd2w5vHg?= =?us-ascii?Q?mB6qxROEkeq485JRNgLesH9VnHi6fEhg0a4hQe8BGDKFTYTjeSBiYjAsOfVf?= =?us-ascii?Q?qDzXZ3Xkpik0wf5jrnzXVEHw9BIIhZNFR36zWoNF4dq7YJAu4bSgrpgAW7AG?= =?us-ascii?Q?WPfPtR9r7UIzrFhVqRh4x6L8TwuvSzQ6PIcqYkQTQ1pi5w0WTGXtXfyVbJUX?= =?us-ascii?Q?epwFGeOXqc6wF4T/FT3Xd1q37yhoQjE1lXV95Y7RQkVPVriCJ/Uy18nC8Svb?= =?us-ascii?Q?DiXI3SoRkn3N9CNRof3qUBNt4yDvZ5iWBlMcyburSgeKnI89oy1gplp8wXNd?= =?us-ascii?Q?8JF1vyeX7dbZoLYgLIhet+t6zlkxsa5X/l9AgLplPAIr1CcpUUwUiyxKOWHB?= =?us-ascii?Q?uX/3X+t9NfYsvDFdu1Qx8q7yxewwqx5w8AJJ11ni4eOEeP4oQWA3OL4i1bo/?= =?us-ascii?Q?ZSpBpY3kCedMD528w8HnjlsWkbt6N3QwaP4SScwsAcQnS81RRZv0Rb+SWvLX?= =?us-ascii?Q?BWR/8LixJaESDgt26FnZTKRn0kCdfCJi8mx2F47tbXSg+fpR9ObXhgS2ofz/?= =?us-ascii?Q?epu9u/fjg3PoL/CE/JBs6h7LYTcNPzpbn9I8pXWPTmljW1rDCfqVCOmjqhvy?= =?us-ascii?Q?tO5vJWMfK+QGr6tFvjGjVRN4C587Pf5JCLuXNtiuAZ5vHm0H5gRJzNxu1xZF?= =?us-ascii?Q?Qn1rVVjnP+tL1x1I7BA1nyPK93QbgRiZ56dka7/rtpGkOmt16wFJaI8GeOUQ?= =?us-ascii?Q?cGr4Fuahy/c1ixFPsMscxQtBU0lhhqSgqfqAQfaLGOVDr7SjXbAbY9AOKrY5?= =?us-ascii?Q?0GswPdX/NPP48fQKmPhmsSDSUKpR1le/YyZgtBnDno8Et9QDM0W0iFErdiAR?= =?us-ascii?Q?tr1X/bXy8/Ck3GKVKNF4RWZWC3qPiu7pwQTPkaq7IHP0SApGI/fdzyNJl1Yp?= =?us-ascii?Q?b0yvFnA3gyzd5MPBpWvdwohXDqx3awYhxVC0bzkVGm2lxrGdL+VQRjnGQkWA?= =?us-ascii?Q?QsvItLGvt9tN+1lavwZxvu/sE0A8wMvoYN5I7romDMkydnwGQOGXJug223o8?= =?us-ascii?Q?ZAJF0vvZKfsSmoHqyxUf91nyJBjbWyaCoYMS63O1sQrRdP6YWk9dZinVqcwO?= =?us-ascii?Q?6EGipr9+D3hkyzZgcWq2mr7YfTGmBtHZGlaM/kOD1EuMNZLexv2xVVpsibJq?= =?us-ascii?Q?kH4qtoB58RtFHQ+qbbb4U8s7ovUBc/bqAotkETk7En6VJdTFGxAfFJtb6Jge?= =?us-ascii?Q?cxWzIp87P7FRUuYgMLqkF0NoE/JT3tuwW4Qm5vVcE1zw0D6QlWv5QNUMK2B5?= =?us-ascii?Q?Y2Twrvw=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR21MB1636.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HEFo1jcuS384LB4bZt8nKDZlsvrdoPE7sr+ZFBf8EW8ZEnQ7CHuc0hFtVWcG?= =?us-ascii?Q?RC8ZvG2gvrn/B2Lc1RMoXTjrnqpeKJyM6OBUXzpTfdGXPzcI4ACGWN6z3TJK?= =?us-ascii?Q?MTY6J1iZxYNEFyE2LXs3aOtnrdODaF1wd0oEkbc3LWuq0fmtfpPv8ENrEIEM?= =?us-ascii?Q?HAraaoXxgjfPLI5yfljl39QpoXANwsdn23OxcIy4IQK5lH5nig87/vXWW+H7?= =?us-ascii?Q?U9YQpNf672vv5V0sKAOce6cTgBoD9O/PNgewhiC5jsx7YcNr7GQdrrJEKXoB?= =?us-ascii?Q?dOyQ5WgNPUpakHLk+QvaSTiHmKvYtHuwyGnzdX88pOTLCYscdyZpSwAFT+rY?= =?us-ascii?Q?0jb3s/UB/Fd9l7SMb7CbKblUtThgZoiqs8xkpf3qCvwEIUOzOV53J1AAfcSr?= =?us-ascii?Q?CaIs2bRgHFa0A0btQKKf1tKuFxNiFWuxcdHUx7vjPRdKdSEuTscXZt9kV9tB?= =?us-ascii?Q?4Kbb1Fiy/iYRtGbjAi2uC2rrV+SgzGQdwdoLhHzMXwCb7Le+5zTWuUcf7bWW?= =?us-ascii?Q?48sBTyNAx5z3k1vWcXeuggcqi/iNWvMZQpPar+6zU2qG5I4B78sLEQZpOM/3?= =?us-ascii?Q?DilPs699v8teJWcXkFOh9nqMlfPdHRLhKhxYtUHzVQmrh4c+liHjMxb6wrZn?= =?us-ascii?Q?YLmxdKcddBCUQsNWLG47PqJ0pxvKVVpICeTugTYp6Hdac6e4zPM2csCysBZB?= =?us-ascii?Q?4TKq4DOWgVFjiyxfFw73XQ0cPiO0BNM2WC++svqpGsbP1Vy0mt5Iss6KYcRl?= =?us-ascii?Q?5Q9Co0fscl2VyPGyvcIO1ABsvRWgvFYFdW5nB6ZNCxkpljTDq77r9QHqeRWz?= =?us-ascii?Q?zz/sTPIU7iat3XdeP9s47NaNK7OayYiBk6EnQ+BzBtAKbPfKTPq16qP5JkNf?= =?us-ascii?Q?C+ozh4/LLS7ugNrZM0C9Ahvto1mRzRwW5JhnCGQsneuQY7tK8mpHl1zyOh5y?= =?us-ascii?Q?s6o5IG2BgVpS7R7OXRY9pUDj34SSr85UiRcAAzJEN5jidWBiBO/vCXmFprtw?= =?us-ascii?Q?ZgIy9TDt0jxUQWUjr1dtqJU5yNDkk9EYLM0V3HSREJ4O53IRXK72rj88m0ku?= =?us-ascii?Q?34i1V+zKv8ytKieBwSLEFR7xZr2/AG9rLRJ/q2vTwfBypBP5vSz5UptQXhRm?= =?us-ascii?Q?A955ZizZrB3zC+TjC8erxN7JWxvWctPrC81QmzB+i35sO/K/kdmqn+MCaAlN?= =?us-ascii?Q?8rMF4D9omyFJsrsiY5G/5tGf/mdPCQWDCigy/h9Rt6LTSxaRp8h3GZlSddf+?= =?us-ascii?Q?BrUulgbHSdWyrDcANxvOLDH+9CdsBWuxwHQm/s4XDovxCP+8te98sdl7W142?= =?us-ascii?Q?BIGbonCYM1mkVdnGcyZgdTPDMS0ZZ9+z0GId/8FUhPgRzCb7lomeIbljGXZm?= =?us-ascii?Q?Eea/w8lxe2b9X0QYyCkJHdlFeACq5vrAVi2LQjZWwJLkvAdPRQP0AZGsVjcW?= =?us-ascii?Q?BlFaxV/sdrxBd6pCfPyv265JKwk25rXSSTwu2mTNBLWi73xR5H6yIYL+/zRa?= =?us-ascii?Q?015dVFkWVw8qg/qpXTlk6ITc0MxHzTIO9Ut+MY9ANPGpHZHlA3Wc8vp68Ys0?= =?us-ascii?Q?1ui71F/6TLu0OVEdp24=3D?= MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR21MB1636.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37cd977f-ec78-4d12-7571-08dc89924cbb X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2024 21:14:22.5198 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7azSTMaNy79wdt1yhGoyMKPbFCvOQXRWNdiqyJ0k5TWXST8B5VSxMpCpExnZjf9RJQhQ5C8hxf4hXf9s8TDidA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR21MB3146 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] Add extra const to FF_PFNGLSHADERSOURCEPROC. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Billy O'Neal \(VC AIR\) via ffmpeg-devel" Reply-To: FFmpeg development discussions and patches Cc: "Billy O'Neal \(VC AIR\)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi there folks! I double checked patchwork and it looks like it's still showing the first version of this patch, before I applied suggestions from Andreas Rheinhardt . Should I resend with a different subject line or is there something else I specifically broke? Thanks again! Billy O'Neal Visual C++ - vcpkg ________________________________ From: ffmpeg-devel on behalf of Billy O'Neal (VC AIR) via ffmpeg-devel Sent: Tuesday, June 4, 2024 8:39 PM To: ffmpeg-devel@ffmpeg.org Cc: Billy O'Neal (VC AIR) Subject: Re: [FFmpeg-devel] [PATCH] Add extra const to FF_PFNGLSHADERSOURCEPROC. Resolves the following compiler error on macOS 14.5: ```console /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/System/Library/Frameworks/OpenGL.framework/Headers/gl3.h:1891:21: note: 'glShaderSource' has been explicitly marked deprecated here GLAPI void APIENTRY glShaderSource (GLuint shader, GLsizei count, const GLchar* const *string, const GLint *length) OPENGL_DEPRECATED(10.5, 10.14); ^ src/libavdevice/opengl_enc.c:482:27: error: incompatible function pointer types assigning to 'FF_PFNGLSHADERSOURCEPROC' (aka 'void (*)(unsigned int, int, const char **, const int *)') from 'void (GLuint, GLsizei, const GLchar *const *, const GLint *)' (aka 'void (unsigned int, int, const char *const *, const int *)') [-Wincompatible-function-pointer-types] procs->glShaderSource = glShaderSource; ^ ~~~~~~~~~~~~~~ ``` Signed-off-by: Billy Robert O'Neal III --- libavdevice/opengl_enc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c index 6f7a30ff9e..7805b641d1 100644 --- a/libavdevice/opengl_enc.c +++ b/libavdevice/opengl_enc.c @@ -117,7 +117,11 @@ typedef void (APIENTRY *FF_PFNGLATTACHSHADERPROC) (GLuint program, GLuint shad typedef GLuint (APIENTRY *FF_PFNGLCREATESHADERPROC) (GLenum type); typedef void (APIENTRY *FF_PFNGLDELETESHADERPROC) (GLuint shader); typedef void (APIENTRY *FF_PFNGLCOMPILESHADERPROC) (GLuint shader); +#if defined(__APPLE__) +typedef void (APIENTRY *FF_PFNGLSHADERSOURCEPROC) (GLuint shader, GLsizei count, const char* const *string, const GLint *length); +#else typedef void (APIENTRY *FF_PFNGLSHADERSOURCEPROC) (GLuint shader, GLsizei count, const char* *string, const GLint *length); +#endif typedef void (APIENTRY *FF_PFNGLGETSHADERIVPROC) (GLuint shader, GLenum pname, GLint *params); typedef void (APIENTRY *FF_PFNGLGETSHADERINFOLOGPROC) (GLuint shader, GLsizei bufSize, GLsizei *length, char *infoLog); -- 2.45.2.windows.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmpeg-devel&data=05%7C02%7Cbion%40microsoft.com%7Ce68dc19582364880041908dc85111878%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638531555682645982%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=uakgyRGMTFxgBQgMH6tXFGnrVY%2BFzcUPa7NMqWnyEpU%3D&reserved=0 To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".