From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C713449144 for ; Mon, 3 Jun 2024 15:51:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D5EF368D688; Mon, 3 Jun 2024 18:51:34 +0300 (EEST) Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11022011.outbound.protection.outlook.com [52.101.56.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 94FBE68D638 for ; Mon, 3 Jun 2024 18:51:28 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JJovfyoms3BDShBdw9IvCuSm1j3pj/Kttdv1ZySjx2X497RoiHEPN7QZ237RIkWtaJlIvhq2EKVd/zw10Rbvvt30qVkk7buxTeyLvvpwJXr9ifIUokxegNEqjc3f41o6OxWfKbv3KBWeErQQ7EPl7kgvM1oUxw3KaEXuM+SfTWKkzdRaKYc7AqePtRH1iyGMObWrP0ew9jptoI31qVdKuh8ZsdKdAAPHzGw845+l9VBsLhuiRFhtdsv5xJcp5lY++8s2oBpd6OdjX4RWmrlk02x87qO7IMBENt+RJeckD9wZvXamm0kE+4PQXc2IFL/SIkGO69Ps4+5OHYzNdzwAJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=764lzyPmufvuG07B7BjxQPMplIkX6VQyu+I2PIrXvHc=; b=ILh0VsLfdZJCX94OEK+KaWKjjKRNspHM29CX+Q1Qs/8uGBnGEy+j0oshBplRNgqmDD/2O1bZlrLJifthpvPdWrLbCscYuBMb8YUKCQT9tZWe9T1arkq3kwHdk1O2km4kjWYQd/7Txm0iWrExFlZRC1zbzyQtzfIZxW4yQXbc3+rLQvfYyXNtUWXMXgWtYL1ghZ6+khes2X3eN9Y90RcaRCvpP3jaRD54s+igr95FiAUJEQP7vyFf6Skwgg4J3U8wVsLX8PE1hOz5ZbLELWawIeY1IB0Zbo2NwOuw8FwCJdDVkD+CCVw6k4MuQ96iMZNnmOXGynuNqq56mTD2vYCQ5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from BN7PR21MB1636.namprd21.prod.outlook.com (2603:10b6:406:b8::32) by PH0PR21MB2063.namprd21.prod.outlook.com (2603:10b6:510:a9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.2; Mon, 3 Jun 2024 15:51:23 +0000 Received: from BN7PR21MB1636.namprd21.prod.outlook.com ([fe80::7dc7:a9e6:aed1:4506]) by BN7PR21MB1636.namprd21.prod.outlook.com ([fe80::7dc7:a9e6:aed1:4506%7]) with mapi id 15.20.7677.000; Mon, 3 Jun 2024 15:51:23 +0000 To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] Add extra const to FF_PFNGLSHADERSOURCEPROC. Thread-Index: AdqzjFACoILuP5/3TyiHmguB6eVpKwALqNqAAISm21I= Date: Mon, 3 Jun 2024 15:51:22 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-06-03T15:49:02.7880974Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PR21MB1636:EE_|PH0PR21MB2063:EE_ x-ms-office365-filtering-correlation-id: 3bd37193-15f4-49bc-d04d-08dc83e504c2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?BiONEGhQTZnLDVSl06Esv9gJHwvyf8rdXZDg1+HHs7vzcnuBJQ0+iU6pZ75M?= =?us-ascii?Q?xoUjlgoTlpeK5QEpjQ1lDr5G3PQxHnmKjXsIsVL/VXT41m8tLL2DfDmuaUUG?= =?us-ascii?Q?/zk01JHFPZtAAbvNj50P1acFCeeqpH7fl5ve7425AB1+7mq5DB2EbY56PoKH?= =?us-ascii?Q?lIJXLX/YXRARgihcbuW5hGRa0RqPdiLTcesBsmVal5SWKhU1GvXCos1HCeCQ?= =?us-ascii?Q?fVGP9R9p8fb0y9CHJfzhqWZiyxXCludidZmZoHMXzLWAqOT+SmCHgKV203AK?= =?us-ascii?Q?fgBY/EXRXCAVp7xUZat41oLVZFg6onj3I8/jTarfEka+h4bRWYnqDwDAvFgf?= =?us-ascii?Q?eRnMMFMWXES5ZbhfqU1iAWawMCj5hXLUnQuGVY0CZlkAOxNPNigL8vrZrK1v?= =?us-ascii?Q?CCClbZoB+DQ9rN/228Yf8GDVrOp1TkoZwtToU1Xh/q6vv4/Hv/STmB6eWIws?= =?us-ascii?Q?APQPhzleIdGdWkajg74RF5XeQNul000xftgwYGueMPHh5k0O79AKkXfO8tUd?= =?us-ascii?Q?y8nfM3yv01k7pS7ARbwltkG5WaL1wMYbNpHSw3DdXVkhG/CmxPCjdEmEIIz2?= =?us-ascii?Q?rpkLmCJWSxTxRz6cxSNdUN+9r9FB1a8qGGD9q5Uz48+jsJ1/Kf+Rk6Z3tOI3?= =?us-ascii?Q?df2OoYStIuOnMv4RItrZkhMTyM9u6jCMw8rYdZOH4X4Za7624KRQ6FY9pT91?= =?us-ascii?Q?Y9IoUYPo0Dg6a7Evs3cJNvyJ4sw2aptEO2jPETHFaGTTT2MDGClYxSEjAC/9?= =?us-ascii?Q?TwQ1jRL7Xr4wJjoDbKVcZ3fo/A8dS/UU4Pt9Vh88alTieBm5XpzAvqvmqWkc?= =?us-ascii?Q?1yOOqZc2ypCpvDYYusjv2Zabrt5rgpuuT0JGgOQf9qAGi0A1Fb8xVrS/wKBw?= =?us-ascii?Q?1WuoRbpLVkpIIfphOIHR2y9tgYo0wBzSzZ2ZTYswRCHryo1u878rq/SZPIUY?= =?us-ascii?Q?amlQSr6JaOxAhwB5ukoP/IzAySe+ZQVoh4RzzqO7h31vgWxyEc7yU1cUn/Mr?= =?us-ascii?Q?JTDxP1kSi3JeDJXkqlO/6/P9GB3++rfGV2Zlfzll1KIOvFUcVkqkhQvxaU8n?= =?us-ascii?Q?GtRjXekPepBFH+gJEW0E6ROZ3O6pTgcWsiUVYuunPs1GImZgxVNx5t3ZtcJQ?= =?us-ascii?Q?j2P9Dj0hYp+mzfa1EReuzZiU3n0CknuBwC7s7COsgB9w/TLv1bH1w/kZu95Q?= =?us-ascii?Q?yvUhvPiOgxWs9tEr4huFLC2L3K6bnVwJeDTWiZ7IN63v56iKax1zp4X0H2eD?= =?us-ascii?Q?XAusg1TdA2euoMFu9GeQceHBThC3rfarUI052SLbc29+qwz0ZUtnHtDnFXhn?= =?us-ascii?Q?AJcRevNa5w/9M6X1GlxQct2x?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR21MB1636.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6oJ6DSlIfnYkDM+fHwr6XIoDOUsh2PcDBHqjnUJaGchZ7AziCenBnOt6S4DH?= =?us-ascii?Q?4m5U5sZSvUSDE7CWFS/dEJmdo/IyobOvL7yJnpihXXzLczF30IXG1FexXX9A?= =?us-ascii?Q?1CtKjRN2IRH/i0sttxbkn0x0HNTwJS+EOJ4/r1vTpxk52G1tXtmhdbBO8CMB?= =?us-ascii?Q?RIDRTYRNaPBul9otjx06J46wz4JB24+P9K6KktvHQLxdbePFjw7Mkfx32bZc?= =?us-ascii?Q?2yjI50OlOgFrdIPodHmCEywkqXBRGoMHf+Bh1tCB9NjOjL4730q8qa+AuLip?= =?us-ascii?Q?TmHsGIFzXmnDiWZfmTPj+IvhnwQcMKMlc0ignzRP3OZTpapUwkqqHKnY7i65?= =?us-ascii?Q?G99Xrl4EvqzgQKWSZ2y/m9SXRH40VPj6Y33JUNdknyBQwL42Lh9r5LrrCkZd?= =?us-ascii?Q?+7VwaFstj8+YUwr1Sjo21WqLIJB78VWSmmokSdEusPJA1yzm1QGgZSwWNSY/?= =?us-ascii?Q?o4YRfCiyK7zAcnLWEYrjd8YClgAIwJWpKNi7vNymlOGPUJjkA5+INAweLnPB?= =?us-ascii?Q?AtB+KaiGEBUNJECdrGb2JD3yOshbdi7MXXWoiRk+wqcX8fNDa58mElSlPQTp?= =?us-ascii?Q?TQ5CY5WXqi4gLlXxlxpRws2vFXsc5afYQ1yCb/cYbtOxKVD1RUfFWmVeYmZJ?= =?us-ascii?Q?nrEzNslTCvnUW1MuN8HfeT37OSaqZRFy2jhxLiuA6qegSkhpSrZ5d169gbId?= =?us-ascii?Q?Bx2cDfg5bEDn1/3PBkKDjFg5sNW8/rh0OQVxNypx1+7rASi1CNUmOIzF3l8l?= =?us-ascii?Q?/CfPx61BsNs981GrAdp1dA8RkKljgqFxbUX4068Br9OVH7f4PxRSP5/spNiC?= =?us-ascii?Q?xc/CZd+E/sorUr2jGZz8zeecnBU023fQbb+MfJWx4rnjsEwJUO+pyG1V43Dz?= =?us-ascii?Q?FXJJuX0vqL0AGzjj0YkALPu3tcjoQQJ9v8RhFYoZLoSo2KVGIdZFtCQiKn97?= =?us-ascii?Q?QqqsMwt/T+STCmkAtrEsJ4XDXdBKOg3Eiqbpmf4skyrPw6bs+6B5cVRppoI+?= =?us-ascii?Q?yfA+NK/7cxvxNHk/iQzWiLdtkmBSPbVACPIp3LuHizxCaO9cW8iB/2ZWSFFW?= =?us-ascii?Q?fTpCvDUPJWn51A5xvdgu1PG/KbEs7GspjaF5BkZwSjFbOvlWk4VamwwKPoeV?= =?us-ascii?Q?5t2IbFX4hod5dUQG9jCRsEizJDX5fAI00wTYvV0sO3Xnyti4mAcuzLEmxlaB?= =?us-ascii?Q?A1xcerxCvR5ScjnklTXwCIyJa7SMoj+L5cfmIYLTmGVv88dnAS/F2AwdxIW8?= =?us-ascii?Q?0VK2d8TWWMZi6o+oH+mXqnWkaxWqZKAHl+mqvl8Ni+ItiDJor9e70ZsGz5Pn?= =?us-ascii?Q?1APcWF8BdAQ+Cc7xAUB2owQCUpj/PXZUTzdW+rjaxjTtaeHrf4kTPTr7xcg6?= =?us-ascii?Q?7eNQgltAJyKyd8Ph6yq8TYTSDgXaAdar1IPcPZ25+2JrOkdXePaIiQGi2Xvi?= =?us-ascii?Q?u8YJBiQuOkWjnmJaGO920YlSw2LuzCBnt4CAJ+7wHvvBfBmkjgZTVukNSsXU?= =?us-ascii?Q?Crc0WZgrWcjQMwpQYXf4mGkLInIRvN4SkfGtWc2P9RCQDxvfkQ3Mz53Bi85J?= =?us-ascii?Q?mJEXQOw/wL2s2o03jS/GbkMn0u4Zam6zL8c/9A5dWcv3vJI9o2jmSBjQ1RBi?= =?us-ascii?Q?8Q=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR21MB1636.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bd37193-15f4-49bc-d04d-08dc83e504c2 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2024 15:51:22.9783 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: idl09l94KX+EZ8EBEB9QJf8K57RdJoINHiseMc7hkBxSpfWXqhRj9c0EmUHXiplPazcmWC0aNz3pitpTyTRHrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR21MB2063 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] Add extra const to FF_PFNGLSHADERSOURCEPROC. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Billy O'Neal \(VC AIR\) via ffmpeg-devel" Reply-To: FFmpeg development discussions and patches Cc: "Billy O'Neal \(VC AIR\)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Assigning the non-const version to the const version is valid (at least, builds on other platforms succeeded). Would you still like Apple guards? (I'm hesitating only because most upstreams ask for minimal preprocessor use) Thanks for the consideration! Get Outlook for Android ________________________________ From: ffmpeg-devel on behalf of Andreas Rheinhardt Sent: Friday, May 31, 2024 5:30:49 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] Add extra const to FF_PFNGLSHADERSOURCEPROC. [You don't often get email from andreas.rheinhardt@outlook.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Billy O'Neal (VC AIR) via ffmpeg-devel: > Resolves the following compiler error on macOS 14.5: > > ```console > /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/System/Library/Frameworks/OpenGL.framework/Headers/gl3.h:1891:21: note: 'glShaderSource' has been explicitly marked deprecated here > GLAPI void APIENTRY glShaderSource (GLuint shader, GLsizei count, const GLchar* const *string, const GLint *length) OPENGL_DEPRECATED(10.5, 10.14); > ^ > src/libavdevice/opengl_enc.c:482:27: error: incompatible function pointer types assigning to 'FF_PFNGLSHADERSOURCEPROC' (aka 'void (*)(unsigned int, int, const char **, const int *)') from 'void (GLuint, GLsizei, const GLchar *const *, const GLint *)' (aka 'void (unsigned int, int, const char *const *, const int *)') [-Wincompatible-function-pointer-types] > procs->glShaderSource = glShaderSource; > ^ ~~~~~~~~~~~~~~ > ``` > > Signed-off-by: Billy Robert O'Neal III > --- > libavdevice/opengl_enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c > index 6f7a30ff9e..691bee22ad 100644 > --- a/libavdevice/opengl_enc.c > +++ b/libavdevice/opengl_enc.c > @@ -117,7 +117,7 @@ typedef void (APIENTRY *FF_PFNGLATTACHSHADERPROC) (GLuint program, GLuint shad > typedef GLuint (APIENTRY *FF_PFNGLCREATESHADERPROC) (GLenum type); > typedef void (APIENTRY *FF_PFNGLDELETESHADERPROC) (GLuint shader); > typedef void (APIENTRY *FF_PFNGLCOMPILESHADERPROC) (GLuint shader); > -typedef void (APIENTRY *FF_PFNGLSHADERSOURCEPROC) (GLuint shader, GLsizei count, const char* *string, const GLint *length); > +typedef void (APIENTRY *FF_PFNGLSHADERSOURCEPROC) (GLuint shader, GLsizei count, const char* const *string, const GLint *length); > typedef void (APIENTRY *FF_PFNGLGETSHADERIVPROC) (GLuint shader, GLenum pname, GLint *params); > typedef void (APIENTRY *FF_PFNGLGETSHADERINFOLOGPROC) (GLuint shader, GLsizei bufSize, GLsizei *length, char *infoLog); > It seems that the extra const is apple-only, so this patch should be restricted to it. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmpeg-devel&data=05%7C02%7Cbion%40microsoft.com%7C27bd60fa36b84575501e08dc81d21fa9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638527986685274201%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=YErh%2BSO4tliFq2fkkncCsj%2BwfWAhX6n2Oilt0Jnld2c%3D&reserved=0 To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".