From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5D99C44658 for ; Tue, 20 Sep 2022 12:39:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8FC6E68B906; Tue, 20 Sep 2022 15:39:09 +0300 (EEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4C62668B58E for ; Tue, 20 Sep 2022 15:39:02 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663677547; x=1695213547; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=9u/UZ8gIXm0EB4/FQXwEORnXC1qXDizZ8wahru44lcc=; b=LhWCZ6w8FJw2aEWieCsDIf+d9DTeRs66U9auPchclU3ufNRVwubKM8sM Gcp7kMXtgwNWCQBuRldBvWxu8j+spCIU6st4oz4dA6Dh3+pr6IBBVtgaz 7XcLQH+C2BAEk1bCVfSRYnKmvnErSUa3WJ2jc4UgJAwQ1RNK/ep/WCYEc WxAQSmC0+3aA63UubHz/zxXHG5Bh7mYwtNbYjfUALCi/zeOP2iSlMUuG+ L9pQZK6/xsQPiM9ZypAmfqZmopimkbJbiTqwhzNBOIoKN9IiGAloQgR20 1Vf/OplKh//n/MAIXSR907HKU09al/w0+IMrPwDbnfKVbgxx1hlUp1CEA w==; X-IronPort-AV: E=McAfee;i="6500,9779,10476"; a="297275018" X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208,217";a="297275018" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 05:39:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208,217";a="707975679" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP; 20 Sep 2022 05:38:59 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 20 Sep 2022 05:38:59 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 20 Sep 2022 05:38:58 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 20 Sep 2022 05:38:58 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.42) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 20 Sep 2022 05:38:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O4UGYqVXODkT/PbiP5foubqdQ9fzjx11dDLtLAUa9Gjq9ZfBeQUO5DqB5E8gUbp52BAbXjXVN/ODlXs8FsU9c5QGckV3Qb/qfE0JQb3B+y2kcYDhJnKyUmUeVPm4e/ohLLNPm/L6YWbFdTAkxm0dC+qKxJqpy+5pLm3VN73ovFCW4BmaQmO3IkJyNe1lGJPWpcoZ4A/09S3Va7PPKb+m00ISkQx5mLhOrCDvFWZrUd+VQN76DvHJJ3ickwRyQgva3EZ2Q2iz0bNmd8/2eLeQilfVOjtD1Zsqb/+4dV2I3qPUPaj7mY5u5fAAOGUHO2yrX+MDLt+Ht/KohDeeird/hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=op7AzbqMX16Ucjlgo+GPRH4pRMtgmIsCe/eyqDSdFxc=; b=Lb/kgu5gcTetYqsBdr+m828oGBlV0nOvaxeg3+YTrThFW/Z1nnyxU76dPfpHs26nvdDmbis43OJXS+qLzXUnM7NEUCtTxJpm5iCT/TIXPtL4k64iDUP6fyMpBmFPjpzhxsFqoejREUy9CBY/j+oJyQsHx7zYo0L1ROmEkX8ZG+OTNy/dkm/kdWNSIL+U7FdU473tr4t+mHeivLkWFi9kCkgp0YB+iqfPmhJ8O55+SKG9+VaTUNX5zV0pyDZlW/xNJaFVa4JLgmF5zckrPrQkfkOOVz8KF9gqZc1Lt4lfuK2+HAgqSTLv9AD1ZrdIld3i/0NsPUiQ7agBoKjLBu80Vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN6PR11MB1746.namprd11.prod.outlook.com (2603:10b6:404:fb::20) by CH0PR11MB5425.namprd11.prod.outlook.com (2603:10b6:610:d0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Tue, 20 Sep 2022 12:38:50 +0000 Received: from BN6PR11MB1746.namprd11.prod.outlook.com ([fe80::3d60:779d:f20c:c43b]) by BN6PR11MB1746.namprd11.prod.outlook.com ([fe80::3d60:779d:f20c:c43b%4]) with mapi id 15.20.5654.014; Tue, 20 Sep 2022 12:38:49 +0000 From: "Wang, Bin" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v4] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI Thread-Index: AQHYwoWvHr7Wo8pbbkGSfUrYRaCEwa3m0FiAgAF+kFA= Date: Tue, 20 Sep 2022 12:38:48 +0000 Message-ID: References: <20220907062641.23091-1-bin.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN6PR11MB1746:EE_|CH0PR11MB5425:EE_ x-ms-office365-filtering-correlation-id: 2ae751ca-46d7-4250-cf76-08da9b051116 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JAAzPcVJguwKijmfvZA/bZdHSzQuMzfPpSge4XUSSzBQG5U3cwLRANFgbR9AZ47yd1jeIjMMBHiwMW/t6OMa5j1V5YxhcQttmAmyg+pHbjjpHKoBNDs1We8gPGrX1FnLT320ZT6u+GgLUr0oBRZc6B1GR6gwx6ul3HZRr0lFqZHHdrJ3LFeN1f3aoHMVcfuh7WPmtgUaj8u+ERl3Wp1uDcQpNGATCF34GBTVMKz1Z4FwQ1LV6IaSiZfQvbEdcheeNpldwNBAkeNMwFpUqQY1gnLGbh73173woGKjTUEx0FxrFOs+mhgq28EhvRVjkIjKWkM6Z62c2jL4M0cD9TT41h9UZjhnctcSf1BYv4uQ8PgB2ktbur1lCcUd6E+i5xAz3BGMwwbVA7ZOy9XIEomUkPxPVwFYkgSJ3hpzulM9I0ZqAXfZyPGDgeSyaadAEhjulVVc8K8r3SI5iz7x/9YwO/8jvv2Zq6yMCH+DZIy3HKgEuoMkQJx0VKDcq4VkArrgA9UPuMwvAeT2DCVyBi2ZJpPc9xvc9TUiDLa1PHHdvGUw8boOtOgbhAINFW5yoADLbweg2MgVYpi2eVpIQK/9TkCKGt1TH0/9QH5rumHTNfxNOtiaKQSJOrWtJ5pBMyWFL7jNUjaW6Cun/GlIeeuByyFST5/8yOPeV5uTiXzHk7qH9bJu1UxJTu9hWcp4kxe65NOIhFUQ5HZgCeWfksd9BjQlrLHrZShIcppqXnUiIZmdP31Q8xwV2CWgafzGwwHsipic0rX5eNc63sHolyK4wVJS20cNYTOeJU2qVAbn8Lk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1746.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(136003)(376002)(346002)(396003)(366004)(451199015)(966005)(478600001)(86362001)(71200400001)(8936002)(41300700001)(5660300002)(52536014)(8676002)(316002)(6916009)(66556008)(66476007)(66446008)(64756008)(33656002)(76116006)(66946007)(38070700005)(122000001)(82960400001)(166002)(55016003)(38100700002)(186003)(9686003)(7696005)(6506007)(26005)(83380400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jESoHKrMStKbWyd2wUbKWukvSYwBROWG5ELUWudpxgYpD0Y1i7ptIjPwO2oE?= =?us-ascii?Q?FIhZSmuykCOhbmJNtATa6+H5rFsD+nzxgPCoTSwsX9GwsU/O8KOJDladNCvc?= =?us-ascii?Q?U/wpzM+EBwNDQKoyasa4LxBEM5g57AHPuj9zo+E187lV5+N5NKrN73+HCEH1?= =?us-ascii?Q?E6VRj/3XwccbdLoHIrrFdWaY88saKdjRWQs1vJgU5KqTPQZkktU45sgJ379g?= =?us-ascii?Q?Jko3VtUSAceKau78NO9YWcOaBUIUxTSfsGrnqKhiSMeHWdHyAdZ+kdrNk1JQ?= =?us-ascii?Q?914GEgOKRwRZylXV3+KT1f3vXcRfXo/vF7Zy5qoamOiNa9xYq/TKHLvMJcOx?= =?us-ascii?Q?p+fEBBkIE8HXvJlOoL5nTnp6QyUf+DciuxFwzX6gP12aDuvg3vKTKLr8MDRy?= =?us-ascii?Q?10oJppLw4Q9AbQdTI3EUc6tracT0Yg6rItRWO3xxUNaJtBMnzFFpNuQ/7KSq?= =?us-ascii?Q?kCJs57OqSxQYCaaRLRc63Clz3Zu7j8ZlNsnTnUxXmtfbE4s8NX9vSkJOukQW?= =?us-ascii?Q?ttD0o1dtbenAMODsosSPzcrF4aBfe8Aw6KTJ6ss689PwfwHSVLDQOwLMif6V?= =?us-ascii?Q?IuPYmK6+ihNeOJTTzfvFuLjf61ofeJRTLdkHwDKKhkqg7XYGJaDRv5jDpE9H?= =?us-ascii?Q?Ei3ypLmYXk02wDeqaN0wbQSTe5ELr3/Ylxkwxfk4aqZeB67RGSkqZvsx61by?= =?us-ascii?Q?LcgPZNnz9wC0WL34MHYXovZ52RdhUBKsTCrBw5+kEJx/bm9jPPSA/nrTlcOC?= =?us-ascii?Q?oNYAYs92NbIDbLm5SInXSngJi3mguTex1EpX7chfXRVcpf8fCUX4DrYE4zjC?= =?us-ascii?Q?mlDCvvOWfnlvXa4NdXQWpmY34BcbrERG28E/96hnZTtCKcMjs3Uri2G5C7YW?= =?us-ascii?Q?lrBU6TLfpKJa0rwM+LED8qZjCwvMNP1pYDTELMmpdf0bs3ypA/M1xq330IXO?= =?us-ascii?Q?3LcLZQzJe7O6saSghex6SwT3LVY2vegKVm9NZii+KNnTRW00Z2URyzVCoytI?= =?us-ascii?Q?5GLPf5gGQL9NGw0a6AjID028TnFTwj19A3h7JzuQinVP7/ghUPl/wU+2q2IQ?= =?us-ascii?Q?kPeI5kUOIOXgFCF3N/BektHRx8v07yHwGRxc1Za4HC9tq+Z+WDwx+1MucWcs?= =?us-ascii?Q?0W0nQ+wR/Nx2a/apTzDWYUhvQL6b/iezUNi4RH6qhfVQdUhZUjartgn4Hh2J?= =?us-ascii?Q?6FtaA23LEMJaZmXBT3/sss1iPGthzMCups/hR9YqlSVw3doaSz4tXwbo0VZZ?= =?us-ascii?Q?K9jLP5ivSmgx3oWWDVfUREvXs/KTDkReQMd0OSw7l6skpHE114jaB4LMa9ij?= =?us-ascii?Q?9QbE47YJafityd89KsczYKpMVgRPhSfski0MXLUMZn0/wYKh0uCJl+4BdI3z?= =?us-ascii?Q?MSKObO+hsIqXnhu0sxnw8A6Dw+Jj3/bW0TGy6jYy6KAww6GWc6TevcFiEJTG?= =?us-ascii?Q?8ZS4PQAbRpH4Dr4PYPkwHkWKxgQKwLw+aIzVnUZ1rh/oMGubqNeg11ge+7AM?= =?us-ascii?Q?IwlWYpL04ia2nZPBeUAODkWL7toaL4os03pAFy7lidh5cAfc7tFsqusjc5nD?= =?us-ascii?Q?GklfgeQuwGa5o0ty2wH36ua+b7aUacYmwKrD9vjk?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1746.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ae751ca-46d7-4250-cf76-08da9b051116 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2022 12:38:48.9727 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WuRghsoab1iMhmpD3/1x40ts5OlgAN3Dk6fEVxsqW+p6dyj78QPWB6WtryWgyHCqOejBjnStLGPOsfkDJm6qDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5425 X-OriginatorOrg: intel.com X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v4] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thanks for the review, based on the comments, patch v5 is sent out: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220920103305.7902-1-bin.wang@intel.com/ Changes: 1. Remove redundant zero-initializations in asm code 2. Pass depth and nb_planes as parameters to ff_sobel_init_x86() 3. Filter-agnostic initialization was moved to the beginning of param_init() 4. I also noticed the duplicate configurations. But I think it may not suitable to change other code path in a sobel patch, just change sobel code path. 5. In order to move sobel initialization to convolution.h, I have to move 3 functions to this header file. They are setup_3x3(), filter_sobel() and filter16_sobel() Welcome more advice! --- libavfilter/convolution.h | 74 +++++++++++++ libavfilter/vf_convolution.c | 91 +++------------- libavfilter/x86/vf_convolution.asm | 147 ++++++++++++++++++++++++++ libavfilter/x86/vf_convolution_init.c | 18 ++++ tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 + tests/checkasm/checkasm.h | 1 + tests/checkasm/vf_convolution.c | 103 ++++++++++++++++++ 8 files changed, 360 insertions(+), 78 deletions(-) create mode 100644 tests/checkasm/vf_convolution.c Thanks Bin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".