From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 737A2430A5 for ; Fri, 20 May 2022 13:14:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 02A4268B4B2; Fri, 20 May 2022 16:14:23 +0300 (EEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08olkn2051.outbound.protection.outlook.com [40.92.45.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D98C68AF3B for ; Fri, 20 May 2022 16:14:16 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SoWOkCAZaoFBNDYnyH75ZiloKHKKinJjMfmABBaPKVIhhCKto6TPmaevlhZdTu3btgj3KBNvIoXpsx4sH2sDfcYJzXA0YTK/IslmJvw3aveHzpJEd25+PiCY5wAaPvEIPBawWJ4xuiK+u86rMov8N8DpRpp4sScgpt9vwO6p/pXn8vCJyEPZ8l1UaErzYrnsIRk2/yOano1jXiq7GGQWRXgtQdD5qQVxktrPefg4GjNecjMA8lSZeyd+7P+6ZrrPtRJdEkjwZ2tmEywZZREv0hAfVSM/lYe5YNUIeylXTnrYMTuEVHGJskLx0lrAqtnk6F2rOz+xnZ66s0dysQxhIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xi1RUm48dtTbLg8+mU2JvZpq7CxYBVMtnOX7CB73Mko=; b=UEeskTCMnDQU81trnTMzXdu0vAu7UkDAPTNrkJfogs6XtLCML6sfPBgVnTvd57Z5yji1eNzNziGOKo4Cj47Jufw4tP1AHVhbn+EWVvb3L53z+pKYjkVEMVHkpq1MegFWAkEWjoz5p1E253AIlePXHrhtGIopNVGBxBtmSxO00fe5b7MzVPMef6SD+JD64eepu6afVZowJjnU5ygkQcX0yZGAA/gxNNn/EKuStCvAh3rfx42sKQZBcZurs9wW4quDgPlmODde0CUZuHtru5VXf2Y0JVHpJgGgtPbq+gHgpv8rrX1m+k3I8kTMx/Bb/JCmwF7qZyxWaOL5rEmbXyqmAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xi1RUm48dtTbLg8+mU2JvZpq7CxYBVMtnOX7CB73Mko=; b=mxgi6pBriyfT7csxjlRLMBFs7E7Wm3Totrq6V6akfyJUSSkdiV1atjZdctk9F4XsBRTQYmb8Hp3oUASuNgnoQb4oNhBS7JN3yRcmc9ijTBRpY5FaqwN6b2jOn47SXCSStI4TVbiTIDylDLO6xmF5APoPiu0Zn1zyx4e/HbpHKLlg3pYUO/L4512sdjp/szqnmb/NG5L2LG/vrQ5T/25vlcc+2r9FUTt/UtxYLW39XxALD68YaWfj9gXISKNruR+MdirsRXPxvhWmQg95oUoZUkWFOESKygpdA9KLMTAuVb0sxWTvAldu4Cycyr+ECkW3B+4X5JFL2/kQWZ+ONnCmxA== Received: from BN0P223MB0358.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:145::16) by DM4P223MB0519.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:ac::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 13:14:13 +0000 Received: from BN0P223MB0358.NAMP223.PROD.OUTLOOK.COM ([fe80::9058:ff52:ab56:5b9d]) by BN0P223MB0358.NAMP223.PROD.OUTLOOK.COM ([fe80::9058:ff52:ab56:5b9d%9]) with mapi id 15.20.5273.017; Fri, 20 May 2022 13:14:13 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static Thread-Index: AQHYa9MhZAmI4J2BGkWRTzy53N4oQq0njh8AgAACJPCAABQsgIAAAfvwgAASIQCAAAKpgA== Date: Fri, 20 May 2022 13:14:13 +0000 Message-ID: References: <23cc0bf5-9cef-5b8d-7e4d-440776cd2e5f@rothenpieler.org> <9d414f9e-0a17-b490-e54c-7ecace981af3@rothenpieler.org> <434aace5-9e50-a32f-a8d2-4f0190e7e367@gmail.com> In-Reply-To: <434aace5-9e50-a32f-a8d2-4f0190e7e367@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [6rFfTMEQDzn+Ob0Xw4I9kJ5AZR1McXpP] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47ad443e-43a1-4753-9ce3-08da3a62a2c5 x-ms-traffictypediagnostic: DM4P223MB0519:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nKeViqULHQaLtNJ4FTlhpZdmG2Y7plAbLruWRTypcL9NNQ0UKk6usZX1oSyn2CvhVdgfdUg9FAJ6cYMqSuc4CRPaMunP1NeCPRtma0lrItZ8e9gSTjJdCun11N/knNFSENBC4P8pz5FXaeWLwvWagIQ7t6NeO5nmN4upd1Cm1qyFSt9VCSdanX6cGJSqmR29rOPp0nDTKq50y6RXhiOi1f4YpbPIYybbB1gMq7zXuIPIlCNBEvZlYJb6IEBMfNy6+69lErZDubQBPynG/97Q4qUj4Lp0z8zUFcAu9l/Yek+mUm/bFAsfMe79jEVmAAxHAR5WgRae6zv/IMoDtIbmAVh3/cl5kLGN8uw35bcq36lxDm0SSD2UJWtJUZefNdFl3B5c7EbYl/hrlLHPY/il6dgfxjTV7U7rX1s++BkSoIg72f7ioTB1+a5JyCjbhS4XdnoXKnrYoKpX/9MYBMUAp1OrBCkvx6REE2pSNHSNr95BPY4JOdBqBfsSstkHRPrUCnrPvBt2953MVRfqtOgJf2bAQRuPq+h5oj21UQJglNHLsSpoy2/6kvVjFbHvAot1G4B6+pX7SXEGBy8ClahLpBHuLIZtUFg5vArUHn/7oSzDpWmoO7VfgGxRBYZuRjs2 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S01NWVlJOUJjRHhmcm9zWFE0a2Uvc0ROT1hDMXV0bFNTR3A1emxseEs3L2FR?= =?utf-8?B?b21SMUpoQm51cEk2ekwrQW9GeGFybklJMlFkVUZXanpHbE9DUVIwUmRoaThl?= =?utf-8?B?c09rV0xjS3QyQWJyNlhXOW1TdzZWS3lwZGdsUnhiYmNTMUpyaFZXeE1jODFT?= =?utf-8?B?TUNrY3g2a2tQdUxESldlSDJMN2w1d1dkRk5qUWJFQzNYYnhhYWg4b1V3OUxW?= =?utf-8?B?eUE3c3pyUUxLNXRPUUxWN1NsVEwwc0ZKenRuYjN6bDE0UCs5N3dEUTJxR1V3?= =?utf-8?B?Qncyc2Zsb1lDdmd3ekMxZWRTRndQZmR3L2tnRTdaU21qNDROcFRGMmJRTWhS?= =?utf-8?B?UFRTd294MG5ITjFXZFB6OFo5YUt6ZGgyZ0hBSFg0a0huYWR5WlV1UDVZa29p?= =?utf-8?B?MzFCRjQxQXZEeXA4T2tYakR3WGo4QTNwc0VIRDBSUHBaaWFMaEZ1Q1pYSGtC?= =?utf-8?B?eFJvNkRlK2lFNjhkWDV4NGcraVVrWTdyYjdwNjZDT3VLbkMrbEhkdzVSZnNL?= =?utf-8?B?Q3d0Q0Nub3hBNVNnZmdINFYvY3Y2b3NncTJ2N3hBVDNtdHg3Z05ZckV3L2JO?= =?utf-8?B?NVpQNUtZWCs5UWRMM05WZUdCNHliREx1VjRwVXZKc3ZVN2lwZUlORUJ4Nk8z?= =?utf-8?B?WTh5VjdVbUpockhjU3RBeEh5MWlZd2p2OE8wcTQ4N0cxdnFERExERlRHaFVL?= =?utf-8?B?OFora1ZRSnhMcmhBMEtQZkxhd3RBY2l1TVV5S2E0eG41enV4TWNPVTdxM0Qv?= =?utf-8?B?RzJYa0JRMHhlVm9ZK1NKdDBiU0Q4ZUk4cVRiaHAvaCtHcyttYXc1ZXl6cFJ5?= =?utf-8?B?TUpxWnVMandqMGVPVDdreHcydzZ4RVNuVlFRN3F4MzNDcmZDZm40VW9IYkFO?= =?utf-8?B?UzlWODNmVnBheStzQmV3NlRzY0cxbkMvS1pGNzFOQkJhQUVJQW5JL2JOMnRV?= =?utf-8?B?UUFac1NZVWgwK1hIRnkxRUlJTFFnY09aeFJxVE9sOTIwNFphaXZ3dWtSZmdT?= =?utf-8?B?NkFuczFDWlZHcUJZS0d0Y0UvY1gyOHYrSjRUa3Y5Qk80TlhTMnF3aktNd3RM?= =?utf-8?B?K2RnU243eHJxU2tCSjY2bDc3ZGZIUEwrUTMrY3BZK2VmcnZHSTN4N1NiYVJp?= =?utf-8?B?U0FYa1hQNno0c3oxUWpzY0xKb1JPVFdzZHdYeXo1RVcvR2F4R0kzYm8xcFdz?= =?utf-8?B?NjZBYnRXdlNkclpZdU5tSFp2cWRUWm1Jait6T0d1YUhyc1BReGpTVDByWDAy?= =?utf-8?B?SWVLb1hyNkI2QmVPU0J5aUE3OTVCRGNzS1NsMHg5bDg2d2ZkM0ttVEtONGlj?= =?utf-8?B?RXNHa0FRR3QyRlNqaStyVEhXK3BKdld6Rk45NkdyZzdOcFlKeURndWVyaUVB?= =?utf-8?B?Q0hQcGl2UEsvVElrN0RMdnRQc2QyZVc0dU9NTUl6NFdIMjREZkhnbzNGd1Bq?= =?utf-8?B?ait4V09FS2tUZTk2T0p0SlVsRmFPUkNMRklYZWVUVjhRVkdxMFcrRTlzNy9V?= =?utf-8?B?RzBmSFQ1cGdRYjNqUVhiOE40VmFsaXIva0d2Vmt3ZlBwVmI3YXA3RDBKVFlE?= =?utf-8?B?Y1BmUStJS29wZ05OOTFkQi9KWXN2bFRMa0tuOWpXbWQyME15YVB4UEJnZFps?= =?utf-8?B?MGd2cWdvRmRwbVh6eUw4OGxnS1hzUXBJV09vOXRPQUZWVnB2Y3ZIaXM3VXpT?= =?utf-8?B?TDhVWmVWWEhTakdXcGhOb1BPTFNGbWV4QXpaZ1hnYlZMNS9jcGdlWnpkb1Vk?= =?utf-8?B?L0ErdGJ6Z256eS81SzBKazgxY3BwOXdFeG5LWWUrbXpxNlpOVG40dlVsWGo2?= =?utf-8?B?NmlNR1dTZEgwdmh2Ynd2RmY1L05MK0Q5THpUclBOYnpYd0htYU1wVDhTYjNt?= =?utf-8?B?ODA5OWFmSmxaZHl5K01PVTJ1bnV5NlNING5lUFVMYTVHNi8zUWFUUStMYTZa?= =?utf-8?Q?7qHAAIH3SdI=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0P223MB0358.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 47ad443e-43a1-4753-9ce3-08da3a62a2c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 13:14:13.7943 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4P223MB0519 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Derek Buitenhuis > Sent: Friday, May 20, 2022 2:50 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define > X264_API_IMPORTS when compiling static > > On 5/20/2022 1:07 PM, Soft Works wrote: > > I'm working with regular Visual Studio projects, though. > > Even dependencies like libx264 are compiled in their own > > VS projects. > > There's no MSYS2, no make, no pkg-conf involved. > > Things should not be added to FFmpeg in support of > non-standard build systems. > > As per Thilo's explanation, I think this is a more appropraite fix: > > http://ffmpeg.org/pipermail/ffmpeg-devel/2021-October/287426.html > > Matt sent that last October, but it seems to have been missed. Actually I had talked to Matt about it and he gave me permission to rebase and resubmit his patch. (due to lack of time) But here comes my dilemma: I can't submit something which I'm not working with usually and where I don't have sufficient experience to be confident that it's all well. There have ben several discussions about it last year, last one with Michael in December IIRC. I wouldn't be able to go through defending and evolving this patch, that's why I wanted to do something very very basic and simple. Kind regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".