From: Soft Works <softworkz@hotmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static
Date: Fri, 20 May 2022 13:14:13 +0000
Message-ID: <BN0P223MB0358EA121137C7F25B546E2EBAD39@BN0P223MB0358.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <434aace5-9e50-a32f-a8d2-4f0190e7e367@gmail.com>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Derek Buitenhuis
> Sent: Friday, May 20, 2022 2:50 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define
> X264_API_IMPORTS when compiling static
>
> On 5/20/2022 1:07 PM, Soft Works wrote:
> > I'm working with regular Visual Studio projects, though.
> > Even dependencies like libx264 are compiled in their own
> > VS projects.
> > There's no MSYS2, no make, no pkg-conf involved.
>
> Things should not be added to FFmpeg in support of
> non-standard build systems.
>
> As per Thilo's explanation, I think this is a more appropraite fix:
>
> http://ffmpeg.org/pipermail/ffmpeg-devel/2021-October/287426.html
>
> Matt sent that last October, but it seems to have been missed.
Actually I had talked to Matt about it and he gave me permission to
rebase and resubmit his patch. (due to lack of time)
But here comes my dilemma: I can't submit something which I'm not
working with usually and where I don't have sufficient experience
to be confident that it's all well.
There have ben several discussions about it last year, last one
with Michael in December IIRC.
I wouldn't be able to go through defending and evolving this patch,
that's why I wanted to do something very very basic and simple.
Kind regards,
softworkz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-20 13:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 22:52 softworkz
2022-05-20 8:49 ` Derek Buitenhuis
2022-05-20 9:36 ` Soft Works
2022-05-20 10:18 ` Timo Rothenpieler
2022-05-20 10:39 ` Soft Works
2022-05-20 11:37 ` Timo Rothenpieler
2022-05-20 12:07 ` Soft Works
2022-05-20 12:49 ` Derek Buitenhuis
2022-05-20 12:51 ` Derek Buitenhuis
2022-05-20 12:54 ` Soft Works
2022-05-20 13:00 ` Derek Buitenhuis
2022-05-20 13:06 ` Soft Works
2022-05-20 13:13 ` Derek Buitenhuis
2022-05-20 13:24 ` Soft Works
2022-05-20 13:14 ` Soft Works [this message]
2022-05-20 15:23 ` [FFmpeg-devel] [PATCH v2] avcodec/libx264: allow to disable definition of X264_API_IMPORTS macro softworkz
2022-05-20 16:22 ` Derek Buitenhuis
2022-05-20 16:34 ` Hendrik Leppkes
2022-05-20 16:37 ` Soft Works
2022-05-20 16:47 ` Derek Buitenhuis
2022-05-20 16:51 ` Martin Storsjö
2022-05-20 16:55 ` Derek Buitenhuis
2022-05-20 17:47 ` Soft Works
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN0P223MB0358EA121137C7F25B546E2EBAD39@BN0P223MB0358.NAMP223.PROD.OUTLOOK.COM \
--to=softworkz@hotmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git