Re: [FFmpeg-devel] [PATCH 1/5] configure: remove build-time check for gzip support in zlib

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ramiro Polla
> Sent: Dienstag, 3. Juni 2025 02:19
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 1/5] configure: remove build-time check for
> gzip support in zlib
> 
> On Tue, Jun 3, 2025 at 1:26 AM softworkz .
> <softworkz-at-hotmail.com@ffmpeg.org> wrote:
> > > -----Original Message-----
> > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ramiro
> Polla
> > > Sent: Dienstag, 3. Juni 2025 01:22
> > > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] [PATCH 1/5] configure: remove build-time check
> for
> > > gzip support in zlib
> > >
> > > Hi Jacob,
> > >
> > > On Fri, May 30, 2025 at 8:19 PM Jacob Lifshay <programmerjake@gmail.com>
> > > wrote:
> > > > On May 30, 2025 4:10:45 AM PDT, Ramiro Polla <ramiro.polla@gmail.com>
> wrote:
> > > > > I'll postpone this part of the patchset (patches 1 to 3) for a while
> > > > > to give more time for people to comment. If anybody can find a system
> > > > > where zlib doesn't support gzip, please let us know.
> > > >
> > > > idk if anyone is using it as the system zlib, but zlib-rs supports
> zlib's c
> > > api but doesn't come with a gzip executable.
> > > https://github.com/trifectatechfoundation/zlib-
> > > rs/blob/7fafed0d3ed7990349f5863dfba755cbac9ca543/README.md#c-projects
> > >
> > > Thank you for sharing this.
> > >
> > > The issue we're looking for is not whether a gzip executable exists,
> > > but whether the zlib API supports decoding gzip files or only raw
> > > deflate streams.
> >
> > with Andreas' new patchset, this question becomes obsoleted.
> > I'm no sure whether you've seen it?
> 
> Yes, I've seen his patchset. I really liked his solution! 

Yea, me too. Even though we both did some unnecessary work now,
this way clearly wins.


> We still
> need to figure out how to properly find zlib using the host
> pkg-config, something we currently don't have in configure. This could
> be a bit tricky, especially regarding pkg-config's environment
> variables.

I don't know much in that area, I thought you might be able to
help with this.

> But I guess you're right, with his approach, this test_exec check will
> end up being removed as well.

It's for the better, even though it came a bit as a surprise 😊

Thanks
sw


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".