From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F1445430AC for ; Fri, 20 May 2022 13:24:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F363068B499; Fri, 20 May 2022 16:24:28 +0300 (EEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2065.outbound.protection.outlook.com [40.92.40.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5A43368B49D for ; Fri, 20 May 2022 16:24:22 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xq9vFNX/XUKYgwPUkuChyXVyr125UcgWvFtV7V7y4HKrmxh8fxgVu4+kOHp5oB75S8RYlH5fj94/UQkjkpPVbekasBC86yhH4ELSq87mv0tPHd+3kiq/+UvLG+G183jKninVZkfhrNSM2XzmBYpfCyrtz6iqPJrmdRSniV9QJNw/fNj0lVedARwyMg6tRy1e2OgEzWGuR16ImQ/8x2uttzBEI9f7rnZd6j96tz7JBJTc+3bmJ0gy5yMgVKTFjtlXxDLEHuXjR4xu/cywfRvc21kpa3L11dSl7jU6UL3fHTtGah5NNRtsEUmKw1q9YsBlBV14B48a8F+lFVOZ/knqFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hyDYuFF5r2/sRrYAl9XvKEnQa1f3xl3hKvbcpeT3fSk=; b=L6HYVWtVySBMAtYZFPJYRltgd30+s8JAxlajbCrKD21UMqdV4HVwYBKJx6NtMwybfHhF1N5J/tDK/iWK2cD3gmSQLZ5mubflY7tFGVjj/dgmHqx51ts0AhWTYi4gRFuiw4ioTjTVCp9nlWpgR3tnsx2s5/7Q8XniDFYUNeqoH33mU+S78NVaisF65TyCrUUoiqvCJJz+3ugIpB4u8Z1k0gT8+znYZkYm7hU6h0RLrMK12s4xDCn+paJAijcufoeUbZk5nefjNhrmvszjxYCWEajk0v3T/rDCCasHTJ5vYSAaKmln8GyZNb+xUG4gFB4nkYxQN98e3IPXdPB2kyvQfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hyDYuFF5r2/sRrYAl9XvKEnQa1f3xl3hKvbcpeT3fSk=; b=eS288+swsb4BtYSnMQ0bsD+JNY5V2YlUBE+GBzIheiYmxmVoOZ7SXiZlXEkT4HI7HVCm3js3WVZZL/bl5Sok7kJ8ydWWaH+u/wmeOlVRLziGuruU9Xppv7ynvoNaJfsF2pdWoRqFKSd86zoGJhJtoEcCpPrMXTpTJ3VvgNWftI+Qha6uYNez77Mz1I1tRYAXgqafJmLMQU2sUMbCw9qSBIQtJAMexNtqc0xznRsNUQMQcZfdTvKyUcxspu8uVHQkSNcrc/CGNwxxnjmznKHMnrtYXdyK7eqPwE9c2tefi+hBcO5TSkPJZccOIJGoMgmkjqV5oLrB7sHFy6HnWLtFGw== Received: from BN0P223MB0358.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:145::16) by DM8P223MB0190.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Fri, 20 May 2022 13:24:19 +0000 Received: from BN0P223MB0358.NAMP223.PROD.OUTLOOK.COM ([fe80::9058:ff52:ab56:5b9d]) by BN0P223MB0358.NAMP223.PROD.OUTLOOK.COM ([fe80::9058:ff52:ab56:5b9d%9]) with mapi id 15.20.5273.017; Fri, 20 May 2022 13:24:19 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static Thread-Index: AQHYa9MhZAmI4J2BGkWRTzy53N4oQq0njh8AgAACJPCAABQsgIAAAfvwgAASIQCAAABXgIAAAKlQgAAB4QCAAABsQIAAAy2AgAABhcA= Date: Fri, 20 May 2022 13:24:19 +0000 Message-ID: References: <23cc0bf5-9cef-5b8d-7e4d-440776cd2e5f@rothenpieler.org> <9d414f9e-0a17-b490-e54c-7ecace981af3@rothenpieler.org> <434aace5-9e50-a32f-a8d2-4f0190e7e367@gmail.com> <215b9f71-0446-2e93-ec31-7a024f8c3674@gmail.com> <7747671f-78d9-a512-331e-3752a1cd10a6@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [treKEqWD6tSPmigODXEFF8xDY70i3UUN] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b9fbec30-b90b-41cc-2d1d-08da3a640bcf x-ms-traffictypediagnostic: DM8P223MB0190:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: opX9+ZZR7agqfM8qmyFiRaFezP0fW3cgEU5rfOzkAPsdw3/veTLGKNNTnTUCBG6xYAdngvRYzM+0+z7HgySOMQvn0OqLJaZ8+8k25nuDYbjRiOEssAPSXtzQxVm+Hvk0w47WttXb/vSj3HSt4LF+CUKbdO1lwylHTNRQiKKkzhxjOO5t0loV7XetcGzE/8IbnJy2QavxIK8dJOALwSJwDVVBy3A1Hdzniuc1iV5FvaNylxd7GmvrHSKDgw28E0fm9JbETAw/K51PbeA/akTpXF4JTfnzOKGP0UTsOROQlsGHR7PzoQ6cFx8rEvFrfYa70y/thdLauS8g1Do2X6+vfTbp7+1v4YiOiEIzeD+FGzUAv1mJYkoemN4BgVw5MeIioDL+c3PJOlG4S0mW8D2IQdVE03Sy5iG9LwiJOBSU8vWyQN5ITSv4UM/KQ3/G0iM5KoRf4kQAiRS0rjGss2a9xnre+uMtd32E16zBIJEWwikCpxYbhbmzr7qszNvWGO5hAweiTqJEBcW5IndqtSTGdVyczecoZELqPdMPKu0M5dea4zHJQRDCi4M8JMF7XqTAMd4HS1ngH6MWpanrLtUgKKyUR9Knpa2kuoj0Y+h8dwZ2eao9ihTdUD5t0+NshWxYtWn8696K6ZbZKjtjYPs5Y3BZ4zHuJ809ZRIBcCex2qw= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d0xKbGt4dGF1NFRjRXowSC9maXIvVUwxSld1RFlDcHJOWnFUbk9ySFp1K1lV?= =?utf-8?B?aHBkd0hjYVd4ajVwWmRhbHRReS9lN0E5MllKakF2RzVJb3RKd0lET2hGTmlQ?= =?utf-8?B?WUw2UDhtYjFzVDZPNlc5RGFTazVGK21qWWRnWktmZkRpaUtZcVlCbEhzL1Ux?= =?utf-8?B?UVJPUi9yNWJtYXJqL0NsVE4wWUZHNEZybVI4NEdHTHpzOUNzU1FKVVcrV3lV?= =?utf-8?B?bTF6YmZTNXVHKzF2UC9kUlh6TzMrVjkxV3FTVEZtSi9DeXRWMGsrVkFtd09R?= =?utf-8?B?M05CM0V4RG56ZzAwNjVEbGVqeGFucURYbzd3WXdDREZFVW5PTnYrMWdBOWhE?= =?utf-8?B?UXZrcVp3Q0dxOUxRdTdOTnRZcGhWdit0eGpzTk5DOUhoNjlEV1U1UTVkOXk1?= =?utf-8?B?cXhCR3krM3VzM2lZMUpsSUxhK0lCZjFtc0NGVU9DRFV4M2tyemEzRnpvcGFa?= =?utf-8?B?b25BZnc3Uk05elA0a2F6dXgxWGpyOVA1cHRCNXhWQ2x5Rnd2a1RESEkvUlBr?= =?utf-8?B?TER4VlE2d0tPUVd6eUtIOHZuNUlDQjhRMEdaR1lQYlRDSTVsWU5vUzdSRG9O?= =?utf-8?B?VysrWmdzYThRM1pBRU11bVQ5NVpMRHNjSCtvNG45TG1peUp6Q281Y1JrZ1pZ?= =?utf-8?B?cGlaZTNmZTgxejBmVnI2bEdlOUdIQmFLVnpLYWo4cFBNZWhuL1ZBbUs5YWdm?= =?utf-8?B?bmJlbFA5Rjc3Vjc2aEZYL1BjbDQyQTh4MDBLRGZpTG5FMnZ4TGdscFFvek14?= =?utf-8?B?Z2d6TnRVL3NsTWJISmxsWGpTY1hKa3pQSEx4dXVOa2dJaXpHd0Zyb211R3Jo?= =?utf-8?B?MGRBc05IVC84WVNGbHFuS0tOcFR5YTlRQkhza3JlbEZEKzYxSW1NZ2pxd1pS?= =?utf-8?B?TDVTa2ZUTFhaS09ZeFN2V3pjbWpUUjgzQ2NRN0JMemhRVHNSVEhXd3hZZ2hB?= =?utf-8?B?SG9aQTFVd2M4Rk1wK3RyeVdtV1U1TnNoejZrYlQ2Y3gveFVaTXZZRmhleEJM?= =?utf-8?B?K2NNZEh5MWs1eklqUmc1c29XL2JHV0Yvb3pFRzhUV2tpWWVyb2E0WUVyVHc5?= =?utf-8?B?Ym9PaExHd1hQdmxRSTBmemlaY1E3OXk1VlNRWmRMZHJuVWtSdjE2d1ROZjFs?= =?utf-8?B?VXd1b1RwMS9CVkF1bVMwdVBxbENQbTNDOUJETWhVUi8vbUxqa1FxWDVoN1c4?= =?utf-8?B?Tm91NVZTYUt0QW50cDRLMTlJSldQellsQVRCUGVtdjYraDlIRHdPd3JPZVFY?= =?utf-8?B?Y09qWkRGVDVuSTNhSXIyZXFoN2EvV2MyWEpWNHJqRmIxSjRLOXJBOXRJbnZj?= =?utf-8?B?ekJFejFpbXBVbXRaRnhDQjlIYlFnRnE3bzhjRWlZYWk5Q3QyRW9WV0pwTVQv?= =?utf-8?B?ejR0bWVyc3hKdTBRYWRQVW44bGM4S2VoQm9uSjZpeUZSYkNkelRXdVU1TUh0?= =?utf-8?B?WnduQUNRS1lYanhpcTVYcXlndDhUTGJrN0pKdGRuVzQ2UHhLL2lHT1lOZmFl?= =?utf-8?B?SldiYWxFZ1h4NTZtTFptVmxFZDdmRjJCVjVaNFU0WUNWMXJuT1k3VnBmS285?= =?utf-8?B?TUN4WWZSU3FsNGFDUjNNUmI2NHVQNE9kWXl5VkRzaXlpMnlUWUIxd3FtMmR4?= =?utf-8?B?bFV2RENOSE9WUGw2M2VWcDU5MitnWi9JVmx0bE5JSGorOHZ0TWdGemIxRnpa?= =?utf-8?B?cDN2QjViUEhVdmJtOFFyemVhb0VhMXhvUXIyaUs0Rm9jN3dsZzJUQ3o1eEtw?= =?utf-8?B?Zlo3Ylp2YnhtZDBKcXZEaXppYUtLeFdyaHNjSHFJRFJJT3NCS21MOUdUbnV2?= =?utf-8?B?dGJxckh1a1h3OVp1dVl3djl5eEtoNzVBRWdlRlRmNUF5THpMNmVJdjN1aTJE?= =?utf-8?B?cjFjTmxpTTg3Rnh1MlF6ODNrbUcwWjRscGpXdGpTVys2SHBuRDFSNHlmK05G?= =?utf-8?Q?L+28EoWVvtA=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0P223MB0358.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: b9fbec30-b90b-41cc-2d1d-08da3a640bcf X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 13:24:19.5145 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0190 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Derek Buitenhuis > Sent: Friday, May 20, 2022 3:13 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define > X264_API_IMPORTS when compiling static > > On 5/20/2022 2:06 PM, Soft Works wrote: > >> As per Thilo's explanation, I think this is a more appropraite fix: > >> > >> http://ffmpeg.org/pipermail/ffmpeg-devel/2021- > October/287426.html > > > > You say you think this is a more appropriate fix "as per Timo's > explanation" > > because of the following message: > > > >> No, not wrong. I was alluding to: > http://ffmpeg.org/pipermail/ffmpeg- > >> devel/2022-May/296605.html - and not the link. > > > > > > ...where Timo said "This doesn't seem right"? > > The fix he suggests, using pkg-config, is what the patch I linked > does. > > I don't know why it is important who is 'right' here, so I'll conclude > replying, > as it is rather unpleasant. Let me be honest: you caught me with this: > Things should not be added to FFmpeg in support of > non-standard build systems. So many adaptions have been made over the years for whatever kind of platforms and builds to work, but as soon as it's about MS, even making a super-trivial macro definition configurable is already too much and it's "non-standard"... Though, I apologize for my slightly overdriven reaction. sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".