From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1B2AD40956 for ; Thu, 5 May 2022 01:42:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D6B3068B310; Thu, 5 May 2022 04:42:01 +0300 (EEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9A9C568A642 for ; Thu, 5 May 2022 04:41:54 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651714919; x=1683250919; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=aJmbtTfAINlKLmmtwE0LQY047/lBVyM6Sdmk+YYyc9w=; b=Vv7K0wxdlpaPM0p58Gon1HXBBmYjYdqAsoqboOtpeCuVg+GNU0limDk/ FsYvSn8ITYdSLl5PmD5jX0GA56PqSC1Ui9SxbZfwrgIkgxxHH4N937G1B hRlca9WMwIpkVFrTzaC4ooov/TfSbkq6xRjyjW1RDwdAzTQmAYaV+6WiP JZFjYbOH/D5eD4ZUKVmffWZrftu44bFGYMTM7XxI5+SaIdx+zdKKQEI1b i/tu4UyREzNmPo2fy/50ru2S2zX8Cc1l8hAnZRtWenWy2/qNcJj0oYUds Z4w+WkRoYtuWpfjXYEuHvlGM+yUqYMXucu6vMMId2L7t5I4rQ8riRnQ/H Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10337"; a="255427134" X-IronPort-AV: E=Sophos;i="5.91,199,1647327600"; d="scan'208";a="255427134" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2022 18:41:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,199,1647327600"; d="scan'208";a="568370072" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 04 May 2022 18:41:50 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 4 May 2022 18:41:50 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 4 May 2022 18:41:50 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 4 May 2022 18:41:50 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 4 May 2022 18:41:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DJe17zo0hAoUVDzPNb0Hhbu6e7MgHdEeWOHa3N11dtBVCAhbQCFI9zLlWZcAZCihv2kbqLa+/V/OiqrblXpyNXsMMiI+/bmQHbsXm4DydFJchG3nxAdxIHPERq57pjrxth2WfzJfud9Bgz7NN/AKJJKaeNy2boLM+8bOmJQPuk7dEo0MA2UXCF68i/nrR/cyzzF2WYpdj8tgZfFuW9VNO/E16aWi6EjZVXZ29lOwJDb+Tj0sE/Hd1RTmMVT79rFHat/WBYgYma53elmL2OckdzRI788ANIqM0rsTiidwO6KSzgzkCF/8tISLB3T+jUI5bD6mQavDJdzKKj1f7jsseQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aJmbtTfAINlKLmmtwE0LQY047/lBVyM6Sdmk+YYyc9w=; b=bue0uQWwhC6Wc1hJO8XdFNKXulJMPFIn1KPW5Uo8ps8XH24mwDzb79mO6tUy+60fWyksfKD91y/F/e57hhwjge20gpLcN2qTvpUw2dX+Ad1uvwjPlfsEacly0Qk2G95kUb89cYlygSZC44MlYIwbh2kyJri0zFvBui5TcKpZdZWugXWhX9UnFhhpOgLeSZifrlXEo/EC229E5IjjNzAoCUAZfQ2/bpMW9676DRNtOZbmIb4HjjBUVAsVMw16nAH5FJSQZKZDNjFrExkwX4l1nDq3W7hvGaTl6BYGprxR/xhinye9L4UVDxfFDRUPtxfy9NMpbuHomh0QAdpUg9Htng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL0PR11MB2979.namprd11.prod.outlook.com (2603:10b6:208:7c::25) by PH0PR11MB5078.namprd11.prod.outlook.com (2603:10b6:510:3e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 5 May 2022 01:41:48 +0000 Received: from BL0PR11MB2979.namprd11.prod.outlook.com ([fe80::1817:efa6:252e:b97e]) by BL0PR11MB2979.namprd11.prod.outlook.com ([fe80::1817:efa6:252e:b97e%7]) with mapi id 15.20.5186.028; Thu, 5 May 2022 01:41:48 +0000 From: "Wu, Tong1" To: Soft Works , "FFmpeg development discussions and patches" Thread-Topic: [FFmpeg-devel] [PATCH v2 3/5] avutil/hwcontext_d3d11va: add a format check for staging texture Thread-Index: AQHYW7Y/LmoZbxIcuEqq3naGQK4Cz60IiUiAgAb7wxA= Date: Thu, 5 May 2022 01:41:47 +0000 Message-ID: References: <20220429104505.1747-1-tong1.wu@intel.com> <20220429104505.1747-3-tong1.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f3e55ef8-707c-4d07-0e8c-08da2e386b53 x-ms-traffictypediagnostic: PH0PR11MB5078:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xt99ygFnxhcw/hX38tqBy3e7uY0mpWVMXUpImK14ZqpJyTgupBuu6gPt6JpbpFwguxJkZ2zYEZYDZHQCL0vpSMG0g0XX0sFYAbrXU19ghDnIIRFqhprqxvu1WhX76YmCc5PC+N8S3c52FjSdTn5R+5h4do6xJhzHpUzm9hgZvKhDfaF/OinrUEFAJjXvjVQ6P1rFzcUqZ+xmgXlTmXf7g7O17bveyuUu4Ie5oC79pUwHsJxiZ4akPmC+PPXAYCejjIjHaIBNSUYEpGslUlTQrVThY8VcnY+L7HogQ+mIvo9GjWSgH4ulDqIF4hwnUOis/Y/xxEcyL43mT4QUyW8z0JelnLL0LZJywUH0ir1+rg8VcSyj9VBZA5oKiVzivx79nrwfiiB/Fzy7A5G65uvXwYw3HadkNSgQ+YZqKUd007TQCAOWiJORjIgbio0rMc4uOR6CLjy8330tDNDjQ0qj9ARXYXnpuroMNqZj5sKFywmbRlemaezj55ObaEtSkHGiBIJ0mBG7u3O+NcvjB6zCQoo5vn56xmiopxklU5xAa3rV6QDq5ULIJx43cS1t/3hW41YwHcoG53Jm2CSIR/hdkuFx24/3v/6Q+slPQy/hksemUpReQ3gb+mhYsez2+LO0v8/G6jE3qzHMQ9N3FbhkipzP9H8UTzGHFaY2HjTj//HOXskVMtOolwIKIho74kWEDKBWDgpsm9RMJnGM5SDJO5QKwlP1GJ2hk6O+7C+RkJo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB2979.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(110136005)(86362001)(8936002)(53546011)(316002)(83380400001)(52536014)(186003)(508600001)(55016003)(66476007)(5660300002)(38100700002)(38070700005)(122000001)(82960400001)(66446008)(71200400001)(9686003)(26005)(76116006)(33656002)(7696005)(66946007)(2906002)(6506007)(8676002)(64756008)(66556008)(460985005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MzRZR3RSTXNxeHJYRTJQOHovOVA5cytFa1dXZUNoZlI1aUoyd2l5ZWxSUlk0?= =?utf-8?B?ZHZ4Lzl6ekYrRDNqTWQ1ZXl0Tjl2WTBUSzFkRElFMDlpU0RlVTBjU2ptNDJB?= =?utf-8?B?dHg5STRpRmdwcUE5L0QwaDcxbStTTTJTYUYxTzM3R29sU3hMZHpDTFlIR3hM?= =?utf-8?B?S2Z0UTFUMWg1cm50eG1BUWJjWGgzVEZieHlJdm8yYTVtWjVyYU9mUytNRVQ4?= =?utf-8?B?dXphd2VWK0Z5dDBhbFIwdlRtWnNDM0ZxdW5vMkhIRFFsdzYrbzkwWW9jZmRF?= =?utf-8?B?MmNRQWRaL0xyOFM1QzYzcHJEWHgvbDhleG5sQ2pkaUlJZ1dmeFcxdSs0UUd6?= =?utf-8?B?SEl0RDh3eGdFdVRROS9JdmZsczZwanJNclBTNWJMT3BmcGJ6bWZxKzUvTm54?= =?utf-8?B?WG82ZCs0S3dYMU1ZZHo4bGlmYjdDMFRxdUZUTEdRSDUybFZHcmdlZ3pnY2xN?= =?utf-8?B?Slg2a05SZzJuNzFweFdGUWFQcE9YNFJ4WmFpbU94TFFOZGNQTlh5SHdXNkdG?= =?utf-8?B?S25GNFRRbkVOWWVZR3VHbHlkZ1ZibGFGVjdVeTNZRlVrbHBEVkNMUE43NUVY?= =?utf-8?B?cmo2bzlZVlFlOGUvaUNQbXBFZHJYL3RQRXJQbUxRbXd6cmYzdVh3UjBnMlNP?= =?utf-8?B?b1E5Y3JXS3RxMkJpZFpibWk5M0lZQTYxNUpyc3p3dDQ5NnFTNVRCNmFZWk9u?= =?utf-8?B?Q2xiMDFjTForSXlGNWRxWWFxeGloUjVQWGkxM2JBYlNNdDdaVkVweXp0bTND?= =?utf-8?B?b0ZtQi9udDZWK2s2ZVZmcThIQktLKzI5cGZ0QXZTeXJ3TWZuTFBWNDh5eXFp?= =?utf-8?B?ODVsTkJNNFZkbmxYVTNyOWtZQlJxdVNUajZmMkFRZlFCa2M1cU83MElkcGw0?= =?utf-8?B?Q1RFUnJwc1FFU05jcUR3ZFYxN3VuWkh2TkFSbGlFejdTL20wbTRObjh2M0pS?= =?utf-8?B?MEFrNUF6WDlYT2hDcERDbTNLR0YzeWo1NzBxZ3NEcFJDd2dNNE9aOFYwWFBs?= =?utf-8?B?eTlXLzhnQXl1YU5uNU00MVQ1ck10NFNLeFJQNTNxYXNGN1BZYkdXTkJYc243?= =?utf-8?B?TXFNdWc1TUNVOHdJRGJXSkdabzZtNEpjcUNSV0VFNWVNV0IwZ3gyOUVBeGVu?= =?utf-8?B?WHk5U3NHYU9jQW1MUzg3b1laYk5EUjZvZncyTXN5eWNzUWNiaXI3NlVFdUJW?= =?utf-8?B?ZytYU24rTndVNGJXZ0RDMzg3NjF5UjNwQy80cHpDeUFQb1NwL1Y3V053QnRJ?= =?utf-8?B?WjhzVGFXZHpaRXJ4N0xJaU9qdExQNEw0cFVXMU44emxkZG05V1I1TnJvT0RX?= =?utf-8?B?ZTYrMUFvNWpXYmlJdWh3WWE0YWtNMENvQUptMlFEMlFjaXB0UlZDNmhaQktQ?= =?utf-8?B?eldqL29neVlIclZUTlRqb0NYYU9mUUhsNUI3WElqZVF6VG00NXZMWmhwdFJO?= =?utf-8?B?U0RZRGp1TXRkd2pvcGZZdjlVZVJNcHpkL0RvTGNJbENRYjBEaWZ5a2ZYZGV6?= =?utf-8?B?OVNkeEcxcXdHN1B3VjFHWjduREJGSTRraDNGYStyeEdWazZ5MDVmcEJMRFd1?= =?utf-8?B?OFZ4RkJ4bEVmUnA2UHpyTGFNL05WNnUrODNTYjZabW4zZ2VSRC8yMjlHbkdC?= =?utf-8?B?UE0wMjFML29rKzBWazJ3bTl3c3Q5VFhpai82QTl2OXNzcVA1a2tyUldUNEpX?= =?utf-8?B?c08xMDJUTTVvaWFlZXhwUWRtTi9IejdDOHNaNXF0eER3MzRuSVVFYitqQ3d5?= =?utf-8?B?aWNueG9hZnBOKzZKRExzWHE0NlhuL092SndTOFlMZk9LSW5BWVVkekxTWkVC?= =?utf-8?B?ZU1DZ0pDLzJYNW5VeUp3R2JNMmlEYlpLamx6MmthVUc0N29CMXkzMjQwdC9G?= =?utf-8?B?NVl5NUhJd3NNTXZrT3BqY05tdnJKMEtQYXJnZzdhUlB6cXJ0Nzd3WUxYaGJV?= =?utf-8?B?TXozWHVETEZNbXdWTTlQTjlvUGRBSTZlQndsZGhMVTc5NEUxcVFDdk5nVUlJ?= =?utf-8?B?cEZNSUtKZTd0VHNDQmJEQ0thTERrTnlyMlpreW1hMFVpWW5rdVNXMUcxZjc4?= =?utf-8?B?cENNaENLNFlOMzdNSTkxVzVmK3RGdXZKNGROYWMwM3cxd1Ztci9uRTM4Z1FS?= =?utf-8?B?bE9SNHBrRzdQK05hVVV0Q3NtTzdJZU0zbUVvRHNyVXUrS2ZlNG5nait3SS9K?= =?utf-8?B?NEZCSS9BbUg2dVFxOG1tTWZ2UE8rclIraXBDQWt2TE9GL0hDam11bzNpYXVS?= =?utf-8?B?bnVKY29iS2FsbDl1ckcvMG03UzJkMzlCTzVMV016aEk3Y3dWUHdYU1RIUkJI?= =?utf-8?B?dFN3cmtIRXA0bjdrQUphbHd3OVRwMjNwc0paRkw0czNvRFBlTlZiQT09?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB2979.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3e55ef8-707c-4d07-0e8c-08da2e386b53 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2022 01:41:47.9685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SGGoK09SIJQCVFQYvCkRgcdjZglv0EDLXPpJnOoA0QBV0hJyYBCwJyrnJGUvbKVPCFRX3eL4NOXynBOa1pAtzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5078 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 3/5] avutil/hwcontext_d3d11va: add a format check for staging texture X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > Tong > > Wu > > Sent: Friday, April 29, 2022 12:45 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Tong Wu > > Subject: [FFmpeg-devel] [PATCH v2 3/5] avutil/hwcontext_d3d11va: add a > > format check for staging texture > > > > The texDesc.Format needs to be filled in with a corresponding format. > > I > > add a format check to initialize the format in case sometimes the > > ctx->internal->priv is not initialized, such as during the hwmap > > process. > > ctx->internal->priv is D3D11VAFramesContext. When it wouldn't be > initialized, then hwmap couldn't work. > > D3D11VAFramesContext.format is set during d3d11va_frames_init. > You would need to find out whether init is not called or > whether AVHWFramesContext.sw_format is not (yet) set during > init. > For the hwmap process, the new FramesContext is created in av_hwframe_ctx_create_derived and the init function is never called. > > If that doesn't work out for some reason, I think the next best > solution would be to add a 'format parameter' to > d3d11va_create_staging_texture() and in d3d11va_transfer_data() > (the only caller) do ID3D11Texture2D_GetDesc() on the frame > texture ('texture' variable) and pass the returned format to > d3d11va_create_staging_texture() > I think this solution makes sense. I will resubmit the patch. Thanks for the review. Regards, Tong > Kind regards, > softworkz > > > > > > $ ffmpeg.exe -y -hwaccel qsv -init_hw_device d3d11va=d3d11 \ > > -init_hw_device qsv=qsv@d3d11 -c:v h264_qsv \ > > -i input.h264 -vf > > > "hwmap=derive_device=d3d11va,format=d3d11,hwdownload,format=nv12" > \ > > -f null - > > > > Signed-off-by: Tong Wu > > --- > > libavutil/hwcontext_d3d11va.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/libavutil/hwcontext_d3d11va.c > > b/libavutil/hwcontext_d3d11va.c > > index db529acbb4..0ec0e07d3a 100644 > > --- a/libavutil/hwcontext_d3d11va.c > > +++ b/libavutil/hwcontext_d3d11va.c > > @@ -349,6 +349,8 @@ static int > > d3d11va_create_staging_texture(AVHWFramesContext *ctx) > > AVD3D11VADeviceContext *device_hwctx = ctx->device_ctx->hwctx; > > D3D11VAFramesContext *s = ctx->internal->priv; > > HRESULT hr; > > + int i; > > + > > D3D11_TEXTURE2D_DESC texDesc = { > > .Width = ctx->width, > > .Height = ctx->height, > > @@ -360,6 +362,20 @@ static int > > d3d11va_create_staging_texture(AVHWFramesContext *ctx) > > .CPUAccessFlags = D3D11_CPU_ACCESS_READ | > > D3D11_CPU_ACCESS_WRITE, > > }; > > > > + if (!texDesc.Format) { > > + for (i = 0; i < FF_ARRAY_ELEMS(supported_formats); i++) { > > + if (ctx->sw_format == supported_formats[i].pix_fmt) { > > + texDesc.Format = supported_formats[i].d3d_format; > > + break; > > + } > > + } > > + if (i == FF_ARRAY_ELEMS(supported_formats)) { > > + av_log(ctx, AV_LOG_ERROR, "Unsupported pixel format: > > %s\n", > > + av_get_pix_fmt_name(ctx->sw_format)); > > + return AVERROR(EINVAL); > > + } > > + } > > + > > hr = ID3D11Device_CreateTexture2D(device_hwctx->device, &texDesc, > > NULL, &s->staging_texture); > > if (FAILED(hr)) { > > av_log(ctx, AV_LOG_ERROR, "Could not create the staging > > texture (%lx)\n", (long)hr); > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".