From: Baptiste Coudurier <baptiste.coudurier@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/ac3_parser: handle more header bits in ff_ac3_parse_header()
Date: Thu, 5 Jun 2025 15:15:58 -0700
Message-ID: <BD12BE31-1169-4590-863B-BE483F530A6C@gmail.com> (raw)
In-Reply-To: <20250605214938.142938-1-jamrial@gmail.com>
> On Jun 5, 2025, at 2:49 PM, James Almer <jamrial@gmail.com> wrote:
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>
> diff --git a/libavcodec/ac3_parser_internal.h b/libavcodec/ac3_parser_internal.h
> index 46814bfb1f..ab5df34003 100644
> --- a/libavcodec/ac3_parser_internal.h
> +++ b/libavcodec/ac3_parser_internal.h
> @@ -46,6 +46,7 @@ typedef struct AC3HeaderInfo {
> int substreamid; ///< substream identification
> int center_mix_level; ///< Center mix level index
> int surround_mix_level; ///< Surround mix level index
> + uint8_t channel_map_present;
> uint16_t channel_map;
> int num_blocks; ///< number of audio blocks
> int dolby_surround_mode;
Am I missing something or this field is not set anywhere ?
Otherwise it looks great :)
—
Baptiste
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-06-05 22:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 21:49 James Almer
2025-06-05 21:49 ` [FFmpeg-devel] [PATCH 2/3] avformat/movenc: fix writing reserved bits in EC3SpecificBox James Almer
2025-06-05 22:07 ` Baptiste Coudurier
2025-06-05 21:49 ` [FFmpeg-devel] [PATCH 3/3] avformat/movenc: handle EAC-3 extension bits for Atmos James Almer
2025-06-05 22:09 ` Baptiste Coudurier
2025-06-05 22:15 ` Baptiste Coudurier [this message]
2025-06-05 23:07 ` [FFmpeg-devel] [PATCH 1/3] avcodec/ac3_parser: handle more header bits in ff_ac3_parse_header() Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BD12BE31-1169-4590-863B-BE483F530A6C@gmail.com \
--to=baptiste.coudurier@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git