From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 855B640448 for ; Mon, 20 Dec 2021 23:25:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 40DBD68AFD9; Tue, 21 Dec 2021 01:25:25 +0200 (EET) Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CC34D68AB50 for ; Tue, 21 Dec 2021 01:25:23 +0200 (EET) Received: by mail-qv1-f43.google.com with SMTP id o10so10850059qvc.5 for ; Mon, 20 Dec 2021 15:25:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rcombs.me; s=google; h=from:mime-version:subject:date:references:to:in-reply-to:message-id; bh=coRyJoJCJUMbtmD2dI7AwdCVs97AwTY+BKasx/S8Gg8=; b=jhGxa1iJG6oTXxWcQXSLCnnw6xn12DBIg6iLkWMyMBeIO+qzPc91E9yjMSE4HZanCY nYKtT4+Hq40g8WiYZIp8uwKekMhxfJWONDOSxcLUrMCo9SsJ260i8IRaTJX0AnWJPVDJ E9yer8fWpWyu+1EyXhm0/4j0OehO6rLBDn/Xa7YMHZyuoIWH7SMZboVbG9THAWywGZ6Y zFwOiT8LrNr4VEsnntciVt6WxhzAi6c1pZBHYgYALMVu0LhB1YCiHZIxBGM/xpzWMVHQ zjLxujthgTRtUh1F1ikETrIJFBPVYy9lEjkQqCKFoaRl0r/kdlELKXRdFzbYKjLUvVrw FhXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:subject:date:references:to :in-reply-to:message-id; bh=coRyJoJCJUMbtmD2dI7AwdCVs97AwTY+BKasx/S8Gg8=; b=6cgGdR+4XlwIed/Vz6Ulh9hngcCZROd0ehqg4fXRqyq7Z5HrUVZ3NI453o0Paj8zgd ZJ3mIY4Dt00hKNeKVgHWR9h6v3o2iG4W63G83kRuCMIuQy3tlLk3dedpKxJeUPxmqcab 20sbvQNYqBNM2ZkJVDeKfREViMWHRs+O/wZ2q9zpCpiN/dO+LOxXXYGPKJT8Av8UoZ+O T0z09rbl4slhjVsof3w5wtb87a75nyNhSkwgsYf2xY5u3NiEXAf+hEJJxaYDK+bqneu+ wa9s74SSFdp9I29K6C49FL/ENk7jyGRrhHAe0jok9yZ/4gFaUqb8jCvUUq8A4G7qUHi8 O3ZA== X-Gm-Message-State: AOAM532GyEehT49XpUYM//+zn6WDPR3kQPYSBKW3hOTVLQrmu3jvhTf9 rIojPwTYNcO05wO0tdOI6NdSqMVbvj8f5+U= X-Google-Smtp-Source: ABdhPJxbCvVXUK2eD/LiJ9iaHldnfFM9Mj+06HiVmMUI56QgcxrLTJf3T94OchFMQZKAJKiTMBD7Ng== X-Received: by 2002:a05:6214:2306:: with SMTP id gc6mr180218qvb.34.1640042721875; Mon, 20 Dec 2021 15:25:21 -0800 (PST) Received: from smtpclient.apple ([2601:243:2000:5ac:f02b:6c4e:f1fb:3dd6]) by smtp.gmail.com with ESMTPSA id bl8sm12636589qkb.38.2021.12.20.15.25.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Dec 2021 15:25:21 -0800 (PST) From: Ridley Combs Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Date: Mon, 20 Dec 2021 17:25:20 -0600 References: <5fb60616-5ded-1b3a-255c-14deb44924d9@evermeet.cx> To: "Helmut K. C. Tessarek" , ffmpeg-devel In-Reply-To: <5fb60616-5ded-1b3a-255c-14deb44924d9@evermeet.cx> Message-Id: X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Could you try with this patch and let me know if it works for you then? https://gist.github.com/7362df8a689c41b9174ac50fdeda3e43 If you can test actual deployment on a 10.9 or 10.10 system that'd be great. > On Dec 20, 2021, at 15:30, Helmut K. C. Tessarek wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > Hello, > > The following 2 commits break the build with a deployment target of 10.9 on > macOS. > > I agree that 10.9 is quite old, but the rest of the code worked perfectly > fine, so were those 2 commits really necessary? > > * 4ac869ca2a | 2021-12-18 11:57:31 -0800 | avfilter: add > vf_yadif_videotoolbox (Aman Karmani) > * ecee6af8bd | 2021-12-18 11:55:47 -0800 | avfilter: add metal utilities > (Aman Karmani) > > Can you make that code conditional? > > > The error messages I get during the compile run are: > > In file included from libavfilter/metal/utils.m:20: > ./libavfilter/metal/utils.h:25:43: error: 'MTLDevice' is only available on > macOS 10.11 or newer [-Werror,-Wunguarded-availability] > void ff_metal_compute_encoder_dispatch(id device, > ^ > /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/ > Metal.framework/Headers/MTLCaptureScope.h:14:11: > note: 'MTLDevice' has been marked as being introduced in macOS > 10.11 here, but the deployment target is macOS 10.9.0 > @protocol MTLDevice; > ^ > ./libavfilter/metal/utils.h:25:6: note: annotate > 'ff_metal_compute_encoder_dispatch' with an availability attribute to > silence this warning > void ff_metal_compute_encoder_dispatch(id device, > ^ > ./libavfilter/metal/utils.h:26:43: error: 'MTLComputePipelineState' is only > available on macOS 10.11 or newer [-Werror,-Wunguarded-availability] > id pipeline, > ^ > /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/ > Metal.framework/Headers/MTLArgumentEncoder.h:17:11: > note: 'MTLComputePipelineState' has been marked as being > introduced in macOS 10.11 here, but the deployment target is macOS 10.9. > 0 > @protocol MTLComputePipelineState; > ^ > > [snip - way too many messages to paste them all] > > Cheers, > K. C. > > - -- > regards Helmut K. C. Tessarek KeyID 0x172380A011EF4944 > Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944 > > /* > Thou shalt not follow the NULL pointer for chaos and madness > await thee at its end. > */ > -----BEGIN PGP SIGNATURE----- > > iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHA9hIACgkQvgmFNJ1E > 3QB0aw//Wsns6KOrT2vlw3RWIyAS1dIrVHO3bBM7NAwl0lYbHkKM6wQpE5sVsSdq > tjAxWH+XikERU2jnHCCZqUormA40iei+WFXKAbZOgrobvrKMeXe/uuQaAmOL3Gkn > o5jvf1+v/Oh3Wd9rSYqdPu+b7VWyz0qj5y8jgBxPtrapfIBh35HBt/41JbVln/PY > d3+h+siAHuBUk1jLHTVep0qe5o3q+mB6m0As9bpGBoQD8oPhQvJxBMqzzzos3mOx > bgVA36NowZEiH8YpEXBMaHk8Ek6k1/37kexinvlRBCmk59mfACShfBJc8J0EC+ii > BVMF6OQvoQ3mHXT79fcd5xV7dueXzLGNAbaK+FQ7ZvAjQ2aEh7xVghH5I8hgRUKT > 8JS1RS6e817+IsSlxFA0UvZ6waF/HINfUXpL0Ca4hFirFKSHRxaMIF/49EPgLk4g > mK/NSvNVIbEN6tpz0Kt0t3cvVEp0O5AoKPAwEuCTWa8io13hgHxlOX0TFMS+3d2A > CRuqROxEpAcOjYo92wWa/S1VFl4lDNBcxHnszA9sLRai7QTdxKmojoU+ti8PqTJa > iDoMVIiH4psyzMMqod7kas06w+KSnr7IyW3bKE50atUBY0P9BCqH1e7/mZ+gn0JM > ZSb61Lo9k0aYbHG7rTtXR4Wvtiao9NFCbD8NbHWPfrSRgs9jqP4= > =/fRX > -----END PGP SIGNATURE----- > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".