From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B09BF4B574 for ; Sat, 1 Mar 2025 11:48:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A700968E0BC; Sat, 1 Mar 2025 13:48:44 +0200 (EET) Received: from smtp.waider.ie (smtp.waider.ie [52.31.250.228]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4635968DF75 for ; Sat, 1 Mar 2025 13:48:38 +0200 (EET) Received: from smtpclient.apple (unknown [109.255.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.waider.ie (Postfix) with ESMTPSA id F37B24448A for ; Sat, 1 Mar 2025 11:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=waider.ie; s=waider_ie; t=1740829717; bh=aelEcw+OrgrnOZ6+6jtgkr7wwyS2rZOWalMcWD3q18I=; h=Content-Type:Mime-Version:Subject:To:From:In-Reply-To:Date: Content-Transfer-Encoding:Message-Id:References; b=eX1GpRFmEQ0Vrx1A/qP/yf9S4N40PZbo4bj6f/wOs5f4v7nt/Y/RnaRR/7M5ZUiIN iiu8oCVJhPlkToRlX8/Ien0PlkmPIjrL2YhoWKN1myCHIQYo3M8iDvPh7kniWjNoQQ u4oMK2M3SBcigiPGqYqUIp4K+ivxifficUU1tvac= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) To: FFmpeg development discussions and patches From: Ronan Waide In-Reply-To: <1D1812F5-DB2A-4847-89DB-EF3A1A6C9BCF@waider.ie> Date: Sat, 1 Mar 2025 11:48:30 +0000 Message-Id: References: <1D1812F5-DB2A-4847-89DB-EF3A1A6C9BCF@waider.ie> Organization: Poor, at best X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Spam-Status: No, score=-102.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=ham autolearn_force=no version=3.4.3 X-Spam-Checker-Version: SpamAssassin 3.4.3 (2019-12-06) on ec2.waider.ie Subject: Re: [FFmpeg-devel] [PATCH] dvbsubenc: add a disable_2bpp option to work around some decoders. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On 1 Mar 2025, at 11:43, Waider wrote: > > As noted in the code in several places, some DVB subtitle decoders > don't handle 2bpp color. This patch adds a disable_2bpp option which > disables the 2bpp format; subtitles which would use 2bpp will be bumped > up to 4bpp. I'm a first-time patcher so apologies in advance if I've missed anything here. The patch is as described: I have a TV that will not correctly render 2bpp DVB subtitles, but is happy enough with 4bpp+, and this patch has allowed me to transcode DVDs into MPEG-TS with subtitles which work on the TV. I've kept the change as small as I can without sacrificing clarity - if I'd carried the `disable_2bpp` option through as-is then I'd have to have each use of it first check if it's set and then tweak the size of the colour table, and the layout of the current code is such that it relies more on the number of colours than the bits-per-pixel so that would have been a more intrusive change. Cheers, Waider. -- Ronan Waide waider@waider.ie _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".