From: Ronan Waide <waider@waider.ie>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] dvbsubenc: add a disable_2bpp option to work around some decoders.
Date: Sat, 1 Mar 2025 11:48:30 +0000
Message-ID: <B57DF5F3-81B4-40E1-8F90-BCF21F144B1A@waider.ie> (raw)
In-Reply-To: <1D1812F5-DB2A-4847-89DB-EF3A1A6C9BCF@waider.ie>
> On 1 Mar 2025, at 11:43, Waider <waider@waider.ie> wrote:
>
> As noted in the code in several places, some DVB subtitle decoders
> don't handle 2bpp color. This patch adds a disable_2bpp option which
> disables the 2bpp format; subtitles which would use 2bpp will be bumped
> up to 4bpp.
I'm a first-time patcher so apologies in advance if I've missed anything here. The patch is as described: I have a TV that will not correctly render 2bpp DVB subtitles, but is happy enough with 4bpp+, and this patch has allowed me to transcode DVDs into MPEG-TS with subtitles which work on the TV. I've kept the change as small as I can without sacrificing clarity - if I'd carried the `disable_2bpp` option through as-is then I'd have to have each use of it first check if it's set and then tweak the size of the colour table, and the layout of the current code is such that it relies more on the number of colours than the bits-per-pixel so that would have been a more intrusive change.
Cheers,
Waider.
--
Ronan Waide
waider@waider.ie
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-01 11:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 11:43 Waider
2025-03-01 11:48 ` Ronan Waide [this message]
2025-03-01 12:44 ` Ronan Waide
2025-03-01 12:55 ` Soft Works
2025-03-01 13:52 ` Ronan Waide
2025-03-01 14:10 ` [FFmpeg-devel] [PATCH v3] libavcodec/dvbsubenc.c: " Ronan Waide
2025-03-01 14:29 ` Ronan Waide
2025-03-01 15:00 ` Soft Works
2025-03-01 15:07 ` Ronan Waide
2025-03-01 15:32 ` [FFmpeg-devel] [PATCH v4] " Ronan Waide
2025-03-02 13:13 ` Andreas Rheinhardt
2025-03-02 15:00 ` Soft Works
2025-03-02 17:23 ` [FFmpeg-devel] [PATCH v5] " Ronan Waide
2025-03-02 20:38 ` Soft Works
2025-03-02 17:26 ` [FFmpeg-devel] [PATCH v4] " Ronan Waide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B57DF5F3-81B4-40E1-8F90-BCF21F144B1A@waider.ie \
--to=waider@waider.ie \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git