From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D2D6D40511 for ; Tue, 21 Dec 2021 07:40:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 721DD68AEF7; Tue, 21 Dec 2021 09:40:00 +0200 (EET) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BC06A68AE89 for ; Tue, 21 Dec 2021 09:39:53 +0200 (EET) Received: by mail-io1-f43.google.com with SMTP id e128so16621416iof.1 for ; Mon, 20 Dec 2021 23:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rcombs.me; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=BBpOl3TMlExbKIfFDBv6qaUAztW0o2KPi8lcWRgbqOo=; b=JHhwXhn13HUD6O3ixv9YovC+Y6H97zbzRma4nWjuOLqdyj/eo8jFJG6s7YsYOJNgaB mCuSHB+a1Zr0H8TN9SGYJcJsYPiKBZzZmJWzpFlP9H92cIZCtHKyEW0QSK4HLjY/iZNQ 9BNj0jZsz+qJv11eOMDBCrpw2Fv/CLr5nI7u8aenF5CDzYSNLv99A6f2Gs0/oEZlSovo 3BskC9S1Ujwp72SPZRFGS6WxvT1xWFCGScOyJK3p5gJGx4fy7BJ2Fp0HQFv7GEy5Dg3s 8pxWNG9Ck52r8OxexH+GOsQlWo0s70i+kK5Po4ukXnTMOkqFJwlXVfoRdbrUbcyRtFK4 VoXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=BBpOl3TMlExbKIfFDBv6qaUAztW0o2KPi8lcWRgbqOo=; b=cVrzshF/ZvvuF8POqgVOeD9LQRBFNtDZAetsJq1SSnfCkyL3C7TqoCqbRQfmJivzbY nSQsiFMF8bHoybXkczuebNMhgl2EIqYgKOOPTNNi3IrPn3Dj/MCrGkNQvdoFioitfbt3 CKTaVvhfqC9hrfVkh7+6PY3YaRKERpotXyRA0D85hf06lDIN9ISOnfPenmMIR/GplAcs eV9pQSXwTAa7rgTicV8Huyw+7veDF9M8n4V5ZopNGqW3Xfj/BEnUBHce9P7eNJGhBBnW bvkH8ttAQCd1CEL0Gb2nOwqfS9xYpcxzh+b7IyddCHfy6OMyg3bXongp10HTATv8NBZi NrTw== X-Gm-Message-State: AOAM533y0BbuRK2lNjm7hDj8imbsdJPA9ED0dri1AiUvXjnUUWK8im4t zm7JqtxPNCkVidRpvMTPcInKYeZGYfmKWBU= X-Google-Smtp-Source: ABdhPJxOgth66pUTuCHUeWthJzDD6vE0qlxW5tGPgZF9y/JdqwtQ5c2fkAprrdYsxyoneAE+xubYfg== X-Received: by 2002:a05:6638:3487:: with SMTP id t7mr1113364jal.316.1640072390457; Mon, 20 Dec 2021 23:39:50 -0800 (PST) Received: from smtpclient.apple ([2601:243:2000:5ac:d068:8cb9:95e2:de39]) by smtp.gmail.com with ESMTPSA id x18sm12173962iow.53.2021.12.20.23.39.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Dec 2021 23:39:49 -0800 (PST) From: Ridley Combs Message-Id: Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Date: Tue, 21 Dec 2021 01:39:48 -0600 In-Reply-To: To: ffmpeg-devel References: <5fb60616-5ded-1b3a-255c-14deb44924d9@evermeet.cx> X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Aman Karmani Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Dec 21, 2021, at 00:04, Christopher Degawa wrote: > > On Mon, Dec 20, 2021 at 7:53 PM Aman Karmani > wrote: > >> >> >> On Mon, Dec 20, 2021 at 5:48 PM Christopher Degawa >> wrote: >> >>> >>> >>> On Mon, Dec 20, 2021 at 7:21 PM Aman Karmani wrote: >>> >>>> >>>> >>>> On Mon, Dec 20, 2021 at 5:03 PM Helmut K. C. Tessarek < >>>> tessarek@evermeet.cx> wrote: >>>> >>>>> -----BEGIN PGP SIGNED MESSAGE----- >>>>> Hash: SHA512 >>>>> >>>>> On 2021-12-20 19:11, Christopher Degawa wrote: >>>>>> So I've exported "LIBRARY_PATH" to >>>>> >>>>> I'm sorry to say, this is a workaround but hardly a solution. >>>>> >>>> >>>> No one said this is the solution. We are just trying to figure out what >>>> is going on, and this added information is very helpful in that effort. >>>> >>>> >>>>> Before these 2 commits all worked perfectly. Now it doesn't. Tweaking >>>>> the >>>>> build env is not a solution. >>>>> Next time someone commits something, are we supposed to tweak it again? >>>>> Where does it end? >>>>> >>>> >>>> I'm not sure what your point is. If you are having trouble with those >>>> commits, then you can use an older version? >>>> >>>> Or you can compile with `./configure --disable-metal` to disable the new >>>> feature. >>>> >>>> Obviously the code worked on both my and Ridley's computers. If it >>>> didn't work, we wouldn't have committed it. >>>> >>>> Once we figure out why some computers are using the wrong metal binary, >>>> then we can fix it and commit the fix to master as well. >>>> >>> >>> >>> Digging a bit into xcrun itself, looking at >>> https://real-world-systems.com/docs/xcrun.1.html, it says >>> >>>> The SDK which will be searched defaults to the most recent available >>> SDK >>> >>> and >>> >>> xcodebuild -version -sdk | head >>> iPhoneOS14.3.sdk - iOS 14.3 (iphoneos14.3) >>> SDKVersion: 14.3 >>> Path: >>> /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk >>> PlatformVersion: 14.3 >>> >>> Which I'm guessing might be the reason, but still doesn't really make >>> logical sense and running >>> >>> xcrun --verbose metal -v >>> ... >>> xcrun: note: SDKROOT = >>> '/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk' >>> ... >>> xcrun: note: lookup resolved in >>> '/var/folders/yf/4yc0fdvx7zv1t17w41kxmr0r0000gn/T/xcrun_db' : >>> '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/metal' >>> Apple LLVM version 31001.43 (metalfe-31001.43) >>> Target: air64-apple-darwin19.6.0 >>> Thread model: posix >>> InstalledDir: >>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin >>> >>> which also, doesn't make sense. >>> >>> exporting SDKROOT to `macosx` does make it show >>> >>> xcrun: note: SDKROOT = >>> '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk' >>> >>> xcrun: note: lookup resolved in >>> '/var/folders/yf/4yc0fdvx7zv1t17w41kxmr0r0000gn/T/xcrun_db' : >>> '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/metal' >>> Apple LLVM version 31001.143 (metalfe-31001.143) >>> Target: air64-apple-darwin19.6.0 >>> Thread model: posix >>> InstalledDir: >>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin >>> >>> so, I'm not sure what conclusion to bring from this. >>> >> >> Thanks for digging in and documenting this behavior. >> >> It seems like a bug in Xcode to me. Perhaps it's fixed in newer XC, which >> is why we're not seeing it? >> >> It may be worth filing a radar either way. >> >> > > As an additional note, just spun up a new mac1.metal instance with macOS > 10.15 to see if I could compile ffmpeg with nothing in the system other > than build tools and I am getting an error of > > xcrun: error: unable to find utility "metal", not a developer tool or in > PATH > > and realized that I can't even run xcodebuild because > > xcodebuild --version > xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer > directory '/Library/Developer/CommandLineTools' is a command line tools > instance > > > It might be better to first check if `$metalcc --version` even runs first > before enabling or even checking if metal works Huh, TIL that the metal compiler doesn't exist without Xcode, but the metal framework does! Wacky. Anyway, this patch oughtta fix that (does more or less as you suggested); if this is all fine on your end, I'll go ahead and split this up into a few commits and send them to the list: https://gist.github.com/44e6575fbd4d84c016e63d8ddb1fb52e > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".