From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 786334073F for ; Sun, 30 Jan 2022 06:13:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5943168AFB4; Sun, 30 Jan 2022 08:13:39 +0200 (EET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2099.outbound.protection.outlook.com [40.107.21.99]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B729E68ADFF for ; Sun, 30 Jan 2022 08:13:32 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RMKnFZCabUuWPrBf4kB4UtrogiK/74C+ljpyT3jWQZMgsAzmgSpfbG9rjN9qHd8ods2Y9uZCV0jqzh63wAT6koowe0lPkpqLsC8InuUBbHaJbK5X1UrSw5JuxmMAzdWEkWfz6APjX0znMmXv89HuaPtdOa+KBgFMuRy6UpiVsajrqgDN8xwSnQWdOVrR8UbYEvd32QoyzgiVJqIaqogQr/JPKVgYJ/vkNESLPtrRA2nUo/SYarOcSM0abxY1BeaYp7ccGlw/vh8Zae8G2vQF5ZAVWTstup3IxheG80d1hcRop+CCnz9Bk3HSIFBR6KZKV54/z0dhIZnQCu7UnLsgEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qEBZJWNNV7GtMxA2T8EVrwEY0FGGPUvOuBkg2wMx4Us=; b=RTzB1wTfziQgpF37xloufBSr8aHBkcZyxR7dVBxgHv53LFh51eDAqQIpHIvIlaXlQ5hEitot7BjqTfC/al3376KRCbFXrBVptHySS3R6NZP/c33vMzozf5TlT2DFvtCb68hNjwkauVV/ja6bxVD2oj8EV1OvwH9+PMRUB29qz/xyCdUqh3vsmXw7hOO5HycHlxRA8XHeuJvY2eEmwAYht4Xd9zHZT6TPdIP+szdmTXie6Min6VMGNWnnM0Bmkn2na6yyhjVMaYQTxCHNEO9YRe8OgjG6o1hMF4Y4VJlJS02DeMFAtsEGnqhVixBdM8Ydf4DiorxuV+dBHSq5zw01Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kaltura.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qEBZJWNNV7GtMxA2T8EVrwEY0FGGPUvOuBkg2wMx4Us=; b=pGsyIBxe84oeYVoKn1kMxIqRFAwHUWTfyYS+tEQWVIydZIWD9WqGoK16iAFXV3YHN7QhKng4ofnBLGPUIaTfpwWWO0n3OsdJHi44eRKRvFDyfYYk+O9Busyogowg24iWZWWUkDGH0voqWxfHKwosN/C7G20wkLTint9hLKFC3HeSPLRzIPPYc14Y0BTXB4B7p9+XM9DhkVtbilLgrweRyfdnjKLWmzqxAlPsh2uKds5zq7xnSch1UC6l751H1AB02hkfA+kV0ThXxJiwd1I/qS5bO/wTFGhVm7pEyqdKTxnaIJ+y8HhO+GdY99zIz5mI2VGnKmHMiKLRstM/qVUahQ== Received: from AS8PR04MB8913.eurprd04.prod.outlook.com (2603:10a6:20b:42c::15) by DB6PR0401MB2311.eurprd04.prod.outlook.com (2603:10a6:4:49::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.20; Sun, 30 Jan 2022 06:13:30 +0000 Received: from AS8PR04MB8913.eurprd04.prod.outlook.com ([fe80::d0bc:2e75:fc7f:cf9a]) by AS8PR04MB8913.eurprd04.prod.outlook.com ([fe80::d0bc:2e75:fc7f:cf9a%5]) with mapi id 15.20.4930.021; Sun, 30 Jan 2022 06:13:29 +0000 From: Eran Kornblau To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avformat/http: Fix double-free on error Thread-Index: AQHYDjTxtln8s8hXR0WH4heaUFeekKx7JDyw Date: Sun, 30 Jan 2022 06:13:29 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kaltura.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3d25ad48-32fd-4616-384f-08d9e3b7a2b5 x-ms-traffictypediagnostic: DB6PR0401MB2311:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:462; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gz7iZLqSGs9g6A160D3P1vv081pv+Yoa5298ea/QPzCwgTqtGpyHUruWX9XBy49jLPm65nVTdBMvgNYIEOeY3tJZUGm9/6cl8t3M6BrurmyYygSipYdbTbYbcEJB2/1YkuK+FtD9L1dbVcVlr1L133sKTGkXDrDpeV7+BtsVUhBPxI/2hdCXBVsv7jFUEacWGMjnUyQ2/DIFsvKBmsONZTLV3nBe4BPpcD2rgAhFe571O62AjCM9a1wu/WWwNSxTtnlgfTN4ilAY1sULmkUztz5kXfa74708apmevHAfs6IE/BQRPV1QOnMGjj8T9VTrRdI5cq3iqRl+hSUC8aHO3qQzdi4aBfsRW+LGcDPRwn/Fb2Eay4/anQoaZUaYypWMWNUVVvhm03DrzpI+lIrsrPEnFbuN2ziHYEpgYo9dtvQqqCg3pKDKNafnZ0jrDjjTH8bgM7OecZ/3RVNeiQWtlkicjm94zI27LGqAVgQWEtIVWsj0FTIMhpHCuKieXOfCw9Fvf4u+WPDhEjcPHdIaAyhlSlctLReZhjlBF/83HaIahmD2kkdTFwI2n4JORTk69PFkEw70U4LvKndaRgOsqE1HURbG/opK9Po+i3r1ZRBINyv4mC1JhNeIdySpfWpXbjdxYK42dtK2F7cpCnm41Z+V3Qi5YTZe/9bZ/KYHTPUFZ9id09/LDy7LiutnK7RSI9jEn5d9DIYdfGU/Q71tJeCjQAH7tRMKV8pXTAkpOuomAxr6fAY42l/0+IZJ6LZZbjDJu5ypJ7xU/08ox0tAmE5iK9o905Rek8TgzzpwA0w= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8913.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(7696005)(9686003)(53546011)(44832011)(33656002)(52536014)(6506007)(83380400001)(26005)(186003)(2906002)(66446008)(66476007)(122000001)(38100700002)(786003)(966005)(86362001)(45080400002)(6916009)(508600001)(71200400001)(66946007)(76116006)(38070700005)(8676002)(55016003)(64756008)(8936002)(66556008)(316002)(20210929001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aEVlSXJCcUpVekZtbFVXMURsUnF4dUJ6Q0pBeHlpYzJjN0M2N0Yra2Rmeldk?= =?utf-8?B?YjJNVmxkYWh4ZDQreVNzR1hTOVNlcGw2RUJoNjcvYTRXc0FqOVlZTURoWnJp?= =?utf-8?B?UEdab3Frbk4rdEJKZFVza3BucVh1dmtFSEQycmV4VjBhbVpiNFE2MHNMR1VY?= =?utf-8?B?SXVQNjhFV0s3TU11N0xZeFFqZVNjamVNQTdsNEptWElOcGdnM2JiSlN1aCtN?= =?utf-8?B?UHgzSDhhUEZjREdsVEIra2oySlVvSGwrWDFJZmNWSW15UkJGS096RnhRczBl?= =?utf-8?B?THZ2cERZbDlGTGZXQVZsVzBZekk1WjZGSUJDQVhZZVY1RjlwNUgwZ0RQQUEw?= =?utf-8?B?WlFTRDNLTW9qSUFWaGpLc29oZ1llQjQ0MTAycllFcXlCM2MyaHk4d0d1ZFRT?= =?utf-8?B?WmVpVXloNmxFU2g4VUZmSVhmMG1hOGs2c1lCbjE1R0FVOURXUGlnVjVYOGRx?= =?utf-8?B?TDFZTG5DUWlVNy90RGl4c1pNa3FpWEpkNko3Wm9TV1N5QlRnQXVqbERLTlRr?= =?utf-8?B?cFFXK285Si9HbHFoRk1VSmRVQXVIS0xwaUx3NFpZS0JHS2Z5QmppSzJRaEs4?= =?utf-8?B?M09TU0JwVUFiTnVOaDBpQkpDcXdOYzRwbHJlZUJXbHpiVkRtZFlTQXZVWGlL?= =?utf-8?B?T25xS2hBQklIRHI0LzRHaU9aY25kUUhqYlBETE5LUFBnK3kydEZNRFB4eUhs?= =?utf-8?B?UXVwRm8vMS9oTnlBWVk4UkhKT3VhdGtPOVFzb3owb3BzY1cxenBQZmhjZWxi?= =?utf-8?B?S0NFWVBRNUFiNDRMeTc0Z1YxMk0wNjZ5aFY1cVhaSmtsRGdFMVpNQjVWcExH?= =?utf-8?B?b3lqMnhlSVg1b3NXNllPN2RKMnRkaytlaXduSUhlU2ZNT1lkbTJSSThQYjh2?= =?utf-8?B?US91WndPbXE5djUxd1pjUXREWEJIK29ySjUyYlFaZlYrMFhTcFpORWtocWV1?= =?utf-8?B?SUFFYXpUV1hLbzRCUVlSQXhxbHVLZE5PZXBadWlWSVlWZXZsUG5xU1lvSkVj?= =?utf-8?B?TlFTa1RvSFh4R2l3VTd4TVhTR0paOVZWNW5JdEVIM3lJU0Nwd2RZaC9hTnhi?= =?utf-8?B?YWJDRm9WRjZqcTRtOTBabXdCc3VZa2RBRWpDQlMrYnZkSW9GWHhmWCsvU1Fv?= =?utf-8?B?QkIwQUZnSHZQL0RFeDBINm1pTHcxdTZyK1pUQUJ4dFYyNWdMajVWMlhUYjgx?= =?utf-8?B?ekw4NnFHaTdDeEZRT1Y1ZGhodkVhV3FnSndoWnVlUGg1M3owSTFvN3MrS1M1?= =?utf-8?B?M3d2OUJCOWJvMVBtbjhTV3pzMXhndk9USUVWT2x3bVh4T2dLTUdMV2ZPQjVT?= =?utf-8?B?OFIrbTB3L1MwTUVleVgrL0paVEd0RXZaNy9vME5rRlVWU043T1dQemtTeUJM?= =?utf-8?B?Q05DQndXZmROYWJRMXFVUlZyd2NZZEFKUkhJTENGKzM2Qk9HaUF2VGxOdGxa?= =?utf-8?B?MTMrNkZobEhxb25hNUpQMnBpdXlYVm9QSlhyYkJEZGVnZi8yRzJxZndhUDU0?= =?utf-8?B?RVlia1didzdVR0RRS3FzdEc0cFJaNVZZSGcxMXd5QVZzUTg5M3ZhM05ISG1l?= =?utf-8?B?YVM5ZlZCNnE4MWlvalJoSTgyd1ZzUFQ3ZVBmRTBNRG16RzkxQytIcEdXeWdk?= =?utf-8?B?TldVb2ljYmFXZXRGdmhXZVJsVHBDRnVya3pTanNML2dseUtjKy9OS1VMdTZn?= =?utf-8?B?Wi9LY0g0NVN1MmplZ1YxcGwvSE53b1NkZUhsSm9xanROazMvMVl6NjE1OEdH?= =?utf-8?B?dDhyUDV0M044K1ZIdXBISlJJMVUzdTlIb0tlSEJtMndwd1JrOER0eTBtaHV4?= =?utf-8?B?bmFnS01nWm9UbWw5eUxLTi9vTjR1ZEx3dGJodXZwM3JWWU5YUnFERytRdzN0?= =?utf-8?B?aFFMR1R3U3FCRW5KZDlxOUtsSDVnb3V2R2RlMmgzWElnK2lxWW5wakM5eFNB?= =?utf-8?B?a2N1SGNHazZqbkgrZXUza0pDem9iL1BFbDlCRGZkMTFJOGdPTHIxU1NrYXV2?= =?utf-8?B?ZnBjOThzZFJieDJmWlQxcFFXOFo0bW9PS2xvQVduVlJRQnZUYVd6eHZsUW5k?= =?utf-8?B?MEsvQytCWnRTOFJ3WnliTnRzeFNUeHlFVkJxY1hHUWY2bGJoWHRLTGJ4QUZz?= =?utf-8?B?VWttcUwrRXd3K3hZNlYzR3RqMjhNS2JSTnAxRlVPcGNRSE8rekk3V2t3ZzVJ?= =?utf-8?B?N055RDdZZVZrN3RnQWF1alZLdlEwdXpPNTYwSTgyTWNXZVdaYW1JenpDNTUr?= =?utf-8?B?SHFJUFhTSGFscFdGSUZaM01OQVNnPT0=?= MIME-Version: 1.0 X-OriginatorOrg: kaltura.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8913.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d25ad48-32fd-4616-384f-08d9e3b7a2b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2022 06:13:29.7160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0c503748-de3f-4e25-97e2-6819d53a42b6 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Nx5gVPUSOCExog3nu/nHKB9mSfvFcYD0HQLORAAUYR3EpW8lLfl/KSceBKpo84KTta39j6PiV15L+S6hldxOGkd0IQXLs804N1o63FJ5pUs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2311 Subject: Re: [FFmpeg-devel] [PATCH] avformat/http: Fix double-free on error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > -----Original Message----- > From: ffmpeg-devel On Behalf Of Andreas Rheinhardt > Sent: Thursday, 20 January 2022 21:21 > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH] avformat/http: Fix double-free on error > > > av_dict_set() with AV_DICT_DONT_STRDUP_VAL takes ownership of the string it is passed to as val; this includes freeing it on error. > > Fixes Coverity issue #1497468. > Indeed, I missed that fact... can this be merged? Thanks Eran > Signed-off-by: Andreas Rheinhardt > --- > Untested. > > libavformat/http.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavformat/http.c b/libavformat/http.c index cf04d3f14f..8b5fc3d2a4 100644 > --- a/libavformat/http.c > +++ b/libavformat/http.c > @@ -335,10 +335,8 @@ static int redirect_cache_set(HTTPContext *s, const char *source, const char *de > } > > ret = av_dict_set(&s->redirect_cache, source, value, AV_DICT_MATCH_CASE | AV_DICT_DONT_STRDUP_VAL); > - if (ret < 0) { > - av_free(value); > + if (ret < 0) > return ret; > - } > > return 0; > } > -- > 2.32.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmpeg-devel&data=04%7C01%7C%7C277f3c04eefa499b2f2308d9dc4c1260%7C0c503748de3f4e2597e26819d53a42b6%7C1%7C1%7C637783041561456917%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=aW6o8YRQtDoE2tMOmg1N0qaFYu9L11TqPETX7ebUTFg%3D&reserved=0 > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".