Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 1/2] fate/lavf-audio: Disable CRC for lavf-peak_only.wav test
Date: Tue,  3 May 2022 05:27:00 +0200
Message-ID: <AS8PR01MB7944FB7FAD614E85D3D1A3DE8FC09@AS8PR01MB7944.eurprd01.prod.exchangelabs.com> (raw)

The output of this test is just a file containing the positions
of peaks; it is not a wave file and trying to demuxing it just
returns AVERROR_INVALIDDATA; said error has just been ignored
as the return value from do_avconv_crc is the return value from echo.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 tests/fate-run.sh            | 3 ++-
 tests/fate/lavf-audio.mak    | 2 +-
 tests/ref/lavf/peak_only.wav | 1 -
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/fate-run.sh b/tests/fate-run.sh
index 821e949b01..c206a439b2 100755
--- a/tests/fate-run.sh
+++ b/tests/fate-run.sh
@@ -312,7 +312,8 @@ lavf_audio(){
     outdir="tests/data/lavf"
     file=${outdir}/lavf.$t
     do_avconv $file -auto_conversion_filters $DEC_OPTS $1 -ar 44100 -f s16le -i $pcm_src "$ENC_OPTS -metadata title=lavftest" -t 1 -qscale 10 $2
-    do_avconv_crc $file -auto_conversion_filters $DEC_OPTS $3 -i $target_path/$file
+    test "$4" = "disable_crc" ||
+        do_avconv_crc $file -auto_conversion_filters $DEC_OPTS $3 -i $target_path/$file
 }
 
 lavf_container(){
diff --git a/tests/fate/lavf-audio.mak b/tests/fate/lavf-audio.mak
index b03030176c..68fca35298 100644
--- a/tests/fate/lavf-audio.mak
+++ b/tests/fate/lavf-audio.mak
@@ -34,7 +34,7 @@ fate-lavf-ast: CMD = lavf_audio "-ac 2" "-loopstart 1 -loopend 10"
 fate-lavf-mka: CMD = lavf_audio "" "-c:a tta"
 fate-lavf-voc: CMD = lavf_audio "" "-c:a pcm_u8"
 fate-lavf-peak.wav: CMD = lavf_audio "" "-write_peak on"
-fate-lavf-peak_only.wav: CMD = lavf_audio "" "-write_peak only"
+fate-lavf-peak_only.wav: CMD = lavf_audio "" "-write_peak only" "" disable_crc
 
 FATE_AVCONV += $(FATE_LAVF_AUDIO)
 fate-lavf-audio fate-lavf: $(FATE_LAVF_AUDIO)
diff --git a/tests/ref/lavf/peak_only.wav b/tests/ref/lavf/peak_only.wav
index c468731b00..9548e639f8 100644
--- a/tests/ref/lavf/peak_only.wav
+++ b/tests/ref/lavf/peak_only.wav
@@ -1,3 +1,2 @@
 f1a8aeeae8069f3992c4d780436c3d23 *tests/data/lavf/lavf.peak_only.wav
 832 tests/data/lavf/lavf.peak_only.wav
-tests/data/lavf/lavf.peak_only.wav
-- 
2.32.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2022-05-03  3:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03  3:27 Andreas Rheinhardt [this message]
2022-05-03  3:27 ` [FFmpeg-devel] [PATCH 2/2] tests/fate-run: Don't create unnecessary CRC-files, forward errors Andreas Rheinhardt
2022-05-03 13:59 ` [FFmpeg-devel] [PATCH 3/4] tests/fate-run: Allow to set dec opts for generated file in transcode Andreas Rheinhardt
2022-05-03 13:59 ` [FFmpeg-devel] [PATCH 4/4] fate/filter-video: Remove intermediate file of meta-4560-rotate0 test Andreas Rheinhardt
2022-05-04 14:39 ` [FFmpeg-devel] [PATCH 5/7] tests/Makefile: Redo how to keep intermediate FATE-files Andreas Rheinhardt
2022-05-04 14:39 ` [FFmpeg-devel] [PATCH 6/7] tests/fate-run: Remove temporary fate-lavf files if possible Andreas Rheinhardt
2022-05-04 14:39 ` [FFmpeg-devel] [PATCH 7/7] tests/fate-run: Remove temporary files from pixfmt conversions Andreas Rheinhardt
2022-05-05 13:41 ` [FFmpeg-devel] [PATCH 1/2] fate/lavf-audio: Disable CRC for lavf-peak_only.wav test Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8PR01MB7944FB7FAD614E85D3D1A3DE8FC09@AS8PR01MB7944.eurprd01.prod.exchangelabs.com \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git