From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 81BEB42CB3 for ; Tue, 3 May 2022 13:45:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7364368B251; Tue, 3 May 2022 16:45:13 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075023.outbound.protection.outlook.com [40.92.75.23]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 868BF68B158 for ; Tue, 3 May 2022 16:45:07 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lsPoLBVcHXe1SJF4D9UIQVNNLptYLTUtLL8rHEk8H3tJ51wp1eBN+lm+kAhEllO4FTZCYzGICeU+uQUieM6sbgAkJ4Pr3eLiqjwSCuyuNQ0mVWgqkWXH8oV+b9UqUqJUMxHCWt6GJte8rHdwknemTiH/xu0EomtbcKJfX3Ha7V7YqSqkRLm9Kg42JXvytPnthMd123YcnLcrCTrWdxDi9Ou1UkBPJnAkTAhyyATjSjDOF+nFlg6yR0JRWhsc4AGTzJe87wKVi1NozHZMZAfD7mNmgiSWH+RC0NwU7TiqgXM/YyftMzkeYV7nrvAB0+sKWpZTZCQmQPIlvFAfsy7asQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4o5mo48qv2jplOwWbk/kPjc6AzwxsE4Q+5f4zHeuhUI=; b=hPGU2fiqrZsPJi+uasydgPC8nTmuHzs8BiGoS3Vf2V5xAYvnn/xmSb/rKyTu42EM3qNy1doaRDhsA5S3vtulRzI8u+5GXqqeqoiGAeSFlH2Bz3JnlkUnbhbqvtSG4An9Vs+9T8VO2DveZpBT+wfxmvMr71TlTvlpAZiJ070i2nJnRrLWe6LQJ3zYIqCtVdmRtCKvUp8frd6voAEA97vJkb1u9OhgXRn2j805WWlOKPqoTNbkduHmYsQp6yfjpgKJiImGmYRI39GHTdkJTw3K9rpqMhP9Pp9UzYikN5Oa/UOX8vK7rXBnASujDD+8fpauOV/2egvh/c0W36psMt36Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4o5mo48qv2jplOwWbk/kPjc6AzwxsE4Q+5f4zHeuhUI=; b=s70s4GR/HamU3BDuk+bojmEAkWB+nkV3UXBf25tXLBcrvkxCrymdxY7YFLBlxY53jlLsG3wCb5GJt8K2GDSoizauwWr9k0cKtFU+DoqSGpBvpi/DCchE1Jn5s9ObbcMl4Jcgh3TNaddrFGIG1kDeWwplp0pemeRe0NRBG1pI2dbblUAXRkMVOXDGamGeY3sUQhMkPb9F8ZtZOq5qCvZ/TgAcJbvBSyP2ljqvfZ9RI1MaMpMIyHec7J+xHz6pvi+ViPafuM8YF7cqIK/5PSOxffudm0uvP6Q6K2E41r2kFox5GK1UdXbZpUTE/b51M1oneUXPVnvqPgWOJQv9zR+Wcg== Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) by AM9PR01MB8332.eurprd01.prod.exchangelabs.com (2603:10a6:20b:43b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 13:45:06 +0000 Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::1854:2c30:7ba1:c431]) by AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::1854:2c30:7ba1:c431%6]) with mapi id 15.20.5206.024; Tue, 3 May 2022 13:45:06 +0000 Message-ID: Date: Tue, 3 May 2022 15:44:55 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220430215010.GD396728@pb2> From: Andreas Rheinhardt In-Reply-To: <20220430215010.GD396728@pb2> X-TMN: [vFIVsjH79iWJjL3LMn3l/PEqfQR4RhEN] X-ClientProxiedBy: ZR0P278CA0014.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::24) To AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) X-Microsoft-Original-Message-ID: <20c17d09-498b-87b2-2ea9-f469b74809eb@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a59a58a-1a83-49e8-67e4-08da2d0b1c2b X-MS-TrafficTypeDiagnostic: AM9PR01MB8332:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nJQNmsTjC//hZkJLk/Vu8+uZqNoFYcuq5Gh3yTQnmmI6GZ/AfFOu0+mXewfMpJG1/z7sgG8ir/g6v3Ig1CSczf8VfTMlg+0jga9Dp0ZiPm8MIISLdBunUImgk7VBllIc6Tqyq8Brs1JFVh6uVJLuk0pd1IWNYgqzc82/6Cy3EJnOH9FQlqy+cmVSDtgQ+uEwG+h8pvKJmEVqpHaGLsn06ReTPSq0QumEVrLDLX9vxdI8G66yb/dfNw6yaDKMT9r2Mw9cG5449IRIAeH4W3PZYrWqOS02OWHD9w9lfW5YDXlljekrDasHKwV7TxUxzTe9o46eHXSZCa63V0Ui20vqR6PrcCXfBStsAvCMDX8zIhHvbFI8tRZ9S9M8h5ljLnTUnDzGggxCvucUyGA/x228m78RXDOID/yHDX9HriKA8em0Zf8H7sWxaqgTnl8jcvSl71ciPM1YOSjbqCT10y1QL6oA8AJ2Q/dsEJNgTjaGdtgZcD241zbFncKfufDz4TxpQgllo1XH8oD/Bs8O0Q28QNcUoEfmBlsIB5lIeRJ5HKJpw8BAVEHK9wo9kWgztTBPlOO/qZHs+2XjUUJfFVP7fg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bklpb01EdEZLUG15U2FmK1RvTUtwY0loQTkwVEtZZkF5aVFCTTB1ZXRlOGsz?= =?utf-8?B?T2dwd1lsQlB6MG9Db1IyeUgveXd0Znl6ekpMY04vZzZjN1JQbmYxQTJCdmxv?= =?utf-8?B?L0F4anlsWDFEVDhVcFg2MWVpaUl1NXFUNElpaXBZOWtRQ2FLVXpPc0NRdVJB?= =?utf-8?B?L1BrTk9jeWxwbEY0VTBqa2FZcENRT3lMbmxycW1ITkJldFErbS9mTTVIVEtj?= =?utf-8?B?RVkyUmpSUG9saUZlVnhDLysyaXcvQ2wySjBxMG1zN2tNQjRzZE9nWHE3aWph?= =?utf-8?B?OTJ0ekxBWkpmZ1NzakxhOE9YRFJMZm5SaTFmRE9IQmM1ZElDVEJQVjRLTE9v?= =?utf-8?B?eHo2dERwSVMvQ1ZiKzNjUUlSUlhXVGNocXVvTEc5M21zZURENEpYOWNDS0hv?= =?utf-8?B?RzRpaGVmVVNYVm96ZEVIYmtUSlZQTm1BR0Z0NlhJb2JPdk01cDgzYU1SZU1V?= =?utf-8?B?dk16RnltcmdZQlplTDRzcWM4VDdaaHRHZnhTc1hGdUVDR2lDeElsZjBzSGdZ?= =?utf-8?B?WUZGdnRXS1AyaXp5eFNzZytWcisvQ3Ftd2t5a2JnclUya3NLWFV0bFlPb2NW?= =?utf-8?B?cTBScVhBTVcxeC9HeDJwalhhNUtzbmFIYVRvVXg0MU4yUExnOEpNOTNhUE5K?= =?utf-8?B?OHBNWkhUOGNWMWlHbHVpajF1Z2RialRyWXV6cXluVFpITXhrS3V4RTQ2V1ho?= =?utf-8?B?NmIxYWRqYm9yNTB1cXVpZnR3LzJKL2NXc2RJSWdLUXZHRmorUVFzalpINzF6?= =?utf-8?B?VkhHeFRUZ1ErcEtPT3k1a0VZRW12Mk5pSmtBOFNVc3BKa0x6Q2RzenRIUTFn?= =?utf-8?B?VEtxQ2l5TmhOWkZSYlJ4cWZMdE8wbEdvZlVJWCtlYW1xM2RXS3hsUEExR1JY?= =?utf-8?B?MjJXSGNQMjNWN0c3aFFQanRtWWJFMzdFbnBIK0J3djl3VzNDYnc5WDNiU0V4?= =?utf-8?B?emhnblg3Y0RxOXNPaWsyODJrOGp1cDA0WmdoVDVGSWpLUHNaU29pY01DYVli?= =?utf-8?B?dVhHelg0NDEwYjVxUFNEdFgyOUFJZUUxNmJZVGdkVE1XNVZtQjRDa3hERCtt?= =?utf-8?B?eEFiRkRwR2hOZkVNY2lUY1FOTXhGNGNnSHQxM2Z4UUsvdU1qcGNuUVlDTzdt?= =?utf-8?B?TTN1NHg0OHlRTStTRTE4bDUvNnlpa0xYTzV5RkF6c0U4QXhYVHlUMTJyZWt5?= =?utf-8?B?QVVBRGZkMEx2REhwQ3JHS1c3TXlvRytONngxL1RXU3lWcklSeVNWQnNFMm5l?= =?utf-8?B?aEFid0pNc1ROaUhuK3JIWElZbGZNOEgzVUxNSXM3TFJxSU9xSmZwM2lXMlJ6?= =?utf-8?B?ZU8yUGZCcDNOdUJSQnZPOU96TjVZRjhYMXBqNEd5eDRwaHQ1WkNQTnVnZlFr?= =?utf-8?B?dE1ZMzZxRHdONGlmdFdyTTVuTEd0ZFpQaGdjc1ptWmhVMTg5M01CT1FLTjdV?= =?utf-8?B?Nmhza0hqazJpTWVYZmY3aytYZWQ4VUZYdVYrUnBLcUlCcGlCN0c5RzIzS3Mr?= =?utf-8?B?ZzNTRWVIdHg4aU5UTlMycjZzOTBkbkJKWWRUWi92S2RnaHVtSEtwbTR5WThE?= =?utf-8?B?bjdBU0U5NGREODcxUm1YWTlKZzdMczJ6QmIxVU52VWpac2o4b2hTYjJVT1Nk?= =?utf-8?B?Sm44bS81NysveTJpWlZCUXdOenpNSmE0L2pkSk50RlZtcGsveXhZclViNWll?= =?utf-8?B?eHErajZrWC9odDhIbGx6RXYrV2x5S0xYRng3aUUxejFvNjVMSmE2RERXUit2?= =?utf-8?B?eE5PakhHcU9SdHFSMkt5aUJQcnBQcWFMNld5bWUvaXBGSjlSSk9qVWRQaHY3?= =?utf-8?B?Mk82eVVRd0dMRkpNL2RZRlJPNWNMaVZpNEV0RGZFOGh5dUZDbTcrbWZ5UjJV?= =?utf-8?B?dHN1UG5QVnd1bGFQQXcxTkRmMkRXbXRlVmJSUGU4UkhHTGgwT001OTJadmVm?= =?utf-8?B?OUxNZVV6dklOcUhITEJ1S3lpZjkrNm9yeWZtcThkd1lJTXZxYXc0bWJNUnps?= =?utf-8?B?dVY3UHdRTFd3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a59a58a-1a83-49e8-67e4-08da2d0b1c2b X-MS-Exchange-CrossTenant-AuthSource: AS8PR01MB7944.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 13:45:06.0766 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR01MB8332 Subject: Re: [FFmpeg-devel] [PATCH 4/7] avcodec/codec_internal: Use union for FFCodec decode/encode callbacks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Thu, Mar 31, 2022 at 12:49:55AM +0200, Andreas Rheinhardt wrote: >> This is possible, because every given FFCodec has to implement >> exactly one of these. Doing so decreases sizeof(FFCodec) and >> therefore decreases the size of the binary. >> Notice that in case of position-independent code the decrease >> is in .data.rel.ro, so that this translates to decreased >> memory consumption. > > by how much did the space requirement decrease ? The three patches fb59a42ef, ce7dbd048 and 4243da4ff4 together removed four pointers from FFCodec; on 64 bit systems this amounts to savings of 32 byte per FFCodec. allcodecs.c contains 796 declarations of FFCodecs, amounting to savings of at most 25472B. (This number is not attainable because some codecs are only available for certain platforms.) I get 488 decoders and 182 encoders in a build without any external libraries explicitly enabled, leading to savings of 21440B. > iam asking because while a single such change isnt a issue > if we accumulate alot of this in the API, the API may become > actually hard to understand by new developers _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".