From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 00FF7428AE for ; Tue, 5 Apr 2022 15:07:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AB8A868B109; Tue, 5 Apr 2022 18:07:40 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2104.outbound.protection.outlook.com [40.92.90.104]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE48168A466 for ; Tue, 5 Apr 2022 18:07:33 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WDGyPzEHuwxFFj3scYQ4+K3t9a2LRUzFtawFgl1Z9WqaPieTn9lk88hk4qUC1audLI30JpIWLJQkDgEstO3HjAwT0C06kMJSMxSh3otRKo2M24QtNkBvGtwNEXDhQdQ41vXVZBprG3pl4l6DzI/5N+G0uxrKAFvhlBQHzEhBEbw8CxOPVyhPGez4sMLon7yu3y51WVMbjNKJDz91cnxiE+EQbDm/0VPpfpowABSbcZnxoHWbejG3x0uXiryxin5gxa47MRwEAYJyRZiHu13balbOSdrY4UN9cemiOOhSEAX6yFnUKsnC4YR3Jpv1ioQBK4sJwVh52EeV0AkjxsQw6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=63eE0USSKdVU33ds4cUFBcnoTJPiViAk13p1azysrN4=; b=BJCwQPnovjnrunoDBlXPmc3qx41xcxbE+PS8awEAnpruczzcfMI1Hq8HCW5IzCQaXWG/tgjBaepFu+QyRlO8bNDJtgx+lntP6YV4jfNf0/P07BxnN33pUUBB6T0bWRiBzixhLLFyQ2gTrEpJK0dkBKCBOFzIzjy9NLLxJQvwg+KrisqzzIfSL1FqD46sQVtcmM/OCP278RJJKm0zHEYgZF53xtBbPoXtOvB8sWqNEiBW2DSwYWEs0CIiHKN+gCn1Oa8VO2MFHnGx+F9aV0EMtVYUZQzg035g6+otNOufAQSSFc839wy9VJZN8GLNLAyW4r6NNbO5OiawxjhQopzQ4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=63eE0USSKdVU33ds4cUFBcnoTJPiViAk13p1azysrN4=; b=MIt7LAuI6Xb19O95q5YnMx/1PSZt4eWNgSZMIUOU3ZunoVTq1TKPn9SwG3kL6HFptWnU+1ydjvnx5PmfAhUTDTHXrJc1ab8flJJUdMV1mqPEZU+SW4+GtvXccDeFOvbrI5qcepli9YYvVZRYfRuLumlECqxCZwWqkNUboVNsATcnJ75tdpnLwC7UdOxUgwNcAUEeXNPRYDC96R7rmOpyFShxm1BTLX9OTAJ4tFEpy5iRXWAE1li+2xcs70fONA/HBQN+2wFGxwBIDzKUIQEbvdIOeP/B9rXvdfgnrDNtrlfRwA/Sq+/n0uMYcQVkQ1oSCfJXAbSpNLQyTiYIsZj8NA== Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) by PA4PR01MB7648.eurprd01.prod.exchangelabs.com (2603:10a6:102:cf::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr 2022 15:07:24 +0000 Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::6553:a424:79bf:6dc3]) by AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::6553:a424:79bf:6dc3%3]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022 15:07:24 +0000 Message-ID: Date: Tue, 5 Apr 2022 17:07:22 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220403214337.4090-1-michael@niedermayer.cc> From: Andreas Rheinhardt In-Reply-To: <20220403214337.4090-1-michael@niedermayer.cc> X-TMN: [+F1z95kg1VE5m/drZE2FjUvQ8GDDV4IA] X-ClientProxiedBy: ZR0P278CA0085.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::18) To AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) X-Microsoft-Original-Message-ID: <1294d566-fcb4-74d7-acaf-0db5267af65c@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b865e255-63d0-488d-256a-08da1715fd6a X-MS-TrafficTypeDiagnostic: PA4PR01MB7648:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rxuy9zs+UkMBbf4MV3WB0xs8cTxlwkxkA34/EXLBbKoBPbM/TdnrsZ5OKntl4+rbmIpGn+SzTjccXsNldFwPjC5SQ/Rdz3/b1lzdf6sZhZtgvhwXBioEEzctri26iR76vdbHAiy5vSlN45iBKECtFg6u3Z9haQm6PyopKqznmZDLriqYLMeHEtpfWa+4/5QD/la7qPB2WdEN0Q/WyS9h29ARvWiIq1DiR/9CPLKRGbDeBFYvQUHRjstm5rwPloCzVQgdcGNEYqsSHTO82B6gsDmo+aSXzGX6Tn87PB1aFFxA2aBDWZoRCxDVWf0BBSYF+yQNyJR0IsePVJuHpYny0tkEddKHB2I3PLDbuXR42z0gAqotfZjTMyrof+60kIa/O/B3LpaM2MSr0vp6yZREYIyvnwNkBBk3Eqe8yI5AEOCuVnI30fREG3Gg96Gi/tDmh47W3q8+mavRaeWlQ6WCJoQ6gYeQSImXbwg8ps8SE8UIv9h3g3l+m0kAUt3iR5UViR6TJU3kuDfpOketsUoxyTiavUClXLa2U+uwjuU0AZA7m3zEtTPAaycPweb4U3iFvDkfyvKzj3nuT/yFAldclg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkRxc3dGelNYczQzZzZZNFBob2JaaGJ2elZZSTM2YlEwK1lnRUEwU3NVYTVj?= =?utf-8?B?MXZzMEQzNmFCbFB3YzRxajl0bGFsZC9JUzFoKzR2ZlpNK2JtN0RhdkVmRWpZ?= =?utf-8?B?QmpFNHJtYkd5TG1zdDBCZ1QyOTlHTUY3bFhHWDBhZGpONDV1QnQySG85MGI5?= =?utf-8?B?RlphUHdobUpTaFdxeDgyNmYzWE8wcXk1bjY1Si8rdU0xeGFhT2pMOUNPb3l2?= =?utf-8?B?bmkyVFZBNldpSC9KaG5QUXN2WEdWb0dLVDNjMU1ZVmJhdElGR2ttb1dqS3JI?= =?utf-8?B?WHpCdGtIWjhCTm00bXgyRkt4bmg4ZHpnMkY0VVJQcXNkdTNvdFpQNjNXd205?= =?utf-8?B?RUs4Sm9ZcjQ0WGdHYVNBY0FqbDVub2ZmS0JsdW1pV2hHWjFFZE5CNGxySXZr?= =?utf-8?B?d28vaW44a3ozNm5BZk9zZnd3MXhucnEwRHVZNHBYRXROb2gwc3JPT0tObU5I?= =?utf-8?B?N3NkTStQeDFBVmJoV3Q3WnpvNHRKZnpVRDRnSnVZQVBjcW8rQml1b0U4MTZL?= =?utf-8?B?bk1QV0lNdEdlcVRFNExNSE1sWHdJaFhZR1IvYXV5Uk1ZT2JxOVFxV0V4aTlX?= =?utf-8?B?ekYzajZsdE5aSTRHZFA3TkIrT0hmWW5PSlFSbHAyaXgzcHlhdkpuOFRLanZG?= =?utf-8?B?aVBoOTFCbGE1RlhuZEFYdGxXOHBmNCtmN3Q5UWR2SnZxK0Z4dnlkaTVwZWI5?= =?utf-8?B?dXJrZXZjUkY5aUE4VHFhMFRiVVFOSDVuRVAzRHYxMXlWS2paTTJiQ0hRaGhz?= =?utf-8?B?UUpKMlplR0R3enp0WThtUlF2ZjV4SkhCWDdJTTRSNmp2VTJ1bjUxTnhHd1dI?= =?utf-8?B?NFRZVDM2THI0VWNkbUM0TlBrcGE4SDkvUnVaYUZReFVsalRycVdQRUJSM3lL?= =?utf-8?B?OFg2Mk4xWWRFM0U1STNUa3ZHZDljaC9qS3JXZVduN2RNb0ZrUlFDL0tjSFpP?= =?utf-8?B?WnBZVVl3dDB3RVQ2R29FMXpVYWxQbzQ4OGIyWURqdlBPLzNJUG00amJ2NzFQ?= =?utf-8?B?RVg4TEZobzF4akRkNTdSVzBFVHZFUlN6SXU0QWNyU0dGNzdLVys1ZkxlVm9T?= =?utf-8?B?WVZ4bGs0WHdQeGVsZTN6Zi9wbmxQcVN6R1FJWjlnYnVISHgrWVJkYmg1RFZa?= =?utf-8?B?TEE5eSswcUdMMzJzWEk1RjZ6OVcyby8yQ2o4cExnQzZLV2RTR3I4NUR1UCta?= =?utf-8?B?YVdZeXZuQmlpcU9yZGUrTlEzTUk0cmpuRjFzUVVsTWhpUDlHeWZDVVQvSzFY?= =?utf-8?B?aW5FSnUvYUlsYU9uOFZHL2MzbzQ3aUxOaWlISzlBNmlaTm9nN1AxNHhPSnBk?= =?utf-8?B?N0RCcUh6WGswbmQ3Z1lDRHdkTllHMldXb2hjTEJXcUZXbGhha1htRUZMNUE0?= =?utf-8?B?Y0dnaEdOMytnaUJCS2cyQkRpK0l4ZElwWjBVdUhMYm1ldklQbmFnZXMwQ29n?= =?utf-8?B?enc3N1pTRnJtSE5Wb1VweGtTTEROaG9Ta0pkamhlbTdmR205L2lGQzFtalJ3?= =?utf-8?B?VncwT3ZydlR6bldyWjJ0UFdSTmJRdzJGQ0QyYkxnOUtvZXJuWU1CVkpCaksv?= =?utf-8?B?djJ5RzJUOENMSVFMKy8wZUx0WTFCdzI0NUdaTEpLRGhkaFBBWnRwUWU5aHBv?= =?utf-8?B?d3hFenhBV0xDSm43YXZYSEJIZlR3WHJwNlJFYXhRL0hMdmlXdjBvTGdQeWls?= =?utf-8?B?cU1sMVE0MjBNYlY0VGZoUVE2d2pZbzI4YzA2Z0syL01lS1RmdElvVWNFVDdE?= =?utf-8?B?citOK2F0Nm9WWjFST1NsRjduN1JoWisva3g0eGxYakVENWdnK3djRVkrYkJC?= =?utf-8?B?aHM2NmQzN1BKRGpraGdtUXoyQWI5aEdYVEpEcXluSnoyVUR5QWdtTWlTR1dD?= =?utf-8?B?bWhqYnJsQlduU0E0MW8vdW5mZE5GQ242MVVBSysvUE03WHRUUDRub3h4U3N6?= =?utf-8?Q?Dvjltdjc/8It1UtndrmM7msNRVQBiO/L?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b865e255-63d0-488d-256a-08da1715fd6a X-MS-Exchange-CrossTenant-AuthSource: AS8PR01MB7944.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 15:07:24.2658 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR01MB7648 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ituh263enc: Add AV_CODEC_CAP_SLICE_THREADS to old H.263 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > It is supported by the H.263+ AVCodec already > > Is there any case where this does not work ? > > Fixes regression of some command lines > > Signed-off-by: Michael Niedermayer > --- > libavcodec/ituh263enc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c > index db7cdf1fcb..82dce05e36 100644 > --- a/libavcodec/ituh263enc.c > +++ b/libavcodec/ituh263enc.c > @@ -908,6 +908,7 @@ const FFCodec ff_h263_encoder = { > .p.id = AV_CODEC_ID_H263, > .p.pix_fmts = (const enum AVPixelFormat[]){AV_PIX_FMT_YUV420P, AV_PIX_FMT_NONE}, > .p.priv_class = &h263_class, > + .p.capabilities = AV_CODEC_CAP_SLICE_THREADS, > .caps_internal = FF_CODEC_CAP_INIT_THREADSAFE | FF_CODEC_CAP_INIT_CLEANUP, > .priv_data_size = sizeof(MpegEncContext), > .init = ff_mpv_encode_init, 1. If you claim that there is a regression, you should mention the commit that introduced them in the commit message (it's obviously 8ca4b515e73079cda068e253853654db394b8171 in this case). 2. What command lines regressed exactly? The only command lines that should be affected by said commit are command lines that set the slices option to a value > 1. 3. As the commit message of 8ca4b515e73079cda068e253853654db394b8171 explains, this was intentional, as the H.263 encoder produces broken files with multiple slices (whether with slice-threading or not). One gets all kinds of error messages when decoding such a file: "I cbpy damaged at 1 7", "Error at MB: 316", "illegal ac vlc code at 0x29", "slice end not reached but screenspace end (7 left 800000, score= -125)", "run overflow at 0x7 i:1". Of course, there are visual artifacts, too. 4. With this patch, this encoder will by default (at least, by the defaults of the ffmpeg command line tool) produce broken files. 5. "Is there any case where this does not work ?": Is there any where it works? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".