From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 98A1F428FC for ; Wed, 6 Apr 2022 01:05:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E730C68B258; Wed, 6 Apr 2022 04:05:17 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075046.outbound.protection.outlook.com [40.92.75.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 68AE568B250 for ; Wed, 6 Apr 2022 04:05:12 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KqPZOhR2UYv4iXvNTW3d/S2GjP5zwFoUoRoAIldmyRz1EXNiuZ5sUalKFgui1JwmgJhf+N/IEuMFBiT0Elqs3TIFqSkX0VnjIr0D6YGxW3UKr7/5TkZTakvUd3o1KWfmKZ+Nx+BSvhAW5dJRYS1a8gWic/O/bmuFmhARaiwDY6SRF/DXgQIDsbrCjalzf2g7QnTS+RTysctnC6u6Xlq0Iq5rBDEcxx3qvjKAnfJu3oftF/uSIXkO+qI04DgoYZIREJpw7OAP1x7vpk7P6four3r2Hd3tD8SF+SsyRgjcnzNGBhICSALbZQsSRTmnMOgnyz3n9RaQ/61P04Uf25q5qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lhEd8pqYI9VxckIi1LSYho6V8oOW8dXheagXbg4TkXI=; b=Pz4ayKfWaZMArEWV9EHXHwRlA5Cn8sun6kvaQZbA2ECI3btjw1no8C1kbhzD9ED8j0wjRK8Bipzw+Sob7ThHinxYOV+FTmC4N34AODKXOIr54rkSn6x6hviTIVMC7WQ8XIhtEtX8oVJePVOr8lmiSodeAgAqcnKHDt3jdGudUb9depu0SKoxN3Yy+Sp1DKODIk32/yfz7w8M0uRqR37Qz6nxXRv1gwJhoA6xGmdf/vNNHefD02HJGK0390ZmhkhXoke5hxX54cqlG8xodRfQ8SNX8+8OTtHFmNkB0VD8vCXZPE+zzukTXHBF1Nd/O7eeMHDNZj12SEhN136sQZDg6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lhEd8pqYI9VxckIi1LSYho6V8oOW8dXheagXbg4TkXI=; b=gjTQlKK4C6n/T2XhBCuHEOTWLdJyXbkXfaTEdA8iz56nrzNCU1W8fWZXW7bQiNhytwfDw0Z26Z461aH6AvE5i9tNQvEUJw3GLXsgqWXaB56A4TDJ8E5EJLAISykXXxm1lHB82dhiH4d1XecTxcG5SfPorVp+OK/YcZObLnTFrez00CVdSkV0OQMpXRHSx1gzyJO0k6Tqd2ENzUxK5IwgI4yaF62qSpewCplZOfvbDQUdCEJ/02XcQQBgscpuXe43LgJBq6jWfC7cL91WdcTkbOW2NZhHa1zuR/oKwSz9jvUdJj3a5zanMuZ4wOWpNj6B8ZoR6LrAi/nYivVLl48hSA== Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) by PR3PR01MB6825.eurprd01.prod.exchangelabs.com (2603:10a6:102:5d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr 2022 01:05:10 +0000 Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::6553:a424:79bf:6dc3]) by AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::6553:a424:79bf:6dc3%3]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022 01:05:10 +0000 Message-ID: Date: Wed, 6 Apr 2022 03:05:07 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220403214337.4090-1-michael@niedermayer.cc> <20220405203658.GX2829255@pb2> From: Andreas Rheinhardt In-Reply-To: <20220405203658.GX2829255@pb2> X-TMN: [H7bBizP15coQiug43H6g2MQMmJOmniEm] X-ClientProxiedBy: ZR0P278CA0182.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::15) To AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) X-Microsoft-Original-Message-ID: <5a923fcf-7cbd-5015-e2af-2b6654e10635@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 95ee0f4a-7adc-45a1-e69c-08da17697ed2 X-MS-TrafficTypeDiagnostic: PR3PR01MB6825:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QQYdItPvzd7Q19NRBqXOz58EXOrTSQxGT0x8ui3rQ/6XnJkr5SShO3GDeQ7FA07g1OVO8XMeSsoJ+2jnlDXu092iJNiUkHVKHKQhD0D4jRmbf+hVEQ6ZA3+JP+zwzJFsH0GhZDLw0W+LiV89VMsiMdfiRhH+l7bSysnhzvoD60Vxhwxw+UhuttqyOUnP6pV6jF48qlI6FiyNFYaS2TIKt00IqbXGPPHrzxl50vRv5UmhGjpg9uBP7vlEqddeEVW2kgXy/jiz1KehtcGRDRPOrKeAA2M11XpR+hlPooEOo6VqSldolV16Ah/25F5/+h0ChtTyQEGNyOJXDeRZY2yw/iccWcNCetpDJE9mjAZfqFzzC0RiceF0F3DNF0FNOUBgOyuzn8sR+SN7+0L8WnHzak8pQjno8UFxMl4qlLvfO8YAR+WnpccISLPU8lL8t9FTFY41pWAB/L0HTFbF8IxMSr9bA2P+aQpM2qKZztX7aVdK6AlzIkgHSF1uAOq2KLUyq6vBVp4NzYJIftOcN+UbbzWaPodhHkRog9g/8XXMtkqYGumwEc3bpFnSHmwlhoV7E9jhz3bM4BpuowPwE+V6cg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzFva2t0a1p0TXhWdTQ5Q3hUVkY0MGg1cGhlaWdqK2J2dDRKZllrSDNMbFBa?= =?utf-8?B?bVYyZFRtMXJWYWFHeVVGZVFtT2szQkM2N3ZsYmt5MnhuN1JoazZZckxpN0J2?= =?utf-8?B?OFZ3Wmg1eTdlRGsxOGdFenQvL1p4Y3dyRmE2UU9hM2EzeUxEUUw4UEtZMWND?= =?utf-8?B?OTdROUI0VnF1Rm9YZDlSMVlTdElPS0hBTGNYZmp3bUR4dHpnSmFxT1BZYVNM?= =?utf-8?B?blRLbHQzQStRUVFDVFJCeW83Ri9yaEpvS05LS0VJaFArdHhpWkpIdWEvWDBF?= =?utf-8?B?SVVvU1o5TkdUWnliRUtXejlERTBwZGhLMm4xWG5HbWFxQWw3R0wzYTZXdCtu?= =?utf-8?B?Z1RJOEZiWjBpK2dxL0l1MDQxQWZNNXBRNEZRM2VWZXFBQ0pDL0dPQXQ0ekNz?= =?utf-8?B?MjlCM1pVV05uTm5rZzVRelNONFlJQURvMFkrcE1iK0Fxc1BGNWgxUWZWelAv?= =?utf-8?B?djBJS01GbFBjZXhMRGRkSzBTUFdDVmJKRHJzL2gvRDZvV3ZHbnRyd3lNdS9T?= =?utf-8?B?NysvS0pLMmNGc3VzT1MyKzVjdVpaWDk5NE4yWE1MTFFBZncxK2ZZMlNabWM4?= =?utf-8?B?a09Ca0E2czVoYlRXSjMvOHU3RGRhV0l6VmdLUEhxRDdOVGNxa1JjNXJnWjJz?= =?utf-8?B?ODdGRXJwUGJtcDEzVm9zOEdPd2VHNUtGam44NG4vdk81SmFvaW5ZV3lvV3RS?= =?utf-8?B?L1RlOHlmRE11cnBCSmVJVWpKUTF1Y3hvRENXTzBnUnpRcG9hVmZyWmZ3VWFJ?= =?utf-8?B?M0M3MTh4MU9GSjhVNFVuNWVUZm1ocjRxK2xGL3A1Q0UxSmRBYm5ETUNxckFh?= =?utf-8?B?VTlPM2tHbWxWVU5ETXFZd0tiWExIajhQY1cySzJJQjNjTzl1eGUyUkpEb1ZZ?= =?utf-8?B?OTZ0MXBGcEJyUGdFZ1grYUJaTEx0SjJOam9nYi9PQkxxV1Y1SmdKNVA3U3NO?= =?utf-8?B?UkpWWHdGZTcwNWU5cHpYTkxDZC9Cc3ZTV3E1bHdiZXdxcGJVbEQ3am9Qcy9X?= =?utf-8?B?TWFhaGVuc1lNTlpicldvMThKTUJ1Z2VVVWlxaTE0SFRXZDdKY2p6MFlqaTkr?= =?utf-8?B?ZXVqbXFQR2tPb0FIUmpQNWZZUG5vTG5JZ0JyRzhrNkxQZFBHMExMdWNXejNE?= =?utf-8?B?NmlvWTZxWFFvWGpiYlFibUFMR1FoNWoyYStYOGxCNDBmSXo5VnVHdU4xbEFv?= =?utf-8?B?ejdYNXdVU0ZSY2JQYUlKUUhlUmQvUDZ3OW5ka1BQdm9wMVJWN2hJOFFGN2x6?= =?utf-8?B?RmpLTWtTS28yeWVoQzBzcmpZWHJtUDFjMGVqZDRzZzhCUlF3UlRnazZrd0Q5?= =?utf-8?B?RmczWlEydGFlU2pFbnlDcVhLMTAwVWozTE9pdzlSR2wyNVM3QkxsbTRBczFV?= =?utf-8?B?emgrQzliT05QZVhRUVBuMXF6ek04bkplN0tHckxaS2Y5WjdLUVg2QnRXUlpN?= =?utf-8?B?Sk52TFRMQXIxTHFMbVJPeDl3Z2FybzJqLzc1SzE2SmdUSzNWRG04T0JqTmtl?= =?utf-8?B?WndtRTZCNjAyd3lNZjR4WDFWdk43cnYrUHBNc2VDUHpPejJSNUthTXc4ZDlN?= =?utf-8?B?cVNxMVJHdE45QURzbFhlSEFOU3ZCYnlyZFVlTnZmbmZ6Z0pRajhyVW5Ca2Vq?= =?utf-8?B?ZWpyNWFBOWE0TVR4S1lzZDhQZXNyVnQwdWs0SjhYTE5DR0MvT1hSTEJnNzl0?= =?utf-8?B?RTBTcWJUMTFCb2pIdlVXN0FKODJ1VXJ4QTlwdEVXbFZ0TnNaMHN3WE1MWm1h?= =?utf-8?B?RmRkK2pFSXFVSWU2NUVPdC9VTVdhMCtycjZLaUxQOXNyRmlFMDNXRm9WK1I3?= =?utf-8?B?MGhhV2hNcDBpcFBjdEhPb0dNVDczM1ZxSmlFNXI4cEFYbGg1bGlxelZJL1NQ?= =?utf-8?B?MDBPTm1Vb1p1MjBWUndhWGRTU0c4eUt4UTdsaWZQVm5oKytEVTAySy80aDQ2?= =?utf-8?B?L0V5R1JtbnoxRERxaVk3UmpRZFNOUW1HdlZvYitDYXhPZUVIYXVvck8yYXNY?= =?utf-8?B?QU5tSmhEcUJnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95ee0f4a-7adc-45a1-e69c-08da17697ed2 X-MS-Exchange-CrossTenant-AuthSource: AS8PR01MB7944.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 01:05:10.7175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR01MB6825 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ituh263enc: Add AV_CODEC_CAP_SLICE_THREADS to old H.263 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Tue, Apr 05, 2022 at 05:07:22PM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> It is supported by the H.263+ AVCodec already >>> >>> Is there any case where this does not work ? >>> >>> Fixes regression of some command lines >>> >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/ituh263enc.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c >>> index db7cdf1fcb..82dce05e36 100644 >>> --- a/libavcodec/ituh263enc.c >>> +++ b/libavcodec/ituh263enc.c >>> @@ -908,6 +908,7 @@ const FFCodec ff_h263_encoder = { >>> .p.id = AV_CODEC_ID_H263, >>> .p.pix_fmts = (const enum AVPixelFormat[]){AV_PIX_FMT_YUV420P, AV_PIX_FMT_NONE}, >>> .p.priv_class = &h263_class, >>> + .p.capabilities = AV_CODEC_CAP_SLICE_THREADS, >>> .caps_internal = FF_CODEC_CAP_INIT_THREADSAFE | FF_CODEC_CAP_INIT_CLEANUP, >>> .priv_data_size = sizeof(MpegEncContext), >>> .init = ff_mpv_encode_init, >> >> 1. If you claim that there is a regression, you should mention the >> commit that introduced them in the commit message (it's obviously >> 8ca4b515e73079cda068e253853654db394b8171 in this case). >> 2. What command lines regressed exactly? The only command lines that >> should be affected by said commit are command lines that set the slices >> option to a value > 1. >> 3. As the commit message of 8ca4b515e73079cda068e253853654db394b8171 >> explains, this was intentional, as the H.263 encoder produces broken >> files with multiple slices (whether with slice-threading or not). One >> gets all kinds of error messages when decoding such a file: "I cbpy >> damaged at 1 7", "Error at MB: 316", "illegal ac vlc code at 0x29", >> "slice end not reached but screenspace end (7 left 800000, score= >> -125)", "run overflow at 0x7 i:1". Of course, there are visual >> artifacts, too. >> 4. With this patch, this encoder will by default (at least, by the >> defaults of the ffmpeg command line tool) produce broken files. >> 5. "Is there any case where this does not work ?": Is there any where it >> works? > > The testcases i had where these: > ./ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 1 -bitexact -qscale 2 -slices 1 -y -threads 1 -vcodec h263 -s 352x288 -an /tmp/file-h263-s1t1.h263 > ./ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 1 -bitexact -qscale 2 -slices 2 -y -threads 1 -vcodec h263 -s 352x288 -an /tmp/file-h263-s2t1.h263 > ./ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 1 -bitexact -qscale 2 -slices 1 -y -threads 2 -vcodec h263 -s 352x288 -an /tmp/file-h263-s1t2.h263 > ./ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 1 -bitexact -qscale 2 -slices 2 -y -threads 2 -vcodec h263 -s 352x288 -an /tmp/file-h263-s2t2.h263 > > The files seem to play fine > i did not try to find a case that fails > ./ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 1 -bitexact -qscale 2 -slices 4 -y -threads 4 -vcodec h263 -s 1408x1152 -an /tmp/file-h263-s2t2.h263 produces garbage; also with -s 704x576. slices < 4 seem fine. If one uses too many slices with smaller resolutions, the file is no longer correctly probed, but can be correctly decoded with -f h263. I don't know what is wrong with the bigger resolutions and too many slices; I don't know H.263 at all. My first (and admittedly only) test for whether using multiple slices with a single thread works produced garbage, so I put this codec in the "multiple slices not supported" box. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".