From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8DB2442B17 for ; Wed, 13 Apr 2022 12:28:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B00CA68B3BA; Wed, 13 Apr 2022 15:28:32 +0300 (EEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-oln040092069094.outbound.protection.outlook.com [40.92.69.94]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A3C3368B399 for ; Wed, 13 Apr 2022 15:28:26 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hO5myw87Z/1LmUJSfu6+tcGi5wyB/aM2XxQTMKjzskfjWPck6TuGVauXVtuYMRtRc+IyKh9KX1JU6mkWKh9fbsm0s/HuSgp6utTpu7zml5z3KLMtp/AXcVCl0O1ShQ+MtGIVoaoxPqEE9s9brnOGlhcnP/6j/m/qqNQb8cwjjoZvHmgPkoDD41HBJ2axji5tV+eKoYeziKW/iJzmIa3PLmjcARf0Wu2bvxk5hlR4Fh0PuzCxfpU1yt8rSQMXKib4WdU77fwwQpO9CxmYl3uBWET6OMJw44WYMVBj6E3fgvIP/TLzZGMmUTXXlJ/RmcQ5q7Mxo5obnuEP2ROb3V5KCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9xr3yL+MNeu42TqRI00WmXJKDDaX/eSh/fwO9sYdxhw=; b=HfQy/wGyucGCBrH3CGM9kNafyIknqVh0EOV2RQ+figTJZEQkZWGH1XMlZn/hEZfyQvmfXeeQ40/ANYLeljM7uXzkJN5KBSpPB+Vy0/PhtWZ+OMXwVu2AjbYBOS3Z9cuBIFIkhlMaZGg4Wi86b/2SR12y1G4EFUdl4oGPiLaJgp9Y3f0mODlsnCs/eCNnTofdc+Y/nOpbMHvPEc1wfeEQbWO0da7KwsHkcWNkbURGROZIqV9Nr5u0YMiKudskKG8d3Ryuc958OD6b9wqQj9KKf/26kzSaoChDKz27wyktcRBtKw/6xDk9laONrskbPqCYxXd/6sUi5g63/ZPMKKdH9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9xr3yL+MNeu42TqRI00WmXJKDDaX/eSh/fwO9sYdxhw=; b=CChNWjUCvm9HxXEItdQltBpePf3wiBxo4VrY6smvmRCUblWhMru/suMO+dmpng3sL5YOMSneOky2/N3ZrywD+aETjSfJkISlWzmPCWMiuGU5QbGx/303WXYhDTwTJ6hkUEb+du0SEKGMy7cMu/iakR38KV1L6c7z+7PwYwRBzMShZvQs9Vj6Pp3JwUEhnG1j9tjFWHYSCvLTEPB0PaJmSBx4ubhIuRJhkc02iuKcYCBxrEWN7/8eugC/CRt/nzLGq3+v9zDxAXSbYTlYO31wNT6rb38lIzy1GAMejHgHpmOUT4QjJBEI+YBMq2LqUIISKFKudFN6dVXvvH/57iu/Cw== Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) by DB7PR01MB5162.eurprd01.prod.exchangelabs.com (2603:10a6:10:88::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr 2022 12:28:24 +0000 Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::fcc3:1285:374c:9b2]) by AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::fcc3:1285:374c:9b2%5]) with mapi id 15.20.5164.020; Wed, 13 Apr 2022 12:28:24 +0000 Message-ID: Date: Wed, 13 Apr 2022 14:28:21 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220406120056.10537-1-markg85@gmail.com> <20220406120056.10537-2-markg85@gmail.com> <20220410144127.GD2829255@pb2> <20220412180257.GL2829255@pb2> From: Andreas Rheinhardt In-Reply-To: X-TMN: [2qJ3MRanjG+AsVGIWdlAUDEP2r8M/nbv] X-ClientProxiedBy: ZRAP278CA0005.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::15) To AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eef1f7a3-5604-4034-aeb4-08da1d491a6e X-MS-TrafficTypeDiagnostic: DB7PR01MB5162:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YP80Np++94LAt3oMb7iL8oX17ybplk9D4T/KvnDtywqMNGswQSz9MAaS34+ZzICYOwbALfm9R2qy/Zys1vyOuf3jeQ5KgZjjh/6f0mY8Fo8/IGsWApiQfPAht1bEszA8DgVaPj3aApaRUuz2jnjO/Z7F8MPHgnBXcAZDLGLAKObTC8xbfA6S/eIxryTZLrFYK8MknkkroDr+ieYvKfC3YWeg2KmeAevUemeNpyNP+AUOWb8uh2lg0YI6alBfwD3xDE3gaiyBiKs2QZLKB6BGf/DQwW2qkb0x+dGHfwCjcqEmJGX3EuqfOpsbx+MsDgWPskQA7Q++ZCpTGxToWKWqEqIOBoTp7ASEzy/TzMmLCPPSNyTDFw6+lSsER2bT84/Q+L6vM5i6icis/4XBgQ7RM4AlK88/v2AxrCLkdqqpyJLrH67xLlq61bMbdUzZJ9g3lK2md15Y757SP1dLcJzXE7dzVptyZPvAudgFqNUL5SbQANvNGkSHCOTOoPUss5UG4FAb0VoteaVRwa2qv+MiDXplduQW0S+0Wnaef/b65OPhkFZ944BCS+lGxSprhKkM4nLnfJve30zvZPMzb+oTmQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmFqR2tRWU91Q1JzcnJBZ2dpTTJPQm5VMWJWYjIyN1JsM0ZhM3ZCWjhucEdB?= =?utf-8?B?aFgrR3ZURTgrU1pWQnZjR25EVTBjNkVrMWtwTXZTbjU2ZnhoM2x5QitoSEht?= =?utf-8?B?VWI5OE55bnV0MEp3cFpwQXQ0Q2U0VWthRXhrNFhBcHdHYithajRoN0hlRzhx?= =?utf-8?B?dlBLbmpzMXYwOW10Y3ZIYnRIYmYxSWRrc2VmQVFlYUxDYzh4cFo1ZTY2dHQ2?= =?utf-8?B?U2c5YmlpUE8vSHVqVldYb2V6SjNVVHd0N1JmbEtFS3Y1dHV2YlUyRk9JYzR1?= =?utf-8?B?cWlQbFlMQnZSckFmOGI1V3VDM3dzOSt2ZjR6aFppcklVeUpKcnZTV0prQ0hn?= =?utf-8?B?SkQwS3lIZmN2USs4Yk96dCtyN01GNExYVlJCdEEzN2d5ZGtRNFlPWTNBRXdD?= =?utf-8?B?ZUlqcGx1K2xwSXpmQXBnNzRVdjFKK3VRSVgrZ2h1N1drRHgxbU9idDB0ZFBt?= =?utf-8?B?NUJiYS9xRnN2Qngwc2ltMENGVWk4MWk4VXN0SzVtQ2xLUU9FbUVXc2xzV2pu?= =?utf-8?B?Z2Q2NHp5b2ZFa3J2bm1wK2FPbmRLY3FCUjVrZmxWSnpVdFBZVUNoSmRpaW1t?= =?utf-8?B?S0YxRWU5T0dTOXJmTXJMSUxOUUIrZEVpcHZMalIzeW5wQ2thMzFQUjhhT2F2?= =?utf-8?B?dXRJTVE3b0VzTVc0V3FHYWdwZnZhbmxwZlEvN2owS1pEVEY4VVJCdUpLRTM4?= =?utf-8?B?QmJ2WlZrYTBTWGpOWUYxVFYycEZCWE90aTFiMTJQY0xCZG5BOG5YbmZ5RXhR?= =?utf-8?B?V1JjekZpVHNMZWJVbU1BZ0tEb1VXMis0eElvQ0Zxa1ZtN0xNVlJyV1MvbElJ?= =?utf-8?B?bm1WWlJuY295KzNFdjVxZUkyOGN1MWxsMlllVkIyVzJ1cXBzWWpDZzl2aUNh?= =?utf-8?B?OE9XbWJHZ0docnFvcldrTUtLOVFjWDJ4ZUhIWEUyT1ZmbU15OHpEamZRV2RS?= =?utf-8?B?R0JSVGM1Rjc4N09uRHllZEhzcDFsVGd4bkJmYnRxMEFVMnJTTDlhTlVTMlBn?= =?utf-8?B?UTFITCtrT0t5SzZtVERDTnY5YmlEQ1ppZGpQVTZDQkp1NWExYk9XTGhmSTZP?= =?utf-8?B?K1BkazBKc0NjMmRON2ZuZ0x6UEo3cGVuN3pDQS9XdlVsTjhGc0N1Zk9oSzBo?= =?utf-8?B?eWFtREJVSW5oeW4vRHE1ZlFtNGtQeDlWNnppVzc5MTE5Mmx2MXBWOGhIdkxU?= =?utf-8?B?OFRiemZvK2RPTGI5UXRhNVZVV0lLSjdMdHhFdlVSTWwrd1F6S010bFg5QUtq?= =?utf-8?B?Vm0rN0xxcnRGeHFhekN0cVNLd3hzczFtUUpXSlRTSjRkVVRGZE9TMnRXWC9T?= =?utf-8?B?R3NIaDMxQ3NqUWhCT0lNemMzQlBIWXhnSHk5eUlXdWYwUmFGWFVtMmx1eDVD?= =?utf-8?B?MDk1VXVaTjNpaUNGMTZWeTlLY2pnMXFDd2lWMjZOci9EOEtuOTFSQ3poSS9Y?= =?utf-8?B?TExUM2E2bGVZaUp0KzJRNkd5L2k1T3JiVHk1amhlVnc4c1MvZld3NGdkQmgx?= =?utf-8?B?REJCbnpnZHpVb01WSm1XdVgvUTl6MEszREZSU2FTY0p1MUlkMlVKeklhZkVx?= =?utf-8?B?UjQzR1VCZVgzQkVzWDB6eDJkNG9kbEh3R3VEWDdLbFZwN2JsdWJUSDlpN0pm?= =?utf-8?B?ZTR3UVRZa2xIMzFLblFnMkR5cnh3S05pRkp3S3g0ZTBaMC96WkNWYzBFQk9D?= =?utf-8?B?UVFCd21yZFA2WmVYWEpEcituUzJHd0pzV2lRUFRzTDg5QUJkTkFPUmFrN3hY?= =?utf-8?B?emhBMFk4NklzOXBsbFZsVGUzcjVldkVldFR6a3dZcEgxRXp3L1dMMGF2OWhN?= =?utf-8?B?WWxURStrQm5na3loT0N2cWg3cFJpRkZPRjUvSDZvdHVUQ05zaHp1QzhCc0tr?= =?utf-8?B?QkRGRkg4WnVsNTlRYmJ4TmZMd25VSFVxVk85SHZoT3BxcEQ2RTlrQmtYd05Q?= =?utf-8?Q?E9qtxdJh6KFUFmPEfdZoK1S1z/+kAXay?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eef1f7a3-5604-4034-aeb4-08da1d491a6e X-MS-Exchange-CrossTenant-AuthSource: AS8PR01MB7944.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 12:28:24.2919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR01MB5162 Subject: Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Mark Gaiser: > On Wed, Apr 13, 2022 at 1:10 AM James Almer wrote: > >> >> >> On 4/12/2022 3:02 PM, Michael Niedermayer wrote: >>> On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer wrote: >>>> On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote: >>>> [...] >>>> >>>>> + if (stat_ret < 0) { >>>> >>>>> + av_log(h, AV_LOG_INFO, "Unable to find IPFS folder. We >> tried:\n"); >>>>> + av_log(h, AV_LOG_INFO, "- $IPFS_PATH, which was >> empty.\n"); >>>>> + av_log(h, AV_LOG_INFO, "- $HOME/.ipfs (full uri: %s) >> which doesn't exist.\n", ipfs_full_data_folder); >>>> >>>> The 3 av_log() can also be combined >>>> >>>> If nothing else is found then ill change that myself and apply in a day >> or 2 >>> >>> applied >>> >>> thx >> >> This broke msvc >> >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): >> error C2065: 'PATH_MAX': undeclared identifier >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): >> error C2057: expected constant expression >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): >> error C2065: 'PATH_MAX': undeclared identifier >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): >> error C2057: expected constant expression >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): >> error C2466: cannot allocate an array of constant size 0 >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): >> error C2133: 'ipfs_full_data_folder': unknown size >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): >> error C2065: 'PATH_MAX': undeclared identifier >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): >> error C2057: expected constant expression >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): >> error C2466: cannot allocate an array of constant size 0 >>> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): >> error C2133: 'ipfs_gateway_file': unknown size >> >> PATH_MAX seems to be POSIX only. >> > > Seriously? > > Shouldn't that define work on windows too? For "that define" to work that define needs to exist. Windows has MAX_PATH, but it is pretty small (260). > And why didn't patchwork catch this? > Because there is no MSVC patchwork box. > What is the intended define to use for this? > Note that it used to be a fixed number in the code itself (4096?) but I > changed it to PATH_MAX as per review suggestions.... Then how about just adding #ifndef MAX_PATH #define MAX_PATH 4096 #endif or something like that. > I grepped over the ffmpeg source. This code is indeed the first cross > platform code in ffmpeg that uses it. The sole other user is v4l2_m2m.h but > that's obviously for windows only. You mean "not for Windows". - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".