Re: [FFmpeg-devel] Need help submitting a patch

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Andreas Rheinhardt:
> Traian Coza:
>> Thanks. I'll use the ffstaging/FFmpeg repo. I didn't know about that, it
>> seems much simpler. I've tried using -n (n= number of commits), but it only
>> generates n emails, I only want 1.
>>
>> I have another concern before I create a pull request. I ran 'make fate'
>> like it says on the website for regression testing, and I got the following
>> error:
>>
>> TEST    source
>> --- ./tests/ref/fate/source 2022-05-02 12:57:02.707487436 -0400
>> +++ tests/data/fate/source 2022-05-03 09:22:31.302681114 -0400
>> @@ -5,6 +5,8 @@
>>  libavcodec/interplayacm.c
>>  libavcodec/log2_tab.c
>>  libavcodec/reverse.c
>> +libavcodec/text_to_bitmap.c
>> +libavcodec/text_to_bitmap.h
>>  libavdevice/file_open.c
>>  libavdevice/reverse.c
>>  libavfilter/af_arnndn.c
>> @@ -20,6 +22,7 @@
>>  compat/djgpp/math.h
>>  compat/float/float.h
>>  compat/float/limits.h
>> +libavcodec/text_to_bitmap.h
>>  tools/decode_simple.h
>>  Use of av_clip() where av_clip_uintp2() could be used:
>>  Use of av_clip() where av_clip_intp2() could be used:
>> Test source failed. Look at tests/data/fate/source.err for details.
>>
>> The source.err file seems to be empty, however. Should I be concerned about
>> this? It seems to do with the fact that I've added some files.
> 
> This means that your newly added headers use nonstandard inclusion
> guards (if they use inclusion guards at all). Look at
> tests/fate/source-check.sh to see how the inclusion guard should be.

Addendum/Correction: There is only one header; the above two additions
refer to nonstandard license headers.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".