From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH 4/4] avfilter/vf_colormap: Avoid allocation of small array Date: Fri, 29 Apr 2022 03:54:36 +0200 Message-ID: <AS8PR01MB7944C128E81078851A605E408FFC9@AS8PR01MB7944.eurprd01.prod.exchangelabs.com> (raw) In-Reply-To: <20220429015436.666932-1-andreas.rheinhardt@outlook.com> The number of elements is always two or three. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavfilter/vf_colormap.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavfilter/vf_colormap.c b/libavfilter/vf_colormap.c index d5c5bec39c..106333ced8 100644 --- a/libavfilter/vf_colormap.c +++ b/libavfilter/vf_colormap.c @@ -24,6 +24,7 @@ */ #include "libavutil/attributes.h" +#include "libavutil/avassert.h" #include "libavutil/common.h" #include "libavutil/opt.h" #include "avfilter.h" @@ -134,20 +135,15 @@ static void gauss_solve_triangular(const double *A, const int *p, double *b, int static int gauss_solve(double *A, double *b, int n) { - int *p = av_calloc(n, sizeof(*p)); + int p[3] = { 0 }; - if (!p) - return 1; + av_assert2(n <= FF_ARRAY_ELEMS(p)); - if (!gauss_make_triangular(A, p, n)) { - av_freep(&p); + if (!gauss_make_triangular(A, p, n)) return 1; - } gauss_solve_triangular(A, p, b, n); - av_freep(&p); - return 0; } -- 2.32.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-04-29 1:55 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-29 1:53 [FFmpeg-devel] [PATCH 1/4] avfilter/vf_colormap: Properly uninit FFFrameSync, fix leak Andreas Rheinhardt 2022-04-29 1:54 ` [FFmpeg-devel] [PATCH 2/4] avfilter/vf_colormap: Fix declaration-after-statement Andreas Rheinhardt [not found] ` <20220429015436.666932-1-andreas.rheinhardt@outlook.com> 2022-04-29 1:54 ` [FFmpeg-devel] [PATCH 3/4] avfilter/vf_colormap: Remove unnecessary headers Andreas Rheinhardt 2022-04-29 1:54 ` Andreas Rheinhardt [this message] 2022-04-29 7:00 ` [FFmpeg-devel] [PATCH 4/4] avfilter/vf_colormap: Avoid allocation of small array Paul B Mahol
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AS8PR01MB7944C128E81078851A605E408FFC9@AS8PR01MB7944.eurprd01.prod.exchangelabs.com \ --to=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git