From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BEC2942894 for ; Tue, 5 Apr 2022 14:30:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ADBB368B20E; Tue, 5 Apr 2022 17:30:50 +0300 (EEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074021.outbound.protection.outlook.com [40.92.74.21]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8647668B0C5 for ; Tue, 5 Apr 2022 17:30:44 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aqp47so9qjQ7BBQLxwoggym7hTy/oaSqC3RHTk5XA1G0Zqogx2N9SgGiyUbiju9N4eZup5kyIV1IGi4WVXaiUleTlG6jggVhitucxeFVaI5bUg0hJOH6XMr917IidDg987XFB1OgDVPLoBRQC3uvuGCBK+F4X+LTPaTlZSLmXKARt2ALbCJxTNrqpkY5eKHZCRIiAEYHmIuSTGTH9KA8xv9TVmtTDVvhtwV1DqS6LCTtwCO8WSEWlsllekZdM7Tqzvi8x1NLtIPGUcfLjRXqczcPH5uut9XV3eg6zFmKcSPBMtdiME+rT5h9/paJYsA4FBivo59WoYPL9fFw+ee99g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=INozBu2whjv6j+QVmYgbs47C1pFddWcYE+itg+a6WV4=; b=mVfB/6uoCWEsphZNj2P1yBHBtup5nT67MSIzRfizRKlG2FEOZdNpIxiMyHJyE4fVvtDa3o89GuYhQzRb8uBT8Zgfg9yH68hSCC8H60sqxVwWNLLElTh8OUpeivpVKW91icHpzeXRK1aWcPVO559kRolEqTvNlHxEYv7XK+Y1BgmfRJV0GQmOgmzqT+wGwdIcxur8JYkkKkaysTkIbIMtie6S5D59OlGe4sGxpxg16rlYlhJrK6J0kNqVCU2CWY9VUr4Pz7fIEd+qaxqGeyJuMP3ARfr3HMiyj71TTXhgynhRRLB1C938MxvUia+mf69TGjg7+yEKk8q4V9+35iwjZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=INozBu2whjv6j+QVmYgbs47C1pFddWcYE+itg+a6WV4=; b=DPLAQn/Rn/036Bk49GThtQ5uSThfFF/lhD10Li/qrSudKQRYUf+jCXXkBX+KBgJ34xKIo0r5LwG/lEybpraH3AIMbcTdmSTMGLn6DRsHQCo81l1by/zygYTKSiAr4ksqf/Xniv4Rrv1gLFkMQVBn6gnAQWsb+MNhepj3VXQS7uqlFgLI8qWnC1JJ4rdXXWu+5j4DfwKZLCvrX0Bx46DPfLPy0vcMyCqnUh6b3FO/4DAGSkoq9ipHvn8uC63tiNERjRztQlMS+fM80991cjumNff4uaOlcdM+XpmU94dR54Ia0CogX7Pj5NzCRd1omJE939iBaO42jA/zuzfaAvfu5A== Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) by DB6PR0102MB2696.eurprd01.prod.exchangelabs.com (2603:10a6:6:5::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr 2022 14:30:43 +0000 Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::6553:a424:79bf:6dc3]) by AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::6553:a424:79bf:6dc3%3]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022 14:30:43 +0000 Message-ID: Date: Tue, 5 Apr 2022 16:30:41 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [GPYeYezQ2En+KLwq/EWm1I/FB1njhjNb] X-ClientProxiedBy: ZR0P278CA0154.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::9) To AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) X-Microsoft-Original-Message-ID: <240dddcf-5278-4a76-41dd-7eae2b7b818c@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d22d9243-aa3d-4980-c80e-08da1710dd85 X-MS-TrafficTypeDiagnostic: DB6PR0102MB2696:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n3asP2Z0YZ5SwFFLIleIUNCKcQQKi36RZxCqlxBeP6SO8+R8pzZTcdYzzHYmolRXqirYsmu6dXguP0koeFo1pqSMOtpmLpY2aAMEt7h6zOTF0OZJ9zx7Vmwz8iyTfYXGRR9zeWZ2q2Wk1/W2/V3XYkly6WO0rk7mxx0V47G1k6T5VO+ilkYOiLOwR7Q3UDZyCm45spm2v5tgpLSWVY7e7JJa94h3+4fivquz2kT/ZDwaK4J01R8EgP6afxSUmid738wA6Xrbk2gGqDTjTicQJKnco5Ze7m6mEv0LeyHT3YqiR6oz9hLEKlmGtU7t7L0njudoghd9HHloJBLS9G61XgE9RAPWSbmEgMoukLJHHxuQtiSOlwsY1wYeiZs77fbGp8gaJPTjZFZeNbA00hSalPc3QOVA9QxJkJbeCS0ulm2VI2nNsw6T/HHy8GLAPVJRVpbrEtaxtkmu874mPLXOrFRhkpOdQcVF3zvqeSEWrTiBdz18a8pcTcHVNOjt+ZNRD9ETwNgZ20lg25G0px9dNIlAPK75PP/D7Si5R6NSRaVqTiWJyn7iuZxoXwUPTUVQT974Ww87YVEihxOH6Csmlw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUZ4VWc0d25qRzVCNG9CMWNQSHFSSHVOVUI5US9aVW1hYzl1Wk05cjRKOWlp?= =?utf-8?B?WEQ4Z2FEK3YwUEt5N2o1djVkVnZqZEhkRXRoZWk2QXJ3Rm15c1Z6ODh0RDQw?= =?utf-8?B?SysvV1pHa0JtTXBtcThCVXlWbHA3RmEwcEg3eGZNN1hWb0dYTHhFUlRYdThi?= =?utf-8?B?d0hUTDhlMy9qTjRKQjN0c2MxY0g3Yml1cDF3Qy85ZGNDWVMvTjJuR3dKbVMx?= =?utf-8?B?WnBORW1zTWRxU0JCVDdGVFA5d0FtVk5XNmluUEhsUmRWanYveFZBeEZqU2VU?= =?utf-8?B?cmVMOWsvL1JLbERGTGIxbWZzQTRROFZhc211cHdnVmM3azNVQlVqOWJpVmNt?= =?utf-8?B?cTNKMU5qYUF4NEJHUUxJK0lHd01XaC9CVlpkb0UrYXUvN3U0OVhWeERMNjlB?= =?utf-8?B?MTVadkNiZk0wMndNZUNGTmRTMFF0ZEdUQXZYS3AwajRmb0dlSHJyTk9BcFBN?= =?utf-8?B?TUMvMGhKdXZBa2gvU2JhdGNVTFRVU3hNR0txVWVjeDdqQ3pYemNFaDRRNjc0?= =?utf-8?B?Um9mN3h1T0tMVDJMT0M4Qm5BNkNrWXR1WHVrZW54VGtIMXZZOE1mZ1VXc1Bz?= =?utf-8?B?OUowVnoyN0dIaVYwb2wvemtxMUNQVEhPMHNYam5IV3huWEx5eVZEaXFTWHV3?= =?utf-8?B?UVRDeElIVFZlUjgxbVk1ekxNeElsaWJOUlFOcDZXaVU2VFU2REN2dzRZTUJI?= =?utf-8?B?a3ZQeXpzWnU4VzBVanBZRXI2dWZZUWEvTmJxcTRtMDlJUzBDdmhjWDZJRWRi?= =?utf-8?B?Vmc4eUFtb2NXNnVoaUFBdTJMZGVkeWRyVkcrREtBWlFUTTFwd29ZYWxUUVN5?= =?utf-8?B?ZGUvcFNRdXFPdHBlemJXVHU4R1RFOWQ1UGNNRXRrWlg5bm9aN1hvT2tWYkVp?= =?utf-8?B?cmtyRWtGNmtLVjdhd01IQXVGRFJOL2xGTSswRmdWTElsUk9sMnFhUzVvZllW?= =?utf-8?B?M1BoWDUxUlB5dE51UmRsNkdWUENYN1ZQSTY0SGR2eGtPL0YyMGZXNE1Jc3Yz?= =?utf-8?B?aXU2NlVOWDlyR29mZ1hkb09TL3NsWEdCV1RXZFYrMlI2MHQ3TXFJWExXbnkw?= =?utf-8?B?bXNhdXhtRkxsZHV1VDhVZkEzZGtBRHEwUXNHYnRPaEJWeTIyWmVTUm5yOGd4?= =?utf-8?B?YVdIUklTeU54WDBDVmFoZFJxRmNYVXV0QklvZ1ZqeGp6N0Z0WStPMnF2Ukl4?= =?utf-8?B?NjBGQlZsTWtiZ2J5OUkvOEV4VENPcVJRTHlFTUtCSFBLcXd1MVIzVUpjeU9J?= =?utf-8?B?NExxWlQwT2FRUTVWYVhaZDNJU3RzaEozZXdwWEppZG50NlVOUWlyU3dYZlA0?= =?utf-8?B?dWJKNmxoWDU4bW1lZ25scG04dnlEV3lUYmVHQmhEdEd5cG4xUDdWelczenkx?= =?utf-8?B?blRudkZRQUJQSklIYWY5VWppbE9lMzZ2emU3TFl1dGZnOEJqNSsyaE9yM3Fn?= =?utf-8?B?bzUreEoxNkxpQ2ovNlRCUWNrMG5hOVpQTW5LYk0raU9yV3BpVnphTE9xUTNn?= =?utf-8?B?dHFLRlA0amczb29WN0dwb09LZDNONFgwMDlrS0xKM2pJRHU0N1ZNeHE5a25p?= =?utf-8?B?aE1rSVE5TytJUHBVZG9qK1dhY1hTMEtLaElmSzFjNTdsZEdEcXJlcGprcVFQ?= =?utf-8?B?WTRSaEVhVERwZHQ0cVpqWnZLRFRKVTZPaHNzMnFnSDkrTVVmOS9yUWJaN1ZS?= =?utf-8?B?UzlIME91eWxmeERRNmRjcGUrcEo0enV0R2t6SThxNHRoWC9lTGJTRXA4eUk0?= =?utf-8?B?U1BoZ21YSnpvZktnWnVlTTVlaE9QcTV4RHJuclo2ejhDM2g0VW9YYi96cTdO?= =?utf-8?B?N3Z5aEFoM3dnMTFBRlRjaWI3akNpS1hOYkJvTTMzcTlFWldmZWk3NWRDRHVR?= =?utf-8?B?cE9abDVycDZXcjRKcU45SFJJa3NqRjNkWWl5RkpVekE4dmg0Q2trSnRJWjFX?= =?utf-8?Q?6cm9Vi5B1CXgvTGppl9DmxdC+rcSXpG4?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d22d9243-aa3d-4980-c80e-08da1710dd85 X-MS-Exchange-CrossTenant-AuthSource: AS8PR01MB7944.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 14:30:43.1981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0102MB2696 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp9_raw_reorder_bsf: Fix leak of cached packet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > In case the BSF has not been drained before flushing/closing, > the context's next_frame might be set; yet it is not freed > in flush or close. The former only zeroes it (which automatically > causes a leak in case it was set). So do this when closing > and flushing. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp9_raw_reorder_bsf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vp9_raw_reorder_bsf.c b/libavcodec/vp9_raw_reorder_bsf.c > index e7d301cb85..368dcb26c2 100644 > --- a/libavcodec/vp9_raw_reorder_bsf.c > +++ b/libavcodec/vp9_raw_reorder_bsf.c > @@ -396,7 +396,7 @@ static void vp9_raw_reorder_flush(AVBSFContext *bsf) > > for (int s = 0; s < FRAME_SLOTS; s++) > vp9_raw_reorder_clear_slot(ctx, s); > - ctx->next_frame = NULL; > + vp9_raw_reorder_frame_free(&ctx->next_frame); > ctx->sequence = 0; > } > > @@ -407,6 +407,7 @@ static void vp9_raw_reorder_close(AVBSFContext *bsf) > > for (s = 0; s < FRAME_SLOTS; s++) > vp9_raw_reorder_clear_slot(ctx, s); > + vp9_raw_reorder_frame_free(&ctx->next_frame); > } > > static const enum AVCodecID vp9_raw_reorder_codec_ids[] = { Will apply this patchset tonight unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".