From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 237CF429FF for ; Mon, 11 Apr 2022 16:05:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 34BDE68B299; Mon, 11 Apr 2022 19:05:14 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2018.outbound.protection.outlook.com [40.92.89.18]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0C7D568B137 for ; Mon, 11 Apr 2022 19:05:07 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GrS590J6RmiR4PXTzo4gw8UT1rLsRRB4yTXu+WToo6E8wlkDG+pbSmJdx51juGOGzgbFkbZfeYzIyzaeSixjMgK54+uotSlNAP2vQRvADlKPl2IadyLT1lg6CJJTLC2oytym6qyII4vw1Wznu7ZIiFv7nSy7sKIoCryWLJtVDXqu3v7LQBfBSy6blcI1JtHeh6LcSV8gMzai5U47t4JW2y5E1eMqZqHcQhNGyBZDdvqftXxmoVJh49BLbaI4jmBkjly4+4Tbfk+lnczFuqhWD6ZkTEEMjt+GAOSgzfoR36o7yaK37NGl+obUWrK5iLJCRHieDWFSOt6W3fFRMwwdGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fe8Jc3ewWOofA1P2MiTJiIumqQ0GiohrrqUblDDHs4E=; b=co51xk4CwB4I96PnAey4sfQx1jJihdghBaGEPGaK/SYmKL6q9eHOVBithwsxm2jfZNi13w1Q8FdMn7ofxUAl0my5fpqiuxN8IN9BD2OnDy7bdPzb65UiZDKDG9aVeG53ZaMUPoCDhznqwm2f6MeBOw6EW88PMRLrIlDKmPlj+mPKxdZe15E90n3bPfytEmTocO3w128iuRKK5E0Rw4XgLa2pi0QiBHRjxt6MO02jT3kMx2bOhYkVTuNO8Nt+UZYPx781IsSo8Q2+aiTwqLLaidDwWGcvn8xtdOr9Mi7ad5BaM3H6etWHXJRr3egBqut5EMkVVCLwRU0jA4Yz235tkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fe8Jc3ewWOofA1P2MiTJiIumqQ0GiohrrqUblDDHs4E=; b=SyKR2zOFqpbro6A5U2iORufugC41Vfs5Stm+CRpKKRYOOnwd/ebNWZqJ6/XSOOEoLah8tzppwdlLQSNUBOu7Fm288KlQ5Joj321REoBGbM+0Xd+Z8oxIcgWyanuQlrwcOwdU8qNqzonY8A6YtB0nNDhOyDSBKxBHY2sH2WOlC2KawFkqZH0MxBl+oWUdv7SNluD/8J1IbXvp3ZfYPc8nqajeOq5953SiHXKIgCQLluMfp4PVFBbJrHVfQOAt4zZpFOem5BxeMWqI0FRQTGnePyCBDvPyOi57ko1q7snAxIBPCclWFh+aauU9lA6irns5/J6bWQRbOqUroU8bLDV7YQ== Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) by PAXPR01MB9387.eurprd01.prod.exchangelabs.com (2603:10a6:102:2c2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr 2022 16:05:06 +0000 Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::fcc3:1285:374c:9b2]) by AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::fcc3:1285:374c:9b2%5]) with mapi id 15.20.5144.028; Mon, 11 Apr 2022 16:05:06 +0000 Message-ID: Date: Mon, 11 Apr 2022 18:05:03 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220409201813.8481-1-jamrial@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220409201813.8481-1-jamrial@gmail.com> X-TMN: [Jx0JwxvQyjODwFgLkxUa/wUc0Fovtzh8] X-ClientProxiedBy: ZR0P278CA0119.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::16) To AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) X-Microsoft-Original-Message-ID: <6a1280f9-65db-4593-d26a-03fb806c3103@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c913b7be-2bf0-4a7f-9160-08da1bd50b13 X-MS-TrafficTypeDiagnostic: PAXPR01MB9387:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: agAwnWH3a6nPGumAo7TfD9Jj6i1rQb99p4da2upkZgnQ5NkGlwp8tdQ7AN9o/zHno0pQaXhwxd0dd7lRF4VokbeYDim/CB8nmWZH55o+n6fi93RisnH1oe7jfVSoEqlSfEKMe83MWstjSzArQyheX9XF6UrxM02KZS0ptprJceBrhng0CNk5DHl+wMc9zc4/+GVUaop6JRBHSL9eYsNC2o7N9uPRGtYvc4QQ1tdzrmRDA8qo+T1LwWG02/LioeUZ0oktP6WQS7CBFR76UklJ2c9r05GB2TMfKV6OZF5/RwoOgH6AUUMY1vPQzvvXJVpr2d5eo7S2kFIx2HtAUHBye2NTxrN3u047cIBydT2+BXbsllOu/8JVy0/hhu2qu+cLPl5/n9cBOJgLONvP/HRqHiP+LqPjM5G0qGFiIjFJDtuBl/1azngoLFlmPmnCVxleryD/B6/ffSBUqRmOgU7DOxykTHq8MCfJyw1NqtGtBmtdNTt+yHIKc6df0LMh5uNKop6HpTYSWcj24jStEOeGvElStaDTPZp5spoxomJHC34UsZAH4bmdtN9n3v9CH5Q1RuUek2Rh+x4z9c2Zxd5e6x9xyDMfnyXCyMZqnd3wyjLnskc3G9ZaCQOlgVk0e3L0 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czhvUUkvYWVtV244TlZaelZLUHQ2TjQyR0tzenMrWXZnUXVWeUsxWERaT3c0?= =?utf-8?B?bHRoZ0gzOU9ra2pCZndnNVBCbWNnUlV5aWZWNks1ZkJocjFGTmRRNlNCcElE?= =?utf-8?B?VENoUEUxVXZrV2dUeVBtY1oxNHBjdy83Wi9FR0lHd3dHclltK01sRGJOQVhm?= =?utf-8?B?SmQwVWVyaHBYMVE4eU03RW8xOEVmRVlOZzIyNmZRNjQ2enRhMVROUk1ka2tk?= =?utf-8?B?MVpLNjBvRmFUbGVoNVhITDBCUHcwYzRGK3RWZkU1NWpCUktqV21hUDkrUEFy?= =?utf-8?B?YmcvaDBhVUMzMmZDczBBRjNFWGdHZGpqZDRjV3dCaTdSQXNQZXBlRXRBTVdo?= =?utf-8?B?dGtBYXJydXBiYjQ3S2FYYmk2eDNHTlJtcjE2Mis5c0FWMkNHdHhzMkdxOTJS?= =?utf-8?B?VjNhaEEzd29wblVCbFdrZ2E3RldGMGZvT1hWZXlzdDlZVFc3bUV4TFNYTktH?= =?utf-8?B?RWRFN1NuRzArbk5OeWVhejQ1REFWclNySUxjM1NsbkhrUURhOFRJa2xJK2l5?= =?utf-8?B?YkVCdSszZkhpV2xERU45Y0duNUFnMjh4a1BLWTYxdkhkRnE4NlpiNlFIT1NE?= =?utf-8?B?aWFPV0dTRWxFdGZxQ2pCQXM5bFBLU0NpdFJTQ0p6YTk4Sk03dEYzSUxxSXRU?= =?utf-8?B?VmwrSDdOby9pbWRSZ0dPeHdmOE1UN2ZFZXVmcmsxalhsaDJWRWV6eEV2K0la?= =?utf-8?B?ckhBdUNxb080Sy9BdDdWQUJtQ0gvQzhacDVCWVFoMEF4cUgxZ0I1N0xIN3lh?= =?utf-8?B?aTV4MC9NcGxVemJjSDBDMEdlQ09yL0huOFZyU2tIdmFUa21iVEtnZ3NiQnZZ?= =?utf-8?B?V0tPL1hWaW1JZUNQbC81UG1hbExnaVJmeE9JL0VSTlB3RFNYNFRrWG9yM3lN?= =?utf-8?B?UFRvd1hxbkJLanoxdC9vejcxSDg2L3N5M2xadktEamhJRUVjMDVvR05VSStj?= =?utf-8?B?SHk4dVg4NWRrclhFVTJqTDdEM091STJ0V0NOREJCbzNwdWNINzU4VWY1YWJo?= =?utf-8?B?SnZQQm5MUTFWS0FkMXhBMDZNWC9zOGt5RXpxdjNTNWRtREdaRElDODhQSjEy?= =?utf-8?B?SC9vRDVDcGVGTzFTK0ZCQUZiRDhna1BOQ3lsNzBqT3J2QzNWMWdncFhwR3Bm?= =?utf-8?B?YTlSQmpEZmVqRGZxUTBYQ3VZTkNvV3ZQRGU3clQxS0ZDb0kzMmR1elZSUDlv?= =?utf-8?B?anVINEdCL0NCZlFXWllvbUMwSS8rTm8rQ0VyODFzYzVCb1hlQzBZTi9sSmNB?= =?utf-8?B?STdVRlVIZGNGczRhZXJEMXdSdzVHNzJtemkxa3d5V0JHeVFXZ3g0ME9BWWc1?= =?utf-8?B?TG5ZWW41K1M1S1FQem1RZGRXRmdlZlRSQXpCWUZhTDlNbkdoNzRlZ1l5ZE9G?= =?utf-8?B?ZEd2SHk5TWNmbzlDUVREWVFOK1N0SjNWbEtpYnZKZXFvVDFMT1lqbVhBWlRE?= =?utf-8?B?bmJNV21qRk56SjE5aUNFUVVockg4TnJRd1RBaDhMQzF4TkIwQWRSSFNYenpR?= =?utf-8?B?NHIwOTZBdVV0ZDBjWFFYYmFtTnhMaEJBNTN0OWs4RzVpbnlGMkxXUU5mM0NY?= =?utf-8?B?RWxKR3NtWkFKcHBzMmp3N2hEOUVpcFUzWndMdlRrbzdIQ3VYTkJ0MjlQZXhj?= =?utf-8?B?SGxWQVJjbkNFQysyMU9JRFVCTTlXeWtPQUJ1Vzk0dlBRQ2kwMjMrczBRdXRF?= =?utf-8?B?S0VGV2cvU0JyK2RFZzdmVUh6OC90RzZ0RDJWSFdUdWhQcU9lTjYwdjM3OVIv?= =?utf-8?B?elV1eERJa3NZS3dtbGtrRzNNSnlNeWJtS2ZWYjN5c29oMWROUitkczNDWWZS?= =?utf-8?B?RG5Wb3hBM2wxZXhjQWxMRzB3WThwM0I5VE9HK1FLanV5QmVRSU8xMFZaU2pN?= =?utf-8?B?eE9zNDBabytVM0lHcVA5YVMyU0JiWnRPT2hicnh6cEEyMXF4THAvNTRHcjNy?= =?utf-8?Q?Rz49oOmPkMYae58jaOd6irXQRp3lLsn5?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c913b7be-2bf0-4a7f-9160-08da1bd50b13 X-MS-Exchange-CrossTenant-AuthSource: AS8PR01MB7944.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 16:05:06.0579 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR01MB9387 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_drawbox: remove redefinition of DrawBoxContext typedef X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > Old GCC and Clang apparently don't like it. > > Signed-off-by: James Almer > --- > Untested since i don't have old compilers. > > See > > http://fate.ffmpeg.org/report.cgi?time=20220409194302&slot=x86_64-netbsd-clang-noopt > http://fate.ffmpeg.org/report.cgi?time=20220409194413&slot=x86_64-netbsd-gcc34 > http://fate.ffmpeg.org/report.cgi?time=20220409200245&slot=x86_64-openbsd5.6-gcc4.2-conf2 > http://fate.ffmpeg.org/report.cgi?time=20220409040143&slot=armel5tej-qemu-debian-gcc4.4 > > Clang 3 even says "redefinition of typedef 'DrawBoxContext' is invalid in C", but newer > Clang compiles it fine. > Before C11, typedefs were subject to the one-definition-rule, so that redefining them was forbidden. C11 allowed it. > libavfilter/vf_drawbox.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/vf_drawbox.c b/libavfilter/vf_drawbox.c > index a4fe0b8abd..65bd039d65 100644 > --- a/libavfilter/vf_drawbox.c > +++ b/libavfilter/vf_drawbox.c > @@ -73,9 +73,9 @@ enum var_name { > VARS_NB > }; > > -typedef struct DrawBoxContext DrawBoxContext; > +struct DrawBoxContext; > > -typedef int (*PixelBelongsToRegion)(DrawBoxContext *s, int x, int y); > +typedef int (*PixelBelongsToRegion)(struct DrawBoxContext *s, int x, int y); > > typedef struct DrawBoxContext { > const AVClass *class; > @@ -96,7 +96,7 @@ typedef struct DrawBoxContext { > int step; > enum AVFrameSideDataType box_source; > > - void (*draw_region)(AVFrame *frame, DrawBoxContext *ctx, int left, int top, int right, int down, > + void (*draw_region)(AVFrame *frame, struct DrawBoxContext *ctx, int left, int top, int right, int down, > PixelBelongsToRegion pixel_belongs_to_region); > } DrawBoxContext; > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".