Re: [FFmpeg-devel] [PATCH 1/2] fate/lavf-audio: Disable CRC for lavf-peak_only.wav test

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Andreas Rheinhardt:
> The output of this test is just a file containing the positions
> of peaks; it is not a wave file and trying to demuxing it just
> returns AVERROR_INVALIDDATA; said error has just been ignored
> as the return value from do_avconv_crc is the return value from echo.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  tests/fate-run.sh            | 3 ++-
>  tests/fate/lavf-audio.mak    | 2 +-
>  tests/ref/lavf/peak_only.wav | 1 -
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index 821e949b01..c206a439b2 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -312,7 +312,8 @@ lavf_audio(){
>      outdir="tests/data/lavf"
>      file=${outdir}/lavf.$t
>      do_avconv $file -auto_conversion_filters $DEC_OPTS $1 -ar 44100 -f s16le -i $pcm_src "$ENC_OPTS -metadata title=lavftest" -t 1 -qscale 10 $2
> -    do_avconv_crc $file -auto_conversion_filters $DEC_OPTS $3 -i $target_path/$file
> +    test "$4" = "disable_crc" ||
> +        do_avconv_crc $file -auto_conversion_filters $DEC_OPTS $3 -i $target_path/$file
>  }
>  
>  lavf_container(){
> diff --git a/tests/fate/lavf-audio.mak b/tests/fate/lavf-audio.mak
> index b03030176c..68fca35298 100644
> --- a/tests/fate/lavf-audio.mak
> +++ b/tests/fate/lavf-audio.mak
> @@ -34,7 +34,7 @@ fate-lavf-ast: CMD = lavf_audio "-ac 2" "-loopstart 1 -loopend 10"
>  fate-lavf-mka: CMD = lavf_audio "" "-c:a tta"
>  fate-lavf-voc: CMD = lavf_audio "" "-c:a pcm_u8"
>  fate-lavf-peak.wav: CMD = lavf_audio "" "-write_peak on"
> -fate-lavf-peak_only.wav: CMD = lavf_audio "" "-write_peak only"
> +fate-lavf-peak_only.wav: CMD = lavf_audio "" "-write_peak only" "" disable_crc
>  
>  FATE_AVCONV += $(FATE_LAVF_AUDIO)
>  fate-lavf-audio fate-lavf: $(FATE_LAVF_AUDIO)
> diff --git a/tests/ref/lavf/peak_only.wav b/tests/ref/lavf/peak_only.wav
> index c468731b00..9548e639f8 100644
> --- a/tests/ref/lavf/peak_only.wav
> +++ b/tests/ref/lavf/peak_only.wav
> @@ -1,3 +1,2 @@
>  f1a8aeeae8069f3992c4d780436c3d23 *tests/data/lavf/lavf.peak_only.wav
>  832 tests/data/lavf/lavf.peak_only.wav
> -tests/data/lavf/lavf.peak_only.wav

Will apply this patchset tomorrow unless there are objections.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".