From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6D6A140AB0 for ; Tue, 5 Apr 2022 16:04:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BBF8868AFD2; Tue, 5 Apr 2022 19:04:26 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073046.outbound.protection.outlook.com [40.92.73.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4254D68AE10 for ; Tue, 5 Apr 2022 19:04:20 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c5R5k41Xucegyl+XTuEALlRexju69VOUIAkE/0MtcNQB8MCQo4ZFhRB34nQduFwifmg5nhZ9qT8S8Q86rzY554n5WA2NWsC78+WIt0E8mZxyRK1Qnw7suuiE2dhqZYgtuYy51B027xWa4yh+5bvM3r2ezCGcoFBq1hOgr10tTu7Hij5kSeqLdrO5x6H490aodjqDOHw7qzS7cgTegj1N41jXgk8mDjKlUuAejSdlbtpVlH5wY2U12+Qhj8uuj7u8is1RRHR2C02UUpjZa2Y8nW1pOQDVgTVp6iG+ZGGI1kMzxIObYUXaRFjWLJs1603Jiq9PP95ZIEco4XPSNOYo4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vcpnz8HLzd/uM5YG5mNOBVMvzS1z6Rqbk931zz+BJ2Q=; b=jW222yeGZZEdIbkPLbSPgJXB+f/TpYViqRxbnAtNZz0yObGONCAJdD4OmETkqeAiMQsAUE8H0y/WVvSdRDUYiKYgLrAcRKQViIZdZpCLem9M46VzaQ3CCCxtKqgKlLvLFm02tenedrxrYPdrcda+5B2DMVz2grJ6afi1TzvRVbUd+HpRuKF4JA/WwkZLDvEeMq3jysS5Mggw41hI0j07IZuAewkD9L9nS4mktEjfoUrgDbtfrFQiIyFZvPqHrt0I5OVujtQqVkohErDd4RM/J1O6Xz8FkwNldoAKpWnLrChhviesEVmt4wWxpBnhngOksQzCoj3mEVqPmkSvl1otqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vcpnz8HLzd/uM5YG5mNOBVMvzS1z6Rqbk931zz+BJ2Q=; b=VuFAlZ4jKpXUVXB2X6duOPOpP+uy1b6J7Y+T3/op1zWBfaiyqs06S5P0YEEkqdOon8kXxkDdmDOwXTL5JeBuTNqotvExE1DbaJD5aZbKDO5atgwKQRS1pZwaTXeCnFIKafPId0792Ozir9IEGZBVAHvVm5sCc83NvWyUuyw+HFYL5baK/plOoRCTZadVubKRTk7rer1U/GqjcK70hCSQ8gHZ+KiaP+p9DMv8w8ta91AZ9C1EQNaGp4CaYW0j2niPkNtzL/NZvczuOYoNttBXVT4jKoe0VnqwvA7ZL0wr7bOYh2oj2XkUGkZ/wghsqbpSQiOvLx598qvqEhdBBtvohA== Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) by AM0PR01MB5748.eurprd01.prod.exchangelabs.com (2603:10a6:208:171::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr 2022 16:04:18 +0000 Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::6553:a424:79bf:6dc3]) by AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::6553:a424:79bf:6dc3%3]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022 16:04:18 +0000 Message-ID: Date: Tue, 5 Apr 2022 18:04:17 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220405133747.318846-1-mvanb1@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220405133747.318846-1-mvanb1@gmail.com> X-TMN: [NpcR6NKuIqUl/BEf5GDeFo5gxlzqj9eM] X-ClientProxiedBy: AS9PR06CA0157.eurprd06.prod.outlook.com (2603:10a6:20b:45c::32) To AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5067743f-33d9-4f83-dd80-08da171df05f X-MS-TrafficTypeDiagnostic: AM0PR01MB5748:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: djsN+6qTlEE+yikRx3co0PGREoxfGnJcheNCbLsBH+zNQlLh//YA60RJ1HiT9Ndx5zjLxBHVaGTv3XuM7N/qrCTDLFNGnpH2SYTLITXKqVikViK3s33ZB2kAdLEqwbYAguEAkldbrMedPC89xvUb24GFIVDJtv1CO0a4/L9Ti8lrYVifdkTjdN+T0n7RFWn4PH5iauGR2BsO/mM55ge0+yW0i1QMAbVprYyz/aQsIE10u/ghBrPhutBDHERL54m18Gs3m4GBlj075bsYE3IF6nl0JI4J7W6ImhXqiatCgreXUuBfarc/FwarSHnjxu5VPzw/eQXuM7AqPC+8fK+b8j8aLvN29SRsjAK1Da8O/CPiL8zRaO3lKaacKyZInFDBq6tD9bbdgfBWz/YvQ9ZSHSO+WBmCrCL1KW44GLqN+yHTbXTH5lO9ccW+edZkyA6XoG5k+aAQwXaiV0Uhh2RZJ+G8FAVpBPyMfi1dcstHFeBCs9ACCYcLNm6YsFNT0ebvyDiXTx62qEIL/g/x1qFUTHnt5933TYZO+JfeUQXLM9/tfTITn30rLkmI31tHWha3JmBPEVCi/QwYrFh28K2ppw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUdwMVI5UW1wUkJvV1FRN2IwYlB6VTdzMitkVW1XTEd3UkRYUDJiSHpBR0kr?= =?utf-8?B?UmZWT0JrSFpNcDFUbzdPL0RCdWpkL3QxNWQ0R00zMlhrK1FEcGJkakxiTjdu?= =?utf-8?B?TVdmOUx1cllncDVoZHpPcDR1YXJDQ1hwOGhtNDFCdlZXVlR4RVYwUmxMSjlK?= =?utf-8?B?N25uNEU4R1V5UFdITkVINVowWXlYenVKM0JCdFdyZnZUWDA0SFNlR2dINTd4?= =?utf-8?B?L2lFMVFKZVdqNFNkd1hhb0RTY1BCdTNic2w3ZklIUVgvNUZybWRpZnlEbEx0?= =?utf-8?B?VmdKeWZKZzdtR2RsamJ2SEFRWXNvRnBCOElpQmEyaEY4VnVFaGZuclFwZDFE?= =?utf-8?B?QWxlK3FrYnNMZFJlcDFUV3IxeUhYdklwYjk3S1I3VWpTZTVjOThPdUluR2Uy?= =?utf-8?B?bmMrbjNUOHNjeVE4WkhHUVBDRjViZVkyYi9XejhOOS9uUlJXYU82WkQ5VUZh?= =?utf-8?B?dTBlRGFaRUV1NFpHY3JzYVNrd1lrNUNTZkN5eEE5ZGpFeEE2QkVXbW84bUZh?= =?utf-8?B?VC9HMk1uQk5SclFCUitSUXhqK2IvNzdyZ3JqMUpoM3R5QWh1SEFMeENiV2Yz?= =?utf-8?B?aU5oM09nZHJTRWVqVWZ0QWtNMkxQcnllQWNuVzJ0MXFBMVBXZXlDMDBISmtV?= =?utf-8?B?bjd0bGNWVkt0cjJiRnU4a2ZqaStXcVFVbjFtNDZ6ZVFaV0ZwRlFGYkRiOG9Z?= =?utf-8?B?a2greXBUSFdzR09NVmpTNlRCZEJ1TGxkdUJmcUJuL1NzKzI0b0Rad0VVYXRs?= =?utf-8?B?WUpJQVdMUFp6VjRISUNxc2M5bUtJck5IQjZaT0pSZ3VSOUxKalNWbnJwUk9X?= =?utf-8?B?WjRnMWlWd2xWZkpVcnJkMkE0L2VDbnZiQVMwYm5Wb2xSdFM5dTVRbnRyRkdV?= =?utf-8?B?a3lQelNmWjdqc0h4R0RwZGV1YW5EUXQ4Mncvek41aERJeFMwTXA5bmRTdENa?= =?utf-8?B?bm52MWlWOGR3cWZxRE5yYlF3d0p4NGtBQjlwL0pWRkl5cDR6TXYvTjVXRExC?= =?utf-8?B?RC92ZDZUd2tTb2h6dkE5MU5YTEIvN2w4UEVNeXRXa3pZbng0V2d5QWwwTzMr?= =?utf-8?B?cDI2SFcyc2d1cXlTWndRbm5mcVdoNnl1ai9oMkJxSW00RnFGQThteVcyYzBB?= =?utf-8?B?ZDAxYzRwdDhXNWZKM05oVHhVK295Ni81T0JLMWhURHVoWUsrTm5ZMlJ0em5J?= =?utf-8?B?a2VLWVNDcW1CcUlkQXM2ZFZXWjZoZmU1OFZBZTJmMlZIK0QxNktORzNXTDB3?= =?utf-8?B?N0JaV21Vb1AwNkhOMERHcXdvVXFYb2ZxR0x5czNjTFdMS3Nnb0xiaXRiTGdI?= =?utf-8?B?RVZnTzhjRUFicW92SG9TYWpsVWJSOVJ4QVFNM216ckYySlFIK2JKbi9xOGJm?= =?utf-8?B?ODV6SzNwMFRMMXJpclBEL1F1UW1nbmloSUFaMUJHYkJxMngrTm5pYkhDK3pr?= =?utf-8?B?dWh3MUpuSlNScEFzMzUvVVhjRk5IM0JRZk4zUXJnSU80RTk0TUd4VnJCQ215?= =?utf-8?B?RXFmdmZDc285MXl1d2Z2N3Vra3R0dzZ3SWp1anVyaGwrNi9BbmVIQ3lpUFh2?= =?utf-8?B?VTlLQkZHeGV1ckRIazRpMXoyRy9IcmhhbU5Bc2lWQ29QY2tLbTl4ZDludC9S?= =?utf-8?B?MXlnV2xNem5lTnlXd0lvMjl5b1ZkaUczN0dQbUhRa2VwNktNaElHKzBrSENy?= =?utf-8?B?NGladXAxbjRQenhnN3ZBU294TG5IUUNHY20yZTBnVGFnc3J1U1U4VkRRWERN?= =?utf-8?B?S1dZTXlXa3BRUWorMjZKOW9Ka1MvR3ZvQ3crN1A4dUlUa3UyTGYySlgzUVFX?= =?utf-8?B?QmtZaWdXTmF1WFovcmxJUlo0aThSYjhCamRsZzZwdDNhZ05VTHF5UXVHNEhR?= =?utf-8?B?KzlmSVRndHRLZDRLYXBUYUZFT0RNOFBPTk95SElTQmNzang2cXRLWUdYT0RW?= =?utf-8?Q?pSOMtOnyXGzDkU/tFt7G/oU5xpZCCKBg?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5067743f-33d9-4f83-dd80-08da171df05f X-MS-Exchange-CrossTenant-AuthSource: AS8PR01MB7944.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 16:04:18.3619 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR01MB5748 Subject: Re: [FFmpeg-devel] [PATCH] lavc/flacdec: Increase residual limit from INT_MAX to UINT_MAX X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Martijn van Beurden: > --- > libavcodec/flacdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c > index dd6026f9de..cb32d7cae8 100644 > --- a/libavcodec/flacdec.c > +++ b/libavcodec/flacdec.c > @@ -260,7 +260,7 @@ static int decode_residuals(FLACContext *s, int32_t *decoded, int pred_order) > for (; i < samples; i++) > *decoded++ = get_sbits_long(&gb, tmp); > } else { > - int real_limit = tmp ? (INT_MAX >> tmp) + 2 : INT_MAX; > + int real_limit = (tmp > 1) ? (INT_MAX >> (tmp - 1)) + 2 : INT_MAX; > for (; i < samples; i++) { > int v = get_sr_golomb_flac(&gb, tmp, real_limit, 1); > if (v == 0x80000000){ Wouldn't it be possible to use unsigned for real_limit? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".