[FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase

[FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase

[Andreas Unterweger]

Previously, the default timebase caused two warnings during decoding
about not being able to update timestamps for skipped and discarded
samples, respectively.

Signed-off-by: Andreas Unterweger <dustsigns@gmail.com>
---
 doc/examples/transcode_aac.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c
index c9b93f6439..6197369756 100644
--- a/doc/examples/transcode_aac.c
+++ b/doc/examples/transcode_aac.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2018 Andreas Unterweger
+ * Copyright (c) 2013-2022 Andreas Unterweger
  *
  * This file is part of FFmpeg.
  *
@@ -120,6 +120,10 @@ static int open_input_file(const char *filename,
         avformat_close_input(input_format_context);
         return error;
     }
+
+    /* Set the packet timebase for the decoder. The input file's sample
+     * rate is used as the denominator for simplicity. */
+    avctx->pkt_timebase = (AVRational) { 1, avctx->sample_rate };

     /* Save the decoder context for easier access later. */
     *input_codec_context = avctx;
-- 
2.30.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase

[Andreas Unterweger]

On Wed, 27 Apr 2022 at 16:07, Andreas Unterweger <dustsigns@gmail.com> wrote:
>
> Previously, the default timebase caused two warnings during decoding
> about not being able to update timestamps for skipped and discarded
> samples, respectively.
>
> Signed-off-by: Andreas Unterweger <dustsigns@gmail.com>
> ---
>  doc/examples/transcode_aac.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c
> index c9b93f6439..6197369756 100644
> --- a/doc/examples/transcode_aac.c
> +++ b/doc/examples/transcode_aac.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2013-2018 Andreas Unterweger
> + * Copyright (c) 2013-2022 Andreas Unterweger
>   *
>   * This file is part of FFmpeg.
>   *
> @@ -120,6 +120,10 @@ static int open_input_file(const char *filename,
>          avformat_close_input(input_format_context);
>          return error;
>      }
> +
> +    /* Set the packet timebase for the decoder. The input file's sample
> +     * rate is used as the denominator for simplicity. */
> +    avctx->pkt_timebase = (AVRational) { 1, avctx->sample_rate };
>
>      /* Save the decoder context for easier access later. */
>      *input_codec_context = avctx;
> --
> 2.30.2

It seems that recent versions of Thunderbird broke eml import when
lines contain single characters (such as + in a diff). Here is the
same patch again sent with a different e-mail client.

Please apply. Thanks.
Best,
Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase

[Andreas Rheinhardt]

Andreas Unterweger:
> Previously, the default timebase caused two warnings during decoding
> about not being able to update timestamps for skipped and discarded
> samples, respectively.
> 
> Signed-off-by: Andreas Unterweger <dustsigns@gmail.com>
> ---
>  doc/examples/transcode_aac.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c
> index c9b93f6439..6197369756 100644
> --- a/doc/examples/transcode_aac.c
> +++ b/doc/examples/transcode_aac.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2013-2018 Andreas Unterweger
> + * Copyright (c) 2013-2022 Andreas Unterweger
>   *
>   * This file is part of FFmpeg.
>   *
> @@ -120,6 +120,10 @@ static int open_input_file(const char *filename,
>          avformat_close_input(input_format_context);
>          return error;
>      }
> +
> +    /* Set the packet timebase for the decoder. The input file's sample
> +     * rate is used as the denominator for simplicity. */
> +    avctx->pkt_timebase = (AVRational) { 1, avctx->sample_rate };
> 
>      /* Save the decoder context for easier access later. */
>      *input_codec_context = avctx;

The timebase of the packets sent to the decoder is given by
AVStream.time_base; this need not be the natural time base (i.e. the
inverse of the sample rate).

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase

[Andreas Unterweger]

On Thu, 28 Apr 2022 at 05:23, Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Andreas Unterweger:
> > Previously, the default timebase caused two warnings during decoding
> > about not being able to update timestamps for skipped and discarded
> > samples, respectively.
> >
> > Signed-off-by: Andreas Unterweger <dustsigns@gmail.com>
> > ---
> >  doc/examples/transcode_aac.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c
> > index c9b93f6439..6197369756 100644
> > --- a/doc/examples/transcode_aac.c
> > +++ b/doc/examples/transcode_aac.c
> > @@ -1,5 +1,5 @@
> >  /*
> > - * Copyright (c) 2013-2018 Andreas Unterweger
> > + * Copyright (c) 2013-2022 Andreas Unterweger
> >   *
> >   * This file is part of FFmpeg.
> >   *
> > @@ -120,6 +120,10 @@ static int open_input_file(const char *filename,
> >          avformat_close_input(input_format_context);
> >          return error;
> >      }
> > +
> > +    /* Set the packet timebase for the decoder. The input file's sample
> > +     * rate is used as the denominator for simplicity. */
> > +    avctx->pkt_timebase = (AVRational) { 1, avctx->sample_rate };
> >
> >      /* Save the decoder context for easier access later. */
> >      *input_codec_context = avctx;
>
> The timebase of the packets sent to the decoder is given by
> AVStream.time_base; this need not be the natural time base (i.e. the
> inverse of the sample rate).
>
> - Andreas

I changed the code in versions 5 and 6 to use the stream time base.
However, the new patches, again, seem to cause issues in Patchwork. I
don't know what is the issue exactly. I double-checked for broken
lines before sending the e-mails. I prepared version 5 and 6 exactly
as version 4, which is fine (green) on Patchwork.
Is the patch o.k. now in terms of its content, and, if so, how can I
send it in such a way that Patchwork is happy?

Best,
Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".