Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase
Date: Thu, 28 Apr 2022 05:22:58 +0200
Message-ID: <AS8PR01MB794444EF549D834B1C3144AF8FFD9@AS8PR01MB7944.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <CAKp+PPpd8adr2DG--xMyo0DijiccXMpogJg2zDEdqTXYO1ycZQ@mail.gmail.com>

Andreas Unterweger:
> Previously, the default timebase caused two warnings during decoding
> about not being able to update timestamps for skipped and discarded
> samples, respectively.
> 
> Signed-off-by: Andreas Unterweger <dustsigns@gmail.com>
> ---
>  doc/examples/transcode_aac.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c
> index c9b93f6439..6197369756 100644
> --- a/doc/examples/transcode_aac.c
> +++ b/doc/examples/transcode_aac.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2013-2018 Andreas Unterweger
> + * Copyright (c) 2013-2022 Andreas Unterweger
>   *
>   * This file is part of FFmpeg.
>   *
> @@ -120,6 +120,10 @@ static int open_input_file(const char *filename,
>          avformat_close_input(input_format_context);
>          return error;
>      }
> +
> +    /* Set the packet timebase for the decoder. The input file's sample
> +     * rate is used as the denominator for simplicity. */
> +    avctx->pkt_timebase = (AVRational) { 1, avctx->sample_rate };
> 
>      /* Save the decoder context for easier access later. */
>      *input_codec_context = avctx;

The timebase of the packets sent to the decoder is given by
AVStream.time_base; this need not be the natural time base (i.e. the
inverse of the sample rate).

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2022-04-28  3:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 14:07 Andreas Unterweger
2022-04-27 14:12 ` Andreas Unterweger
2022-04-28  3:22 ` Andreas Rheinhardt [this message]
2022-04-28 14:13   ` Andreas Unterweger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8PR01MB794444EF549D834B1C3144AF8FFD9@AS8PR01MB7944.eurprd01.prod.exchangelabs.com \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git