From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1EC6C40AEE for ; Tue, 5 Apr 2022 19:43:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 76E6B68B1B8; Tue, 5 Apr 2022 22:43:05 +0300 (EEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064020.outbound.protection.outlook.com [40.92.64.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4F51268A3F4 for ; Tue, 5 Apr 2022 22:42:59 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lAyKGIKjL317YQtXs15+uswi5AgWhXSG1/W6jOCy5YopvVrPKusO66o7+ZS18IAZ/kz9rOobGY5OGwava+f4QBYIvzLXdOXCZqU3mtkgqFGWIXVR6dnWhytwwqp8gNqDGzTjoV4pqrMQduAAPQ3adohgG5XYXIymhdhwFg9FnVVaFwhJMjiWa2MGBNd3ryNjdKVxWS97w3B6kBa6K7AD6BkKvh4KCcjAwK4NbC1H5J2FKrH+G/pvHd9YG+jUHP/F8Z21N8mGmj7/tx6Wdb2LlJYSlmEsz97ztoncBW0hLrDTNo9gL5wTB9Cdy66Kdmz/v7OfiLnWtRxJtWegasIk3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2U6JbdFzAYp7GrcIP2S2H8L4gbB+9Zvaxu9dFVVR4kA=; b=JjVoUiSwUPSU7kRg8hyot1URptPVMeaL122a1j0WPcjWnuM/ooxaFd9UIMYqtq9BtcWNWwxHQLE47rkluQClS2a0/iqca/z/WNUilKYNhfLR72K8aoHJUvGS1gsLiCTVa3E3FkE9tQ/rS1wEMtfzVtpOSzF1JcEZlFue7CcFFJ5Gusm4RGz1/G6QOnIrjBAoeHpJ+XKyhfr2reOY3PAWUmY2mf25jwOm2YH9l7IZPmWTf3n21C7REUHtH+Qcz9JO2HRR9oycMzDfx6J3HAD66+4bBKt63YQ7u3Qi/Cd3w4KME0xyxbXaP4RV1oTcmovgwdMbK2sexqFdqFeFmF9FGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2U6JbdFzAYp7GrcIP2S2H8L4gbB+9Zvaxu9dFVVR4kA=; b=Xs4mazbHqzjFLZvndMa9KxN8Nj6vVUFSh9fFruvjBBNkLXTyQREIldaMPufPqUt0QKGhyQTjCZZlobI9n/wWjM4kmtxImKI7vMlKQiUZ8Hmoofz9g6y03fVQIHZYuLMn8pQ2G+Ys7XCUVd/9vEM4bHSwrcg/FUn7s9V11bnLKGUPY+GFZU9eJVHp8tTFtodAc3GX4vgS9taPzwQPqoTEI49Pv0GT0W5kb9ipC5gKoWNFC1t2O3Ll70b8L6FPrUBvplemMewlb/BO3q8Fh0UkCZ7FE8gNhgQpYqtFrx5qShurxh2Fj1esI7eMPD1MtcPQw6U20M2JdAOIddiIg4XhrA== Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) by DB6PR0101MB2486.eurprd01.prod.exchangelabs.com (2603:10a6:4:32::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr 2022 19:42:57 +0000 Received: from AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::6553:a424:79bf:6dc3]) by AS8PR01MB7944.eurprd01.prod.exchangelabs.com ([fe80::6553:a424:79bf:6dc3%3]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022 19:42:57 +0000 Message-ID: Date: Tue, 5 Apr 2022 21:42:54 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <1648423513-21261-1-git-send-email-lance.lmwang@gmail.com> <1649166427-9667-1-git-send-email-lance.lmwang@gmail.com> From: Andreas Rheinhardt In-Reply-To: X-TMN: [DPmFkPlp/oNWUE1SKeLVZKxQWwG/3Y3e] X-ClientProxiedBy: ZR0P278CA0044.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::13) To AS8PR01MB7944.eurprd01.prod.exchangelabs.com (2603:10a6:20b:373::5) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d56cfc66-b536-4a41-67c4-08da173c7bbc X-MS-TrafficTypeDiagnostic: DB6PR0101MB2486:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GdndBVLaXyPO4LmbnkP+ZbVDxi3JiKWbAhLU7U2uO8SakuvzWGKr3eF8d2pJ+bUEpZjWkK8KX1ELt5rgKKtmDk++gL3dBRaOUzWrFnT8Y3RV0EwanzIQbgosna9GQ1JKUmAf4RTtPsJY1RW7/2N1cdTQz3pMIjKPJVNmSFNCl0S5OOBVuRZ7x/cOS65nsjRSY+RgyA4t668kfbKVar6sPoKoiZDLYIUI4FniQ2orlkirXrg9OpkYwPRfalqzDhhUJ+GIe+kMsc8a09gcsuM25xvUACZbWb70V2ITCuaTQbmb20DdTx5w62qmKCO/AYeFn9wA2VQ7Q2Xhbwda7GwDdguihF5CuiQ2F9AgGpc6fLU9+IKaJeSVUYjKfydAq7ImtnrRORPn788iMamzNd7rT6SfsHwXWzRqubDQ3cS3DBOJkzOX/HDItTCXrZV0Mviml9WHCUeSfOyMWGXwGmKiHcwulTmz8EYNZPO6gmP3XSgnw+qg39FQW58B0vlhOixSyvi2NSUXYLY+w/1ci3bcKpQB5CRKWHbui6264L2wQ4TqyxMs+TAQOnFMVHPSlkokr6FqNYuMl3WSPgrxTq/YMQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2txaUt2MVhTNTdsTkRWSXJpaDFiMlN6UzRTUW1VOHd0bVcwem05WlhQQnFk?= =?utf-8?B?amZNcmQrVTNKNGIrSFBCWlZlZy9wZmpPbGw1R25LRW84aTdackdNL2Y0WWdy?= =?utf-8?B?OWw1dzNra3pJbXJzSXpIb2VFZXAxUXhRUWN1VldzeGN0dTFOcjVINktzV1VX?= =?utf-8?B?d3l5T2VBYkh1WjQyc25GS0NtbDNuQ2JlOFlBRkFtbGkrNjUvcEpSV1dSRVdm?= =?utf-8?B?RnpNelhycHl3MnhqMnJHak4xME8xSnVUMzRkVGN4V21OcEQvTE04OEllMElt?= =?utf-8?B?SGRVRVNTZ2hoNzNPYStiaEZoVkVEWlIwdFdsaEh2U0dZakZDV29KVmFDbFZa?= =?utf-8?B?VlRiWWFTNENURGNmdmFjT056QStuSDRxWXRrWjVzeDV2bVpqZWFUK0lXcXA2?= =?utf-8?B?ODJzem9KQ3Q4U2FXK0tTeFJDOFNiSElRSDVoK1lTTGMrSW1nanNyTktTbklo?= =?utf-8?B?TzRDcVBUN3JwMkM1aXNHcDhFcmpSc0VreVRjM1pDeEpCOWdrZ3FCLzJpYVJD?= =?utf-8?B?eGJrK0dyUG1EV04yVlZVSGE0ajhRelRub1hMVE0xbUZPaHRXVjIxZkFDT3JF?= =?utf-8?B?Ukt6NjNOUCs2QU5XUjQ4RDlKeVgyKzZCVWxrSnRaOG92WmFpeUZTa1dKWVFy?= =?utf-8?B?Rmc4Mk5Pa3BvblFvUHNtb2p0azltR3NRay9OeDIxYlpnNHo3aEpxSDhST0k1?= =?utf-8?B?dkJKdEFBNW9UVHBUMWpxdjE1TmFCZnVCRHEvaEFvcnp5bnlTN29yRDlnRTRY?= =?utf-8?B?aVRNZTdQblpOalpJekVCYkFIdlhlRmp3K3B3RjZGMUJwYnpvRitsTmlkL09N?= =?utf-8?B?ditPZi9WRzB0M1EvOE41TW1SNXRLVEpIU1hIZmxuTExRaEFnQnVudUR6MGha?= =?utf-8?B?ZDBtREloeGNqUGdHU0o1ajg5WjNCWVFmMTZhMFZIWTgvR0w5ckZ4NE5QYmJT?= =?utf-8?B?blI5bmkyeVlLc2R3N1RxbnYzRW8xVmp6NysvL1FhZVpWTXc5K1Y5ZlVlVEs5?= =?utf-8?B?ZURtWk4yaWNoakkyMnU3NmFVWldwNEtKdmoza3JaWk1Mem5WVnVoN29CZUxX?= =?utf-8?B?MWloYVhzU29zbi9xckFWb2V2aGlpeUJVZHozU0lxYTFzNHhzaWdvNzdUNFdh?= =?utf-8?B?VUt3TXlmYTBOR1J5UVZyOUFRdG5sMGlPYkVhRHRjcS9lSnBoMmRHOGtBbGdY?= =?utf-8?B?K014Z0Jydm1MY0IvSkhQYVVMWkg4a2p4VlU2QjhWV2RNb3JiY3dseU5iM3JU?= =?utf-8?B?ZW9yTDR5L1VKcktvcG56RE9sOUhERFgrc3k1dmp1Y3Vqd0kvYVFkUmpBenYw?= =?utf-8?B?bEVBZzI4MXdWaHNZREFsaCtBVGFjbUtNVS9Ud2NkUzRqZmg4UmZrTEVWaEJN?= =?utf-8?B?NjBqMU9SbU1OcjAzWXBNQTBoRWVBZHJWczcxTXFLd3M3QnF5bzJaeWNJM25F?= =?utf-8?B?VjR2NnVaY3pmSGcxZ2lOUDlJUlN5SFJOWUhUZzRzcFFrZWFGN3o3bmtwQ2xx?= =?utf-8?B?bXlaRHdJTTgreFcvbWtmcVRNODhSNXpSbHo2MStMV2JleTJ5SSs3Sms0VDl1?= =?utf-8?B?cHExVnk4M1JNeEd4dTFydE5QOVFzR0ZUQ1RLVnFXVTJ1WXRyRW0xWmdIS3BY?= =?utf-8?B?MldlcWdSQTc1VHpnbFlOY2hvVHBhUjFyQ3RLa2NxemNiZlVyMWRaaGpqQXRr?= =?utf-8?B?UGVDMzIvcDBMdXFKRmVNcWsrL0ltN3RFdS9Hblp5NFh5VjIydnI1NWMrNGdV?= =?utf-8?B?TnlHT3ZtdnBjQzFSdDdjNlg1Zmk5bkppRWNoUG94N2dhV0VTeDViWllSTWNO?= =?utf-8?B?YisrZVFKUHNKMDlBMVRLVXRlRERWRk9IWVlIZExuVUVNK2hxZHBrZ1AvcmlJ?= =?utf-8?B?b3lhU3NnZ3E0cmw2cVVQbVNSSzlxWVdjMGttZ0tjSUpaNmYxWjk3MW5CSjh0?= =?utf-8?Q?CtAm+fpjFzBekJuT5kf8THpJU1kVgXMB?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d56cfc66-b536-4a41-67c4-08da173c7bbc X-MS-Exchange-CrossTenant-AuthSource: AS8PR01MB7944.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 19:42:57.6997 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0101MB2486 Subject: Re: [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Lynne: > 5 Apr 2022, 17:32 by andreas.rheinhardt@outlook.com: > >> lance.lmwang@gmail.com: >> >>> From: Limin Wang >>> >>> Signed-off-by: Limin Wang >>> --- >>> libavutil/frame.c | 1 + >>> libavutil/frame.h | 6 +++++ >>> libavutil/mastering_display_metadata.c | 23 +++++++++++++++++ >>> libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++ >>> libavutil/version.h | 2 +- >>> 5 files changed, 76 insertions(+), 1 deletion(-) >>> >>> diff --git a/libavutil/frame.c b/libavutil/frame.c >>> index fbb869f..8882da2 100644 >>> --- a/libavutil/frame.c >>> +++ b/libavutil/frame.c >>> @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type) >>> case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification"; >>> case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data"; >>> case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata"; >>> + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment"; >>> } >>> return NULL; >>> } >>> diff --git a/libavutil/frame.h b/libavutil/frame.h >>> index 33fac20..92413c9 100644 >>> --- a/libavutil/frame.h >>> +++ b/libavutil/frame.h >>> @@ -209,6 +209,12 @@ enum AVFrameSideDataType { >>> * volume transform - CUVA 005.1-2021. >>> */ >>> AV_FRAME_DATA_DYNAMIC_HDR_VIVID, >>> + >>> + /** >>> + * ambient viewing environment for a video frame, as described by >>> + * the AVAmbientViewingEnv >>> + */ >>> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV, >>> }; >>> >>> enum AVActiveFormatDescription { >>> diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c >>> index 6069347..f094eab 100644 >>> --- a/libavutil/mastering_display_metadata.c >>> +++ b/libavutil/mastering_display_metadata.c >>> @@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram >>> >>> return (AVContentLightMetadata *)side_data->data; >>> } >>> + >>> +AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size) >>> +{ >>> + AVAmbientViewingEnv *metadata = av_mallocz(sizeof(*metadata)); >>> + >>> + if (size) >>> + *size = sizeof(*metadata); >>> + >>> + return metadata; >>> +} >>> + >>> +AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame) >>> +{ >>> + AVFrameSideData *side_data = av_frame_new_side_data(frame, >>> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV, >>> + sizeof(AVAmbientViewingEnv)); >>> + if (!side_data) >>> + return NULL; >>> + >>> + memset(side_data->data, 0, sizeof(AVAmbientViewingEnv)); >>> + >>> + return (AVAmbientViewingEnv *)side_data->data; >>> +} >>> diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h >>> index c23b07c..c1ba659 100644 >>> --- a/libavutil/mastering_display_metadata.h >>> +++ b/libavutil/mastering_display_metadata.h >>> @@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size); >>> */ >>> AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame); >>> >>> +/** >>> + * The characteristics of the nominal ambient viewing environment for >>> + * the display of the associated video content. >>> + * To be used as payload of a AVFrameSideData the appropriate type. >>> + * >>> + * @note The struct should be allocated with av_ambient_viewing_env_alloc() >>> + * and its size is not a part of the public ABI. >>> + */ >>> +typedef struct AVAmbientViewingEnv { >>> + /** >>> + * specifies the environmental illuminance of the ambient viewing >>> + * environment in units of 0.0001 lux. >>> + * ambient_illuminance shall not be equal to 0. >>> + */ >>> + uint32_t ambient_illuminance; >>> + /** >>> + * specify the normalized x and y chromaticity coordinates, respectively, >>> + * of the environmental ambient light in the nominal viewing environment, >>> + * according to the CIE 1931 definition of x and y as specified in ISO >>> + * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of >>> + * 0.00002. The values of ambient_light_x and ambient_light_y shall be in >>> + * the range of 0 to 50000 >>> + */ >>> + uint16_t ambient_light_x; >>> + uint16_t ambient_light_y; >>> +} AVAmbientViewingEnv; >>> + >>> +/** >>> + * Allocate an AVAmbientViewingEnv structure and set its fields to >>> + * default values. The resulting struct can be freed using av_freep(). >>> + * >>> + * @return An AVAmbientViewingEnv filled with default values or NULL >>> + * on failure. >>> + */ >>> +AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size); >>> + >>> +/** >>> + * Allocate a complete AVAmbientViewingEnv and add it to the frame. >>> + * >>> + * @param frame The frame which side data is added to. >>> + * >>> + * @return The AVAmbientViewingEnv structure to be filled by caller. >>> + */ >>> +AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame); >>> >> >> All this boilerplate code for the various side-data--types makes me >> wonder whether they should not be replaced by something like >> void *av_frame_side_data_alloc(enum AVFrameSideDataType, size_t *size) >> and a corresponding av_frame_create_side_data(AVFrame *frame, enum >> AVFrameSideDataType). >> These functions would return an error in case it doesn't make sense to >> create a side data this way (because there is no struct associated to >> this side data type or because the size of this struct depends upon >> other parameters, too). >> > > Why is this side data type allocated, rather than what used to be > the standard, making the side data struct size const? Copy-paste? > > Are new fields expected to be added in the future? HDR mastering > metadata is also allocated, but we've never added any fields since > it was merged. With "const" you mean make the size part of the ABI? Well, given that side-data is always allocated, it doesn't really hurt to make the size of these fields not part of the ABI. (There are cases where this is not so: sizeof(AVBufferRef) not being part of the public ABI means that every av_buffer_ref() has an allocation and therefore needs to be checked. No addition to AVBufferRef has ever been made.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".