[FFmpeg-devel] [PATCH 3/7] avcodec/pgxdec: Remove pointless checks

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

These checks were (most likely) added to check for overreads
as the bytestream2_get_* functions return 0 in this case.
Yet this is not necessary anymore as we now have an explicit check
for the size. Should the input contain a real \0, pgx_get_number()
will error out lateron.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/pgxdec.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/libavcodec/pgxdec.c b/libavcodec/pgxdec.c
index 9c474036da..c9ada5afb5 100644
--- a/libavcodec/pgxdec.c
+++ b/libavcodec/pgxdec.c
@@ -69,14 +69,11 @@ static int pgx_decode_header(AVCodecContext *avctx, GetByteContext *g,
     } else if (byte == '-') {
         *sign = 1;
         bytestream2_skipu(g, 1);
-    } else if (byte == 0)
-        goto error;
+    }
 
     byte = bytestream2_peek_byteu(g);
     if (byte == ' ')
         bytestream2_skipu(g, 1);
-    else if (byte == 0)
-        goto error;
 
     if (pgx_get_number(avctx, g, depth))
         goto error;
-- 
2.32.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".