From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 250AC4896D for ; Wed, 21 Feb 2024 17:06:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F321B68D0E9; Wed, 21 Feb 2024 19:06:04 +0200 (EET) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2105.outbound.protection.outlook.com [40.92.59.105]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B9BF168CCED for ; Wed, 21 Feb 2024 19:05:56 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bytzGxBE4ptERtr5O1plrXrVxQxA7NUtihlqHUT26PMql8wD1PVYY1Uul4Xx3+OR6NOMI9NRXCdvyQrKxTytqbFN+pLkamHoD0/OtHLKKQZfyHicESpPfI4aT06wTR/hSGcrpFwt7JUx/dUw1fO0SJYUkueKBtYLiMYrBR9rAK58MIRNDDrBGDKLMKFidlMmJeTP7WxXlfrWhHt2OAm6sZGCIU8ee6ZnhHwzkhqCnZZMRxZuIEfep2a8IZoC0NBL/Vfc3+u3AIDa1p5kgvZxjQEDIC+cawLXl2NX7lWHmuR9nawysXM8UyoFhATR0d10lax6U2son7y+860gkUaQ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4VPpBOsOb4zQ5GV5ej7Dk/qfQsTkp4GyucSjgRy/b2U=; b=Q7r1svi8qxDOKw3nGYJuTMvD3xMLhbdWN8nTdU7d3a+Xpl2Tr2fuwgFKzrr/pBxcb8amUINjhNiBg23z89kyAXbAAMDZ3k+5Tsk0wGuaQb84QueBuZ1lxkNM7sKG6vPuAbPXKcLsotDxy3Eb8/nKUrQITHkghU+6lv9pZTt4grkImB2CFMiXhJDqvTvGNPtPsO2DEH/vbjy6FVlRla17/nZmfinfxeaznY1VXeDuLm1626P2f5asj2PPaeUdvGwTu13nhnv9/U/V/Ycf5UV32N3V7TSytWH+6HBbXNplF6Z6PYXkSkFHJEBSSLSAoPXu28r85PC3Z5FE0Bz8RCy1Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4VPpBOsOb4zQ5GV5ej7Dk/qfQsTkp4GyucSjgRy/b2U=; b=UJ2xAplza2w5XMdxaSV+KufYFlkyUkUTtW47OW0qEK2uvz1qm7hcUhsyh4UkfuPi38L7wDUlDsd5aSq5RDaUs1zuH9H3e+VlmR7Szm2cZX3MoDSRVfCsaU6jeFtkNJ7iE4f2klDUKgdU12F/c4MGhgtw5M6UuxgNJC7SYG8F5nGyE9Ado7vPydcu96+nuv01XuwSBMDuRs7DQvXLVrIR7sYdoznPak5MWW5VI5WuwKD2g/Dw3l93xfxBM/plCxFR74m8NjXNU55KMcS/jL+izHSQRhcVQfo4g4C+Xd5vYblAHLwIbyPE5teTClsc3Pdp0z+T/YAzTn5V+S0JWJ4TSA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0049.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:14c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.39; Wed, 21 Feb 2024 17:02:55 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7292.033; Wed, 21 Feb 2024 17:02:55 +0000 Message-ID: Date: Wed, 21 Feb 2024 18:04:53 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [u5A+Cc/RA679XkVr3u5gq45EVR3Cqb0UJI87JthSy+I=] X-ClientProxiedBy: FR3P281CA0050.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::19) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0049:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d45cad4-31b0-47c5-6f29-08dc32fef26c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XCGMShgVgpKj8qCNIIBiJL+rAnpozIxLwaa512reqrZiUnVzO/z5OUb4CgsTlSVAEEs8NBi+iDCVi83/O6G8mAYE5RdDDdYMBpyL243sZ4kRaq1agn0sxj7mdNPiesysKvKAw3CZMPbshVmkZiTB4h+JMpUiYvJqziLPlBXomqcgvtfAkG2xdPZ8VI+KIo46Jz9zDILarjpeamanpYO1d/8GnJTEWjRIp5ub+dgUBPGoK5+MR+S/wF2B+M+dXvR70wvYnzgstU+c1EeIkRMkmR0EBbMUr2d2849loPVjFhVXnpbuEOgnDvgauaAKkaav+JEYEN7kRfcdqNVRNdcOx2k3HZlX7MO9zxCxRaiWjRC5+HdhpZnWTQSI5wPFA9Yry7D0F4dqTyi/YdzR9IfKZ++RNzhgZdMqrP4/Pui2bzC/t/rfjNu4lbUBGtn7UBCFToIBZnX2ZqAVCdH3g1nsiMCKMBunnY2mEkOyHa5IZBB2K655q62pdRz6BOkWEaPbqy1ddoTT4qsvaB+9BT1/4DfE+/R9uaqJe9T8X47748csvMpcEFdj4nZyQKeSYsqr X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVFTd0cyRjFqOHNwS1VCZUZYdzJnWlArR1pITVpmc2pjOGgrVnFLOEh2V2JV?= =?utf-8?B?K055S2VjdlJVVUNjZU83Q2ZqRThkK2RkU1c1QzdTdnZiUUNES0xkTEhhMndY?= =?utf-8?B?MlZVWGhUMFhLdW8xT0YvUDY1L2gxMnppRVBNQmxta1hseXg2cjZRcnc3TXRZ?= =?utf-8?B?VGRQdUZPNU4wMS92MUs5RlVGaElabkdoRFFGcDQwMGplS3ppbmM5NWRCZDNI?= =?utf-8?B?c2pSbEV4UEgvS3pnOXpWVU5pdWlvMzBCZkkwUmt3eWlEQWt6Skw5WVRLcHRX?= =?utf-8?B?eExUOSswNVkyc1hYekFuNXIvRjF1a3liRTl5N1pXK0hhV0JMVFlzT3dxV3hX?= =?utf-8?B?OVdXMEM1QmNnL3JveWo5Mi9OZTUvclJaQXlIS09weEthamF1VFB5d0dvbk1R?= =?utf-8?B?ZC9VNDB0UHIzejRjdFNNQ3hTcUZZZWV2a2M5SGhUeXhNekExbEkrYWpqZzhW?= =?utf-8?B?MU9FWWdjRS96cEZHQ2pkU3c2Tm40Q0RFMkVjZ0pBMGRxMHF0ZDlwN0JTT3Vi?= =?utf-8?B?TjlIaUFDWWNlZmJoZlRxMmVjOG9ML251b0UySlhxK2VzSzdROGpVd2xrMzJL?= =?utf-8?B?bDl1aEhpZDlHZENtcnRGYzQrcVRheXQrM1dGd0ZQS3F5VmlROVFRQUQxZVdv?= =?utf-8?B?TGpRYi9wMzdEQzZIMTQrZ0hmditDTjIzb28yLzAwdGttVHZHR2pNelhoaHlK?= =?utf-8?B?NjIzdWhkMHBySTVDQmJKOHVxeFplN08yTnZJN1VCaXQrdU8vemlpY0tMcU1C?= =?utf-8?B?S0lGL2RHN3VLakZ2bE11eXZObnVZSjFwcW1WTjBWUk1WR1lXOGhYeEhCbGZz?= =?utf-8?B?a1FkS0FvUXFEY3Iwd2J6RkNqK0ZHUmhXcGVnTFR4RzByaDFJN2lTNVJpb09y?= =?utf-8?B?SGE1aUM5QmJsZktmUndrQnNKMlZ3VEZ3b1ZtTTZRZTNmQlI0em1iak83Q1Va?= =?utf-8?B?WURkVDJzdmdMV0FXMHF4ZWhRWTFFbVd1T2cxSk9BZ0RKZmM0Qm91YWE2M3pT?= =?utf-8?B?V240a0tHS0FOL3BURE9hSEUrS0VlK29KbWEzK1QzVWh4TU02VUliQnBZVE1N?= =?utf-8?B?SWJCSExBZGVFWUhhOVZaS2gvWlQyZ0pCUkg1UGgzOGhyQS9SRXV1N3U1VWR6?= =?utf-8?B?NklURmxiSUVVSFhhb3lpOXJVQW9vNlZFR2c1OU5EdHA5WllGN3Jpcm4xNnpX?= =?utf-8?B?RXdET1RtYUYzdUk4WWVFZVlwZXpBejU5L2djU3o5a2x2U0hGeGdZYW1YN0lU?= =?utf-8?B?aCtZRml5cnNvME9PMUZwc1dYN1VJZENBNnRQNnFjMjJDZHJCTTBoMGlIcjht?= =?utf-8?B?cis5RGFndzFXVjIrbnd1WTd5MTVSUmZqa3lzNVprVWovaGJhcTFLcUxtb1ZE?= =?utf-8?B?VDFxK3NGNlpLbU1wMm1zR0R0NXpiNEhWV2R5N1ExOGFLQ3NYMnc4dTRSSzA4?= =?utf-8?B?ODBqUGpCQy9Rb0lYRHBtN0hkcHVzalpxUEpscjdOc09hUzdSV05vQjAxemdR?= =?utf-8?B?bXVkMHZWNklSTHltR1ZNR3BZUE4raFNDbnlzY281V0toeWpiYjU0Ykg5ME9P?= =?utf-8?B?b3Rvd3JXK1BmRGdZVDc0elg2M3NxSFcvMEI1UXpRcnB2N2ZXL2FDUzNxUGl1?= =?utf-8?B?cmQrKzQ3U2RFTDdhN3V5aVA1L01WYzRCOVlJQ0UvcU1EdzMrQVJmYUQ1RlY0?= =?utf-8?B?Q3VvQlcveHpuelhONkxkQWtYajk2R0hEdkdiMFd4M0VjSlBqQWlNZ1pnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d45cad4-31b0-47c5-6f29-08dc32fef26c X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 17:02:55.1844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0049 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: Don't leave out ... in calls to variadic macros X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > It is undefined behaviour (see C11, 6.10.3 (4); see also > 14dd0a9057019e97ff9438f6cc1502f6922acb85). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_vp8.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c > index eabdef358f..1f7e81cfe6 100644 > --- a/libavcodec/cbs_vp8.c > +++ b/libavcodec/cbs_vp8.c > @@ -223,19 +223,19 @@ static int cbs_vp8_read_unsigned_le(CodedBitstreamContext *ctx, GetBitContext *g > #define SUBSCRIPTS(subs, ...) \ > (subs > 0 ? ((int[subs + 1]){subs, __VA_ARGS__}) : NULL) > > -#define f(width, name) xf(width, name, 0) > +#define f(width, name) xf(width, name, 0, ) > > // bool [de|en]coder methods. > -#define bc_f(width, name) bc_unsigned_subs(width, DEFAULT_PROB, true, name, 0) > -#define bc_s(width, name) bc_signed_subs(width, DEFAULT_PROB, name, 0) > +#define bc_f(width, name) bc_unsigned_subs(width, DEFAULT_PROB, true, name, 0, ) > +#define bc_s(width, name) bc_signed_subs(width, DEFAULT_PROB, name, 0, ) > #define bc_fs(width, name, subs, ...) \ > bc_unsigned_subs(width, DEFAULT_PROB, true, name, subs, __VA_ARGS__) > #define bc_ss(width, name, subs, ...) \ > bc_signed_subs(width, DEFAULT_PROB, name, subs, __VA_ARGS__) > > // bool [de|en]coder methods for boolean value and disable tracing. > -#define bc_b(name) bc_unsigned_subs(1, DEFAULT_PROB, false, name, 0) > -#define bc_b_prob(prob, name) bc_unsigned_subs(1, prob, false, name, 0) > +#define bc_b(name) bc_unsigned_subs(1, DEFAULT_PROB, false, name, 0, ) > +#define bc_b_prob(prob, name) bc_unsigned_subs(1, prob, false, name, 0, ) > > #define READ > #define READWRITE read Will apply this patch tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".