[FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: use open GOP by default

[FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: use open GOP by default

[Xiang, Haihao]

From: Haihao Xiang <haihao.xiang@intel.com>

HEVC spec has CRA frame which allows random access with open GOP, hence
it can achieve higher compression efficiency.

Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
---
 libavcodec/qsvenc_hevc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c
index a5bf915954..ba83987151 100644
--- a/libavcodec/qsvenc_hevc.c
+++ b/libavcodec/qsvenc_hevc.c
@@ -294,7 +294,7 @@ static const FFCodecDefault qsv_enc_defaults[] = {
     { "qmin",      "-1"    },
     { "qmax",      "-1"    },
     { "trellis",   "-1"    },
-    { "flags",     "+cgop" },
+    { "flags",     "-cgop" },
     { NULL },
 };
 
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: use open GOP by default

[Andreas Rheinhardt]

Xiang, Haihao:
> From: Haihao Xiang <haihao.xiang@intel.com>
> 
> HEVC spec has CRA frame which allows random access with open GOP, hence
> it can achieve higher compression efficiency.
> 
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---
>  libavcodec/qsvenc_hevc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c
> index a5bf915954..ba83987151 100644
> --- a/libavcodec/qsvenc_hevc.c
> +++ b/libavcodec/qsvenc_hevc.c
> @@ -294,7 +294,7 @@ static const FFCodecDefault qsv_enc_defaults[] = {
>      { "qmin",      "-1"    },
>      { "qmax",      "-1"    },
>      { "trellis",   "-1"    },
> -    { "flags",     "+cgop" },
> +    { "flags",     "-cgop" },
>      { NULL },
>  };
>  

If you want open GOP as default, you can just remove the entry, as open
GOP is the default anyway.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: use open GOP by default

[Xiang, Haihao]

> Xiang, Haihao:
> > From: Haihao Xiang <haihao.xiang@intel.com>
> > 
> > HEVC spec has CRA frame which allows random access with open GOP, hence
> > it can achieve higher compression efficiency.
> > 
> > Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> > ---
> >  libavcodec/qsvenc_hevc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c
> > index a5bf915954..ba83987151 100644
> > --- a/libavcodec/qsvenc_hevc.c
> > +++ b/libavcodec/qsvenc_hevc.c
> > @@ -294,7 +294,7 @@ static const FFCodecDefault qsv_enc_defaults[] = {
> >      { "qmin",      "-1"    },
> >      { "qmax",      "-1"    },
> >      { "trellis",   "-1"    },
> > -    { "flags",     "+cgop" },
> > +    { "flags",     "-cgop" },
> >      { NULL },
> >  };
> >  
> 
> If you want open GOP as default, you can just remove the entry, as open
> GOP is the default anyway.
> 

Thanks for pointing it out, I will update the patch. 

BRs
Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".