From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6E3454C815 for ; Tue, 6 Aug 2024 17:55:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5548E68DA62; Tue, 6 Aug 2024 20:55:08 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2080.outbound.protection.outlook.com [40.92.90.80]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 851C668D97E for ; Tue, 6 Aug 2024 20:55:02 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LBWa/ZnYRheGvfM/j3NlhbtGKTT/y4twME0cBigIW2YAkPFmoTFAm/R6lVUO90/stLfsRnISMCRph0Gvi/l9pbhWxW3+544ZNMtMrIoI/yNCxU2uBBKe3VXoaT1kxwxAvi6RHrm5aRj0/mk2XJO4qClpU6HLIVgVIeKgPwIld21xfqhqQyNVAbAFf6QefsxaOL8UKxakKR3hWGT5Qu67LXj8HZi08osXfQrVnWPifcXQxSQPZF/KvaFB8Ek9Ff3iYRhIOGZRAqp9w68ZD6ajvWdOfEHObYfdK9loDzxgA7KTKnJtUr9M7NZsiAPo6q9ro8V5TcRL3JKPU/qlD4WiuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4/hs88dfLe5MH0WDHudYKJl/GWTSEC/kB+gVH6uYa2U=; b=awKyYOpTJsTjxBxwHoDd31nerHmhc0m4vVZFBGoTNmId0ZM8tP6wZWtj/NoIA9Ly6RXnMb4fM/jv/wrDZR90i1Pw+AlqoU+UVK/HEMDstWYr1IqMgIrXobxiKqEpWG/FrTlqLphQxs3TRL6xcB6qYCX94t1Q4iQdsZ2rFyy/+E46LFXhOKZjednb2qFTrwSdPJlXHlh2xx5ZHju5ewc/YpZJlqQeaIfS0zXnH2QkEZ7nvwe9QrxrAxpX/piFlaXMCHbCU8ttjqF/qDA5H6jEDSEas3jFMzH9SlvHt1RpWko0YIvaAenUX6+PFltvBYcwz/Fnm9524XIOYYyLj5r/7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4/hs88dfLe5MH0WDHudYKJl/GWTSEC/kB+gVH6uYa2U=; b=byVrKF/JjNrtpAlp7RBta8e+dmaO0kcGjghLkaKHuC4bCiYSzti6tJXkcZWOSmcXT6f6OasCibTF6KZrPCSZ5UYH4FEMaI1/sDzMmbVWm8FqAcNkVtjMHpRw5K1Pdph/b/Z7mE0o9XjHRKr5Ry78lpC+dG/jfM4AVJM+cYoO6SfAPV2Wff2olSkd47iG8uaaiOBCptp0J560J19wCCHEGrKv3+EozCKd3MjHi/3AyzxpoBbMfDv3Wl1YEmyKuVhfdDeGZlUwMVm/Uy/Q75odVZNDSgwdCYCoasZd8bkQDfUhDuvPKrT1JkAxXj1GWeyuFDXFcMHF3Tf+bVQUu6Zc+g== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0325.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:328::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.27; Tue, 6 Aug 2024 17:55:01 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%3]) with mapi id 15.20.7828.023; Tue, 6 Aug 2024 17:55:01 +0000 Message-ID: Date: Tue, 6 Aug 2024 19:54:58 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240806170538.GI4991@pb2> <20240806173823.GJ4991@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240806173823.GJ4991@pb2> X-TMN: [5XwGg2d+O/wal6126MaZY/C2bdwwcVYdlBpc3gmnH3Y=] X-ClientProxiedBy: ZR0P278CA0066.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::17) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <9fc50083-75b9-4c61-b990-dc3ac7241cad@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0325:EE_ X-MS-Office365-Filtering-Correlation-Id: 39b5760e-acef-4ee7-616c-08dcb640e4c6 X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|461199028|5072599009|19110799003|3412199025|440099028; X-Microsoft-Antispam-Message-Info: lB8xNCxNN84MHZdpjpGwHmyimHFpY+roBD2EOiALe6nvlaQwqrCRTlvG+KIc0Is/35KByduMBm8xv+z7ZU7maOr7xb+b9Azsdv7YkMBF1TU5CYkGDBcLzTEZQPFj7NaOqPSPY9Uasz6q0QQLL62MFKvvyY7BpxbjJpUTy4rIkWMUPpq+vRDPwnt0OmvJyvlAskAkBoQkwU9a8zZlmwcf3XkxyuTf3rWH5z8Mhn2nGsqNzp0MRZJ7rxYyktmZeSm54jMUvHX9tv6z+xdqRWjIwsjXqbnhv6uvspe5oimuxRo53uw2AtQ3o8gU/E38VCy6hxohibIvImr5kSObAY3IwyriWyh57xPBLOBMBgKkYThIjC/9qYeHfl4R0Q952w0nCA48+eVmFvNPyrKhJZWw07VtEsamiIpTXi4cz8G26vPt5WMe5IGluuSYbnHYqZToqG9WYyEZrySvPSG3FuMspIjGAehH4TeobQR9Nionq4UKXoAnEIXIZKUOdwB3f8p5oez/sRn64hrleFpyFB31LmL6TpQg4mDPZ2VT7idAJp/x4Op5ynwwihUEY1tDvUYBsGUKyDiYYbXdDfTDqNvw3UUfLLBfOnujo13LaI66tFUtXfTPy8ARGxsl1OJu77B4GdTxsk1VXh6o1zSpR63koBp1+PLvlKEo0g+648DIz6sxhHb9yI6vgKhH72TRiD0S X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWx3MW5ibHN2ZkVEUGR2ZEd3OVRHYU5RckdHdC9FSG1EQlZpSDZiNkpuK3Vo?= =?utf-8?B?WWRpLzJVN1VjRTE2c0U1NDRxWnhmV0dSbnJqbVE3cFgwUTVzUlBzRFVuaUtl?= =?utf-8?B?OEpISHZiTkZKb0dtQXdBcGhPYXl6NEdEUUZmZlhwVnh5RlpXMGlJYzZFTEJv?= =?utf-8?B?cHNtb2Z2MFRrNTlnMVZJcU9JZVJtejIraEhKb3lSaXdoWWhKSUx3LzZ6dUV6?= =?utf-8?B?M29qdFFKUFhRZkkwWDllVTd0Y2g1dnl4VTBxUXlZVStsTldnMWZKRUpqVWxR?= =?utf-8?B?R3dodUh6TlVDT3dPaVNOaStINm9xSkY4MXluN3dmcWwvSWlIK21oOFF0dXIy?= =?utf-8?B?Q00yS3JuZVpQYU9uWlN2ZjFhVk84R25MdGRVenFlN1FrSyszVE5BNmJINDVs?= =?utf-8?B?WWdEeHRwdGZYOFVOY0Fxd2xUV1JCM0V5S20xTXB4WEZMZW1ZS0NtejkvdXdB?= =?utf-8?B?dW1xTjdMV003WUJWenZhN3RjZ01kT1dDdkxOZFo3MWxnY1J5M0lqWkhzOG56?= =?utf-8?B?Y3NwS3lHc25QS0xJdE1tTVFNSkkvSTRubmVMSXBHMnNGcmVmQ0ZUUU1zSGFG?= =?utf-8?B?bGR4UThjRllYR3dXbzhDMnBaSndkMWxVYWduWUh6VTEybzY4bjJmQ0k1dERE?= =?utf-8?B?NEV6VW9jb1hnRElhNjJFWE5KK1dUVVg4NXNrQkdJczR1dURMZ0JmNXpyR2M2?= =?utf-8?B?NnFkOGVSKzNDVzIzYWhsRGgrV0UwQzlJMzUyemlPdDdiOWdDODFva2p6YXh6?= =?utf-8?B?SmdYYWtoVHNoeDhlWUdrRnhUL0RiSGZYTkRCdiswM3AvK21PcDBiRE9IM1c3?= =?utf-8?B?NXd3QlEyNmhuV3hDdUV1YlJHeXVxQ2tIdGlEM0hOYWljeDVways3clBaZk9m?= =?utf-8?B?TkFNc2VSN1VYeUpKaEozc1RWbDk4c0s3Zm1PQURuclJzbFdvaUo3b1RKVTl6?= =?utf-8?B?YzdoUnVTR0xSQ0F3SUtNcmo4aEQyU3gvZnlzcDhVNGhjTXVVT0RsQXZGQUI2?= =?utf-8?B?VjdHZ20rTm1UeW04WUY4amo2QUF4NW1QME1wajZnWjZlYTF1ZmhuaEJyUU1U?= =?utf-8?B?eVBVdHVpbENvMS9wN3EwUnFzNFd2eGhmMnp6a3lDZkhmak9kbmVOekV3Z2Jt?= =?utf-8?B?TTlNaU9rRWJDM2pkSng1WURjWWNRNG5QUjc2QVNTZ05iWlJFRUtUbEF3a3c1?= =?utf-8?B?a1JmbnA1SE0wZDJKQ016Ym9mTFMrdWhtbktZSTRwSUkxSDZaZ283S1pnWFg4?= =?utf-8?B?WXdYcFZ3SHRsMTk5RldMbWxxN0pQWnJLZmZ1WUNsd2lCNll6dmV2cW1oWVBn?= =?utf-8?B?dEhXdnh5VnRWb3VoYWpNcmVrbzBDMFNtcjdSY1RLVmdCTXNwUzlGb0RCR3BR?= =?utf-8?B?TjNNU2kzSGdFcEUrcWtXd3FBRnBoZ3RwR1gxN2FVVkVhaXY4cDl0cExkMTY2?= =?utf-8?B?QXBmTDdOSWQ1NEdQajBRU01VSmcybU1OcUMvSE56eENXMjZ0M0NtWkltR3Ba?= =?utf-8?B?ODU2TXpLNWF4RkhmZTc5dGpGeDk1WEowWGkyeE1pY1lVWk0vQUI1eE1tSmRZ?= =?utf-8?B?TXJoWDZuRGlYWWRHZTIxUk9WZ1BHSnBYcmh3SHU1TXlqNEZpOWllMUlHaXpW?= =?utf-8?B?VzQ5cER5WlY0TWpzY0lZMm9TZVp0MEpoMjJzTWVFSUsySEtKSnVtS1R0NWps?= =?utf-8?B?UXR5MEU0RDJzdzRSWkorQ1RuaEFldVh6TVlaZDYrSHFvRkxsUCtGcG5nPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39b5760e-acef-4ee7-616c-08dcb640e4c6 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2024 17:55:01.3633 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0325 Subject: Re: [FFmpeg-devel] CBS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Tue, Aug 06, 2024 at 07:05:38PM +0200, Michael Niedermayer wrote: >> Hi >> >> Did CBS win the obfuscated C contest yet? >> >> I was just looking at a msan issue and then looked at this: >> >> CHECK(FUNC_SEI(message_list)(ctx, rw, ¤t->message_list, 1)); >> >> >> #define CHECK(call) do { \ >> err = (call); \ >> if (err < 0) \ >> return err; \ >> } while (0) >> >> #define FUNC_NAME2(rw, codec, name) cbs_ ## codec ## _ ## rw ## _ ## name >> #define FUNC_NAME1(rw, codec, name) FUNC_NAME2(rw, codec, name) >> #define FUNC_H264(name) FUNC_NAME1(READWRITE, h264, name) >> #define FUNC_H265(name) FUNC_NAME1(READWRITE, h265, name) >> #define FUNC_H266(name) FUNC_NAME1(READWRITE, h266, name) >> #define FUNC_SEI(name) FUNC_NAME1(READWRITE, sei, name) >> >> #define SEI_FUNC(name, args) \ >> static int FUNC(name) args; \ >> static int FUNC(name ## _internal)(CodedBitstreamContext *ctx, \ >> RWContext *rw, void *cur, \ >> SEIMessageState *state) \ >> { \ >> return FUNC(name)(ctx, rw, cur, state); \ >> } \ >> static int FUNC(name) args >> >> >> anyway, can we remove all preprocessor use from cbs ? I don't think that this is really obfuscated. > > the issue iam looking at is due to > > SEI_FUNC(sei_pic_timing, (CodedBitstreamContext *ctx, RWContext *rw, H264RawSEIPicTiming *current, SEIMessageState *sei)) > > having different active SPS on writing than reading, so the write code > has nal_hrd_parameters_present_flag set while the read had that 0 > so uninitialized data is written > > I cannot find any match for "cbs" in MAINTAINERS, also there are no copyright > with names in the cbs code. 1. I just sent a patch that "fixes" this. 2. But actually, there is a deeper bug here: We would need to defer parsing certain SEI message units to a second pass when the currently active SPS is known. This can happen with spec-compliant input (and even more so with spec-incompliant input, which is presumably what the fuzzer produced). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".