From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F13624B085 for ; Mon, 27 May 2024 17:18:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B226468D4D0; Mon, 27 May 2024 20:18:21 +0300 (EEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2037.outbound.protection.outlook.com [40.92.58.37]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6894668D084 for ; Mon, 27 May 2024 20:18:14 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Camf4sGXyFokHLYXx2pVGlwxGCEju/fOPWGlrZD0+gLdbW28GxwFj8lHv7iL0hzVj31k/uXcWKGZlYD8nvVWu3/x9UEYySc5JDjxw/85depsrPtMIykmQLrGWjkgYVu3UjzQ1byTgEknb05mmeytm0YibQLLnSQGlmV5gJr2hXg2fMMb1ubgR1R5GQZ9r/ghl8Z2OVVzHPVkDh9o1rPaRYp4Uh25GZsq36ezjXbG/9Y5HFWgCQGgbIDuI7fCpzQtyJ/d6/TyBOXb+TDlal2H/37/9US6yLxrmt+qx/SlzphG78FjnIBo04c3P3GgHnCk2RbNpLdd9nM+tUrLno07LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9PFnBb76Az8OIr3xiqwrvIdnTwhvTIFALbebIndSoRg=; b=cozeGNXBxVQQY0LEELKiUkMc3/zq0fCR0LqxEUaz000svs0s0EniPYb/+n6QZtADTY25HL5YunID46S68YLe4QVKHDbPVVkeHPbRqcxMaK7adQbHS5CZlfKmjdOwxP8t3t9LwC/KZEOpGHwgmwoeQha44a5JQIZMhC9WWfbuvd2QMhb1ON4imZtPjAJlqjg/085OWhB7+zfdN9maRdcvoN48dAEbjQ5x3ics59DIpnwsZjlJT7XjJBzB55L9lOz5zFXFNarzIYfgtUfI526IzlGjWAI+2Ov0l/OWaqh1gQmGUpjrSL3pjV/wu3Ov+O/nQq1Lmf75uyWHLn90lQMuzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9PFnBb76Az8OIr3xiqwrvIdnTwhvTIFALbebIndSoRg=; b=XzyjVgX15WNTWPA/bQ3AS4wY6t/ng3xtv2Ll98esXY2sOm/b9+YsIrsx29jLCdbwDwxdx3Qt+MxSWYZun+Pb83yADqZfYprSGCXXtObq/kjzWSP/nMtx5/BJ9u3zzP5Nzvwd26roeh5uVKmo+vzyZ8AXmNsty52HRMnFbe93E4oikGDKD41LXA/a4lhlzS0eiY9/1WctyzLHC87u6/iTctic1wRMMPnDQr9Oc1cH1VjjBpLs9iBRxgxQxBGhB1VP9tWNJ55LHZwNyTn1Fi/37Hb6sL1SAn3DTH8a5Rb2VSTzBo1MOKKgyAUUxh8XjRBUCLp7nnxRu//ABwr3yJEFgg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PRAP250MB0489.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:29a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Mon, 27 May 2024 17:18:12 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7611.025; Mon, 27 May 2024 17:18:12 +0000 Message-ID: Date: Mon, 27 May 2024 19:18:10 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [OaF1gxS2dqhQ+YNi5TRsXFYQsF3MbviN] X-ClientProxiedBy: ZR2P278CA0044.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::6) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <911a7cf4-1a01-4a82-908e-8240a077de6e@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PRAP250MB0489:EE_ X-MS-Office365-Filtering-Correlation-Id: 82a931e0-a698-4997-cb06-08dc7e70fcc0 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: chV2HQ3jYQI0KudymxBdyCQn0Bevmr/zAUjIzw3bI46e/sgRSubHRi6woPe6OY1lM5c0iOu/yXQCBv3YdpYpMuyNFVHyPgIxALMywd26HkMjgLEdgXVAHRb2K8AypJdf6LYqfoQ+tIq0RiqigD59o722Tr4LJ93hWPplSlU5fN/IhGJEltZbn05OZmzMGTTKosIPzr5zf0zBl9o4vYS+LYCwzAhwn7YT/0uph2pIl1GMpdmA3FZtWt6g0JXo6oJx7MDSsvrAc1Cah2Hvk++CQmYjIocfqySQJgb5A0QEEBTLCKAGuwPSi8klwZwhGADvWufGv2pcxemCBlpJVUN7Cr/T9+PxSO34vHiBniku3Mjv8QcBP1I3OgOSBG5bHPglDE3ebZjh2SD5cxkcbHRfqst+t97Upe2brvw4UI120U0MktqlSFEtYghzQPF6aB9lhSNx52XwR5Fu4ce+vAl1+cDnJeS6l5Rvz/DawGZr5rug0xXs/ct4IQFQEihgoyeOL7ezb4MiMTxXlOxstJrTbmoDaS6MWxkzslyW7DjCI5QvY7iB/PWz1n6tYon73ii3 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWQ1OGtXVE9SQ0grZWpzR0laNllwT2s1WFY5T3dFdUh4bEZZY2JwUzFVVVIv?= =?utf-8?B?V0Q4Uk9JdEFtWkN5TGpWZmhqWnNPL2htYlp4MUlXZE1BTWR1a05oS1hEVUti?= =?utf-8?B?TENzUHh0NkxEZHJOVDYwbDVPSUVHRG12SmcxY1JiY1luRTNuV0ozQ0xBUytt?= =?utf-8?B?K0dmalEzYmRGV2xiUkJUemRCOGR6QWJXc1A4ampsTlYxOGdCWmFRbUxVLzdo?= =?utf-8?B?N29ITFdoZnQzc3p2ZWRjaGtZL0tnWDNiL2plQkEvL2dQbitxV2pEWFllTUVS?= =?utf-8?B?Vnp3dE1MdUNGRk5CcmlMTFJmNDIxa093NVRaS1d3ZFN5OExQNER4cUJGRy9y?= =?utf-8?B?VkVhaFdRVTNFYW1XRGVrWWRpT09mTmlYYlE1MEIvVVRQc3RiTFpVZU1XSFhy?= =?utf-8?B?WEUxRUdmS0NLNjhlZUpqVWRaLzRWblFidVVmZS95cW1PazRHNzV3eFp4VStq?= =?utf-8?B?ZnhkK2J2SXNkNnkrSkJSNWhiNGRMdGJuWFFMMFVhamhLNGc2dGxSZkk3NUlz?= =?utf-8?B?dHhDSnR3QnhCOGlQREloMTBUWTBuNDNOOWxyajkvQ0ZmRk9QZmVUL3JDKzVW?= =?utf-8?B?US84WXcwck5MY210c1VoeE50UFlMRjcrRHpDcWp2T0t3cGlscDNxdk11MjVr?= =?utf-8?B?STlKMlMyYWlXOXFGMG9oVXBXRkc3T2JOM2RBRWREelJlcnpSQXhxZUN0T3Bl?= =?utf-8?B?c0hVTkxRdWkvL2pQU2ZVc1BQdE5pcmVSN3NWTWxpWEI5RDJzdGpTRTRJbVpz?= =?utf-8?B?VC8rUzRxSXcrQXdMbjYzQXpHRmZGWVdNVmM1ZGh0cUNzbkoxY0hGbVQ1YnIr?= =?utf-8?B?cVZ0M2s1a0VSZTNiWDA1K2Y2SC9ibE50RHI0WlBnSU1Cci9HN21XdTl1V2VQ?= =?utf-8?B?akQyMVdRSWsrbSs0c0JZcGVxVW5nL1JlVi9yRHh5cG9oU09XQjFTUW1YblQ1?= =?utf-8?B?a2tvNFpkV0d5UFFvbCszZ2dBWUduYW5hVFNaZFlDSnZRaXNnWE1hdTlIQTdO?= =?utf-8?B?QlVqcW5OMkMvaXZ0Y29qSGU0RXl1T0xlaU01TmlWNVhvZlZIL0wxUU5lZHE4?= =?utf-8?B?SWFjd0orcVBIdDBMNDVONTZPdzR6aW9XbUE2dFl4K0hLNUZQQURqNU42OVhw?= =?utf-8?B?TlhZK3Vzd01YNjBOZkxGSzRmMXZoRHJjMFB5QUZMS0QvWmdnNTlVcVkyanc5?= =?utf-8?B?UGxqbmVxTEkrY0F1NDM5QkxhOUxhUEM5WWFUejZMNVRVSEpiaDFSN004UHV5?= =?utf-8?B?VGZzT2xYdVZGdGZ3OGhoWG9tbmRTTWw4OE5JeTVIbmZSVWhYand4elBaWHhU?= =?utf-8?B?NStEaUJCbEpjQnF3bHFQWms0K2poLzFZVlVXNVlneGZlUXZCSXg2V2laNlhN?= =?utf-8?B?a1Y2VmUzb2pUSC8wYXM1SmtjSTVORmk4Wk9BalZ2OElCenFHNGJYa2dIRExo?= =?utf-8?B?UmVYdWpzQ0JVUWZSSmFlVlVWdDI4aWkrdXl2U0Q3all6L0dTZE5iOUJXSEkr?= =?utf-8?B?OGRaemJOaGZMSFpKQVk2bzlseUFxbitDeldLd2UweloxdmEyZ0RSaE0xVkxN?= =?utf-8?B?ZUx3TEd6WFVFVVdaUWVSSWxaTVF3MEV6bVp1am1DMkVxVXJZTVhLM3hoejcr?= =?utf-8?B?U0QxczNwRjBzeXZDc3R6eHIzSTdFbjQ0TnpHNDhVcDZwVGFmNkowYlJsVm1p?= =?utf-8?B?Sk9jTXJqeXVmZ1d4MlJxajlnODVOMStPR2FSUmtvVEFwZkQvSDFhbHdRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82a931e0-a698-4997-cb06-08dc7e70fcc0 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 17:18:12.3847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0489 Subject: Re: [FFmpeg-devel] [PATCH 1/4] avfilter/vf_signalstats: Use 64bit for processing histogram X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > The result might not fit into 32bit if an image has gigantic > dimensions and one of the planes has a dominant value > (particularly so if said value is big). > > Fixes Coverity issues #1598399, #1598401, #1598402, #1598403, #1598404. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_signalstats.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c > index 50c9df4298..78a23bb705 100644 > --- a/libavfilter/vf_signalstats.c > +++ b/libavfilter/vf_signalstats.c > @@ -721,10 +721,10 @@ static int filter_frame(AVFilterLink *link, AVFrame *in) > if (histv[fil]) maxv = fil; > if (histsat[fil]) maxsat = fil; > > - toty += histy[fil] * fil; > - totu += histu[fil] * fil; > - totv += histv[fil] * fil; > - totsat += histsat[fil] * fil; > + toty += (uint64_t)histy[fil] * fil; > + totu += (uint64_t)histu[fil] * fil; > + totv += (uint64_t)histv[fil] * fil; > + totsat += (uint64_t)histsat[fil] * fil; > > accy += histy[fil]; > accu += histu[fil]; > @@ -745,7 +745,7 @@ static int filter_frame(AVFilterLink *link, AVFrame *in) > maxhue = histhue[0]; > medhue = -1; > for (fil = 0; fil < 360; fil++) { > - tothue += histhue[fil] * fil; > + tothue += (uint64_t)histhue[fil] * fil; > acchue += histhue[fil]; > > if (medhue == -1 && acchue > s->cfs / 2) Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".