From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 72EEB450FF for ; Fri, 6 Jan 2023 19:02:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7986268BD1D; Fri, 6 Jan 2023 21:02:17 +0200 (EET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2082.outbound.protection.outlook.com [40.92.75.82]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E1CB968BC2F for ; Fri, 6 Jan 2023 21:02:10 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DO00/I9MwD0fZHWIwd3MdzXNkCH+9KvaoCjeacSM59iedIdTlFEDh0drgEoznc+GxeGUT9XfpslkoHLDhTlX4Zj1f9XiXYu8vHeX7L6lshFjhOoo6RNymQpQsjj2gbc29kRl557cbVqocSxDxrLw3wZDrzHzCkotkoa4MNx9SKH1H9rZUuXlVnfbXelDd5KxQ5BfKYe3XsrB/tNBhUE/aXQhQtZrGNw5I5MF0QRT6OA+g7PzuvesLLQE+zO2955gZUwX0zTCL4XXoOEFJPmL28OK2BChjl6PIWKSBCqZ3Br5MWssxzMwIzTDWTmT0SqOlgDJEWtJZhiN7L6ldgqoXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8EQ+IR14MGVeoZw3A2xetobGIWOY5gvSPDUGFe2rpbw=; b=IDYriC34IItOOtdQ/6ZMjcENhl6obLo8fgdI3pz8qJu/shrIjjw8Z8Y2F2aHUNnr2Ao+3eiH6QkaiTF04S7WllZczB7e9HiCnObyikX+f0NfiJdb60UkQAwLw6K0D5Pd5X0b1BPiMyFmnFTjRyFhP/bwZBT2AIk8XV+NnP1UNOrlOBIGnvkf15QglkVciHGWRgzPeulvV/KpXQCqk9xz6va9JPlbJlb5R4NizaQR+zQ+T2f+ExFApU6WYJk9t9aSQBXdDfCCsIZlWSmF1T9gqWEh/EEUrwOJojAaFOZE1WrauXG3jCpwROpZJL3Tt2Z2u/hoOV10OpQiWMQKuX2RBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8EQ+IR14MGVeoZw3A2xetobGIWOY5gvSPDUGFe2rpbw=; b=HtlKTHlsvyxpCe1JptYrY4MUlgz8zKmW4RKem/6p/zyNQBngr9eW1GZVNN72vqrMfl6CcS9NzbK5bCGtSaKJkCIYCrIVBz7LRXNmjKzfq1xVTq85Ffbtu7dnUb6KHbNHmeEtJFQ1MH1jRNuhh0v8MzgbrdRrYmDNXh5Qw90+vj9nitKjhw/6fPpYE43KiN9RFwowEsYcvGZOQoME5YLyissmi8xlKvktAM4mFCs2514h3Ey2tAD/DUjbJxGZypNcaDslRFXenC0vKYGc+X1Y+qZkLn4yJipxpsEeTx9FZBFga84H580H+TYjfKedgElTYNdph0+hWlKVJc1HCfC5bw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by GV1P250MB0738.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 19:02:09 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::c37:cabe:316a:60b2]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::c37:cabe:316a:60b2%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 19:02:09 +0000 Message-ID: Date: Fri, 6 Jan 2023 20:02:31 +0100 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [SaRZikG8eA6ktd2BPPvgS0pX5hbZMKAB] X-ClientProxiedBy: ZR0P278CA0112.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::9) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|GV1P250MB0738:EE_ X-MS-Office365-Filtering-Correlation-Id: 8aae02f5-c7c7-47a3-3934-08daf01882a0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YTv1w6Txid6KcTzwFSLCHh9TAv5cf6gHhFCKYnZIN9c7onf3oKc74ntr6E0FVfw/fVIX3Q2Y974EENB89P7qKE6Czr1lZVF6fzQrRfqQ5wrsdLDSS7AoMMpNlxtr8+OCY9OwHTz0t9DGhlV8NTaVv7SfLsH7dIKTCmV4smNZm+C0yXem90lG0334yyOGiX0pILz8kdhiW5RdIh9XG7EnfOBViJUWu95n8vnH0byZ3a//JlZTvQPLjYUUy5mEn0o/QNqtgP2LQ425lKLlVDqBdDujYv9uCjSaIkv7Wq0mu3PBL8xLd9gW3r0FUQy6t6KlX/Hl//7mVZGX3EVVC4k0PCSovrSFBhzAMn0Mt6+YBSEDPLbbkFAKR/k/icnEgos2dJdWEp8tqDnR5k8THDaCTn/4Vfvux4Fp2vRFNlnRI3PxoC61LawoIQe1AkaADtzMN34qZKHeBTV+MMR4dBE6awQY1aMts5xWWMY/LHinBf4NCw9OL306QcLOKAL0Jfgok4z7ZosJKvC3NxWXa86XEEJtutuMTXvSgENKYIDCzWwiwI83kK0+Wf2NmricxqpT3Er+niSLQHio/EV3241IBlnurdg9wyBBbgbn+9LEY8PjZPAUmipQlPuooTix4WbSBn6LlK+SYHGkgZ8h2Y1/ZwNxboDMYLkn37cwKi2L10XA+ho89Oa1hI7BfLzmomN1 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmJwTUhtMWtKc09VUkZ0emdWam04aXQwNDdXdlBYcHlZOHQzbXFLVlNDYmJR?= =?utf-8?B?MnJtL1B1OHNiMDVGdEQ3SiswUjEydGh5MGZEcVZWZDBmY2VKY1RNQkIvSFh4?= =?utf-8?B?dXFFUWdFZ2c1eWFLd0Jpb3E2MFFKYVJlYk8zb25mWmxBMUorOUxpRHZoZFZS?= =?utf-8?B?c2UyR3F3MXNNQzNpclVBNEM1d3lScXJmRndMZXdCU05iR1RFa0RGcTdCUVJm?= =?utf-8?B?dm9KOGNJbWlER3dRa2JSbzZQdnRDZzBWbTJtcDRsUjdRSzA3aHUwRVJ5cVRs?= =?utf-8?B?NkhvSjN6aktJWkhYTEhRMUNyUTRFTEoxZWxHN0hqSmNuUUFocVlhUG1NaklJ?= =?utf-8?B?YUZNd0l0Z3RyT04wcllXTG42UVM4M1o1NFhGOWlUVm1MWHJFMnhvMTRsOHUw?= =?utf-8?B?dy9nY2ZFT09XUDZpc2lwcnROdnphTXg1VXlKNVhPVk8wQkpMUW5rbU1XOXhm?= =?utf-8?B?VFVCTjA2TFluTXRwWDFaam5SRHNrZ1Zvd0pBZFdreUYzKzdwVmVvam56Yzdl?= =?utf-8?B?QUwza20yOE82b2pFZFo4NWtuaGFiRVBqejlsWEQ3NXBFL1ZPVUdFc0w2NUwz?= =?utf-8?B?UCtZT3Q4N3IyYTdQTFJSQVRiU2FPUDNHbU05Mm5PT3VuQ3JzUjRBRFVyck9O?= =?utf-8?B?dTUxcUI0ZXRPM2VsaEtsMjN2Ulk0VVUwUisrdXlhQStJak1EZExCZEUzVXdt?= =?utf-8?B?WHpGZnhqQ2hENE1odDJHWUdCblJRVjVTRHVOYUZkeWxVUUJ6NnhpdEd0WGNJ?= =?utf-8?B?a1ZCdWJZUlhyUWw2bDh0bWJJekpQbzJtRkJEYVJQZnBOWGZvd2p2WU5ES3d5?= =?utf-8?B?djk4Z1BJNTNFWUNiaEFKc2JHVWhkTkRtelZjOU1qTTlmZHVUdUdzY09WNTRa?= =?utf-8?B?TE82eUh5bE9yU09ENG1JR2ZwK0lrVW8vQmRud3Y5dmJkUUUyWmRmM2tvN1BH?= =?utf-8?B?Qk5hTUhpVGtBb00xMlBQMHZrYWJjZVVWTmNmT0FTc0ZQdXVMdnBjV0MvTnRN?= =?utf-8?B?dUpNY0ZMelgyZlp0b0NsQXZPV0xOTmVsb1RDQkg5TUt0M2VnbnNtdkR2Zytx?= =?utf-8?B?Y0JqV2IvQUZCZkR0ak15NCtSaU1IWXMrdTduNnRQd202T08ycGp0eUZNYUJF?= =?utf-8?B?ZW91ZGo3MDlWZENFOWc3K01tYzZWdmZlcXg2V3llV3l4a2V0cGhLNmRJVG9L?= =?utf-8?B?a1h0VGpMOWZYWUtvdU9XWXllNTFSeDBiMnREVjRLRGo1eW5BL3c5d0tjTFFZ?= =?utf-8?B?bUFHeHViNlZPeWpqb2VxODN4R3Zya0xyRkszNVBFMEJQUk52c1IydjdVZjh2?= =?utf-8?B?NjV3bWdZTWIzNUh4ZGxTaE11L255RkZNSDJjV3p0UndzQk0yejlxTTd1YmVH?= =?utf-8?B?NTh3S3dhSVIvNHV5OWRFUGFOemRwTzFRVmp3OGQxWmZpRzNwakVkSTErc2dH?= =?utf-8?B?V1pRZ2dOcHRYaWhCVHRBTXZDRmNxMElYVWxnRjJrNHFFSHFNb1ZXQXpLVFM0?= =?utf-8?B?L1ZNUzcwUmtBY0lSb2hRV0pSRFFGbThWUWxlUmJxVWdCeUNFS2srQ2Q3ajJV?= =?utf-8?B?YWk0REV6VnVzdUJRRnVpRUZaU2JBR3JvdlZXOTRSWmRuUXQrcnQzNzRmQWEy?= =?utf-8?B?ZE5lVzA0enY3M3NWeWZzdWhsbzRCNy9TTGt1NXZkSG9kOHlzVTRHNmpodkk2?= =?utf-8?B?bkJzR0pISjdqUEFnVm1KUXF6MVFBMzZoN0M0Z2hibEpvbmJiS0xaZ0p0RGlj?= =?utf-8?Q?UKuIHR1HNJ9Mrj1yz8=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8aae02f5-c7c7-47a3-3934-08daf01882a0 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 19:02:09.0280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1P250MB0738 Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/vaapi_encode_h26x: passthrough A53 CC data as H264/HEVC SEI X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Aman Karmani: > From: Aman Karmani > > Signed-off-by: Aman Karmani > --- > avcodec/vaapi_encode_h26x: passthrough A53 CC data as H264/HEVC SEI > > v3: fix build failure v2: add control via sei parameter > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-46%2Ftmm1%2Fvaapi-a53cc-v3 > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-46/tmm1/vaapi-a53cc-v3 > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/46 > > Range-diff vs v2: > > 1: 9a2fee07a9 ! 1: 149fa8e61c avcodec/vaapi_encode_h26x: passthrough A53 CC data as H264/HEVC SEI > @@ libavcodec/vaapi_encode_h264.c: static const AVOption vaapi_encode_h264_options[ > { "recovery_point", "Include recovery points where appropriate", > 0, AV_OPT_TYPE_CONST, { .i64 = SEI_RECOVERY_POINT }, > INT_MIN, INT_MAX, FLAGS, "sei" }, > -+ { "a53_cc", "Include A/53 caption data" > ++ { "a53_cc", "Include A/53 caption data", > + 0, AV_OPT_TYPE_CONST, { .i64 = SEI_A53_CC }, > + INT_MIN, INT_MAX, FLAGS, "sei" }, > > @@ libavcodec/vaapi_encode_h265.c: static const AVOption vaapi_encode_h265_options[ > { .i64 = SEI_MASTERING_DISPLAY | SEI_CONTENT_LIGHT_LEVEL }, > INT_MIN, INT_MAX, FLAGS, "sei" }, > + { "a53_cc", > -+ "Include A/53 caption data" > ++ "Include A/53 caption data", > + 0, AV_OPT_TYPE_CONST, > + { .i64 = SEI_A53_CC }, > + INT_MIN, INT_MAX, FLAGS, "sei" }, > > > libavcodec/vaapi_encode_h264.c | 33 +++++++++++++++++++++++++++++++- > libavcodec/vaapi_encode_h265.c | 35 +++++++++++++++++++++++++++++++++- > 2 files changed, 66 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c > index b1b503b2a6..9f9d77a0e9 100644 > --- a/libavcodec/vaapi_encode_h264.c > +++ b/libavcodec/vaapi_encode_h264.c > @@ -26,6 +26,7 @@ > #include "libavutil/internal.h" > #include "libavutil/opt.h" > > +#include "atsc_a53.h" > #include "avcodec.h" > #include "cbs.h" > #include "cbs_h264.h" > @@ -40,6 +41,7 @@ enum { > SEI_TIMING = 0x01, > SEI_IDENTIFIER = 0x02, > SEI_RECOVERY_POINT = 0x04, > + SEI_A53_CC = 0x08, > }; > > // Random (version 4) ISO 11578 UUID. > @@ -98,6 +100,8 @@ typedef struct VAAPIEncodeH264Context { > H264RawSEIRecoveryPoint sei_recovery_point; > SEIRawUserDataUnregistered sei_identifier; > char *sei_identifier_string; > + SEIRawUserDataRegistered sei_a53cc; > + void *sei_a53cc_data; > > int aud_needed; > int sei_needed; > @@ -248,6 +252,13 @@ static int vaapi_encode_h264_write_extra_header(AVCodecContext *avctx, > if (err < 0) > goto fail; > } > + if (priv->sei_needed & SEI_A53_CC) { > + err = ff_cbs_sei_add_message(priv->cbc, au, 1, > + SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35, > + &priv->sei_a53cc, NULL); > + if (err < 0) > + goto fail; > + } > > priv->sei_needed = 0; > > @@ -681,6 +692,22 @@ static int vaapi_encode_h264_init_picture_params(AVCodecContext *avctx, > priv->sei_needed |= SEI_RECOVERY_POINT; > } > > + if (priv->sei & SEI_A53_CC) { > + int err; > + size_t sei_a53cc_len; > + av_freep(&priv->sei_a53cc_data); > + err = ff_alloc_a53_sei(pic->input_image, 0, &priv->sei_a53cc_data, &sei_a53cc_len); > + if (err < 0) > + return err; > + if (priv->sei_a53cc_data != NULL) { > + priv->sei_a53cc.itu_t_t35_country_code = 181; > + priv->sei_a53cc.data = (uint8_t *)priv->sei_a53cc_data + 1; > + priv->sei_a53cc.data_length = sei_a53cc_len - 1; > + > + priv->sei_needed |= SEI_A53_CC; > + } > + } > + > vpic->CurrPic = (VAPictureH264) { > .picture_id = pic->recon_surface, > .frame_idx = hpic->frame_num, > @@ -1226,6 +1253,7 @@ static av_cold int vaapi_encode_h264_close(AVCodecContext *avctx) > ff_cbs_fragment_free(&priv->current_access_unit); > ff_cbs_close(&priv->cbc); > av_freep(&priv->sei_identifier_string); > + av_freep(&priv->sei_a53cc_data); > > return ff_vaapi_encode_close(avctx); > } > @@ -1252,7 +1280,7 @@ static const AVOption vaapi_encode_h264_options[] = { > > { "sei", "Set SEI to include", > OFFSET(sei), AV_OPT_TYPE_FLAGS, > - { .i64 = SEI_IDENTIFIER | SEI_TIMING | SEI_RECOVERY_POINT }, > + { .i64 = SEI_IDENTIFIER | SEI_TIMING | SEI_RECOVERY_POINT | SEI_A53_CC }, > 0, INT_MAX, FLAGS, "sei" }, > { "identifier", "Include encoder version identifier", > 0, AV_OPT_TYPE_CONST, { .i64 = SEI_IDENTIFIER }, > @@ -1263,6 +1291,9 @@ static const AVOption vaapi_encode_h264_options[] = { > { "recovery_point", "Include recovery points where appropriate", > 0, AV_OPT_TYPE_CONST, { .i64 = SEI_RECOVERY_POINT }, > INT_MIN, INT_MAX, FLAGS, "sei" }, > + { "a53_cc", "Include A/53 caption data", > + 0, AV_OPT_TYPE_CONST, { .i64 = SEI_A53_CC }, > + INT_MIN, INT_MAX, FLAGS, "sei" }, > > { "profile", "Set profile (profile_idc and constraint_set*_flag)", > OFFSET(profile), AV_OPT_TYPE_INT, > diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c > index 94b56c6578..f5b85cef6f 100644 > --- a/libavcodec/vaapi_encode_h265.c > +++ b/libavcodec/vaapi_encode_h265.c > @@ -27,6 +27,7 @@ > #include "libavutil/opt.h" > #include "libavutil/mastering_display_metadata.h" > > +#include "atsc_a53.h" > #include "avcodec.h" > #include "cbs.h" > #include "cbs_h265.h" > @@ -40,6 +41,7 @@ > enum { > SEI_MASTERING_DISPLAY = 0x08, > SEI_CONTENT_LIGHT_LEVEL = 0x10, > + SEI_A53_CC = 0x20, > }; > > typedef struct VAAPIEncodeH265Picture { > @@ -84,6 +86,8 @@ typedef struct VAAPIEncodeH265Context { > > SEIRawMasteringDisplayColourVolume sei_mastering_display; > SEIRawContentLightLevelInfo sei_content_light_level; > + SEIRawUserDataRegistered sei_a53cc; > + void *sei_a53cc_data; > > CodedBitstreamContext *cbc; > CodedBitstreamFragment current_access_unit; > @@ -226,6 +230,13 @@ static int vaapi_encode_h265_write_extra_header(AVCodecContext *avctx, > if (err < 0) > goto fail; > } > + if (priv->sei_needed & SEI_A53_CC) { > + err = ff_cbs_sei_add_message(priv->cbc, au, 1, > + SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35, > + &priv->sei_a53cc, NULL); > + if (err < 0) > + goto fail; > + } > > priv->sei_needed = 0; > > @@ -888,6 +899,22 @@ static int vaapi_encode_h265_init_picture_params(AVCodecContext *avctx, > } > } > > + if (priv->sei & SEI_A53_CC) { > + int err; > + size_t sei_a53cc_len; > + av_freep(&priv->sei_a53cc_data); > + err = ff_alloc_a53_sei(pic->input_image, 0, &priv->sei_a53cc_data, &sei_a53cc_len); > + if (err < 0) > + return err; > + if (priv->sei_a53cc_data != NULL) { > + priv->sei_a53cc.itu_t_t35_country_code = 181; > + priv->sei_a53cc.data = (uint8_t *)priv->sei_a53cc_data + 1; > + priv->sei_a53cc.data_length = sei_a53cc_len - 1; > + > + priv->sei_needed |= SEI_A53_CC; > + } > + } > + > vpic->decoded_curr_pic = (VAPictureHEVC) { > .picture_id = pic->recon_surface, > .pic_order_cnt = hpic->pic_order_cnt, > @@ -1355,6 +1382,7 @@ static av_cold int vaapi_encode_h265_close(AVCodecContext *avctx) > > ff_cbs_fragment_free(&priv->current_access_unit); > ff_cbs_close(&priv->cbc); > + av_freep(&priv->sei_a53cc_data); > > return ff_vaapi_encode_close(avctx); > } > @@ -1413,7 +1441,7 @@ static const AVOption vaapi_encode_h265_options[] = { > > { "sei", "Set SEI to include", > OFFSET(sei), AV_OPT_TYPE_FLAGS, > - { .i64 = SEI_MASTERING_DISPLAY | SEI_CONTENT_LIGHT_LEVEL }, > + { .i64 = SEI_MASTERING_DISPLAY | SEI_CONTENT_LIGHT_LEVEL | SEI_A53_CC }, > 0, INT_MAX, FLAGS, "sei" }, > { "hdr", > "Include HDR metadata for mastering display colour volume " > @@ -1421,6 +1449,11 @@ static const AVOption vaapi_encode_h265_options[] = { > 0, AV_OPT_TYPE_CONST, > { .i64 = SEI_MASTERING_DISPLAY | SEI_CONTENT_LIGHT_LEVEL }, > INT_MIN, INT_MAX, FLAGS, "sei" }, > + { "a53_cc", > + "Include A/53 caption data", > + 0, AV_OPT_TYPE_CONST, > + { .i64 = SEI_A53_CC }, > + INT_MIN, INT_MAX, FLAGS, "sei" }, > > { "tiles", "Tile columns x rows", > OFFSET(common.tile_cols), AV_OPT_TYPE_IMAGE_SIZE, > > base-commit: 3bcec58535d395945a390bdc7af4048a7abc60eb 1. You are repeating yourself in this patch. 2. You forgot to add the necessary atsc_a53 configure dependencies. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".