From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D4FBA4479D for ; Tue, 25 Oct 2022 21:39:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5F8BB68BBAD; Wed, 26 Oct 2022 00:39:46 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073086.outbound.protection.outlook.com [40.92.73.86]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F335568B9DC for ; Wed, 26 Oct 2022 00:39:39 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sqbz1xePd7xyzcb2dy4/M3LpXmj91XiNtr87k8hoHC1/w9+IpdysND//ZUBAcciw0gkltD6Q5Yd5ShV4+hN7D82mtqTqJezxPYctr9FTbH3pw9JGura/44qyJIeJ/wmZnVMDcPT7mE5Q4Aff2mxmb4D1vXCLqFnh/o5VFQAuOoZt572cYIX9dFFu6+FthtgVo/3j5BAjUDPV39dXM4tUQSNP6h7g/YgtF0IhD7EcLG+MyWcqhGX6rIJX85VB/1EOzQHlRjImLgBGAFkZBwJOm2qj0FDuHLH/Ax0Wy0Cc7hPWAg6NciYTAXc5XyxN3d4mxebqm86uj/wVZUIwV3Leag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XuoQI9YnfT+OBCbhF51NyoYhAKAIkmEKy+mCaZk5fxc=; b=eQL9Q7UiqL8kC87JsqqllDWTJbsf+uLKQyojXAYHmFY3JWlvlx/spCnlb1dkterPBPwtwF6VPJMfM0jjPHUyMbf6ufoi2Rf0dsSDFHLE74ycbif0OwQx4ebjqjvAvJ5sWcotddPSN2n8rKO7I4hwqRiXSiFyHpsQDziI3kWXsQCGTru6ukgceb98VfGVtnI5duyXds5UfxHEFLAqQOu+7HQqknta5mxrTC4hftm+KwJ5IEbqJU1Maowg6q9C3oEgD+XHhKj6Zau5d7Dx8NSoHqXPxzGQoXWFmpKt16C+DX11CFMJvKDdUjqFp3IjKs4lzYLMqXM+zp0imBDLa2os2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XuoQI9YnfT+OBCbhF51NyoYhAKAIkmEKy+mCaZk5fxc=; b=AGpitdcwOrhtMP86ktWeAqBbjdawMJT2phlmQ9RgIudFi1tBGHGo8Q7E9oXvHAWU+8UGlV7XwWea6OTZexmPGhrG1FKDgqKwBacUBk0h2iZG5qytInZRMmJYeSW3qvxGAIo7RFt3Djs7WRzp9UztnPNLvTSlgkfUdY7Zf0U/8IOxMFnSAotVqHda7BoNRBudvijssmjFlojxsG7YGbGuA7ylWEBPipNk2we2oeqNsYsyGvMnC6HaEo94yFztVNPTctpfmsTO7AGOb7ej5OVYI5WbtcEkNOH2Hr+W0WfTO9UWVpzskJDUSAI8g6Bq5WYlOqE5hhBh8SFLa+lsDth9Sw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0239.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:278::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct 2022 21:39:37 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f9d7:680f:70c4:44fe]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f9d7:680f:70c4:44fe%7]) with mapi id 15.20.5709.015; Tue, 25 Oct 2022 21:39:37 +0000 Message-ID: Date: Tue, 25 Oct 2022 23:39:49 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [4HqvbdWaibE4MWE7il0LypLiAEEf8VSgDzbZbDQzi/I=] X-ClientProxiedBy: FR0P281CA0117.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::15) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <58bad842-d093-6222-44d8-fc63bc4f79b9@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0239:EE_ X-MS-Office365-Filtering-Correlation-Id: cb1c2a76-9c1c-4c42-e327-08dab6d16a69 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zu9NNbzSfqa4uifosd6njX2dn0UGpMMKnIYtk7li9I1Ak8A8EprZGfHXpDaU8WLwPF+YRNAvz02GxDDis/kDp5hBPzgDJHCxnACzRpvO2JU1SPmptTGyOGAhl86BcDx4v2mmSPU3RqCyFqfNTeB4PX74zWvETUNeiY2w/lIxjGyh4DVP1H1bsFx/iaPEIFRy6eSYIlSlg5PAf6oUg1MNT5GvJ5o0khK8HlGguhrmO9NnbiPlq9SpKBKXTGib8j5ajHqk/A0nSC7W6SBp5jJJxzGIOS6+yFWw0HURLAoPoUcLUKmHb/+dQL6sDGWT6V1zFPdfeSjNtWQoAzvUNEn6pe6rZIJccTcSic5tTk+Qx4cbJTDpEe6J/3ZjAlHtGEBLMYpDV4wtcQQ1g2FV7pR+c1NhKsAorhjfN5qDrw+wIZWMI0MUMx+j+wU2sVEmDEx38xVLblyLpDkpYxmstAM5mTrvAJ8yS8jaNPCp4gD9ncICOVRYywCHQPk3ldLgg0sg1w8DAfhOKK1CZj5LemoXlan68qra1xRCZLEnDEPK4ZGnrB6VmZ9ETZUvidybh9713InwsFRBkEidk5qhe7J0bHt819+IjUCkYmyxGLnoLSl2YBz/4T8vfYoHAHikgjUi0DpMJFKhpVp9O03/GYgN2wGAnizzXychtbvt0VzMFhklkhfWzxvGOcDTIN7HKx4M X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFZxTnZVdUpud3lkMy8yREpuVVNqamlybklOUS9jZ1NsSXRweXpKTVNwK0dQ?= =?utf-8?B?blV1WkFxV2JhQkpXWkNJQTJ2VDFXWm16NGRJNkNFaTUzcDFxZWRoOXNqNTMw?= =?utf-8?B?MjdkNmdCaUNaelNua3kxeWNLb25vSFcrSm9ndFJoOWNZZmhDZ1MxcEpna2s2?= =?utf-8?B?ZmtOVGs1cDNLd1JrWVRwdVNCZVg0MkxwSzFBUS84eVdSSnBMMDFTeTVMTmZS?= =?utf-8?B?dTQvVS9sRkJyTWNEem5OZXZOS2xvdm9DaDRpeC9SYytlNVhTRVlrWXYvY3Vz?= =?utf-8?B?a3lFb29XSURBZHkrZ2VxYkRlTy9qUUd5ZW1wWWhhN2Rya2lBY3lXaHN3NmFG?= =?utf-8?B?R09mTDQzTGRZZTJCOGVsYkwzc2t2NUZqUE83U1VhbERtWVJPNUFweUoxbldy?= =?utf-8?B?azYzd3NiTlBQZVlZYUNXT1pPbloyTkFOZlgweFJqbmtDcEV3Zks5bUJ3bW1s?= =?utf-8?B?U3hlS3hod2lJTWhDT3ZTVWM4cDYyekJlMlg2cHp0eG9LNndrY1ZWWmU5TXVZ?= =?utf-8?B?bnpmNGtjNnhwbWg1WERIeHErcFNBOE5lUmNZYUhGMVhyc3VWR1VhOFdLYi91?= =?utf-8?B?UnFwck43b0R0a2E1QjRDTmFBL2NkZENXcEMzcEh3WDkzVlVxeCtjZ2wwL2w2?= =?utf-8?B?c1h5Rks5emtzSmd5cEJ4U2RFbCtDeEM0cytVc1N3Z0plcnBsVGVobERLUWQr?= =?utf-8?B?UWhkbkI2Qk5hbXNKdFNUTTZWcEdUVFBZcE9UVmhnRHNwZWhBYTVIRUk4N2xo?= =?utf-8?B?emRtbTg4Wlg0TDNCM2UwVDQ2UXc3bCs5UHJSNFltRVNSTkV3VE44aVkyb1lN?= =?utf-8?B?VWsralZaZVNjWUs1N0RjSU5lQ29sL2NjWlNaL1FzUThSL3NJOTc0VmdRY0Jx?= =?utf-8?B?dDMrc1FXTnlFZzhybmhVKzhjbldWUXhtRUdRd3p1RFlBK2E2K09oaEYrVW16?= =?utf-8?B?SHdlelJiWnJ4c1hRMHROOVJmQnhMSGExUkt0aHpNL1cwZkxyZmhNQ0k5UUxp?= =?utf-8?B?YjB5Ull5Z3JjSjZKNG5rYjByWllVMUl2RHRseVNabjJkUnllTDRZT3ZGdjE4?= =?utf-8?B?QUdIRzM4c3BvMEhjYy9TUHhDTFVaWkFuN2dGVUdvK3JzakdTckxCaDJCZTRV?= =?utf-8?B?MVNobFpoUDJpR2xPMXhKejVRb0VEK0FER2MxVXhieFRtMS9Fa0d5dFR5RFYw?= =?utf-8?B?eHJqcFJ0TGs4WnNza1RDcHBDWUdEVy8wTHEwMDlXWW5tRXVEVFlqWU0rNjRX?= =?utf-8?B?M0dYeXhWRGtoWGJ4a0x6M1VkNjVXUTlQTEtyQW5YMTdaa3ZEeno1b0E0SVhz?= =?utf-8?B?QWtxVGp4R0xlYTZJd1R4WTRjc2hDdXhUejQwZld0UDFTbmFORkZFSnNuR1Bq?= =?utf-8?B?TzVaM2k4ZkRGQTl5S09HMDFJNStzL0tkK3hWK2taWWJPSzFkV0pLdEM4OWFt?= =?utf-8?B?cENySFB3aXBuQWtyZU1oOW41MEdKcmdWS1RKcFFqMFdhNGxHS1VoKzdIN2lj?= =?utf-8?B?NXBRS3hrOE5LbFBIMjd0dzRXN1VVdEVOZHlLWkhidUhxUjVLM25nZWhyMVF4?= =?utf-8?B?RWhaWEZVNHNWcjlxRG5qUjlVVUV1OTdyMnQ4NVRNTWlzTGhpNk1JeFZOUTZt?= =?utf-8?B?T2prMmFNNkJ2VWE3ZEQySktEbkRjU1FyK3JWREFWblNQZHNScGdaME5vY3cv?= =?utf-8?B?M01LZnpGSEk4TXl6YjBMVlRRU1FHbm1aY0ZUNHJaNXNYMFNmRFZ4OUVzUzRR?= =?utf-8?Q?XglhZ7jCNiuADlTw7i/QOE6cXoqY9xtlYvTmZBf?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb1c2a76-9c1c-4c42-e327-08dab6d16a69 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 21:39:37.8122 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0239 Subject: Re: [FFmpeg-devel] [PATCH 01/17] avcodec/mpeg12dec: Remove redundant function call X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Redundant since dcb29d37d4ffedc84e44df99f8d22ecf27e0f2cd. > > Signed-off-by: Andreas Rheinhardt > --- > It is of course only redundant if avctx->codec_tag is not allowed > to change after avcodec_open2(); the corresponding option is not > marked with the AV_OPT_FLAG_RUNTIME_PARAM and the above mentioned > commit also relies on this, so I do, too. > Btw: I wonder whether vcr2_init_sequence() should not simply be called > during init. > > libavcodec/mpeg12dec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c > index 56bf73df11..c942be158e 100644 > --- a/libavcodec/mpeg12dec.c > +++ b/libavcodec/mpeg12dec.c > @@ -2797,7 +2797,6 @@ static int mpeg_decode_frame(AVCodecContext *avctx, AVFrame *picture, > } > #endif > > - s2->codec_tag = ff_toupper4(avctx->codec_tag); > if (s->mpeg_enc_ctx_allocated == 0 && ( s2->codec_tag == AV_RL32("VCR2") > || s2->codec_tag == AV_RL32("BW10") > )) Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".