From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E7BE34FEFB for ; Thu, 3 Jul 2025 20:27:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BB2C868F22D; Thu, 3 Jul 2025 23:27:14 +0300 (EEST) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2079.outbound.protection.outlook.com [40.92.49.79]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id A690768F094 for ; Thu, 3 Jul 2025 23:27:07 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i6wsv/4h5uHvnKU/5QnSu/1FXYPSlkrgnMVUx30uiMXzqZB1eSRvj7/s++K6hz2BjN2OvPb5qJXYyL5PYFROpfQnZzZlbdKJkUdwOGmFmUgO6IJUsS0Vag74sUp+gbkmp6HtSeo5cYsDkrqlJ8sst9GgEv7qwZThvht7wMvoevg4bF3xxuIwvcBpCbaibdgm7MF42CwAYcjypl1T1DDoyEhMTgR7t09hr5fGBLUpIRCYy5RDUjitTP2DSOu1c28gyU+JMtM2ZqGRKqUXjBKHEm4F6HLZCRxBmkeFRefpm6LlJz45yBJazb+bTJy8wVp/gcFw92/Y4j0WaOVbNB7M1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eNcWeaNb3tI9apz/A2JPQuWU82d8v3ZyFhKFzYiZkjM=; b=H/pN2YSzpZm6BR3sWCgjuIqzyUNv2qcmDCcpa9t8hMADV8qIN7jc42xMXOoZNgyw63KaTvVKOfGJATLOmYTRlG8vNIj0kdpKu3hH0RYOdLNTXHlC+0NveP7YeCUQPZsBbqyyRdRpgKt6irRTJPruveCRoeKv02drIQt+PtiomuSQ6UQV61uiuBA5F7lufk6byEQbQr7jqxN+DUPUhGHDUs/x/we+vMWudbkRcEpcyapinbd9hIa4SjtaGi2vqSBzqF1A8ztHjYpSF2PmauBhKYDn2SOn2YRZu906wTh4fTNnmzUw+OLrlA4YoUGBr0dvc8/SMMO9/oMmUvOxoUlSyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eNcWeaNb3tI9apz/A2JPQuWU82d8v3ZyFhKFzYiZkjM=; b=i7RZEWVah/AIAPx1JNoGSmaynKh5coM97MIhCxn56OxMOB8KHR7SlwZgIn23WvFEQ2bsemuV/BtbDQaD50VBdUuF5DcxcXgxlpzotGqt2vXfDzrCmbfDQDqaJrObnkO9XZotwgX7j8vIPLA6qPYsRbCPaa403gbYGaib9lEIIqepR0gCtKNfL9YLRNW2Mrq1cYNlbDSoWF4FNDHftC+138OYNf0jOv3IuuWwjaJLiSgcmxazY+wxJ2LNzXp1c3HhWx0xuCzJdBuxCf0d1vlpOxGI3s0iWUxbM3TW9KgqoVD9e26/XxC5/T3zLgVzJGbex/pV65MxIUq93+1Om3wVKQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by GV2P250MB0999.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:e1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.21; Thu, 3 Jul 2025 20:27:06 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%6]) with mapi id 15.20.8901.018; Thu, 3 Jul 2025 20:27:05 +0000 Message-ID: Date: Thu, 3 Jul 2025 22:27:04 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250703020131.2506428-1-michael@niedermayer.cc> <20250703020131.2506428-2-michael@niedermayer.cc> <20250703202258.GM29660@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250703202258.GM29660@pb2> X-ClientProxiedBy: FR4P281CA0287.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e7::12) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <7e786f62-3632-458f-aa95-345166ce34cd@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|GV2P250MB0999:EE_ X-MS-Office365-Filtering-Correlation-Id: 54bdec1c-6fe3-436f-bc17-08ddba6ffa0f X-Microsoft-Antispam: BCL:0; ARA:14566002|7092599006|8060799009|15080799009|5072599009|6090799003|41001999006|19110799006|461199028|440099028|3412199025|40105399003|10035399007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QVVIcmJTazZ2WFJuQ3VjNngrMUk1Um94bjdKUXdkQk5CTjJqVXRpWWFZM3hu?= =?utf-8?B?Yk1yYllmSDZ3c3V4cGVzWVo2M1JPdmtzVk1tMnBXTHZsSzhnZzRtTENtZTdE?= =?utf-8?B?S25jaklvMjZacm44NFQ5TkdFZ2ZzMGVFNFhtWE5uTko2a0xtQVlYa0FsYk10?= =?utf-8?B?bUVBZHd4a2hEOHlmWE9zRUVtVVlGUXZCY2xsc3RxeFdJVU55Tk5LK085K1dx?= =?utf-8?B?YVRleTdRVTNVRjVkb2JhMjNZNFlFR1VhZ2dCT0xHeWZyWmthS3BVMG83UFd1?= =?utf-8?B?SFl0b0VTajhnbXJzbTROdWc1NllFVlozU3kzWndvemV5WWlOSHNRZTNYSDJv?= =?utf-8?B?UGFaejRjT21iL2pWdHhwcWJjMmlBUURDdnZseTB4SkpvQ0FBZm9zWEE4Z0Ro?= =?utf-8?B?ZytqSC9RNHVSNE9wK25ob3orMktVdUxtYzBrdm9TeDh3N2VZb0FIS0toa3hK?= =?utf-8?B?cktnMDk4Ui9IRDFZNm9SM0E2KzlvNEFYWmYrNTl5TmN3clVCTllQY2tWMWZH?= =?utf-8?B?aTk4N05naVppOG1JZmFCNDRQUkxRMWZMYkNpLzIxWXN1azFHQi9vTjA2dy9F?= =?utf-8?B?VDFVc2RlN3VCa0g5WWZjMTZrRitzNFFXcnh3THBqbllBN255K2pyRU1KNXU1?= =?utf-8?B?Q1RvemYvK0xhSFZTMW1VTVNPWXJ4NVZmTDIyL1RSVzVuOWQ0Y2I2TmpFcG16?= =?utf-8?B?U1lJZlRIZGFFWlgzQW1yMXpyNzhkcGs3a21DSTluWVl5cC9rdTB4U2lOKy9M?= =?utf-8?B?aEVHWG13dVBZVVRFbWJ0R2xpVUFZTUhucXBvb3FrNDFkNlVCclRoREJnOGFY?= =?utf-8?B?WEZvM0J1bWhsbUUxTUsraGkxRzVmK3J1SFJZdFBKc1N6TUtlUlU1ei9MNXYy?= =?utf-8?B?MTBHVTRnVm1ScXhUUGhpSzNOUlVKT21qcnNSTGpvaVdxOVIxZWVsY2lZUHZ5?= =?utf-8?B?ZW5NWGVxVmx1UXB4VkRRaVY5YTBHbVVHQnRGbFdyTVhPdzBqaFFUWjV0NXdV?= =?utf-8?B?Y0NsOHM4YmIwNngzL3M3U1dmcHVqWWtTRExZQm9yUFY4Z0pRTFlMM3VETmxL?= =?utf-8?B?QUF4VHUrM2RiaENNUWFKZzVnRXNVK29uYi84cG0xV0U2RTdIVXVvZUNMem1y?= =?utf-8?B?cTBxL0lQdzhNSDdCa1p0cnhwSC9zMEFlZ1A2b05acTlqcFNqTlBKR1gvbU9Y?= =?utf-8?B?M1ZJclg2dDQwMk05MHpJZktJd3dyS3JMQUcwTmp2RS8zM29aZlBVbWlTbXRi?= =?utf-8?B?cXNzRVhrTHNYakE1Q3hITjY4V0RydHo1R2pDb2J6a0N5dFh3c2ZYdkI1WUZS?= =?utf-8?B?emwreUdiTEZBNjc3QXFRUkxIRTRmVHIyOFNQVk9qYlZESHVQTHNWdDZMV2FO?= =?utf-8?B?bXpsWGoxZHoxYkxSQWoybnV3NEZaaWZIL2pCTVVVWjhULzNIT3liN3BLalBo?= =?utf-8?B?SllXdjI0aXNmY1ZoR3Y2MnVGUU83ZjU1YlBmNkQwUWVRdFhnWVpjWXgzSUpK?= =?utf-8?B?bXczTFFSOHhUK3JFbHVBR1ZCVllQck5ld2dYSEhmcnd3YlZEczZjSEs0NTVr?= =?utf-8?B?L0JadjRaRi8yUUNHRGhCanJJOWtaSStzdUJIbVhzTzg5WVNpRGRseGNxRjJa?= =?utf-8?B?d0tSVXRWclVLMkVhOE8xQk8xMjdENVpWeVczM3hkTnFqTEVXazB4bWVnODRp?= =?utf-8?B?bjl6clA5Y1B5WXFpb3phTXY1VWpNUzJLMkNiTmZXcTVNQnhoMzNBdXlBPT0=?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckJJRjVnSjZaWFFRZGo1RWc1VysrMG85aFdNS0kwL1o4UUkrd3B3bzIzd3A3?= =?utf-8?B?ZEM1UllDM216d2dsTDduWSsxb0tsMFFkQnhjaEVDNlQzeXdhMitvazJ2V2hW?= =?utf-8?B?THp5bjQ2OHVCQzVicUsxMWFUdDZPdXUrWlgxdldLR3VwNS84RXdHc09Oc1ZM?= =?utf-8?B?SHJvVTBmS3o2dEp4a3ZSUW5ZRXJyZk9yVFY0NWFhMUd5V2VNdFN4MFkxY1Nw?= =?utf-8?B?R1VEbW55blNSMnpWalY1c3Z3cDBObzZmNWk0UjF1amRWY1RQYzhQODhrWk92?= =?utf-8?B?eFlMVmxhUkdOWE1oMlQzZER6RWpCNk0wQkdNVHpLSkszdmxrS1dYaEs2OVFr?= =?utf-8?B?SmZlYk1ONlg3dkNXdFRhcmdHY1d4cThiOWNJeW1oemlocVpPVUlVRUdoS3h2?= =?utf-8?B?bXo0YnRqczB3SGQ4dk5pNDFGSVRJWDlOZW1pcXM1L3RBcVVQVTlwZm1GVUo2?= =?utf-8?B?YVNseWhwanNjaFNGdmZDanQ3ZXpjVmtFV3grT1d1R2ZaSUhQQ09RNVpQWVlp?= =?utf-8?B?NU1mVVd1RDdvKzQ4ci9SNEh2eVFZWEV1SGVMVU9Laktxb0tnL1BNcG5wUU5W?= =?utf-8?B?SnBpZ1IvYnppVTFNbHcxcFlmeVRtRFFwcUR2MlEwQ1pvWWU3Q1drUngvaEpz?= =?utf-8?B?WTdFOVFHMXRBQXBGejF1aklPaGYzbTB5TmJMNnM4bitIejJGclUrQlUxWGpz?= =?utf-8?B?emJUK2xxditSZStsckFuK21iMmVReGN1dHY3UDNKZjhMaTMwWUxwMkFrVlFJ?= =?utf-8?B?WW9jbi8vZHREUHY0TE5NOUdyVVg4Rzc1bU5lUHRtZkl4cldEZVkxN2UwdGxi?= =?utf-8?B?aStXOFhESXh4QmtQbm5KcVJZcWNwSjNnRUtjWkJ1S3lVeXo4QjJMcUNXZGtl?= =?utf-8?B?czJ4TXRXcXNJSHpkcFVCc2I3OWd0a1ZlZG5vblJhUys0WXIxbnExVFVDNW4w?= =?utf-8?B?dGc0NysrUkpXaWovVW1oWmIybnpmTmZ2RmxqalhjelJQVncwTW44aHBtZUxI?= =?utf-8?B?YmthSjNqN3pyQ0d4VEJhNzc0NHFtSTBNb2o2TU9oNWhlM1F3dU5XM2hlNGhW?= =?utf-8?B?RXllZTlteFhzb2xZZXZTNm1na3VvUGJ1MXBYN0JiTHI0U3UvVzIzbm9hOVdM?= =?utf-8?B?TnNKQXBJSERGYlYzc1FIMFc4c0xqSkhSSVpQVUx3OXdCdGJkSUFVQ2hRakc0?= =?utf-8?B?S2M5M1k3Ti9GTDlWQjVBL0F0QUFkTm81aWpOYnd1TjVZYy9ia3JoRHo2NXNX?= =?utf-8?B?SHMxT0UvQzR6VlFFVFZ6aGtna28wZDV0YWluRUIwSDQ5eTN5OW5ybkJ1SVVK?= =?utf-8?B?YzZnYzVmczZKL3Uyd0VadHpPZEFTd0dXMUZQcDM5RmQ4aVlFVkFWeVRBL0sr?= =?utf-8?B?R0FQQlVWL0VjM3hOSk9uUkRXbitVa3dLOCs0RUh6OG1WQU5LQy9iNDVWTmZo?= =?utf-8?B?MjlqTU5IMG5BWXFVZTVzcjhPUW41UE8vOTFjamhDSmlSYkhnVXFEYitMcWts?= =?utf-8?B?OHlPdU5hbHZxZ1MwT3FvZjVpWHpjY3NndkJVcnNnWkpldzdBeUpLYzEzUUZP?= =?utf-8?B?L1VYTHJmSStYY0RmNVRoZDBleW9qTExWU1Roc0hsM0NXRm9NN0dtUElRODQw?= =?utf-8?B?L2dTSFRRSmdBMGhlcnpRZ3VJaUI4TWpJK1orQnZxOWI0bTJkYXVsajBINFlv?= =?utf-8?B?eS9yVy9xb1VpNjhpbVRRL09vZWpvTmVGT21neUZmZDg2SDhaL0J1bHZVYmQ4?= =?utf-8?B?M3FlN3pCT0RUZFNZdkQ5ZmpaTi9FalRyOWcwRncwZndaY2xnc1dkc1BBci9h?= =?utf-8?B?RUNiWVRjLzJoLzUxem5vdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54bdec1c-6fe3-436f-bc17-08ddba6ffa0f X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2025 20:27:05.7783 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2P250MB0999 Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/smacker: Check input before allocation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Thu, Jul 03, 2025 at 09:14:42PM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> Fixes: Timeout >>> Fixes: 421650030/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKAUD_fuzzer-6144441767493632 >>> >>> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/smacker.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c >>> index bd08bc7be28..99009bfd361 100644 >>> --- a/libavcodec/smacker.c >>> +++ b/libavcodec/smacker.c >>> @@ -662,6 +662,10 @@ static int smka_decode_frame(AVCodecContext *avctx, AVFrame *frame, >>> } else >>> values[i] = h.entries[0].value; >>> } >>> + if (get_bits_left(&gb) < (stereo+1) * (bits+1) * 8) { >>> + ret = AVERROR_INVALIDDATA; >>> + goto error; >>> + } >>> >>> if ((ret = ff_get_buffer(avctx, frame, 0)) < 0) >>> return ret; >> >> What about constant output (which you even optimized in >> 08e82e5b572b440f4faf160d2eac923ca47a59f8)? > > from this: > > if(bits) { //decode 16-bit data > for(i = stereo; i >= 0; i--) > pred[i] = av_bswap16(get_bits(&gb, 16)); > ... > } else { //8-bit data > for(i = stereo; i >= 0; i--) > pred[i] = get_bits(&gb, 8); > ... > } > > I assumed that there are at least (stereo+1) * (bits+1) * 8 bits > bits can only be 0 or 1 > > did i miss something ? > No. Seems fine. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".