From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8E24F49611 for ; Wed, 14 Feb 2024 12:22:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B723968D1C8; Wed, 14 Feb 2024 14:22:34 +0200 (EET) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2037.outbound.protection.outlook.com [40.92.48.37]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4EBC268C92E for ; Wed, 14 Feb 2024 14:22:28 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+VixccfAgz/mjjx5YySJKtO4zA3td5lzbMwOrFnoLFS3I8kzqFNhG/FyycBM26n7E9e+7SyJRX8FkcEJuodpGOl/W8/06pKGYHBXW8P+Rf0pTkhjGauRSRnvOg1PdYIxiQBSDfcyfg/D1GcZ4ZFRNsbIpGaY9Mx3i6xwuIaJSseR3m4VjBMoEGrYe2JmO4Q1AOD8TrgKlxk+MrHR2+uu5shTRYyE9hEzB/psq98QNT37fxlQippJc3vFgrHZ7Yt1fXrZKEmMpaX3pxC8OY0Z+kWVDTA3Ow4LBEXsYRU8Dx4LOOCDUXRj+jdZtV/uBOVcUTymEXJKiaVgy75Q5xuIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OZuhGdBoIgZHazBsqxneH6OyFPAS9ZXNsyofvgCgtQY=; b=RwIZgVj35FVNqU4UHVHdJggNjq7cUxUnssWjCNhgY+RGUFNTWX4RJu4RuVNJzGWIf7SEFVNHbNvq1KPOEqmVCwnT7owwbMsUzU2TrTckqXb0eZ8UMyWOu5sfPhah2Qr1gnYmn9qCYvEqfvRuqo1Jm+vHH68SjO+JsOk1X5B413CnElkofZpNmd1O91P2j68YfBpQvwM1njvBV5vtvRR+Bt6ZR/dhmI3VV8rPXveieQTRTwozt7nKhCDkZNp9DHjVzT7cky8vWIX6ojEoEFqil9SIx3XmcQtscESr0wco/Dr9Ldcr8P+DZNS/y3wLFw5Xn5LFNluVcbi1u2bUT8g/Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OZuhGdBoIgZHazBsqxneH6OyFPAS9ZXNsyofvgCgtQY=; b=nxykmDU1yafvu93/W514YiCH+KgayBha1AMqfDg8RDS91gtuGzqLiUUPfKst6L5EwwxTJ1ELshGCAWL8zJKs2JBqhAktYSKimd00N8X+wFa8YkRdNDNNlRjq5c2iHlKWeLTzLs9YjJKOTGRMsf/ZS2gkwJAAs0mAanF/puKt6zi9jA+i4RPj3WKVefbtuTOr02GDte5dCIuWNFp+Y4DHY4d4I+Y86YTDDuGgVpE4GLKuWv2MmiV2RjazAR8Ehn32RaorMzz5vgiuNdTiumdP5irFhuV3pHlran1cdbFzhHahp4As8TQfT8TZlasaR920WoPu92D9gjV5TdKthHkSjw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0174.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:273::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.26; Wed, 14 Feb 2024 12:22:26 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7270.036; Wed, 14 Feb 2024 12:22:26 +0000 Message-ID: Date: Wed, 14 Feb 2024 13:24:21 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <8EE4271A-1080-46B2-AA3F-8DF135007508@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <8EE4271A-1080-46B2-AA3F-8DF135007508@gmail.com> X-TMN: [ggt7ml0eObJuGaaDuahz4gLFyeUCRir0NALfBy7k1Zs=] X-ClientProxiedBy: FR0P281CA0161.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::8) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0174:EE_ X-MS-Office365-Filtering-Correlation-Id: 28496476-ab2c-40bc-0747-08dc2d579a98 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: if2oOfK5geRpayAkOyWVWva9bnvsiNlEra7wxEMGJ9CVkOy54XhHJaoERiZiFU0tXvIqfCPXU9QRWhfAPieWb222YabKl11gvys0Fon1vAbHKR+KqkemwDFmAIqh1xBGQSEb+44bGCcEhkExmeX2pDiNtD26OmuIfU4ahBadaTHwZcbZKNY22p+0i7HZ3qiI0K7VCKh55jKIf+nNe4wEP730D3Dzrmx2DdIsQpQdi0sBzfttGXOIUOqK1Noe0TbADoyjlPUJWjHC/cOtfLlbys3MwzaUru5+akqPNgp3qzZOSgSWvt3dwAF4t3kfuQsCoH2Y38fBeXE8PrTMjVCi+6XqlGsVuF4eRbVj0QvnHPKo7ObfT41j54tfRi94BBEphN3eenM/fisMgBLNVP8Z4d0vvwsSoeR3R94OJinX0pJB2ApMiFS5R2CXxtjLT+3t9yN02RRbMuUGcmIoLaipAZzYZ6Hyns1nq3Xuj4sAxUz3iWVjFT6fN55y4AnUXy/+AwjaTWQ4mWU7nAg92Y91Gr2njfKK6+xVphNVjAl2v7D2GeA9jfzm4L3aIGLk0jDj X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b25BU25YeXVud0dZQWh0T2d0ZVUwcy9tYmt4YVU4MUJ0RGY2dGFjNzBWVS9S?= =?utf-8?B?bDJDdjB6U3JBbXVnYTV2VGIzQWx4VlZjSHMxVHVFRVNpUCthQTBpK1BqS28w?= =?utf-8?B?REJCNHp3ZDVWdi9iOG52cW1ISzNhd1luSXRQU2liQWE2MXIwOVRDZENnbFlS?= =?utf-8?B?R1dtdWkyWEVUT3FKTGhsZWxheTYyaDIyVngyeFpJSGZmMFYxeXdJc1ZwVmpG?= =?utf-8?B?Ykk4eWM0L2lLVUppSDJNbTlkYlhuZHpBWFJrYzFZK0V2YndmQ2tXbDI5ME1u?= =?utf-8?B?OCt1M3YvbFlBNk5xbUhCblZlelplNlhhRkNjdWFtKzd0QVAvdlFoVFE3WFJv?= =?utf-8?B?OUpLYURCcHpORVJVVG90MTZoeGhNVVhKUVQ3cWtxa1owbVg4TTBLWTRPZmtZ?= =?utf-8?B?RGtRcjlQY09kV0lHZmNOcFVOZWx2ajFORzFpVGM1QVVDYUFFK1ZpNW9adk5J?= =?utf-8?B?amhaRHZLempteEJlMlFQUFE4NlRXOTBMcVNVTHlzemxiZHBxYktlTjloK2R5?= =?utf-8?B?WnRVRkQvSVM5RHRwTlNmYjI4cTdKREtJYjBWMmZ3eWM2WElFaWsrc0FHR3RJ?= =?utf-8?B?VlIrc0lJb1JCRStPYStHaU1TTE84NGttVUxzZGF0Zm5PbHNIQWhtTmxEWkxv?= =?utf-8?B?NExMYkdOSVUwRHJlNTBkTDI3MVJvSzVmSHBKL05ZdW5UN1BIelFTQ2o5WE12?= =?utf-8?B?OS8zaFFxU0IwRHFwaVZVU1hOcEpab0lERDhnTVlRNDMyVVFBNmZSaEpPcFlk?= =?utf-8?B?VFpYeHdFV1llMXp1NzdqaHkxbTVYL2ZTSFlSUkRYZHdRZVNJdkdrOXlWWkFx?= =?utf-8?B?WExTZUo4ZW9ib2JxYUJoeml1RmJKdjBSNzNMZ01WaysxTkZieWs3dStaa2x3?= =?utf-8?B?R0hHZGpZMitHQ3kxT3pGZDJLNkpuWTF5dE5WZklDUE1CTVlJQUcwL2djSVlU?= =?utf-8?B?ZFJ5Y1lqVXA0QlRVeTJpVkZDdEYyM3Bpc2p5S0JrVGVwaVhYVE51T3JETVVN?= =?utf-8?B?QjNPbldCNitWUHhrMG9GSXRrQUZVcldKTzY5K29JSmNZNGkveVVnbHVzUWpj?= =?utf-8?B?R0xsV1MyaGFTR3hpZGpPK2pLaEZrR2tTbXZrTUxDNDdjdWFkTGQrWG8zZVFl?= =?utf-8?B?WGI3NWxrRWVQTlJwOWZqcStyTnhZNFpCaXBQNDFmNEVlRUh2T2tWNjZwZHNk?= =?utf-8?B?NlRzNE5pNmNhQjNZcGNrdTN5cHdCUDB3YjQwRDZ5WXFzdXgvSHVIekZCUzkx?= =?utf-8?B?ZWZVeUZWMGh5Q1NxaElxWHViK3hUUFh1SjZMSWxKUzZMc2VZeXZTSDdoTUg1?= =?utf-8?B?SmFzdWNJd2p1cCtLZTlRemJDVjFOSE1sMEs3b3ZMSjJwbDNLMmRYZjUwaXJS?= =?utf-8?B?RGZ3WGtXL1liYTlJbGZCQ1pCTWJicXF5MXZPbG5ub0loVy9obUphUGFva21K?= =?utf-8?B?cjc2eVlySGhEaTl2S3VMRkZHeHZjdU1ReldudWJTTWVtOHZFMFlxZTZSdHBE?= =?utf-8?B?ZFA1bnE1cWdZQ2JDd2haTTNiWENhNnlHR2RvcXFOMlFHaGRjcDNqeFdJN0xB?= =?utf-8?B?L2x1THA4cFhMcGVXTldqNzRKL20xUTA4VkNxQmRQTTdyS2JLTFRuYkFWMHN4?= =?utf-8?B?ZjU4Mnd3U1VlbndKbUNPUjZWdDRWam5CUFhlRHhTb2oxMlBKcWowY05UejVk?= =?utf-8?B?ZllYREh2aTdmNWVYVHBtNkhlUENQS053ZWRRUkNqTysyK2xBWVFnak1BPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28496476-ab2c-40bc-0747-08dc2d579a98 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 12:22:26.0578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0174 Subject: Re: [FFmpeg-devel] [PATCH 1/5] avfilter/vf_signature: Allocate arrays together X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: epirat07@gmail.com: > On 14 Feb 2024, at 13:03, Andreas Rheinhardt wrote: > >> Signed-off-by: Andreas Rheinhardt >> --- >> libavfilter/vf_signature.c | 9 ++------- >> 1 file changed, 2 insertions(+), 7 deletions(-) >> >> diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c >> index 4896e8f2c1..eb48bf773d 100644 >> --- a/libavfilter/vf_signature.c >> +++ b/libavfilter/vf_signature.c >> @@ -250,14 +250,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *picref) >> int64_t* elemsignature; >> uint64_t* sortsignature; >> >> - elemsignature = av_malloc_array(elemcat->elem_count, sizeof(int64_t)); >> + elemsignature = av_malloc_array(elemcat->elem_count, 2 * sizeof(int64_t)); >> if (!elemsignature) >> return AVERROR(ENOMEM); >> - sortsignature = av_malloc_array(elemcat->elem_count, sizeof(int64_t)); >> - if (!sortsignature) { >> - av_freep(&elemsignature); >> - return AVERROR(ENOMEM); >> - } >> + sortsignature = elemsignature + elemcat->elem_count; > > Just my 2cents as someone not maintaining this code, so feel free to ignore completely: > > IMHO this makes it harder to understand what is going on, does it provide any meaningful > benefit? > > At the very least I would suggest to add a comment for the sake of whoever looks a this > code next and tries to grasp what is happening there. > The benefit is to have less code; e.g. if the second allocation fails, one needs to have special cleanup code for the first one. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".