From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E9C4049076 for ; Thu, 2 May 2024 08:25:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B700568D7AF; Thu, 2 May 2024 11:25:33 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2108.outbound.protection.outlook.com [40.92.89.108]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E0D1468D778 for ; Thu, 2 May 2024 11:25:27 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fmmcYZsYmYJSAnrBw8RFczYT28OTF2Y0u17J+prA6wPELX5btfa16mtmsZlYhryZGxs5kZ7X1t1H5FN28/iWx6VLZxLd3VHxjuTgG9wvbfEwa3f8esEsrnpt4N1s9B8d3+q6IDATQ/qRDPpu3m7tTeWUQAcA28fobcAFLYgiqD4j1TnEpLC1Rp+87giAPpvhS3IDVcme3ZFa3pCwvmE7479zIy51XQu34Y/0Bo9qeH30O0CxMhihP6oQDIqzHccY2sf++nxJNOY5SmR1Hfjzal7mirdmj3OeZZbk4aWiv22Z453a0YO6CcDrZgnMJTYMmZAVIyi5D8Q1KQhHJTxvyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V1Cod7hugoQB9QaRwLIG2Q2INqRbQVUHFyxNntEEN34=; b=AAg3wZMGjlBqEXiHOYAWc76XEhNczLXgbXbZ1PlLBzKYzYVCZt3YNDJpbDzEdSEW31+inb01URWvb47uEnd15Tyx/zFOTOQSzOsZX7v9TunjjPHM1rD3chb2migYvjrxkjKYRdq7eHnYUoUhdXT4kqRygZVQH8peQVtuMGAWKVq+J9jhydofkZwyO27xTxqPJsCCx+w39kE1/IKNxo9v9plGadnj2fRhIapJFJ/KZR6tWx55qNdv16Xol0760H+svPXYSmLELN4In4BDuQ9I4V6VTMn91+mZIE/PPCTkbPNP/Cx5iRhHMDhGeF3T+vhc38VPODvItolOLjT7APl3Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V1Cod7hugoQB9QaRwLIG2Q2INqRbQVUHFyxNntEEN34=; b=Td0yiRHnKaWeDQ0r3/6Ze62JXOvyJm7gAFV6aEtufY1pBowYk4yuJgz5KQcV6jqsoR64ZKlU1GCLD8v5m03OXVNXCFEch5shSSDpMPGBMCcek5+fLCuHwq7Gs+tTeZNIUrd/JgO4HrL0Mdzt3pss38fDiTd4v1WxpFkN2BTqduap1wzNWjILyoaDaKVr0nKXSB7jQTmNGh5adHxuCxur2bIoefMBHLMDu8xKgC75RELY44H4ncnqH/X6aJZ9m/q7H0YEb6jkxNvDns5AtWxH8X6f8q976pyfMaHL/1kFykK6ha4CD/7N2WJJ9OEofGbXi3cqFSGn2wLVJUit8q0reQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0278.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:329::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Thu, 2 May 2024 08:25:26 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7519.031; Thu, 2 May 2024 08:25:25 +0000 Message-ID: Date: Thu, 2 May 2024 10:25:24 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240502004150.3627661-1-michael@niedermayer.cc> <20240502004150.3627661-4-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240502004150.3627661-4-michael@niedermayer.cc> X-TMN: [r1QDQkOsPhqhObckcI+10E1ZCsTS0ifSoLvoqjjx3gg=] X-ClientProxiedBy: FR3P281CA0055.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::18) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <5ae8b8f5-e8e3-4244-93b1-996f558fd094@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0278:EE_ X-MS-Office365-Filtering-Correlation-Id: cf5eb254-e24e-4e5b-43d0-08dc6a816aef X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: HkRiiBDi1HRjulmpzL3JumdSVH44jvAkpwHNUO7dkxJS3ScrGBqK7eGE9VPbFC+M2DMr9C85BPmmiNgbjbJ0Cbyg87fRBFwI2V3yHRGKWOKV0uHzR80tTGExsT9EqojmqgOPy2tdj8+3tLZJO/8BjpnQvTehW3h7/p5210VSTbaxllIKMWzmhkxwxAtMdDWIGo+j3+Tm36p2JKNpiMgaroHxLNUuUlHyIkiOwwjgUc55V05o7uDmxNbSeDv3Mo1b8fJp0L+m73cEe+XVsPrNLJ1KkLLFNDeHc/iXuCM5SHRf1ofYfd5elNX0p83vChbrfaBuAa20nPfHAr4h4s11TM/P5OC512fOLn5pDo4170cy8rGx5CMLfGMi+8SJXX4Ch42aDdDoKtQgb78uDJhCcDGjq5PtzPOToALfpMB3TnR4CsdjTaBP50cdwxtp/HRUUCsx/7/dZKcthz/ImW7mEFXMpbujaMUBVZYBgCTkye19YMBZi+jgwRLFboIzKjnpD64b1PIgK7xDL2rGPn2QJAsQwR0LKmBoBDb8tyFuwoo3LBONAU9a57Do2JQ3x0f+ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTJWZ3B4YkxTTE5rcmVGdERReDJEcW4ra3ljNEc1dm0wUWhWQkJmdWdHMUJ5?= =?utf-8?B?a1BnTU5VT0p3QXV5R05leitlTThDMTBJNURmM0UzbnpKNUJGc1kwNTRjbm0y?= =?utf-8?B?OE01WFBzK3pOVlgzUjhHTjVLdDBpdFlqRXhNRE9IejhOTi80NDBmVWFRZ00z?= =?utf-8?B?VlN3eGU0R1lIbmVBY1dkcktKQmNZY1FCc1JxR2pqVnp6MFNNWE1tODU2WUgw?= =?utf-8?B?Ty81REQ2d2o1NUZvdGxGWlBtWjJjRUNPSGgxTEdBdTQzVDRBdFZEam55d1p6?= =?utf-8?B?Rzc0T1BiOU4vc0lBLzFIWkNaMWtGSnE2bzZMK29wMjl1eWVCY3gzNWFFWmtV?= =?utf-8?B?R2tNaGlNYlhXcDBhTzdxQUI2L2Iwc3FCSDA5VFg2VGVlY3NXRDhsQ1FMSUY5?= =?utf-8?B?dHU4dmM3NUdsQy9wTnZ2RHVrRWR0cjVmaHZsUEpRUmZXODFGNHdWUlRnZm81?= =?utf-8?B?UHFLL0lSRWxxRzJVSjc1dE1yeUhNNFdEc2JMMWcxSUlhaDBEZGVzR2NhRUJ6?= =?utf-8?B?KytNMmoyeEk0SkcyV3RmeGxVMEFLWlVZQno4Nzd3UDBHaCs0UVVOZ2l6VG9t?= =?utf-8?B?VU43RlJ6LzdvK0pNdGlzSG1SOHBkdmZEZGtVbXRIYjQ3K2crWHJCRHd5QUd1?= =?utf-8?B?b05BNUxuRHNlMk90V0dqdjNsbjF1U0p5dmh2STRPK3h2ZllKWlFOUHNsQ0px?= =?utf-8?B?c0tjRURxNkxMT3ROVGtWWjR5bkpDWUxMbWlzZjNlQldBTkJSRm0wR1FNb1A5?= =?utf-8?B?bFc5dFJWNzVCNTNrWWpPQTRvTy9QL3RwRUxZR2k4Yk5uS3dCekVib29aSkdV?= =?utf-8?B?S0NtVW5JR3FsVGlCZnpITHpBeitKVFR5djhkUFR5ZTl4bE4wVWxXNGdjYnBy?= =?utf-8?B?YWYraE5jQmw5WjJ5K0d2dWJHdEN3WTJ1V09lcWFWTVpQNGJjWU9oWHVuYjAr?= =?utf-8?B?VlNhUzFCYWNmeENPcFlhRWRVenJxYlhRWVhvTC9xaXNVZEFsaWt6RXZxSGVo?= =?utf-8?B?ZFh5NkV4alB6emVheUpXVkl6V0hFbmtkRmxiS1VYeUhScURiRWZsSG50dkU4?= =?utf-8?B?MFhjR1ZJUWJlblZpL0d2VzZMdzJSVFJZTjRCSlgvMXdQVDZHenVJelVZMUxZ?= =?utf-8?B?VTRvZ2o3RFNZV3Jaa3d1ZTZ6S0d1YVVVVHE2cVg3MHVlU28vaGptSVpob0V4?= =?utf-8?B?WWlQSlY4UlI1TkgxYlE1bVA1alBNOGlFNE9LNklHbVFKK1NYaXhqdUlqeEMy?= =?utf-8?B?TFZod3RzR3A2eWNzZWIvM3pVZW5UUFhxemtaZ1c3cXNyNFUwRU8ySWZFNXRv?= =?utf-8?B?Q3RIaTFuK0kzS2tTeHVaMjF1cTF0anhGeHR3VHg2MTlWMmRqeGFGRGxhUnJa?= =?utf-8?B?OVdQSFd2OTRYZExOeTBySUZoUnIwUWFyd01FdHZPYTBQOWJ2UlU4MFl2QnQ1?= =?utf-8?B?Z2xtT1VkM2l5NTFlNFhVWm5GYTh1bmdjcjZUc0JEU0toZHZvdXdYNzhOV0dS?= =?utf-8?B?cTZvMWdqMjBkVGxBZW1Za2pPWVFRUEdUemtnS2Y0SXluVUtpek1tWndKRkV0?= =?utf-8?B?WFM0eDBYWmIzVE1MYVdacWhlajdsNm1xMGlORStmVUZPTURqaHdISkpPVjNP?= =?utf-8?B?OGIyNGMrQUIrVGU2eEpPM3JDL0FOS2NudU1ZQnVyWTQ5OVFpNXJqUlVzdk1K?= =?utf-8?B?eVc0TDdzd0VOcGlMdUN4YXlTNy9JcW5PSlJ3aUgvWk1WWWh4c3gxRTZnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf5eb254-e24e-4e5b-43d0-08dc6a816aef X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 08:25:25.9025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0278 Subject: Re: [FFmpeg-devel] [PATCH 4/7] avcodec/avs2_parser: Assert init_get_bits8() success with const size 15 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: CID1506708 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/avs2_parser.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/avs2_parser.c b/libavcodec/avs2_parser.c > index 200134f91db..8d4bc3cee0d 100644 > --- a/libavcodec/avs2_parser.c > +++ b/libavcodec/avs2_parser.c > @@ -72,13 +72,15 @@ static void parse_avs2_seq_header(AVCodecParserContext *s, const uint8_t *buf, > unsigned aspect_ratio; > unsigned frame_rate_code; > int low_delay; > + int ret; > // update buf_size_min if parse more deeper > const int buf_size_min = 15; > > if (buf_size < buf_size_min) > return; > > - init_get_bits8(&gb, buf, buf_size_min); > + ret = init_get_bits8(&gb, buf, buf_size_min); > + av_assert2(ret >= 0); > > s->key_frame = 1; > s->pict_type = AV_PICTURE_TYPE_I; Code like this may trigger set-but-unused variable warnings when ASSERT_LEVEL is <= 1. Add av_unused to ret to fix this. Apart from that, it should be av_assert1 (this is not hot). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".