From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2F2C349091 for ; Thu, 2 May 2024 08:28:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 773E168D7B5; Thu, 2 May 2024 11:28:49 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2079.outbound.protection.outlook.com [40.92.89.79]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B973A68D701 for ; Thu, 2 May 2024 11:28:42 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FAt0k+tWTpdcPW1+wGgHo6sdzWyJlM9nu9R9V650+nyXtUPqS/JMo2JnRcGU1LzDCl7RpOF2iWm6cGIzGBj23kZ9JAHm247i/9qFrfTKEQ7gVa10W/kWr9tGvYwj35XabxA9uq5cqXQJKO5Mx7q+ftgnqSBLmayVHmEb43/96eGRM7WiTsYSGyI/bezKkoQ5yu0hPKMHfwhDjznatOpRu0RoqKL8ADt27/jF9kSa7HBWaU0YKeY3bJA9CXCDrukAp8ZjBN+9e/SAUh6ZRywWT130YnUVvLAhAhAC41E33DOMGyD3uinJ2lIU7kTXx9SMoa82tq4xIUN+PxxCcXqovw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IFfbeHbWH9BkhSXafFuPbys5xfvYHRP1wYevRheb7ds=; b=P1OeYx9wo4+4RKpwgHVqJJ7lLZyhzbx2T7serTCUeVaRLP89h2Xyw47ipOgDTEg08zrIRJZwy+w6C46m2t21OMMz9ts44NyHkIJb9+aVGTeMo9YzIOyYyYRVwUrv+Z2ve6KsjXuq/1y70L0jISbUv5tUjZqa+GIkSfDbUYA2i6lH67mWlcpjLpDBC0NFemlyza+gT1BxRHV1cvbwFsq1QyiHA1RJB0bxAlHiatTKF5Ml/hZT0BpFfBGCW5S4tyUFNq/e0IPn/pQVyHN/Jed1vEeHNjrLJY8/KGSck0TvTb73tWuNZxOBPGcO5tduHIpX5rERBKiLH+CG0RL6WZwlTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IFfbeHbWH9BkhSXafFuPbys5xfvYHRP1wYevRheb7ds=; b=UthruexyZzHjZo8zUiZKOfdkn2QfluW62OJvtoMe30n4wEOobWbMKd62/nVU13erizM0i5uHRjNiAkouxHGZCGVzCOJUWmUbncrBmuwnI47rraWkT9IS/c9ZCejPw7RtnxpkZpwWPt9WBBQD8VGNd/x8PfMJBaM6uAaujdYHPG6BLBd8/lZEtPtPG+30C2u9vnID8+5hnaYKAjTiw3BjgWjTNSY8ozQMyApWmRkobW75uNWCuLlZ/hRaivERIco7ipTjt0nH3EZh5bU0GzqMpGJP1hV8CsFg+xQphjwhh3n6LsxJQg9qcMh5PyaZJ7vSs1ggRvTzfE/9YsurxWRcTA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0278.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:329::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Thu, 2 May 2024 08:28:39 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7519.031; Thu, 2 May 2024 08:28:38 +0000 Message-ID: Date: Thu, 2 May 2024 10:28:36 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240502004150.3627661-1-michael@niedermayer.cc> <20240502004150.3627661-5-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240502004150.3627661-5-michael@niedermayer.cc> X-TMN: [37ZN9drQqlLAVygBU87i8faMSF9xb3k2FkZlBXgbwwQ=] X-ClientProxiedBy: ZR2P278CA0070.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:52::13) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0278:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d9035e1-3ecf-4d91-73bb-08dc6a81dd96 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: SKh7MOcq7n2QGWxxDGtNWZ5F+KAhGfMahE50fJm90BXvV9Mfq6zfhQvAHwchoPkD9xxkIquqocKV18xI5ZAme0JWuv3up0IWwu1KDBlMBOkTYwo2UXYDataB7KQXWkKwUelBJQK4082IaB2qMFCFtj9jAz0tQeJ1eIn5BdoKPtTrTAP9DVuipo96Vor720ftcqI3BKHcUzAwwBRKW2Xu4LqB2laOFUq8+P+5KrQdJabEsnINpOUAPR7i2DOpE1rhWq3eyp0xfJqfxs/p7LQlXtCmgiy38BsOzL70nwRK16wRu52l65X9W3XlSXARIbEvPMBPr07x0BBpdTCPlTz6HuY1r3bcX3/ibqFv0BwPipw0k9FHQrjaRj1P4mxC9jSv17W0bJ8ubJC13ElCSsvmRXmreu8wdGL3rF8hEpMGZtN8QrliSF1jujngMVUBKV1qkVfFseFoYsrwklIytYJ1okBoh2H0QOs244L3PBE+jk0M2lDbudQYQVS3hhpNxjGYZ1VEInluF26OGmS9Yd+WIszrgJXnfzHMjGm6y3856Yj1YGhxo1AnN4Hgkw0S2Qf9 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0VxQnJGNmNwZTFLUkFpUFdMMTJyN29DYzVhZ1VRTnB4T0hLMThsKzQyQzl0?= =?utf-8?B?anJZbkpXbXJGNUF3Ymc3OUYvNWwwYzdXM01MaXNSYTlERC9JRVZVUjV6N0xS?= =?utf-8?B?VXNYT2x4UHJ1VCtmZFdwY1U0bmlERklWZVJ2U0V5a3gwY3dCcFVqYWlLMjk0?= =?utf-8?B?R05EbU9BMEs4MkFkakpEVldjWWg3Sm9Mam52cy9kWG5kczdMWkhZSjNBNytD?= =?utf-8?B?VGxQTmN3K2JhaldndzdMUHp3enYyeVdDYlUyTVQ3cG54c3Rwd2hXb3k4QmNx?= =?utf-8?B?eHhnR0dLaGJuQTZDWEhYZUZUdUtyU1ZVa3lVK2ErU3Z4cklQYnF5UVRnZ21n?= =?utf-8?B?V2I0MzhBTEw0dVVDK2R1dUJ1MEt6RDZxTSs2cEZhOGk4RDlUTTVyRFhOMmMz?= =?utf-8?B?d1dsdUFMZk55RTgrM2NEY0gyWlA5bEhib3ZvQkViSTZWQWpmTDVUck94c1Zm?= =?utf-8?B?d281bkEySzhaK0YxbGlCOW8xamJBK2xaSE5pYWFaazJLb3R5WTJlK1M0aURG?= =?utf-8?B?VzNrMUY1dmI1MjRDSWV5SEgzS1NXaldXT2tOR2F5MFlnYWlGdHB5MnhSRmwz?= =?utf-8?B?UkhFdzd3R1FLOW9XNmZhSmJXRDhmdlVkMWQvQnJzcHpTRjh4d0UvdUJaUS83?= =?utf-8?B?TDlZSDNiVUUvaUZ5Wkw2UExXMWU2RHM3ZlMxQkZQNGJSdEVUSEhqamxMUWZP?= =?utf-8?B?cXQ1UkhncnJyRlMrR1RJN0NET0M0RFBCeHJKeXZWNHBKaHg1MmZKWitXOGND?= =?utf-8?B?eVNlcDZnR2toY3lKMkdSY1J4ZmFCZjZOcGV0MVV1WUt4SGtiVldRSWtHQXRk?= =?utf-8?B?LzZqMUY1S3pTRThFdmFCbVVYbkhZZDlMTVNFOTl0U1ZKRUNiRkcweHE3aFdu?= =?utf-8?B?a21Mb1U4ZFBhT1hlR2NSOTNocXpZSm1wMTJmTG1SaE5PczQ4UzZBOFdMU2JK?= =?utf-8?B?c1pRTTlYNElybDk3NlZpYUNGQ0lCdXl2UE1URjhVS050czlhdGFmNWtIOCti?= =?utf-8?B?NWNRYWJ3VUVPa3NydlJKb2I0QnNRMFlmQ1RkOVhQeHlPWHVnYUdQTHFsTEtl?= =?utf-8?B?VHdmbVRKak4yVDRSSUN2Tko5U3VWWW1leHB1dTBQRVBqSG5RM2xoMXhVUC91?= =?utf-8?B?QWY4eGQ0WTcrQUdUUVJHeHI0RGRIamJ1RGg0djN4ZUtsSk9OaVJYSitwWnZP?= =?utf-8?B?OXE3NEVCWnJUSTc0R2N0bnJET1QrQnBRdVk4UE5Wb2k4YnVuS2JxbXM5eG14?= =?utf-8?B?ZnZ0RngzWTJCTmZJWHBMdGRsaU1FWXpNd2pPejl0dnNDRWE0Z2tzeWZtcUR2?= =?utf-8?B?VTlVY2lvbndPTEZCT0xSWHBBVEMrYURTZVVZT0VwRExWdVo4aVlIT3FNdzhU?= =?utf-8?B?RWF0eVprOGp5RzdkL3FEcGFBTU9tbi9EbGx0bEdBTzlnWHBmVWptc0Vlamw3?= =?utf-8?B?M0d0OHYvYWdqZ3hYSEVWelAvMWgxZmF1YUZVSUJpUWE1TldHb3VEYXVjVWZk?= =?utf-8?B?OGYxWitpc05RbkhIQjNIQWIrK3VzTEVybFNEcVVZNjdNSGJsSzRTWlZURUVG?= =?utf-8?B?c2MrdnVIeGphTE93d28wSm0xbW5KaHhOOUFZdmR3M0FGa2Zwd2xwY2M2TWM3?= =?utf-8?B?eFhKSVc4azBjRmdxZTltZEVqakp0UUxOT2RSU3NqbnFzemdNZzNLTGVNSm9R?= =?utf-8?B?dGl0bm9BaGhGZis0Q3FlbGtiRGY1R1U1ZlAwY2FzVy9KckFLZ096M1p3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d9035e1-3ecf-4d91-73bb-08dc6a81dd96 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 08:28:38.4704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0278 Subject: Re: [FFmpeg-devel] [PATCH 5/7] avcodec/avs3_parser: Check the return value of init_get_bits8() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: CID1492867 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/avs3_parser.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/avs3_parser.c b/libavcodec/avs3_parser.c > index a819b5783d6..0f9076befe1 100644 > --- a/libavcodec/avs3_parser.c > +++ b/libavcodec/avs3_parser.c > @@ -73,7 +73,9 @@ static void parse_avs3_nal_units(AVCodecParserContext *s, const uint8_t *buf, > GetBitContext gb; > int profile, ratecode, low_delay; > > - init_get_bits8(&gb, buf + 4, buf_size - 4); > + int ret = init_get_bits8(&gb, buf + 4, buf_size - 4); > + if (ret < 0) > + return; > > s->key_frame = 1; > s->pict_type = AV_PICTURE_TYPE_I; This code only reads/skips a few bits here (at most 100 if I counted correctly), so one could initialize the reader for a shorter length and assert that the call succeeds. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".