From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] MpegEncContext->class is never initialized
Date: Tue, 4 Mar 2025 23:03:16 +0100
Message-ID: <AS8P250MB0744F3063AF075AD322AA00A8FC82@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAGeeRwnB6+x2xf5eV8J095wzL+jugokruZXjkcUitC9Y_zf9HQ@mail.gmail.com>
John Dorian:
> I discovered a crash here if log handler function tries to get the class
> name from "s"
>
> mpeg12dec.c:
> if (get_bits_left(&s->gb) < 0) {
> av_log(s, AV_LOG_ERROR, "overread %d\n", -get_bits_left(&s->gb));
> return AVERROR_INVALIDDATA;
> }
>
> And it seems to be because MpegEncContext->class is never initialized (or
> rather it is initialized to 0) due to av_malloc_z() I assume.
>
> So the question is, is it valid for any av object to have its av_class set
> to 0.
Will send a fix shortly.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-04 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 21:55 John Dorian
2025-03-04 22:03 ` Andreas Rheinhardt [this message]
2025-03-04 22:36 ` Andreas Rheinhardt
2025-03-05 3:21 ` John Dorian
2025-03-05 3:33 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB0744F3063AF075AD322AA00A8FC82@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git