From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8428346804 for ; Wed, 19 Jul 2023 10:32:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B198D68BEC1; Wed, 19 Jul 2023 13:32:21 +0300 (EEST) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2099.outbound.protection.outlook.com [40.92.49.99]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2F6C068BEC1 for ; Wed, 19 Jul 2023 13:32:15 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GhmAQXlNmw6ImIUs5v+CR1qmYk13xUUQKzEtaDGXuun4BQlMxAsLsQ6utlTVlcEutqu1BXYx6mHqtOIICoMUCEHL6JXPI139983L5WK6Li1NTAy2x8Z5f3DZ9w+dqYMc+mARPBkxEIJPvOqFhMvbu1bzLtimw7rrb/XeDtfXO/7RbwGn0z82GlyJPdb0GKSHfskonwkMo8GZX6hTSMz+8LThikP/zB82gtmvHP6NMYnxjL0s7ALRcf+kviFYOe2xxNKjJTIzN5eviCheZX754j/UgWwErWmdOYkFkdp5s28CLPTmbm0TifyDXBXdi6fv0uZ7pzssOgV3cw+0yXwmCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fzHb0jszZdRVMjan8OKRHRyfE3TokNriOrOAfr+a3Lc=; b=BZp9f34wLR2ZICR9byU5nJI57UZ+3jjMJ7cZXfPZHQPS3zPMIeZygx8zyL5kwexFZwQyV4PDHJ9dojoCJyFdjj42X1+RNtDNPsXZoSB5o7Q08kNyjp5VDNGLs1pdcv9KvFweWiYoSDutVXUuNcwX+vq6wbz5qm2foGkFAS44aj0w2b4HSoaNYGCfsum/DRtlKjczG6DDtMJNNTW1qEfvTS5l8bpe5n5I3GuCGpvuwLTV0KMfJxJxpKU/MmEcfROny/CVgXPjTpH0FhMhE9+H8Z3dOVaCOReP1Tb+LXvdL0h/QKxWIXeFoHSCwBGkLXarZM8WGC4EYtAhSHdPzBButA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fzHb0jszZdRVMjan8OKRHRyfE3TokNriOrOAfr+a3Lc=; b=NVIPBN6uIppbeeFOenPc8GoDOZJMu6D9cXKp3dFWUrjprOVaorVeV5T8lGsXlV3n/r4F93MrZlh1YiR/FfBFnuILcr687St49ta9vjEqmYRvP/7c4zN3jYsl8cDFUbw/EQFL+cpOVclmH8rq5I/UOm9Ue7PxnTfHGke8xHBG0+lT7UO++JxS9Fr/akRXdURCAWB4OdhWqdkuN1c/N5raSkwVGLgjIToIXbYCFgh4GDk74Xc/yapVgTkaqYT76dxLmc1cXsmsAoLfdo4hAtkng+dQLL7n68OHK7Kt309pxFzIiIY4/gZD+YcTH3tsiPfEIMoAeFHNZcIYuKivduMgig== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0372.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.23; Wed, 19 Jul 2023 10:32:13 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::a38:e93f:c7e0:f473]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::a38:e93f:c7e0:f473%7]) with mapi id 15.20.6588.031; Wed, 19 Jul 2023 10:32:13 +0000 Message-ID: Date: Wed, 19 Jul 2023 12:33:23 +0200 To: ffmpeg-devel@ffmpeg.org References: <20230719090316.56268-1-lq@chinaffmpeg.org> <20230719090316.56268-2-lq@chinaffmpeg.org> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20230719090316.56268-2-lq@chinaffmpeg.org> X-TMN: [JXvIRtdPfyXHjY4CfKngKSx+RjeX/Rsv] X-ClientProxiedBy: ZR0P278CA0002.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::12) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0372:EE_ X-MS-Office365-Filtering-Correlation-Id: 74ce7e72-0db8-4fe7-12f6-08db88436a78 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XNLnPoqHnkBYEl/TOZeStz1Qr6ci/SsonVnkQr4MAL6L9WlVwcAmnCRSBbYjnfb15rdzFhqdggCiWzlRSgZKutaW4EovfNQJEbjpX72CDsK0Ih8ltyCEnZSUt1mZqUzGhMVmsTd4TWPm7jM+nkuxvIhy4CznizhuXT1P07qqZIBju9LhqZ8/GB+OzaE6yVhK8icYhGNfPPgup05sYmE1/VPvEoxHDAFgJoGzwr8bPJPpfJH2+3AHl+GIr2iwp9/LUNzGK/4YACW7pSYsPXRK6qRyRmUqn7bucM0x8z4a26PJEQX51KvVx0VYOjE/h7mPKih9p0obmGfTy977/UGclz46yBqXfCz8N4W10kiBl6mBV7sDifvHOS4uitulf/0ewv5Zl1bJsuPRSTuz9hqhVxp/Ry0G2sfS+awl+UWfeYG1OjAIWTx+If0D4Trn8AZyvbilJvbIWhKobQih4YDK8i58zlKlYbzPTCaW5cApwgRZEyD1Tr36t49BwQVkGXdOA0x9MpOompT0rLmp0y9kfnOsxni3KGADVSrVllDF4rh/bqajoEjYLLoeHldzmp3Z X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0Vzbld4TEhvSWx4enV5ak9ONVgxcDF6VUsxYW9vQTM2Wmp3NHVNU3drNHBX?= =?utf-8?B?eldiSWRMQ2xrazRGazltSHZJMmJ2YngzUkZUclcyaTZraUJ1SEtZZ2phTU15?= =?utf-8?B?c3owZXV4blhZa1hXdVJneEhydUUrL2lHTHVybVd5TjVHcUxZNHZRUjEvM2Rw?= =?utf-8?B?WlIyZjdINE5HTXd1M0x2anQvZUJXdGQ0cTk5Rk05MnBuOHJicHZ0aUUwaUc2?= =?utf-8?B?NEU0dGYxZjhKU1FkYkR6MWh4TDlpcDBLT2FhN0VqeXlEZng0Q1RjaEhYbnF3?= =?utf-8?B?NFB4ejk3U0hRV3p6QXdEVHFTa1F1Qms4a3h0c0FaNWNoWkJIMWJpclFhYWJV?= =?utf-8?B?WG11N0ZWb0UrR29WeGd0QUxYMzgxbGR0ejJlNVI4STFkVWgwZUxHZWN2cU4r?= =?utf-8?B?YkY2Uldsa0FlU3VCWHk0ME1aUHlHZVo5WncxQm1JSm9NazRGY0xUYjFzK0lJ?= =?utf-8?B?N09aNE1lemQvRnQ0bTFNQjZKemhIM1QxTVpLUnhSRkhGdC9SdFUxOHREbjVi?= =?utf-8?B?L1RXci9LRGlUWVUxQ3lNQnpOQWtvTHhYWDFzRnZUaUQzQjdQZzhadWZkUXZJ?= =?utf-8?B?bnF2WGVndEJ4SFFoejh2U3dSa2JMWmVjT1NETHowL1R3dkJXNUJEMVh4Sldn?= =?utf-8?B?Y3JjN2MxVm9xZ0NWQ0t2NG9EMEx0TVlDdHFGNWp6ZjNRZXpPTGptRlpyT3ov?= =?utf-8?B?NXNCcW91RVdWWGphWnpCWk5jdm1sTGZncUdaUTJvMHVaVGRPZWVwRmxxbVdN?= =?utf-8?B?RThQb1VGajllTlAraTBiTmxJVks1ZVducmFybUVrN0p0ZWcrK1IyYWIvZDZ1?= =?utf-8?B?NFZ6Q1FrWGxyNHE0TWJ6T2FoWHljZXpGR09EWUhTaGRQdDJPeENic01mOFpP?= =?utf-8?B?TmdCQjdLdnpYdnV3N0hRTStJeU9NMDFsM1NJMFh0M2hYNTZWQ0owbmJDeDh6?= =?utf-8?B?NmZTOGtmSCszdGZHeFZHeFVvdkFrZEg4ZkwyRHBIa0hMdVJlaWhkQUNRT2N3?= =?utf-8?B?WWRpblRJb3dtQzd5WEZvN3AzajUyN284endHSVhSeFIwZlJyUXQ4NW1JR0FT?= =?utf-8?B?NHdoWnY1cHJMVUJwTjhaVEluaVgzWFQ1Z29xbUxlMlp2Mkg2Y244ampweFpn?= =?utf-8?B?bG50MEFINXJ3eHFBWVdjcGhMb0x0Q09mSXNkd1Vyb1VVMVc1ekxqSVU5ZVZq?= =?utf-8?B?R0lVMWd6YXpTd3lNb01TK3lham5rN0FrOFI0VHkvZGxiRHFwK3RTR2xjWThx?= =?utf-8?B?V0J2eGhzc1hXSnhoSmhvYVBEeXB1OVZoSFYxWmxEV3NtZ3d1NXhXMG1sYnJH?= =?utf-8?B?NThiOExoS296Vjc1NTJIR3hwVDZJZjlGa09QdCtSNCs4RUlkam1yd2JwSFd2?= =?utf-8?B?NDVBdkloY2NCQm4vcm4xZzc1K1BybUs1bnBHY0RSNTNSS2VMelJOVWdHa01T?= =?utf-8?B?SEdiTWg2WGEza1pmN05TanorbEdqeGNqd1RTK3IzeHdtc0V5c2NxTm84TVJD?= =?utf-8?B?R1ZUWkcxeC9xbjYyK0R1anl1ZC9pWVNtdEMxNkVaU3JPTEZkdU0vK2xuRWp1?= =?utf-8?B?cWJlZ0tyVmZTMXJ0aXZsWm9STnBIYm9PaDJUMVovK2pQTERuTGJwTVU2MjJs?= =?utf-8?B?dVpBTEVCY0VoLys1YjZnNDE3MUpVKzNYZFNtSWo5UWppZlJOMEZMQmMrbURE?= =?utf-8?Q?zus+b4sm9bosOKL96OsG?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74ce7e72-0db8-4fe7-12f6-08db88436a78 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 10:32:13.6031 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0372 Subject: Re: [FFmpeg-devel] [PATCH v3 1/3] tests/fate/flvenc: add hevc in enhanced flv test case X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Steven Liu: > Signed-off-by: Steven Liu > --- > tests/fate/flvenc.mak | 7 ++++++- > tests/ref/fate/enhanced-flv-hevc | 8 ++++++++ > 2 files changed, 14 insertions(+), 1 deletion(-) > create mode 100644 tests/ref/fate/enhanced-flv-hevc > > diff --git a/tests/fate/flvenc.mak b/tests/fate/flvenc.mak > index 5032fface3..6b2fbe8c89 100644 > --- a/tests/fate/flvenc.mak > +++ b/tests/fate/flvenc.mak > @@ -1,5 +1,10 @@ > FATE_FLVENC_FFMPEG_FFPROBE-$(call TRANSCODE, FLV, FLV, RAWVIDEO_DECODER SCALE_FILTER TESTSRC_FILTER LAVFI_INDEV) += fate-flv-add_keyframe_index > fate-flv-add_keyframe_index: CMD = transcode "lavfi -graph testsrc=r=7:n=2:d=20" "foo" flv "-vf scale -c:v flv1 -dct int -g 7 -flvflags add_keyframe_index" "-c copy -t 0.1" "-show_entries format_tags" > > +FATE_ENHANCED_FLVENC_FFMPEG-$(call REMUX, MOV, FLV_MUXER) += fate-enhanced-flv-hevc > +fate-enhanced-flv-hevc: CMD = transcode mov $(TARGET_SAMPLES)/hevc/dv84.mov\ > + flv "-vcodec copy -map 0:v -frames 1" > + > FATE_FFMPEG_FFPROBE += $(FATE_FLVENC_FFMPEG_FFPROBE-yes) > -fate-flvenc: $(FATE_FLVENC_FFMPEG_FFPROBE-yes) > +FATE_SAMPLES_FFMPEG += $(FATE_ENHANCED_FLVENC_FFMPEG-yes) > +fate-flvenc: $(FATE_FLVENC_FFMPEG_FFPROBE-yes) $(FATE_ENHANCED_FLVENC_FFMPEG-yes) > diff --git a/tests/ref/fate/enhanced-flv-hevc b/tests/ref/fate/enhanced-flv-hevc > new file mode 100644 > index 0000000000..41eaefaf6e > --- /dev/null > +++ b/tests/ref/fate/enhanced-flv-hevc > @@ -0,0 +1,8 @@ > +afed0105d121688bad7dc94218256571 *tests/data/fate/enhanced-flv-hevc.flv > +64396 tests/data/fate/enhanced-flv-hevc.flv > +#tb 0: 1/30 > +#media_type 0: video > +#codec_id 0: rawvideo > +#dimensions 0: 1920x1080 > +#sar 0: 0/1 > +0, 0, 0, 1, 6220800, 0x1f259c93 Why are you restricting this to one frame? And why are you not copying the audio, too (this would test multiplexing)? After all, FLV supports AAC. Furthermore, you are copying the video when creating the intermediate FLV file, yet then you are decoding it at the next stage. This decoding would necessitate a dependency on the HEVC decoder (and maybe the parser as well as the extract_extradata bsf?). Alternatively, one can just use codec copy when reading the intermediate file as well (the latter is my preferred approach). The same remarks also apply to the other patches. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".