From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 07CA447CC8 for ; Thu, 15 Feb 2024 13:42:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8270B68D230; Thu, 15 Feb 2024 15:42:19 +0200 (EET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2043.outbound.protection.outlook.com [40.92.65.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 20AAA68D1E6 for ; Thu, 15 Feb 2024 15:42:13 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TSG2P+3hwzfVnhYodQkbmko/wNXpqY+n5fbcbiFkxsZeCCuNNBNbqYCX10cXGs3cwL09gCqIet1Ram7ju1kg9qYXwE8AVqU6b2ciW/JhibzNigxe4p7UXQ2VlcvIFqcs01+oB7ytE3XJq2AzRw+ypn67vCwNWpyMhnk2nHw3TlgEq2ZWkJxleepuUX2hFDBkdd2BFUJ7hsL6RByTW8496L6pn1POT5+HJ0Crn2htjRBs0+XU96BrTjiEol+OlKyD8DAY4yjPDI9WpL//lyRpYz6LHb01mYTvnxlQUCmpL8D7skdbC/zCZSRpbU0zMW1Ng9sGBkHhWGEU/42KhpYFRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=po6Y52dAxGytrsvKECXtuJ7rhOhb+2JuhqiSynRXD4Q=; b=D+BGEueJZQ8Y5MwL5DWUGZGn0LGQ1RQdMk5Fmx/qmzOTnY8X43fYRcFjp97q6C3+6FX9tKijPIz2wLpkOl5t44B4JTEmcdQysZQenGsd+ujRMS/6DdqwerMsSi0x93zSpfSR3t5s/YwzV347pqdbNtfLNJv5dJWbk5uJjNsNzjcZwC/0LZaK1ijUmDORGVLKBY58EjjVNOI++JombrZOlmLbVpe3Ty5Mhpkmb4u0JkoK4wumHvHviEwGQ9GvggURCztMiF8L+2lBW4G5iXSvlflHZv+w1geARQevsCfKrkUiCvvvndV4CWsJ/SElZRpgVXR04yiB185YHUy3eGa/VA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=po6Y52dAxGytrsvKECXtuJ7rhOhb+2JuhqiSynRXD4Q=; b=fqTvuQWR5YybW3VG4UJeCLOukIcecZCEF2XxTS2E4h5e+pxZRvz8Wmb2cJA2RmLj979A3Q6VmfFyOotUetJMfnuJT1pYbmCRqJycD55U5N8RhKUk3JKJ+U2xiWWD+8CUbBqeS7hCpYqnKO6qtzzusVBw2/M2kYCioDq7cX5yqwAvTJUS8Nlg4+TWsx6O3stB7rJvOvhsmz8rPHC9fPD8tAYBMYb1YwL5/C384oqdCWrZ7RYCUD6z7uvfxGYIG6O+i3S3zAEpxxkKAOQlmLYKKd1PqvRGjomiQXkexFC4trgQNC0Hl6WyBVs4RAWUuxr1Nleb6829KmFXe9CH8ZsB2A== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0129.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:174::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.26; Thu, 15 Feb 2024 13:42:07 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7270.036; Thu, 15 Feb 2024 13:42:07 +0000 Message-ID: Date: Thu, 15 Feb 2024 14:44:02 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [m9RP7oRKB12W3B1+Kmvwcptu9zegOOjnvv8/rfE5Lc0=] X-ClientProxiedBy: ZR0P278CA0020.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::7) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <1a7a5e97-5301-4a94-8ee2-1f2e5b1e75be@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0129:EE_ X-MS-Office365-Filtering-Correlation-Id: c64e6ba6-0737-4c39-1d4c-08dc2e2be6e9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /bQcbBAkl85BBLmeXRWBHi9yXtFP2MyteXBhJFPjrNp5b7cN5T8JBDJIgP/mQu6zyWxCXXo4CqS2l0CuXJuuFRvxsP9L1q8EUfTjjy+dpsen/jINi6GaGjMhhGhB6YjmC7OtexKEB/kHL5nPfcFLsHKBe3ihiB4CgSypdzwDUKbazmLsp+CdR5KloglqqWF72bukEUeTtDtnLqAh0R1TE0RFB9yVHYo9g8M6DYIP/ITF+jSpod5oEpit2/Qk8+xce5DQCnqC7TuFy/dlMHLcOru986Ryo+ynZGQhpUKUNUD9P3tAJFuotV/X2p5CUq1EdKgL88XYs4QUMmeafFljM7G1GGQTzFnTEZyNWG76yEW1+IQlNy7DbZTgfO5/hUsfAUx4NKZZIyGg1fsX7ZRj1nvx+bHC3VUu7xuEiVU6DwFvGkbMVyzgmzAubdWMYbf6hrUpJ/KE9cgd0zMf+uMrh/HadnNeQNgUUPNiO0vq0/1V/c4yR79+i963Zlt7Fxyhu0nBIRZcYnhqxB11Z/PAkau9KZOgNiY3wsvTKBm0qUvk0VVJULMSbVvWkGpn0vhQZpZZz3eTYyz9n3eBqS80yoSjJrm7Upld+lg9wtohrmE= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGdxV2tQZXFmUmpueWdodDhkTlZ2NDJhM1BwQmIrVStuMTRRcnJORTVhYSt5?= =?utf-8?B?RjNmTU5Ia3NtWHhUNlRBUkg2QUJ6d1Q1R0U5VlpXVEN1Umg0RG1kbWF5V0J3?= =?utf-8?B?STAzdUhWUFlQaloxamxKbFl5eDRxWDllN0wzczErTWk5U0tmdlVuVnFrNDBK?= =?utf-8?B?RllZZ0pMSEFvcEdNdXVCSmVETSt0YlFsbVBBa1ZFYVhSSGFiUVlWWjZ3VWxX?= =?utf-8?B?bE05TlpwRjMrM0h0WTcwSXFqdEx6WWw5S2RpbUNycXRlRmRLT0hXSzZKVVFR?= =?utf-8?B?K1IzVmpDSVZSSEdwZnpTeGc1ZURETjFoQ2xzUUtUM3dqdm9BbG9zVVhHQXF0?= =?utf-8?B?MlJkWXp5aVlkOWFLZUR5aEhiMlVrdjZKZWpFd0dFSS9tUTVrUW9hc3VicGdU?= =?utf-8?B?Q2lacHZFWmF3Y0xLWWx2RUhOTFJJalpaRDY4ZW9nUGF0WDdMZnNwbkV1clZF?= =?utf-8?B?N3ZmZW9LSkpnK0hXcE1sTTg2RkprK1NXUVQ3ZlE1NWM1WXlPWjRNSlJYL2or?= =?utf-8?B?OTNTSFVteEFuaUNPV2Z6K2dLUnhBUk5pSGNyeWxiZTZkQ0F5eklhYkVJSGpu?= =?utf-8?B?eCtoZTVpQTdxZ3Uxd1E3ZHdLZ0puc1Bvakl6dXhLdTdBeFEzL2hTZ2lab3gz?= =?utf-8?B?L2FNY1hBS1lvMFA1emQzdjNvazFrT0JSa2FYdSt3NUVBSjNjYzAxaHNadmpD?= =?utf-8?B?bGhGYnRlZ3VML0lOV3lGaW5FamNVeWNCTDJ3QURJRTJCNm5GKzRSQTllaDl3?= =?utf-8?B?NG1WdktRckNNOUFjWkFGc0REU2NGMWwxZE9rTWR1MzIwWHJ1R2ZuazFLdDZu?= =?utf-8?B?azFwR3djbFRSVUdsVlErWWFxaXJwc3ViaGlvaDRJRVNHeXpFYzUyN09LcjlP?= =?utf-8?B?d0VkV0dpcXg2d0R0T3ZYWldrYWY3NGFVTGM0ZFpPMi81SVFnb09YbmhEWW12?= =?utf-8?B?OEUzWjNMS0tCL2VTRitBS3BjVUZNNG5ZclQyNE54YWpMZ3YzblIvZWEzMmYx?= =?utf-8?B?d3VNRVdwdjB3OXM4YTk1bTdLLzdPT0QxdU5LdERxRUptRlhNSFpFdDBNTE1Z?= =?utf-8?B?T1pqUG54M3I3VHFSTDY3bGlpb2t5N1hJc0RmbUJyYUlHcUFTakp5My91dnh4?= =?utf-8?B?OVFVR1plOElkL0dJNndrM1IrUEpuaE9mb0E0UkJmeld2QzBsSmFFclR2eGE4?= =?utf-8?B?Rm1MMWVmSDUzZFVWalBYNzVQdWVjR1o5MUpPMzVKRm9ZMXBkUnhxT0kxREhm?= =?utf-8?B?blBsSVZkOTBKWUdkUkVLNFpuUTQ3UnNnVktjelFVZW1VZVJXc1ptRkRZR3cx?= =?utf-8?B?T2hLVm42NG5CM2tER1FlL01LaThpN3BGME5SbnZOVUJnZ1hzV0ZqaVpTWkRG?= =?utf-8?B?VW9Xa3I2VzJSOHhoL3dETEtlK3BtbGo0eFlUb1pEVWJDTDRQQ2RwVHowZjNU?= =?utf-8?B?Q1dFRUNKU2hsS0lobHovdzJpVVpPYjJOMlFlSCtVNEVKSERUd0VVbExVeFd2?= =?utf-8?B?WnpuazhDcTRCWElYa2RyK0xGOFFRTU5tajBVd29tS3pTcDFFNHZOUmhsVktO?= =?utf-8?B?aGt5K01oOG81LzF6V1kwSGNmWFgrbXIxSW9BRHN6eGY5UFphbzd2dWlZbFlM?= =?utf-8?B?WEtZbVdCUzVZZDBlMXA2aXd4UGZrSUJjVkRPZXRsYTQrNG93VnFJSkdhdFFo?= =?utf-8?B?S0UwYnFvcFhJaWh5WGRNKzB2cGlhVkp2aW9PUnBVdm5wMHNoUDNGNHdRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c64e6ba6-0737-4c39-1d4c-08dc2e2be6e9 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 13:42:07.4305 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0129 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/simple_idct: Empty MMX state in ff_simple_idct_mmx X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > We currently mostly do not empty the MMX state in our MMX > DSP functions; instead we only do so before code that might > be using x87 code. This is a violation of the System V i386 ABI > (and maybe of other ABIs, too): > "The CPU shall be in x87 mode upon entry to a function. Therefore, > every function that uses the MMX registers is required to issue an > emms or femms instruction after using MMX registers, before returning > or calling another function." (See 2.2.1 in [1]) > This patch does not intend to change all these functions to abide > by the ABI; it only does so for ff_simple_idct_mmx, as this > function can by called by external users, because it is exported > via the avdct API. Without this, the following fragment will > assert (on x86_32, as ff_simple_idct_mmx is not used on x64): > int16_t __attribute__ ((aligned (16))) block[64]; > AVDCT *dct = avcodec_dct_alloc(); > dct->idct_algo = FF_IDCT_AUTO; > avcodec_dct_init(dct); > dct->idct(block); > av_assert0_fpu(); > > [1]: https://raw.githubusercontent.com/wiki/hjl-tools/x86-psABI/intel386-psABI-1.1.pdf > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/x86/simple_idct.asm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/x86/simple_idct.asm b/libavcodec/x86/simple_idct.asm > index 982b2f0bbb..4139b6dab5 100644 > --- a/libavcodec/x86/simple_idct.asm > +++ b/libavcodec/x86/simple_idct.asm > @@ -845,6 +845,7 @@ INIT_MMX mmx > > cglobal simple_idct, 1, 2, 8, 128, block, t0 > IDCT > + emms > RET > > INIT_XMM sse2 Will apply this patch tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".