From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/4] avfilter: Deduplicate default audio inputs/outputs
Date: Sat, 5 Aug 2023 09:38:50 +0200
Message-ID: <AS8P250MB0744F11F5D2E119DC856632C8F0EA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB0737FCB5E606E15B87D929DA8F08A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Andreas Rheinhardt:
> Lots of audio filters use very simple inputs or outputs:
> An array with a single AVFilterPad whose name is "default"
> and whose type is AVMEDIA_TYPE_AUDIO; everything else is unset.
>
> Given that we never use pointer equality for inputs or outputs*,
> we can simply use a single AVFilterPad instead of dozens; this
> even saves .data.rel.ro (4784B here) as well as relocations.
>
> *: In fact, several filters (like the filters in af_biquads.c)
> already use the same inputs; furthermore, ff_filter_alloc()
> duplicates the input and output pads so that we do not even
> work with the pads directly.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
Will apply this patchset (with its potential for many conflicts) the day
after tomorrow unless there are objections.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-08-05 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 14:27 Andreas Rheinhardt
2023-08-03 14:33 ` [FFmpeg-devel] [PATCH 2/4] avfilter/internal: Don't include video.h Andreas Rheinhardt
2023-08-03 14:33 ` [FFmpeg-devel] [PATCH 3/4] avfilter: Deduplicate default video inputs/outputs Andreas Rheinhardt
2023-08-03 16:44 ` Marvin Scholz
2023-08-03 21:12 ` Andreas Rheinhardt
2023-08-03 14:33 ` [FFmpeg-devel] [PATCH 4/4] avfilter/vf_colorconstancy: Remove redundant CONFIG check Andreas Rheinhardt
2023-08-04 0:49 ` [FFmpeg-devel] [PATCH 5/7] avfilter/internal: Don't include formats.h Andreas Rheinhardt
2023-08-04 0:50 ` [FFmpeg-devel] [PATCH 6/7] avfilter: Remove unnecessary formats.h inclusions Andreas Rheinhardt
2023-08-04 0:50 ` [FFmpeg-devel] [PATCH 7/7] avcodec/qsvenc: Remove unnecessary config_components.h inclusion Andreas Rheinhardt
2023-08-05 7:38 ` Andreas Rheinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB0744F11F5D2E119DC856632C8F0EA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git