Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 10/20] avcodec/snow: Move initializing QpelDSPContext to snowenc.c
Date: Thu, 28 Sep 2023 16:39:49 +0200
Message-ID: <AS8P250MB0744F0C04900CBFECFCA51D68FC1A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AS8P250MB074456F3AE7C6EF9A216420D8F209@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

Andreas Rheinhardt:
> Only used by the encoder.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/snow.c    | 25 -------------------------
>  libavcodec/snowenc.c | 26 ++++++++++++++++++++++++++
>  2 files changed, 26 insertions(+), 25 deletions(-)
> 
> diff --git a/libavcodec/snow.c b/libavcodec/snow.c
> index cde09902c3..c9bc4dbab9 100644
> --- a/libavcodec/snow.c
> +++ b/libavcodec/snow.c
> @@ -438,31 +438,6 @@ av_cold int ff_snow_common_init(AVCodecContext *avctx){
>      ff_dwt_init(&s->dwt);
>      ff_h264qpel_init(&s->h264qpel, 8);
>  
> -#define mcf(dx,dy)\
> -    s->qdsp.put_qpel_pixels_tab       [0][dy+dx/4]=\
> -    s->qdsp.put_no_rnd_qpel_pixels_tab[0][dy+dx/4]=\
> -        s->h264qpel.put_h264_qpel_pixels_tab[0][dy+dx/4];\
> -    s->qdsp.put_qpel_pixels_tab       [1][dy+dx/4]=\
> -    s->qdsp.put_no_rnd_qpel_pixels_tab[1][dy+dx/4]=\
> -        s->h264qpel.put_h264_qpel_pixels_tab[1][dy+dx/4];
> -
> -    mcf( 0, 0)
> -    mcf( 4, 0)
> -    mcf( 8, 0)
> -    mcf(12, 0)
> -    mcf( 0, 4)
> -    mcf( 4, 4)
> -    mcf( 8, 4)
> -    mcf(12, 4)
> -    mcf( 0, 8)
> -    mcf( 4, 8)
> -    mcf( 8, 8)
> -    mcf(12, 8)
> -    mcf( 0,12)
> -    mcf( 4,12)
> -    mcf( 8,12)
> -    mcf(12,12)
> -
>  #define mcfh(dx,dy)\
>      s->hdsp.put_pixels_tab       [0][dy/4+dx/8]=\
>      s->hdsp.put_no_rnd_pixels_tab[0][dy/4+dx/8]=\
> diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c
> index ea0d4fc27f..929edc1340 100644
> --- a/libavcodec/snowenc.c
> +++ b/libavcodec/snowenc.c
> @@ -67,6 +67,32 @@ static av_cold int encode_init(AVCodecContext *avctx)
>      if ((ret = ff_snow_common_init(avctx)) < 0) {
>          return ret;
>      }
> +
> +#define mcf(dx,dy)\
> +    s->qdsp.put_qpel_pixels_tab       [0][dy+dx/4]=\
> +    s->qdsp.put_no_rnd_qpel_pixels_tab[0][dy+dx/4]=\
> +        s->h264qpel.put_h264_qpel_pixels_tab[0][dy+dx/4];\
> +    s->qdsp.put_qpel_pixels_tab       [1][dy+dx/4]=\
> +    s->qdsp.put_no_rnd_qpel_pixels_tab[1][dy+dx/4]=\
> +        s->h264qpel.put_h264_qpel_pixels_tab[1][dy+dx/4];
> +
> +    mcf( 0, 0)
> +    mcf( 4, 0)
> +    mcf( 8, 0)
> +    mcf(12, 0)
> +    mcf( 0, 4)
> +    mcf( 4, 4)
> +    mcf( 8, 4)
> +    mcf(12, 4)
> +    mcf( 0, 8)
> +    mcf( 4, 8)
> +    mcf( 8, 8)
> +    mcf(12, 8)
> +    mcf( 0,12)
> +    mcf( 4,12)
> +    mcf( 8,12)
> +    mcf(12,12)
> +
>      ff_me_cmp_init(&s->mecc, avctx);
>      ff_mpegvideoencdsp_init(&s->mpvencdsp, avctx);
>  

Will apply patches 10-13 tomorrow unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-09-28 14:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09 18:08 [FFmpeg-devel] [PATCH 1/8] configure: Remove dependencies of inexistant rtjpeg decoder Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 2/8] configure: Add missing prores_(aw|ks)_encoder->fdctdsp dependencies Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 3/8] configure: Add mpegvideoenc->fdctdsp dependency Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 4/8] configure: Remove unnecessary me_cmp dependencies Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 5/8] configure: Remove unnecessary binkaudio dependencies Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 6/8] configure: Remove unnecessary qdm2_decoder->mdct dependency Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 7/8] configure: Remove unnecessary wmavoice->mdct dependency Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 8/8] configure: Add (dnxhd|snow)_encoder->videodsp dependency Andreas Rheinhardt
2022-10-10  3:12 ` [FFmpeg-devel] [PATCH 09/20] avcodec/snow: Move initializing MotionEstContext to snowenc.c Andreas Rheinhardt
2022-10-10 16:14   ` Michael Niedermayer
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 10/20] avcodec/snow: Move initializing QpelDSPContext " Andreas Rheinhardt
2023-09-28 14:39   ` Andreas Rheinhardt [this message]
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 11/20] avcodec/snow: Move decoder/encoder-only inline funcs to snow(dec|enc).c Andreas Rheinhardt
2022-10-10 16:16   ` Michael Niedermayer
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 12/20] avcodec/snow: Move initializing HpelDSPContext to snowenc.c Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 13/20] avcodec/snow: Move freeing encoder-only buffers " Andreas Rheinhardt
2022-10-10 16:19   ` Michael Niedermayer
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 14/20] avcodec/snow: Only allocate mconly_picture for the decoder Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 15/20] avcodec/snowdec: Don't zero encoder-only buffer Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 16/20] avcodec/snow: Move allocating encoder-only buffers to snowenc.c Andreas Rheinhardt
2022-10-10 16:23   ` Michael Niedermayer
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 17/20] avcodec/snow: Remove outdated assert Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 18/20] avcodec/snow: Only allocate x_coeffs for decoder Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 19/20] avcodec/snow: Reindent after previous commit Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 20/20] avcodec/snowdec: Remove debug code Andreas Rheinhardt
2022-10-10 16:26   ` Michael Niedermayer
2022-10-11 14:21 ` [FFmpeg-devel] [PATCH 1/8] configure: Remove dependencies of inexistant rtjpeg decoder Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB0744F0C04900CBFECFCA51D68FC1A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git