From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 308684416A for ; Tue, 30 Aug 2022 17:27:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E889368B9E4; Tue, 30 Aug 2022 20:27:32 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-oln040092065093.outbound.protection.outlook.com [40.92.65.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 29A9C68B9C1 for ; Tue, 30 Aug 2022 20:27:27 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CNRg7GTbNCDVLmJt4RJJvA5AuRH//VTYAu4sg1I29Gi3eL7vLiKIVkMkeeJ1FrSxvsDywKcD+oQhxzEv9j3cRV7O8MCZtIyzLTlwyO/LuGCKaQ/eI7fMBvOuuUNmIPLvLxtaZutSxgRM0y2BLJ8Ku/FDIOBytTGm6aIyjGIvjdnnFOM93wxc1TmwcBDMzX4tKtzen0tprbkp48Vu/BKbHc3OHE1Tlo4xSsJOkB1eiB0/RSZVCj4yNB5zcZ+exrh1lomH5vkIYy6c7mPKmvThbUyTAAkGZvZKruPJY4ktHGQWUlOMW+qb5itJWIrwX2Sc3UL3LqcoesbhKKflpz6bTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iFt97tsJAL4zVjs12I4NMs0bppB3qzBv0l+xeaXVeOU=; b=aoZFBn1qAtnBvBAPm2h+Aye2NTDFTkt1hGlDTnHw4U8RqFhbAwSotFUghx9/TIMLc0R8mzcfMAa+QheMxLah8BpCtgat34vSjITZxelyREt/NqNmQEIP/p7xpbS7DUe46cWWIc/jgbEhGcMejZPFrOPuVVJesnRJSNArJWCvRkCnh2AAS7mvypLrfx8hFgz/fy96KLfMq8lqJtJH8ZsydQJksqr2W1D2XrHIV1WIXx9CM8oV86BGi+CAb9L0R13yx2QPSyw3QFyosDu6/iHSe54zVQTBkR6o//zXd7YQUWqVH5NFUSbaFSq5mgfqFT3ZjRR04wfgAmngUTRihU9wYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iFt97tsJAL4zVjs12I4NMs0bppB3qzBv0l+xeaXVeOU=; b=WF4evp9TiYmsO4RcUt0q01Lz5aMEbGkWt9+5ywBR9YrxrWthbjDV+sf1IRH4j2PuUE+GVpUxC1EPpY59XSsuK6/we6GaEKDFXDyePh9R+CcI5iU8FA0kCfGJCxLqOyF6vrh+8HEeaGwWgdJA6QqWQb7vPgKyjQonwtGMsT/da95ZUxe/ayHt4QpcWHFqd+PmR7ecLCvkKMX5yJIsdyNbu0+4mpJJAUv2I9W0mpnLt/adA7+tR90aiazuq7LIdagdwLsSi8Xo4cyFjsLrrKFOOWzM1gxD1g67ylhtdrVMA1ESqt8Gm0E1UtUmb6V0dYXe/oQBeL7nM1GuZkOnjO7qQQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by GV2P250MB0802.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:aa::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Tue, 30 Aug 2022 17:27:25 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::7d2a:d9d8:f384:4cee]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::7d2a:d9d8:f384:4cee%9]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022 17:27:25 +0000 Message-ID: Date: Tue, 30 Aug 2022 19:27:23 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [Tk6fm0/0a5VdjBXEwr7hfR1K3lyzJFJh] X-ClientProxiedBy: ZR0P278CA0157.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::22) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b2614ea-9f08-45fa-7082-08da8aace785 X-MS-TrafficTypeDiagnostic: GV2P250MB0802:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z+Oy2gVIr/IWYjEi8sywluCOiXOcK/ljR/nLJHN5VuYwPi4qvGqANgOyh2/SVpYoAF867PyhEuhAyQuID6NDZrd3GBRExN8/tAVZTKuScyKYboRW8v/MNBTGGPp015ec7EtlMYHUaEEdKmpeIPfO1uu2Yg8RjBlH9cj850KJ1AdLRYHzafWV79m7G8aEeqN2ksh1FzY7fHeCK0bQpv1jyqcpLtmWLngLdyNYPLEjKzrfcCxN9oDgbq2n+B7GXySSBKQgrMKte9fUrAFzA0P+tpOIZWNxYWHtOaPJ7nIuEsn0bMaKu74PmSN22jUVvuDUpeLxgSiQiLpjtkZaf6gF6omV0JcOhzVKE1Ir98MGBX0CPyDkwKeB7qsp80UhDD7QfaUPMHivQKkCW9GbSY+51n6eWAiHoGBt4g3CmyqDrhToGBIkzTFTOFQ831lIWSfgLDIFkC73wwu5+lvQru8sojIIXtGMo+tEvgQx0qdMgNO2D4l92RnFdJRwTjLssrMLh2TMJRznKl+tAh3cJaefpU+N74YMsycBEvGsERAW8XYrauZuZJQsWf7mR9jN2bk8/EijuJbOxbaj1V/LREDn0menioDF/MqoeZjccPOMymYDCajgIHR5vdjZEZuGor4mke+FzM4po4RLlXg9EtzeAHFaFtndVODJqIaqmPOKGH+Q8GKcEoCMmU/Owdn3SGYv X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGlQSnNhRFZ0RE9QajJBaFQyRGF4cHVDT0FXVk1yU0FEaDg1NENGRTM0UGE3?= =?utf-8?B?dTlxbkNCOVBENmZlZ3VVREZwSDd5V0dxNXNlWTlBMGM4ZW5HckRaZmNyN2lv?= =?utf-8?B?UGJ1bGhoNHR2MEp4ZGVVQm1LM0paRDUyVitvVFNHTUdxR2djVXVKcmtZY3J2?= =?utf-8?B?K1BreWZGLy9LcGlLaXJOTjJ6bnAxTXM2Y0pHdVVlc2ZleEVKYTZwV3RmTUpD?= =?utf-8?B?SVFVUjVOcUtoeW84Tm1DZVJmdG93WFdNdXh2cDUrRi8xdlNNa1YzNFl0VUht?= =?utf-8?B?bzBnZmJJT0xId1h5R1ZZdWkyck16VXRUOExLQ3h2T2dkZVYvcmpwSHJmYkRr?= =?utf-8?B?eUxkN2dCcC9HNGNSWmU1anRMczlKWGZGaXJmeWhzV1U5aTMrbzhEd0wxQU1m?= =?utf-8?B?emVxcGxlU0hnWEhtMWdoL2ZvaThXaFBKNlVRSDhlU0RxVCtIV2I4NE5iWTNV?= =?utf-8?B?MlduNUVqeXR6OUhuS2hheTNIaHYrVVB2NzBVby9ZSzNIblJQY21jODMyVTE5?= =?utf-8?B?ZjlkRmtkSFhwL29vQjhCb2NUQnQxZkhVOUx2ZGt3bExRT0ErUDBOTC85YlhL?= =?utf-8?B?NUJRZXpHT1pJU1JSZk9hczUvZEFRQlF6UUNvUElUWmhldFJickVtNS9PcEk1?= =?utf-8?B?ZkRUY2dXTmVjYkN1NmNZTndMbGRZRm1CRDA3czQwcXpKZHgyVzFTV01VTmlp?= =?utf-8?B?UGY4VXRFSTlmbmhjcGEzTENGQk5iRU9PVXNaVDJBTFVTZ3hlQWxOMEYvNWR4?= =?utf-8?B?QmpjTVlwS3lMc09pWHJOOVZyWnQvSjZSWlI0ckpnb3M4bld4SzRkWDh3R2Jh?= =?utf-8?B?by9HY3hBd0I3WGtzcm05ak55ZVpJR1hqWjRsUit3ZjBSNVhLbFRRZWJCSXl2?= =?utf-8?B?VGtscFZhWjZXT24vMDlNNkEvWVFIbFhJR0N0WUtwUzNNcTBSNzc4ZU5JV1NB?= =?utf-8?B?c04weDV2NUZ1N1ZZMEZPUzRUd1YzSnhZVzB5b1Q2bEJZSk1kTFBuUERHZDJW?= =?utf-8?B?dHA5cFFBMUdWQkU4eWdHRTV3TERtR0liN0U2MGNUUm1YNFZpd2ZFWmx0bHM5?= =?utf-8?B?em10U1I2MnYxS1Z4eUFEOUpKeHhkYVI3ZmdaRC9hTzZUbTJJK3RaVVRSTVRK?= =?utf-8?B?R0FlNlZnMWdjOU85cTlpb3JxeE1hWllobHNIRk1UKy9WYUVYaDRFcWxRY3Ev?= =?utf-8?B?d2loR0ZwclluRmtXVElWbnhEeGM3V1I4ZjhESFAwV0ZKaU12MHlQQ1BOYzkz?= =?utf-8?B?dmM1aGIxbVVSK3lBUnNtcmozdmI5RzZXMERyNEU2Y2NiZm03ZSs0SG91QVNm?= =?utf-8?B?T28rNUdNVGJIS2pqRlM1cmovaHAwY3IxQ1hnZlM4dnMxRWlnOHVmLzA0UDBR?= =?utf-8?B?NHhNckJhTldwRHJlZFJMQ1hxT2k0d1hmOEZDczRWUmVIdUl0L1p0aWJXdXZH?= =?utf-8?B?Z1p6bS9MS3R1SldIejlQQjlBUDNCaVAxdG8vN0hHaXk1VGl2aTg4TDY1V2tQ?= =?utf-8?B?T3JHdnhwWkxLQ2RncDRtY3AxYnhlQ3ptYXI1U3BMZ1Bvdzl3ZWR1MTgvS2tU?= =?utf-8?B?bWoxVmM4ZnVSVDRMVkl0Vi9lNDNoMnY5bE1vOWtSZldzbnhoQS84YjdoZjhJ?= =?utf-8?B?ZytjSnk5SFFUTnAvOC9uWTlDT3lXVVlUa0FFUG5MRHRqY3Y1Umo1VEFETW9K?= =?utf-8?B?SE1HTFBwTHl4NzdQTjlEcVZtTEFrRUNVTFdRYUoyd2hhQ0lBVEk5eDY0U0w5?= =?utf-8?Q?pI33VAvI7pBoqJFSeI=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b2614ea-9f08-45fa-7082-08da8aace785 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 17:27:25.1979 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2P250MB0802 Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] fftools/cmdutils: Add function to report error before exit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > This is designed to improve and unify error handling for > allocation failures for the many (often small) allocations that we have > in the fftools. These typically either don't return an error message > or an error message that is not really helpful to the user > and can be replaced by a generic error message without loss of > information. > > Reviewed-by: James Almer > Signed-off-by: Andreas Rheinhardt > --- > fftools/cmdutils.c | 6 ++++++ > fftools/cmdutils.h | 11 +++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c > index 18e768b386..da3d391694 100644 > --- a/fftools/cmdutils.c > +++ b/fftools/cmdutils.c > @@ -90,6 +90,12 @@ void register_exit(void (*cb)(int ret)) > program_exit = cb; > } > > +void report_and_exit(int ret) > +{ > + av_log(NULL, AV_LOG_FATAL, "%s\n", av_err2str(ret)); > + exit_program(AVUNERROR(ret)); > +} > + > void exit_program(int ret) > { > if (program_exit) > diff --git a/fftools/cmdutils.h b/fftools/cmdutils.h > index d87e162ccd..4496221983 100644 > --- a/fftools/cmdutils.h > +++ b/fftools/cmdutils.h > @@ -54,6 +54,17 @@ extern int hide_banner; > */ > void register_exit(void (*cb)(int ret)); > > +/** > + * Reports an error corresponding to the provided > + * AVERROR code and calls exit_program() with the > + * corresponding POSIX error code. > + * @note ret must be an AVERROR-value of a POSIX error code > + * (i.e. AVERROR(EFOO) and not AVERROR_FOO). > + * library functions can return both, so call this only > + * with AVERROR(EFOO) of your own. > + */ > +void report_and_exit(int ret) av_noreturn; > + > /** > * Wraps exit with a program-specific cleanup routine. > */ Will apply tonight unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".