From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 55DE5442A2 for ; Sat, 5 Nov 2022 17:18:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 20F2A68B109; Sat, 5 Nov 2022 19:18:33 +0200 (EET) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2093.outbound.protection.outlook.com [40.92.59.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EB6FA689920 for ; Sat, 5 Nov 2022 19:18:25 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cSKQO1rEi0Lj2tajRwVRBYjW9WDxTUkqfAOCP0AKTsPFBXIqF/RBc18eqU+zWlgzVssgGu7IQxzZ6ZsEJRhqtyxwqtLE2Tcq8+BP6e00xa8KuXPOPftZTOwacDW6jWIODQF95WbKG05smJiUkyeT2YSyzY4LPmfZeK8YmYV8JH4ajTX/khcazoKbUr6eew2b4H5gxtvmISXV6s+14Rs83RLoceKyAHASRfasceYYVcklXVg2d7OwZ1Nm5X7zh9myvVEiz7lGr+IKQVb+Bz/vY3MXN+wzRLNLz5PLr5pGFB2UN3Do2LepV4tNP+g/AhQM9aNyG3rh5uCSQqxeLZBbRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TL+h5WHSH4b1CjoktpF83jhQ7xstxNCI91EUIu9D1oU=; b=nwO0gKIhhFsvwnGm0S2JOFLoLa965F2644hB+ylhKfZWlPVFKJKduM9UH8ySdtZrDugZOBDHxUdgYsD54QKi6ep3/SsiYrOTfbytPckkKrHAABpajhaoEoIqlTkb/UvjN3xdXDrkQ1TKTZXt3qqaWbpSgC6FnrgOiVVD8uCyunWb7jFasJ0tGYzbKU/n8zs9GxOxOAJP+TDZoPr4v6BKuN/d0WpXmXnhFvyYzvZC8ijSe4/T/QqTzl8r4p2STr35nCeaogGsj3NDz+GlLpvjiKs3D9TXmA0QE/x4jTRzbOnHUl+fqESbl8y8HX0l28GdEnaEU6Yuu85bIldrSVUz9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TL+h5WHSH4b1CjoktpF83jhQ7xstxNCI91EUIu9D1oU=; b=lOisaIlaePv9IDWUw7dk/7fr+ca3YbgcFckp1YoDC0a/J3F8MjsVw0fh4/sR7KbxFh7rNsIUeqSX35pfbXcAAV3InLiDAVh+c2lL35SS/o6a2w+xDoqmc3W+UBDzcX0QrtGxpN60KULkzTDbDf+aVt47MYAa9FyqBby/Ga7msbDMw7M18BEQu014kLQO3X1YyXYsz73Ofp0eFbiPUB28oNzpWLt9IgoP2NPvXnQgAKTZrR9+QSV56beMTenurOJ6FXBJpbgBcp8CgOPxMTUYJLQ3yYawNlnlxbWe/KQXmIm+i072VSf1s4KkPqks+QVg3mH4UQid4mWKP+VTvZRGHQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by GV1P250MB0713.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24; Sat, 5 Nov 2022 17:18:23 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::9587:72b8:e3ec:c4fe]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::9587:72b8:e3ec:c4fe%6]) with mapi id 15.20.5791.022; Sat, 5 Nov 2022 17:18:23 +0000 Message-ID: Date: Sat, 5 Nov 2022 18:18:34 +0100 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [Nrvda7dWGI/Bzmc3/EOeOr7Rn69PMpF42LJbnnIc3TA=] X-ClientProxiedBy: AS9PR04CA0127.eurprd04.prod.outlook.com (2603:10a6:20b:531::21) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <0ae2f30c-986c-69a8-1198-c10a87f22449@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|GV1P250MB0713:EE_ X-MS-Office365-Filtering-Correlation-Id: 32e44f20-ad8c-4ee7-8aca-08dabf51be2b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ET+K8z6GfwXH7cueWSTHfiq43plIpLFDa+xvIk2VGoqE1AYp3AqHO2PC37YoYP8Jr6M9PWUGCL7ISaX8gdRikj1l2R1FKrNcvklEJrT8v6/QFhAGjuQ9vzSuJojjY80KKOvQj/z4qkksLZCXZU8UYeHrXaT4sny5Lvldtdt92dxQkBHNG5oclBT/kgPTsBmP/3loN9tGpsg/nVzXeS0VTFWDoph/eZALUBvsFh2I9FLlpc0JR2lMhSsOpnDCMn/Ft2y5FsP6avdbUbCXF2L7b8kFvcXALCYbVTuCDjsQQxJAM5/yhRZkreLqYlKQFjjxNo51cX7uOi29I9TiieZ14uZM1AMSCGsVDDkv6ySu2cuw4s17dIjgkoxSoUXx496Jnv1ueCegpZKXE08R/k0fdmiYFkSiOmU+HNd1OXK8uN6wAPWwHX6U0AoOxTS1TpjJzHTjpjodgqGZrfVmSs27nm6By6k6Inr5bxIpxZtpo6tjGCCKnzFs7AkHkTaGkczWAMv+YvY99BqLxjJLPV9O0lwen9exUh1zo/y9AKQSuHwSzJPj/kAS4HFZHKPtAnkFFniGDdT6XxJGnEEkComCTNJmr+K+o/XCyeKE17Wcfm070ZSFaixNLC+eXG3MvPP88Hc3EuXn10XzMTXb3JXzmXphwdGJyvSs+ZcY5zMeTfePisGxg2TkXwdYTaFsp7NM X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azF3cFRiczlwNUcxTFZVejM2L1F5dXFTRi9xTDZYMWxYbnVFVmtIYll1Tzlj?= =?utf-8?B?czBmV3doT1JvMllYV3hlYmEydGxESUpvWmhac1FyMUh4MHdXWmhYdHhqeGlV?= =?utf-8?B?RGx1cGVIc1dKVHB6MGYybElSNmZkQUhvelF4OHNJU1ZhM1RSUUtFUHJuOXFV?= =?utf-8?B?QjdVdDAvM0xXMkdoaE5QQ2prM2picGJ1Zk1sMks3R291N2dBSDhCYmZaQW1D?= =?utf-8?B?NUo0ZnBxS3FsWXc1R0tVZ0c5V0xGeURJMTAxL3V3V21aNStXK2d4Y3BwdXVM?= =?utf-8?B?ZE5UaDh6VEM0Y0lzT0pjem83eG9jclRqNjRrUm9ONHlBdkpEU2VySm1SY2VW?= =?utf-8?B?L3lyNzNoelZjYTl4Z3dRT3lERWlqcnBJTlZDOHEzRmdnK0dzbE1qUVhZeTgv?= =?utf-8?B?NUtTRUlnbkR2Z201aUhvTkkxMUpFeHdjcWpVS3FZQVp5cVM0aC9Zd0dvQVFV?= =?utf-8?B?bC9xVGo1OUpLRVEyK2M1YVlZV1VBV3hyUHVGT0M1Mzg3eW1yMS9NbXZzWUJk?= =?utf-8?B?WlpIbjlSaThXU2JZcHNEWk1ZMDZsUHp3NW0wd3RKeHV2SmRHdGQ3dXFDUVBK?= =?utf-8?B?c1pZSUdCL2RtV2E5ZTZieVFuY1FvMGJacGcvRzQzNFhnWGhvKzJkY3dxRGwz?= =?utf-8?B?VG9Jc3dGbFF1bVNZWFY4eVBZaXdIRm9WV0daSTB4aE9qSDIzQytDY3BKZ0FG?= =?utf-8?B?NGxwYUhEWGVjMzNSUnVNNUt4WW5HVlpVTHloUUZUMmJxNHZSTFVtbVRDdm0w?= =?utf-8?B?VlAxT0lEaFVZTjI0b0xEdVZibC9mMWNiWnRPTkI1Ynl1RVlKUnpJTVJxb2d1?= =?utf-8?B?K3JpT1RYUGhrRnpDeEE4SUx4SWpMalpqKy81YjJBVGRVeGJmSnN4dXNsbWRy?= =?utf-8?B?NTFicUlDZ0VVOEkxWE81TkpmYUFKMVBBYjh3THV0TkpMVXZzZzRxajZJNlhK?= =?utf-8?B?QUZLL2liN1dnVlBMNWRJSTY0WmFPbThwUzZscmxSUkd0MHF2WmxqY3hzZTlE?= =?utf-8?B?MTFqWlZ1VTlpUElsb090cFA0SE4rVnVHbFhLc3JmWmgxMDh3NUh1bGFoZ3Fz?= =?utf-8?B?YS9kZzlLb0NUbWFDTHBoaEh6OXZMS081QWdESGVJR0VGck4xdnhrSnZlRFlY?= =?utf-8?B?S2g2aWhaam5ZUkZkeW9obmFYQnpEcXlQMDMyUFNoZklvMmF1dWczdDhucjk4?= =?utf-8?B?UFZRb3lRSmpVbFhacmJmWFhjM3cvR0N6MmRMTmJzdjBxUFk4akhLUzN3emVm?= =?utf-8?B?VGZ5cWpWc05yZDZ4MzRzMWJuMURPQnBqNXduSmZud2NyVmIwVGQ3Z0VKNGZX?= =?utf-8?B?TWk4N0pjMlpjUEdkczNVRDZFVGxpcnFFQ0VYSmNMMVJJZk9Sc05NNXkvVVlU?= =?utf-8?B?YXRCQ3BCT0s3ZXNkOGx3dGc4T3hwd1N2cHRrY3hhLzZNcDdicDNqcmZ1RmY3?= =?utf-8?B?ZlBFa0R3VTgrQ1dQa0VORU5sbHk1VGdJT3B5ZGFDTXFWTVg5c0l3RWViV1pq?= =?utf-8?B?ODA5RWlwL2NHamRxZ0JUZnlLbmZqbEsxY2dnSjlmVXdBZjRHNVlPQ0JobE1r?= =?utf-8?B?ZTQyM0lGTGE3VlEvVHZGdEhDUmQralJDYTVEZ0VydWZTZXBoWi85Rk1tVitY?= =?utf-8?B?bmMvZ1lwRlF6OFNEWmZpS0FrZmFkN1ZmOGk3b2lqTDlXRUwrT1hnNmkzTHo2?= =?utf-8?B?Q0o0SzVTK3k0ZXdUZUg2M1pNYkxPSmFhakIvc3l2Sk9oVis4bE5tblk0alJk?= =?utf-8?Q?swprZO4zQ7pyGGVrTnhSx7tr0yBW1+ImUA2TEs+?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32e44f20-ad8c-4ee7-8aca-08dabf51be2b X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2022 17:18:23.3108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1P250MB0713 Subject: Re: [FFmpeg-devel] [PATCH 01/19] avcodec/vc1: Don't check for AVCodecContext.codec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > This check has been added in c617bed34f39a122ab1f89581ddce9cc63885383, > merging ee769c6a7c1d4ec6560f5e5a6f457b770b10fb33 to fix > a possible segfault if AVCodecContext.codec is not set > as it may be during parsing. While this fixes the segfault, > it has the unfortunate side effect that it makes the output > of the parser dependent on whether a decoder is set (and > ultimately available). The fix later applied in > 5d2be71b9ecf2a88752666a2c4039f4d98419d35 does not have this > downside and makes checking AVCodecContext.codec superfluous. > So remove this check. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vc1.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/vc1.c b/libavcodec/vc1.c > index c9257b290f..f6de8b9e75 100644 > --- a/libavcodec/vc1.c > +++ b/libavcodec/vc1.c > @@ -632,8 +632,6 @@ int ff_vc1_parse_frame_header(VC1Context *v, GetBitContext* gb) > v->fcm = PROGRESSIVE; > if (v->finterpflag) > v->interpfrm = get_bits1(gb); > - if (!v->s.avctx->codec) > - return -1; > if (v->s.avctx->codec_id == AV_CODEC_ID_MSS2) > v->respic = > v->rangered = Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".