Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/cri, tdsc, tiff: Don't forward AVCodecContext.dct_algo
Date: Tue, 13 Feb 2024 13:23:59 +0100
Message-ID: <AS8P250MB0744ECECEEA3C9EF1FC6865B8F4F2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1SPRMB00475F256E6001BD059C49EB8F492@GV1SPRMB0047.EURP250.PROD.OUTLOOK.COM>

Andreas Rheinhardt:
> It is unused for decoders.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/cri.c  | 1 -
>  libavcodec/tdsc.c | 1 -
>  libavcodec/tiff.c | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/libavcodec/cri.c b/libavcodec/cri.c
> index 0380a0c665..c4eb468610 100644
> --- a/libavcodec/cri.c
> +++ b/libavcodec/cri.c
> @@ -70,7 +70,6 @@ static av_cold int cri_decode_init(AVCodecContext *avctx)
>          return AVERROR(ENOMEM);
>      s->jpeg_avctx->flags = avctx->flags;
>      s->jpeg_avctx->flags2 = avctx->flags2;
> -    s->jpeg_avctx->dct_algo = avctx->dct_algo;
>      s->jpeg_avctx->idct_algo = avctx->idct_algo;
>      ret = avcodec_open2(s->jpeg_avctx, codec, NULL);
>      if (ret < 0)
> diff --git a/libavcodec/tdsc.c b/libavcodec/tdsc.c
> index 739738d9b1..624e219cb4 100644
> --- a/libavcodec/tdsc.c
> +++ b/libavcodec/tdsc.c
> @@ -127,7 +127,6 @@ static av_cold int tdsc_init(AVCodecContext *avctx)
>          return AVERROR(ENOMEM);
>      ctx->jpeg_avctx->flags = avctx->flags;
>      ctx->jpeg_avctx->flags2 = avctx->flags2;
> -    ctx->jpeg_avctx->dct_algo = avctx->dct_algo;
>      ctx->jpeg_avctx->idct_algo = avctx->idct_algo;
>      ret = avcodec_open2(ctx->jpeg_avctx, codec, NULL);
>      if (ret < 0)
> diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
> index adb49e4525..7687dfd0d6 100644
> --- a/libavcodec/tiff.c
> +++ b/libavcodec/tiff.c
> @@ -2416,7 +2416,6 @@ static av_cold int tiff_init(AVCodecContext *avctx)
>          return AVERROR(ENOMEM);
>      s->avctx_mjpeg->flags = avctx->flags;
>      s->avctx_mjpeg->flags2 = avctx->flags2;
> -    s->avctx_mjpeg->dct_algo = avctx->dct_algo;
>      s->avctx_mjpeg->idct_algo = avctx->idct_algo;
>      s->avctx_mjpeg->max_pixels = avctx->max_pixels;
>      ret = avcodec_open2(s->avctx_mjpeg, codec, NULL);

Will apply tomorrow unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2024-02-13 12:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-11 10:53 Andreas Rheinhardt
2024-02-13 12:23 ` Andreas Rheinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB0744ECECEEA3C9EF1FC6865B8F4F2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git